Skip to content
Snippets Groups Projects

Code style

Merged Mark OLESEN requested to merge code-style into master
  • main real change is the addition a coeffDict to refactor the code.
Edited by Mark OLESEN

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark OLESEN changed the description

    changed the description

  • Looks fine to me. Please merge.

  • Matti Rauter mentioned in commit 28c8d896

    mentioned in commit 28c8d896

  • merged

  • Author Maintainer

    Just as a note to ourselves (or others) - like discussed on the phone yesterday, there are a few other ways to pass around the various model properties, none of which are perhaps necessary at the moment.

    • could create friction/entrainment/deposition properties based on Time or the faMesh and use lookupObject to obtain the transportProperties IOdictionary instead of passing it in directly as an argument.
    • or could define a generic base class (maybe avalancheModel or avalancheParameters) that is a system IOdictionary and then pass this as a reference for all the various bits (deposition, friction,...).

    IMO none of this is required at the moment, but might be needed in the future as the models grow in number and complexity.

Please register or sign in to reply
Loading