GitLab

- use keyType::LITERAL instead of (false, false)

- makes benefit of changes in OpenFOAM-v1812 to avoid future
  uncertainty about which 'normal' is meant.

This reverts commit 0cb890e0.

- fixes regression noted in issue #6

- Note that this is not a style change, but a fundamental issue with
  how cfmesh is currently handling the patch names. In a few places
  the names are treated as regular expressions. A proper keyType or
  wordRe should have been used on the input, but needs to be addressed
  in the future.

- improves alignment of DynList with other OpenFOAM list containers
  (especially DynamicList), increases code reuse, simplifies memory
  management.

- avoids needless creation of a regExg and comparison when the content
  is a plain string anyhow

- more consistent with other OpenFOAM containers.
  With the exception of meshSubset, the other classes already had the
  found() and find() methods added previously.

- consistent with the static sizing of FixedList,
  but signed for convenience

* The generic templated constructor and assignment
  Eg,
     template<class ListType> DynList(const ListType& lst)

  Provides the best candidate when there is a int32/int64 mismatch:
     DynList<int64_t> list(10)

  The cleanest solution would be avoid the generic templated versions
  entirely, but they are needed when converting from rows of graph data
  (which are stored as LongList). However, this approach introduced some
  odd regressions.

- erroneous conversion from LongList to DynList

- avoids potential collisions and allows easier migration of classes
  into OpenFOAM itself

- use fully-qualified names in implementation

- the previous code used a dual-purposed graphRow for non-const/const
  access. However, clang 4.0 rightly identifies there being no
  constructor path from "graphRow<T>" to a "graphRow<const T>".

  Since the row-access is a somewhat similar concept to an STL-iterator,
  now provide non-const and const versions of the row access.

- use range-for when iterating over HashSet

- prefer forAllIters(), forAllConstIters() with automatic decltype

    containsAtPosition   -> find
    contains             -> found

    lastElement          -> last
    removeLastElement    -> remove()
    removeElement(int)   -> [TODO]  remove(int, bool)

    fcElement -> fcValue
    rcElement -> rcValue

- Eg, readIfPresent() instead of found() followed by lookup()

- use FUNCTION_NAME for IO checks

Using UPstream::commsTypes::blocking everywhere.This should work on other versions besides -dev.