1. 20 Oct, 2017 1 commit
  2. 12 Oct, 2017 1 commit
  3. 09 Oct, 2017 7 commits
  4. 05 Oct, 2017 1 commit
  5. 29 Sep, 2017 1 commit
    • Mark OLESEN's avatar
      ENH: adjust infoSwitch to report host subscription (related to #531) · 5873cacc
      Mark OLESEN authored
      - this compact form shows the subscription per host in the unsorted
        mpi order
      
            nProcs : 18
            Hosts  :
            (
                (node1 6)
                (node2 8)
                (node3 4)
            )
      
        This provides a succinct overview of which hosts have been
        subscribed or oversubscribed.
      
      - The longer list of "slave.pid" ... remains available on the
        InfoSwitch 'writeHosts'
      5873cacc
  6. 26 Sep, 2017 2 commits
  7. 22 Sep, 2017 27 commits
    • Mark OLESEN's avatar
      STYLE: minor cleanup after merge · 4996ac85
      Mark OLESEN authored
      4996ac85
    • Mark OLESEN's avatar
      ENH: improve input stringency for argList options · 13f04876
      Mark OLESEN authored
      Previously:
      
        - bad command-line input such as -label 1234xyz would parse as a
          label (with value 1234) and the trailing junk would be silently
          ignored. This may or may not be appropriate. If the trailing junk
          looked like this '100E' or '1000E-' (ie, forgot to type the
          exponent), the incorrectly parsed values can be quite bad:
      
              label  = 32684
              scalar = 6.93556e-310
      
      Now:
      
        - use the updated readLabel/readScalar routines that trigger a
          FatalIOError on bad input:
      
              --> FOAM FATAL IO ERROR:
              Trailing content found parsing '1234xyz'
      
              --> FOAM FATAL IO ERROR:
              Trailing content found parsing '100E'
      
         This traps erroneous command-line input immediately.
      13f04876
    • Mark OLESEN's avatar
      1c649817
    • Mark OLESEN's avatar
      ENH: improve consistency in parsing primitives from strings (issue #590) · 41f59b07
      Mark OLESEN authored
      - Any trailing whitespace when parsing from strings or character buffers
        is ignored rather than being treated as an error. This is consistent
        with behaviour when reading from an Istream and with leading whitespace
        being ignored in the underlying atof/atod, strtof/strtod... functions.
      
      - Allow parsing directly from a std::string instead of just from a 'char*'.
        This reflects the C++11 addition of std::stod to complement the C
        functions strtod. This also makes it easier to parse string directly
        without using an IStringStream.
      
      - Two-parameter parsing methods return success/failure.
        Eg,
      
            if (readInt32(str, &int32Val)) ...
      
      - One-parameter parsing methods return the value on success or
        emit a FatalIOError.
        Eg,
      
            const char* buf;
            int32Val = readInt32(buf, &);
      
      - Improved consistency when parsing unsigned ints.
        Use strtoimax and strtoumax throughout.
      
      - Rename readDoubleScalar -> readDouble, readFloatScalar -> readFloat.
        Using the primitive name directly instead of the Foam typedef for
        better consistency with readInt32 etc.
      
      - Clean/improve parseNasScalar.
        Handle normal numbers directly, reduce some operations.
      41f59b07
    • Mark OLESEN's avatar
      STYLE: typo in doxygen string · 3cb9c66c
      Mark OLESEN authored
      3cb9c66c
    • Henry Weller's avatar
      Updated to avoid warnings from gcc-7.1.1 · 24527f76
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      24527f76
    • Andrew Heather's avatar
      ENH: Reinstated the wallBoundedStreamline function object · c7edc26d
      Andrew Heather authored
      Note: performs its own tracking and does not rely on the base
      particle::trackXXX functions, and uses a local particle position.
      
      Look to update to barycentric tracking in the future.
      c7edc26d
    • Andrew Heather's avatar
      ENH: Lagrangian - provided backwards compatibility for cases using the · 65a9d494
      Andrew Heather authored
      old "positions" file form
      
      The change to barycentric-based tracking changed the contents of the
      cloud "positions" file to a new format comprising the barycentric
      co-ordinates and other cell position-based info.  This broke
      backwards compatibility, providing no option to restart old cases
      (v1706 and earlier), and caused difficulties for dependent code, e.g.
      for post-processing utilities that could only infer the contents only
      after reading.
      
      The barycentric position info is now written to a file called
      "coordinates" with provision to restart old cases for which only the
      "positions" file is available. Related utilities, e.g. for parallel
      running and data conversion have been updated to be able to support both
      file types.
      
      To write the "positions" file by default, use set the following option
      in the InfoSwitches section of the controlDict:
      
          writeLagrangianPositions 1;
      65a9d494
    • Henry Weller's avatar
      tmpNrc: Updated to use clone · 5d4d1cd2
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      5d4d1cd2
    • Henry Weller's avatar
      GAMG: removed warnComm · ab51dc5c
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      ab51dc5c
    • Andrew Heather's avatar
      INT: Added missing #include statement · 4a2f5122
      Andrew Heather authored
      4a2f5122
    • Henry Weller's avatar
      reactingMultiphaseEulerFoam: Limited phase-fractions · 82ed8758
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      for consistency with reactingTwoPhaseEulerFoam and to ensure correct operation
      of models requiring formal boundedness of phase-fractions.
      
      Resolves bug-report https://bugs.openfoam.org/view.php?id=2589
      82ed8758
    • Henry Weller's avatar
      externalWallHeatFluxTemperature: Changed Ta entry to Function1 to support time variation · fb846bbd
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      Temporal variation of Ta is generally more useful than spatial variation but
      a run-time switch between the two modes of operation could be implemented in
      needed.
      fb846bbd
    • Andrew Heather's avatar
      36423b25
    • Henry Weller's avatar
      Rationalize the "pos" function · ae277fd1
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      "pos" now returns 1 if the argument is greater than 0, otherwise it returns 0.
      This is consistent with the common mathematical definition of the "pos" function:
      
      https://en.wikipedia.org/wiki/Sign_(mathematics)
      
      However the previous implementation in which 1 was also returned for a 0
      argument is useful in many situations so the "pos0" has been added which returns
      1 if the argument is greater or equal to 0.  Additionally the "neg0" has been
      added which returns 1 if if the argument is less than or equal to 0.
      ae277fd1
    • Andrew Heather's avatar
      STYLE: Code clean-up · d0a6fb9f
      Andrew Heather authored
      d0a6fb9f
    • Andrew Heather's avatar
      e67c54d4
    • Henry Weller's avatar
      Function1: Optimized field evaluations · 176f3af9
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      176f3af9
    • Henry Weller's avatar
      made the clone function pure virtual · 1cd76515
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      Avoids potential problems with derived classes which do not define a clone function.
      1cd76515
    • Henry Weller's avatar
      Function1::ramp function: Added clone function · 357fc39b
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      357fc39b
    • Henry Weller's avatar
      05b2f9bd
    • Henry Weller's avatar
      fileOperation: Corrected processor counting for moving mesh cases · 18874f00
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      18874f00
    • Henry Weller's avatar
      argList: addition of fileHandler option moved to argList.C · a0692de3
      Henry Weller authored and Andrew Heather's avatar Andrew Heather committed
      Patch contributed by Timo Niemi, VTT.
      Resolves bug-report https://bugs.openfoam.org/view.php?id=2645
      a0692de3
    • mattijs's avatar
      BUG: argList: disable checking for exact path; rely on fileHandler instead · c6954f09
      mattijs authored and Andrew Heather's avatar Andrew Heather committed
      c6954f09
    • Andrew Heather's avatar
    • Andrew Heather's avatar
      INT: Integration of Mattijs' collocated parallel IO additions · 85f12ff5
      Andrew Heather authored
      Original commit message:
      ------------------------
      
      Parallel IO: New collated file format
      
      When an OpenFOAM simulation runs in parallel, the data for decomposed fields and
      mesh(es) has historically been stored in multiple files within separate
      directories for each processor.  Processor directories are named 'processorN',
      where N is the processor number.
      
      This commit introduces an alternative "collated" file format where the data for
      each decomposed field (and mesh) is collated into a single file, which is
      written and read on the master processor.  The files are stored in a single
      directory named 'processors'.
      
      The new format produces significantly fewer files - one per field, instead of N
      per field.  For large parallel cases, this avoids the restriction on the number
      of open files imposed by the operating system limits.
      
      The file writing can be threaded allowing the simulation to continue running
      while the data is being written to file.  NFS (Network File System) is not
      needed when using the the collated format and additionally, there is an option
      to run without NFS with the original uncollated approach, known as
      "masterUncollated".
      
      The controls for the file handling are in the OptimisationSwitches of
      etc/controlDict:
      
      OptimisationSwitches
      {
          ...
      
          //- Parallel IO file handler
          //  uncollated (default), collated or masterUncollated
          fileHandler uncollated;
      
          //- collated: thread buffer size for queued file writes.
          //  If set to 0 or not sufficient for the file size threading is not used.
          //  Default: 2e9
          maxThreadFileBufferSize 2e9;
      
          //- masterUncollated: non-blocking buffer size.
          //  If the file exceeds this buffer size scheduled transfer is used.
          //  Default: 2e9
          maxMasterFileBufferSize 2e9;
      }
      
      When using the collated file handling, memory is allocated for the data in the
      thread.  maxThreadFileBufferSize sets the maximum size of memory in bytes that
      is allocated.  If the data exceeds this size, the write does not use threading.
      
      When using the masterUncollated file handling, non-blocking MPI communication
      requires a sufficiently large memory buffer on the master node.
      maxMasterFileBufferSize sets the maximum size in bytes of the buffer.  If the
      data exceeds this size, the system uses scheduled communication.
      
      The installation defaults for the fileHandler choice, maxThreadFileBufferSize
      and maxMasterFileBufferSize (set in etc/controlDict) can be over-ridden within
      the case controlDict file, like other parameters.  Additionally the fileHandler
      can be set by:
      - the "-fileHandler" command line argument;
      - a FOAM_FILEHANDLER environment variable.
      
      A foamFormatConvert utility allows users to convert files between the collated
      and uncollated formats, e.g.
          mpirun -np 2 foamFormatConvert -parallel -fileHandler uncollated
      
      An example case demonstrating the file handling methods is provided in:
      $FOAM_TUTORIALS/IO/fileHandling
      
      The work was undertaken by Mattijs Janssens, in collaboration with Henry Weller.
      85f12ff5
    • Will Bainbridge's avatar
      vectorField: vector2DField: Added zip functions for stitching together a · f10f67b4
      Will Bainbridge authored and Andrew Heather's avatar Andrew Heather committed
      vectorField or vector2DField from scalarField components. To do this
      properly and have it work for field-type combinations would require some
      new field function macros.
      f10f67b4