1. 26 Jan, 2019 1 commit
  2. 23 Jan, 2019 1 commit
    • Mark Olesen's avatar
      ENH: make use of FOAM_API for environment as well (issue #1158) · 6d7cfa2f
      Mark Olesen authored
      - was WM_PROJECT_API in the environment and FOAM_API in dictionaries.
      
        Make these both consistently FOAM_API.
        This is a non-breaking change, since the value of WM_PROJECT_API
        (added in 1812) and/or FOAM_API is purely informative.
        For the current correct values, always use
      
          * foamEtcFile -show-api
          * wmakeBuildInfo -show-api
      6d7cfa2f
  3. 10 Jan, 2019 1 commit
    • Mark Olesen's avatar
      ENH: make use of FOAM_API for environment as well (issue #1158) · c733f1b5
      Mark Olesen authored
      - was WM_PROJECT_API in the environment and FOAM_API in dictionaries.
      
        Make these both consistently FOAM_API.
        This is a non-breaking change, since the value of WM_PROJECT_API
        (added in 1812) and/or FOAM_API is purely informative.
        For the current correct values, always use
      
          * foamEtcFile -show-api
          * wmakeBuildInfo -show-api
      c733f1b5
  4. 21 Dec, 2018 3 commits
  5. 13 Dec, 2018 1 commit
  6. 12 Dec, 2018 2 commits
  7. 11 Dec, 2018 1 commit
  8. 10 Dec, 2018 2 commits
  9. 05 Dec, 2018 1 commit
  10. 04 Dec, 2018 2 commits
    • Mark Olesen's avatar
      STYLE: incorrect option name handling for foamCreateModuleInclude · 8abda731
      Mark Olesen authored
      - The usage claimed '-output=', but was using '--output=' for the
        output file.  Rectify to use single dash as documented.
      8abda731
    • Mark Olesen's avatar
      ENH: update handling of versioning and make control (issue #1010) · f308aa61
      Mark Olesen authored
      - Use the OPENFOAM define (eg, 1806, 1812), which normally corresponds
        to a major release, to define an API level. This remains consistent
        within a release cycle and means that it is possible to manage
        several sub-versions and continue to have a consistent lookup.
      
        The current API value is updated automatically during the build
        and cached as meta data for later use, even when the wmake/ directory
        is missing or OpenFOAM has not yet be initialized.
      
        The version information reported on program start or with -help
        usage adjusted to reflect this. The build tag from git now also
        carries the date as being more meaningful to trace than a hash
        value.
      
      - Update etc/bashrc and etc/cshrc to obtain the project directory
        directly instead of via its prefix directory. The value obtained
        corresponds to an absolute path, from which the prefix directory
        can be obtained.
      
        The combination of these changes removes the reliance on any
        particular directory naming convention.
        For example,
      
           With an 1812 version (API level):
      
           WM_PROJECT_VERSION=myVersion
      
           installed as /some/path/somewhere/openfoam-mySandbox
      
        This makes the -prefix, -foamInstall, -projectVersion, -version
        values of foamEtcFiles, and similar entries for foamConfigurePaths
        superfluous.
      
        WM_PROJECT_INST_DIR is no longer required or used
      
      ENH: improve handling and discovery of ThirdParty
      
      - improve the flexibility and reusability of ThirdParty packs to cover
        various standard use cases:
      
          1. Unpacking initial release tar files with two parallel directories
             - OpenFOAM-v1812/
             - ThirdParty-v1812/
      
          2. With an adjusted OpenFOAM directory name, for whatever reason
             - OpenFOAM-v1812-myCustom/
             - openfoam-1812-other-info/
      
          3. Operating with/without ThirdParty directory
      
        To handle these use cases, the following discovery is used.
      
        Note PROJECT = the OpenFOAM directory `$WM_PROJECT_DIR`
             PREFIX = the parent directory
             VERSION = `$WM_PROJECT_VERSION`
             API = `$WM_PROJECT_API`, as per `foamEtcFiles -show-api`
      
         0. PROJECT/ThirdParty
            - for single-directory installations
      
         1. PREFIX/ThirdParty-VERSION
            - this corresponds to the traditional approach
      
         2. PREFIX/ThirdParty-vAPI
            - allows for an updated value of VERSION (eg, v1812-myCustom)
              without requiring a renamed ThirdParty. The API value
              would still be '1812' and the original ThirdParty-v1812/
              would be found.
      
         3. PREFIX/ThirdParty-API
            - this is the same as the previous example, but using an unadorned
              API value. This also makes sense if the chosen version name also
              uses the unadorned API value in its naming
              (eg, 1812-patch190131, 1812.19W03)
      
         4. PREFIX/ThirdParty-common
            - permits maximum reuse for various versions, but only for
              experienced user who are aware of potential version
              incompatibilities
      
         Directory existence is checked as is the presence of an Allwmake file
         or a platforms/ directory. This reduces the potential of false positive
         matches and limits the selection to directories that are either
         with sources (has the Allwmake file), or pre-compiled binaries (has
         the platforms/ directory).
      
         If none of the explored directories are found to be suitable,
         it reverts to using a PROJECT/ThirdParty dummy location since
         this is within the project source tree and can be trusted to
         have no negative side-effects.
      
      ENH: add csh support to foamConfigurePaths
      
      - this removes the previously experienced inconsistence in config file
        contents.
      
      REMOVED: foamExec
      
      - was previously used when switching versions and before the
        bashrc/cshrc discovery logic was added. It is now obsolete.
      f308aa61
  11. 03 Dec, 2018 1 commit
    • Mark Olesen's avatar
      CONFIG: adjustments to environment · 99505b84
      Mark Olesen authored
      - provide default WM_DIR if not already set, to improve robustness if a
        reduced environment is used
      
      - add etc/ to WM_PROJECT_SITE search. This makes the site directory
        structure consistent with the OpenFOAM structure.
        Eg,
      
            WM_PROJECT_SITE/etc/..
            WM_PROJECT_SITE/bin/..
            WM_PROJECT_SITE/platforms/..
      
      - Don't set/export WM_OSTYPE.  The default is POSIX and is properly
        defaulted throughout, including in CMakeLists-OpenFOAM.txt (also for
        Catalyst)
      99505b84
  12. 02 Dec, 2018 1 commit
    • Mark Olesen's avatar
      ENH: add isTrue function to RunFunctions · 269c531b
      Mark Olesen authored
      - check if the first argument corresponds to an OpenFOAM value for
        'true' (as per Switch).
        True == 't', 'y', 'true', 'yes', 'on'. Everything else is not true.
      
      - when the first argument is '-dict', it initializes the value
        with a query via foamDictionary.
        Eg,
             isTrue -dict mydict -entry parallel
      
         ==> value=$(foamDictionary mydict -entry parallel -value)
             isTrue $value
      
         a missing entry is silently treated as false.
      
      ENH: add getNumberOfPatchFaces function in RunFunctions
      
      - simple extraction of nFaces from boundary file for given patch/region
      269c531b
  13. 29 Nov, 2018 3 commits
    • Mark Olesen's avatar
      ENH: relocate WM_PROJECT_SITE default (issue #1050) · a79d28ab
      Mark Olesen authored
      - was PREFIX/site, now PROJECT/site
      
        This avoids several issues when installing OpenFOAM in clusters
        without an intermediate OpenFOAM-specific installation prefix.
      
        The 'site' directory may have a reserved meaning in these situations
        and it is undesirable to 'leak' upwards into the parent directory to
        look for configuration files.
      
        Placing the default within the project directory avoids this.
        Alternative locations can be given via the WM_PROJECT_SITE variable.
      a79d28ab
    • Mark Olesen's avatar
      ENH: improve setup for paraview · b38efe61
      Mark Olesen authored
      - removed reliance on ParaView_INCLUDE_DIR variable for conveying the
        major.minor version information when compiling. This can be somewhat
        fragile and also adds variable that is an unnecessary when running
        (only used when compiling).
      
        Instead use `have_pvplugin_support` function in paraviewFunctions
        wmake script to determine the maj.min from the PV_PLUGIN_PATH
        since we have already defined the output path there with paraview
        maj.min numbering.
      
        Can now build with paraview from the operating system,
        provided that it has develop headers available.
      
            ParaView_VERSION=system
      
        In the etc/config.sh/paraview setup, the maj.min is taken from
        the corresponding `paraview --version` output and used when
        defining the PV_PLUGIN_PATH.
      
        During the build, the include path taken from `paraview-config`
        for a system installation, from the guess installation root
        of the paraview binary, or ParaView_DIR otherwise.
      
      NB: using a system ParaView for building runTimePostProcessing is unsupported.
      
      - these types of builds appear to have various library resolution issues
        (eg, libexpat not being loaded). Additionally, the build logic does
        not yet cover this type of use case.
      b38efe61
    • Mark Olesen's avatar
      ENH: do not foamCleanPath on system directories (issue #1102) · 3f2caeea
      Mark Olesen authored
      - skip /, /bin, /usr/bin ... as potential filters.
      3f2caeea
  14. 26 Nov, 2018 1 commit
  15. 24 Nov, 2018 2 commits
    • Mark Olesen's avatar
      STYLE: remove special '.' version handling in foamEtcFile · 142c5c0a
      Mark Olesen authored
      - this would automatically change openfoam<digits> into maj.min.rel
        values, thus transforming openfoam1806 into a version "1.8.0.6" !
      142c5c0a
    • Mark Olesen's avatar
      ENH: improvements to foamConfigurePaths tool (#1010) · 1cbacc7d
      Mark Olesen authored
      - provide edit for adjusting the ThirdParty and fallback site variables.
        This is useful when packaging into a single directory, and possibly
        without any ThirdParty dependencies.
      
      - support '-prefix' (similar to auotconfig) as an alternative to
        '-foamInstall'. Use this prefix to set the prefix directly.
        Bypasses and disables the bash sourcing magic.
      1cbacc7d
  16. 23 Nov, 2018 1 commit
  17. 22 Nov, 2018 5 commits
  18. 19 Nov, 2018 1 commit
  19. 16 Nov, 2018 1 commit
  20. 15 Oct, 2018 1 commit
  21. 12 Oct, 2018 1 commit
  22. 12 Sep, 2018 1 commit
  23. 09 Aug, 2018 1 commit
    • Mark Olesen's avatar
      ENH: ignore -noFunctionObjects option when disabled · b63191a0
      Mark Olesen authored
      - With argList::noFunctionObjects() we use the logic added in
        4b3a34f0 (issue #352)
      
        By removing the '-noFunctionObjects' option, we automatically
        suppress the creation of function-objects via Time (with argList
        as a parameter).
        There is generally no need in these cases for an additional
      
            runTime.functionObjects().off()  statement
      
        Use the argList::noFunctionObjects() for more direct configuration
        and reduce unnecessary clutter in the -help information.
      
        In previous versions, the -noFunctionObjects would have been redundant
        anyhow, so we can also just ignore it now instead.
      b63191a0
  24. 07 Aug, 2018 1 commit
  25. 27 Jun, 2018 1 commit
  26. 26 Jun, 2018 2 commits
  27. 25 Jun, 2018 1 commit
    • Mark Olesen's avatar
      CONFIG: eliminate most occurances of outdated FOAM_INST_DIR (issue #444) · 6ed971a9
      Mark Olesen authored
      - since 1612, FOAM_INST_DIR and foamInstDir longer have any
        special meanings when sourcing the bashrc or cshrc files.
        Thus no need for special treatment in any of the dispatch wrappers.
      
        Retained FOAM_INST_DIR as (unexported) variable in etc/bashrc,
        just in case people are using patched versions of etc/bashrc
        as part of their installation.
      
      ENH: relax prefix restrictions on foamCreateVideo (issue #904)
      
      - shift the implicit '.' to be part of the default prefix. This allows
        things like "-image myimages_00" to work as might be expected.
      6ed971a9