1. 01 Feb, 2019 1 commit
  2. 13 Dec, 2018 1 commit
    • Mark Olesen's avatar
      ENH: consolidate handling of mandatory/optional command arguments · 4aeb97b5
      Mark Olesen authored
      - for some special cases we wish to mark command-line arguments as
        being optional, in order to do our own treatment. For example,
        when an arbitrary number of arguments should be allowed.
      
        Now tag this situation with argList::noMandatoryArgs().
        The argList::argsMandatory() query can then be used in any further
        logic, including the standard default argument checking.
      
      - with the new default check, can consolidate the special-purpose
      
            "setRootCaseNonMandatoryArgs.H"
      
        into the regular
      
            "setRootCase.H"
      
      - revert to a simple "setRootCase.H" and move all the listing related
        bits to a "setRootCaseLists.H" file. This leaves the information
        available for solvers, or whoever else wishes, without being
        introduced everywhere.
      
      - add include guards and scoping to the listing files and rename to
        something less generic.
      
           listOptions.H -> setRootCaseListOptions.H
           listOutput.H  -> setRootCaseListOutput.H
      4aeb97b5
  3. 11 Dec, 2018 1 commit
  4. 05 Jul, 2018 1 commit
    • Mark Olesen's avatar
      ENH: improve controls for Time (issue #910) · 1fe7a4f5
      Mark Olesen authored
      - relocate some standard functionality to TimePaths to allow a lighter
        means of managing time directories without using the entire Time
        mechanism.
      
      - optional enableLibs for Time construction (default is on)
        and a corresponding argList::noLibs() and "-no-libs" option
      
      STYLE:
      
      - mark Time::outputTime() as deprecated MAY-2016
      
      - use pre-increment for runTime, although there is no difference in
        behaviour or performance.
      1fe7a4f5
  5. 01 Jun, 2018 1 commit
  6. 27 Apr, 2018 1 commit
    • Mark Olesen's avatar
      ENH: make format of ExecutionTime = ... output configurable (issue #788) · b77e4888
      Mark Olesen authored
      - controlled by the the 'printExecutionFormat' InfoSwitch in
        etc/controlDict
      
            // Style for "ExecutionTime = " output
            // - 0 = seconds (with trailing 's')
            // - 1 = day-hh:mm:ss
      
         ExecutionTime = 112135.2 s  ClockTime = 113017 s
      
         ExecutionTime = 1-07:08:55.20  ClockTime = 1-07:23:37
      
      - Callable via the new Time::printExecutionTime() method,
        which also helps to reduce clutter in the applications.
        Eg,
      
           runTime.printExecutionTime(Info);
      
        vs
      
           Info<< "ExecutionTime = " << runTime.elapsedCpuTime() << " s"
               << "  ClockTime = " << runTime.elapsedClockTime() << " s"
               << nl << endl;
      
      --
      
      ENH: return elapsedClockTime() and clockTimeIncrement as double
      
      - previously returned as time_t, which is less portable.
      b77e4888
  7. 03 Apr, 2018 1 commit
    • Mark Olesen's avatar
      STYLE: more consistent use of dimensioned Zero · 5632ef2d
      Mark Olesen authored
      - when constructing dimensioned fields that are to be zero-initialized,
        it is preferrable to use a form such as
      
            dimensionedScalar(dims, Zero)
            dimensionedVector(dims, Zero)
      
        rather than
      
            dimensionedScalar("0", dims, 0)
            dimensionedVector("zero", dims, vector::zero)
      
        This reduces clutter and also avoids any suggestion that the name of
        the dimensioned quantity has any influence on the field's name.
      
        An even shorter version is possible. Eg,
      
            dimensionedScalar(dims)
      
        but reduces the clarity of meaning.
      
      - NB: UniformDimensionedField is an exception to these style changes
        since it does use the name of the dimensioned type (instead of the
        regIOobject).
      5632ef2d
  8. 19 Jul, 2017 1 commit
  9. 24 May, 2017 1 commit
  10. 27 Apr, 2017 1 commit
  11. 16 Dec, 2016 1 commit
  12. 15 Dec, 2016 1 commit
  13. 27 Jun, 2016 1 commit
  14. 31 May, 2016 1 commit
  15. 08 May, 2016 2 commits
  16. 01 May, 2016 1 commit
  17. 13 Feb, 2016 1 commit
    • Henry Weller's avatar
      Solvers: Added support for extrapolated pressure boundary conditions · acaf72b4
      Henry Weller authored
      The boundary conditions of HbyA are now constrained by the new "constrainHbyA"
      function which applies the velocity boundary values for patches for which the
      velocity cannot be modified by assignment and pressure extrapolation is
      not specified via the new
      "fixedFluxExtrapolatedPressureFvPatchScalarField".
      
      The new function "constrainPressure" sets the pressure gradient
      appropriately for "fixedFluxPressureFvPatchScalarField" and
      "fixedFluxExtrapolatedPressureFvPatchScalarField" boundary conditions to
      ensure the evaluated flux corresponds to the known velocity values at
      the boundary.
      
      The "fixedFluxPressureFvPatchScalarField" boundary condition operates
      exactly as before, ensuring the correct flux at fixed-flux boundaries by
      compensating for the body forces (gravity in particular) with the
      pressure gradient.
      
      The new "fixedFluxExtrapolatedPressureFvPatchScalarField" boundary
      condition may be used for cases with or without body-forces to set the
      pressure gradient to compensate not only for the body-force but also the
      extrapolated "HbyA" which provides a second-order boundary condition for
      pressure.  This is useful for a range a problems including impinging
      flow, extrapolated inlet conditions with body-forces or for highly
      viscous flows, pressure-induced separation etc.  To test this boundary
      condition at walls in the motorBike tutorial case set
      
          lowerWall
          {
              type            fixedFluxExtrapolatedPressure;
          }
      
          motorBikeGroup
          {
              type            fixedFluxExtrapolatedPressure;
          }
      
      Currently the new extrapolated pressure boundary condition is supported
      for all incompressible and sub-sonic compressible solvers except those
      providing implicit and tensorial porosity support.  The approach will be
      extended to cover these solvers and options in the future.
      
      Note: the extrapolated pressure boundary condition is experimental and
      requires further testing to assess the range of applicability,
      stability, accuracy etc.
      
      Henry G. Weller
      CFD Direct Ltd.
      acaf72b4
  18. 03 Dec, 2015 1 commit
  19. 02 Dec, 2015 1 commit
    • Henry Weller's avatar
      fvOptions: Reorganized and updated to simplify use in sub-models and maintenance · 9a536b02
      Henry Weller authored
      fvOptions are transferred to the database on construction using
      fv::options::New which returns a reference.  The same function can be
      use for construction and lookup so that fvOptions are now entirely
      demand-driven.
      
      The abstract base-classes for fvOptions now reside in the finiteVolume
      library simplifying compilation and linkage.  The concrete
      implementations of fvOptions are still in the single monolithic
      fvOptions library but in the future this will be separated into smaller
      libraries based on application area which may be linked at run-time in
      the same manner as functionObjects.
      9a536b02
  20. 01 Dec, 2015 1 commit
  21. 19 Jul, 2015 1 commit
  22. 17 Mar, 2015 1 commit
    • Henry's avatar
      Solvers based on p_rgh: Added support for optional hRef · afcd290d
      Henry authored
      Allows the specification of a reference height, for example the height
      of the free-surface in a VoF simulation, which reduces the range of p_rgh.
      
      hRef is a uniformDimensionedScalarField specified via the constant/hRef
      file, equivalent to the way in which g is specified, so that it can be
      looked-up from the database.  For example see the constant/hRef file in
      the DTCHull LTSInterFoam and interDyMFoam cases.
      afcd290d
  23. 11 Feb, 2015 1 commit
  24. 10 Feb, 2015 1 commit
  25. 09 Feb, 2015 1 commit
  26. 21 Jan, 2015 1 commit
    • Henry's avatar
      Updated the whole of OpenFOAM to use the new templated TurbulenceModels library · 93732c8a
      Henry authored
      The old separate incompressible and compressible libraries have been removed.
      
      Most of the commonly used RANS and LES models have been upgraded to the
      new framework but there are a few missing which will be added over the
      next few days, in particular the realizable k-epsilon model.  Some of
      the less common incompressible RANS models have been introduced into the
      new library instantiated for incompressible flow only.  If they prove to
      be generally useful they can be templated for compressible and
      multiphase application.
      
      The Spalart-Allmaras DDES and IDDES models have been thoroughly
      debugged, removing serious errors concerning the use of S rather than
      Omega.
      
      The compressible instances of the models have been augmented by a simple
      backward-compatible eddyDiffusivity model for thermal transport based on
      alphat and alphaEff.  This will be replaced with a separate run-time
      selectable thermal transport model framework in a few weeks.
      
      For simplicity and ease of maintenance and further development the
      turbulent transport and wall modeling is based on nut/nuEff rather than
      mut/muEff for compressible models so that all forms of turbulence models
      can use the same wall-functions and other BCs.
      
      All turbulence model selection made in the constant/turbulenceProperties
      dictionary with RAS and LES as sub-dictionaries rather than in separate
      files which added huge complexity for multiphase.
      
      All tutorials have been updated so study the changes and update your own
      cases by comparison with similar cases provided.
      
      Sorry for the inconvenience in the break in backward-compatibility but
      this update to the turbulence modeling is an essential step in the
      future of OpenFOAM to allow more models to be added and maintained for a
      wider range of cases and physics.  Over the next weeks and months more
      turbulence models will be added of single and multiphase flow, more
      additional sub-models and further development and testing of existing
      models.  I hope this brings benefits to all OpenFOAM users.
      
      Henry G. Weller
      93732c8a
  27. 10 Dec, 2014 1 commit