OpenFOAM-plus issueshttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues2017-12-18T23:15:10Zhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/555refinements for lumped movement2017-12-18T23:15:10ZMark OLESENrefinements for lumped movement- could add the current simulation time to the forces/moments file, to allow for movement that is time-dependent only (ie, ignores forces). Allowing the boundary condition to provide a forced movement only.
- may need additional handlin...- could add the current simulation time to the forces/moments file, to allow for movement that is time-dependent only (ie, ignores forces). Allowing the boundary condition to provide a forced movement only.
- may need additional handling of clamping at (0,0,0) - fixed, interpolate etc.
Ref: telephone with @Roger on 2-Aug-2017v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/562simulation stop at reaching a preset wall time2019-11-25T07:22:28ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsimulation stop at reaching a preset wall timeFeature to stop the simulation at a prescribed wall time (and write the results?). This is for running under batch queueing systems to avoid them killing the job. (or can the queueing system 'warn' us when it wants us to stop (and give s...Feature to stop the simulation at a prescribed wall time (and write the results?). This is for running under batch queueing systems to avoid them killing the job. (or can the queueing system 'warn' us when it wants us to stop (and give some time for writing)?)https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/572snappyHexMesh : visualising connection between inside and outside points2017-08-17T09:01:13ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsnappyHexMesh : visualising connection between inside and outside pointsWould be nice to have a leak-detection process, either built-in or stand-alone, that can detect mesh paths between provided 'inside' and 'outside' points.Would be nice to have a leak-detection process, either built-in or stand-alone, that can detect mesh paths between provided 'inside' and 'outside' points.https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/361Add in architecture checking IOobjects read.2017-09-27T08:49:24ZMark OLESENAdd in architecture checking IOobjects read.Placeholder for topics related to "arch" handling (endian, label and scalar sizes) that was added for v1612.
We now emit arch hints such "LSB,label=32,scalar=64", but don't do anything with them on input.
The first point is to simply to...Placeholder for topics related to "arch" handling (endian, label and scalar sizes) that was added for v1612.
We now emit arch hints such "LSB,label=32,scalar=64", but don't do anything with them on input.
The first point is to simply to check their types on input: "arch" exists and is identical to the current OpenFOAM configuration.
The next would be a special-purpose foam-convert utility. Handling a change from int64 to int32 might only work in very special cases. For example, when snappy needs 64-bit labels because the input surfaces have so many points and faces, but the resulting mesh would still fit with int32.Version v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/326ENH: wmake for file with future timestamp2017-09-27T08:49:24ZPrashant SonakarENH: wmake for file with future timestampPlaceholder for check for files with future time stamp (when transferred between different systems)Placeholder for check for files with future time stamp (when transferred between different systems)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/138writePrecision for sampled items2017-09-27T08:49:24ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comwritePrecision for sampled itemswritePrecision is definable for FOs but not
- surface writers (except for VTK; Ensight not possible)
- set writers
We could e.g. use IOstream::defaultPrecision which even without a runTime (e.g. surfaceConvert) still is set from etc/c...writePrecision is definable for FOs but not
- surface writers (except for VTK; Ensight not possible)
- set writers
We could e.g. use IOstream::defaultPrecision which even without a runTime (e.g. surfaceConvert) still is set from etc/controlDict to 7.https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/246Add sudo to docker container2017-09-27T08:49:25ZBernhard GschaiderAdd sudo to docker containerIn the install script /etc/profile.d is projected into the container. Which is great because that way a non-root access for installing software etc could be set up. Problem is that sudo currently is not installed in the container.In the install script /etc/profile.d is projected into the container. Which is great because that way a non-root access for installing software etc could be set up. Problem is that sudo currently is not installed in the container.Pawan GhildiyalPawan Ghildiyalhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/723Function1 missing Integrate function definition2018-02-02T13:27:43ZMatej FormanFunction1 missing Integrate function definitionOnly few functions from **Function1** has function **Integrate** implemented
(*table, CSV table, Polynomial and Zero/One*).
Those without the Integrate function definition cannot be used to specify the **motion function** for DyM.
Woul...Only few functions from **Function1** has function **Integrate** implemented
(*table, CSV table, Polynomial and Zero/One*).
Those without the Integrate function definition cannot be used to specify the **motion function** for DyM.
Would make sense to add the definition to others as well.https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/727checkMesh report on volume of cellZones2018-07-04T11:09:43ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcheckMesh report on volume of cellZonesCurrently checkMesh reports on bb of cellZone but not the volume. This would be nice to have. Attached a hack.[checkTopology.C](/uploads/6e375995442c91c5aa45f31290ac675c/checkTopology.C)
? For all zone types report:
cellZone : nCells + ...Currently checkMesh reports on bb of cellZone but not the volume. This would be nice to have. Attached a hack.[checkTopology.C](/uploads/6e375995442c91c5aa45f31290ac675c/checkTopology.C)
? For all zone types report:
cellZone : nCells + volume
faceZone : nFaces + area + signed area (i.e. closedness)
pointZone : nPoints
https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/747Additional time control to functionObjects2018-03-06T10:50:24ZNiels G JacobsenAdditional time control to functionObjectsHi,
I am missing a flavour of time control in the function objects, namely an approximate output interval. For some of the applications that I am running, it is restrictive to use adjustableRunTime, because it affects the execution too ...Hi,
I am missing a flavour of time control in the function objects, namely an approximate output interval. For some of the applications that I am running, it is restrictive to use adjustableRunTime, because it affects the execution too much and the time steps become integer ratios of the output interval, however, the timeStep output provides too much data. Often, I do not care that the output time axis is non-equidistant.
I have added a new flavour which I call "approximateFixedInterval" and it simply outputs the sampling, if the time is greater than or equal to an integer times the output interval (the integer being larger than the one at the previous output time). Could the addition be adopted (perhaps with a nicer name) in the next release? The required modifications to functionObjects/timeControl/timeControl.[C,H] is attached to this report.
Thank you
Niels
P.S. I know that it is not really an issue, but it seemed to be the only way of making a request.
[timeControl.H](/uploads/c49e31d1d8fda3eb9662f68ed05132b3/timeControl.H)
[timeControl.C](/uploads/f28679a18ddd72a438b6b5c6615dfd63/timeControl.C)https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/822Function1 could use faster searching in input is sorted2018-05-08T10:39:58ZPrashant SonakarFunction1 could use faster searching in input is sortedIf the table is sorted in increasing order we could use a binary search (e.g. ListOps::findLower) to speed up interpolation.If the table is sorted in increasing order we could use a binary search (e.g. ListOps::findLower) to speed up interpolation.https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/937decomposePar - disallow decomposition of 2D case along thickness2018-07-26T15:23:07ZPrashant SonakardecomposePar - disallow decomposition of 2D case along thicknessIs it possible to warn/ error when attempting to decompose along thickness?
@Mattijs @mark @andyIs it possible to warn/ error when attempting to decompose along thickness?
@Mattijs @mark @andyMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/961BUG: avoid initiating fvOptions in SHM process2018-09-17T09:49:53ZPrashant SonakarBUG: avoid initiating fvOptions in SHM processRefer EP#760
```
Layer addition iteration 0
--------------------------
Determining displacement for added points according to pointNormal ...
Detected 0 points with point normal pointing through faces.
Reset displacement at 0 points to ...Refer EP#760
```
Layer addition iteration 0
--------------------------
Determining displacement for added points according to pointNormal ...
Detected 0 points with point normal pointing through faces.
Reset displacement at 0 points to average of surrounding points.
fieldSmoother : Smoothing field ...
Iteration 0 residual 7.07211044e-05
Creating finite volume options from "system/fvOptions"
Selecting finite volume options type limitTemperature
Source: limitT
- selecting all cells
- selected 59289 cell(s) with volume 1.600752072
--> FOAM FATAL ERROR:
request for basicThermo thermophysicalProperties from objectRegistry region0 failed
available objects of type basicThermo are
```Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/986snappyHexMesh does not extrude (using medialAxis) in thin gaps2018-08-30T11:38:48ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsnappyHexMesh does not extrude (using medialAxis) in thin gapsThe medialAxis shrinker by default used to disable edges with any point
on an extruded wall to contain the medial axis. Now this is a bit more
intelligent and it only checks the actual medial axis point to be away from
the wall.
```
// R...The medialAxis shrinker by default used to disable edges with any point
on an extruded wall to contain the medial axis. Now this is a bit more
intelligent and it only checks the actual medial axis point to be away from
the wall.
```
// Revert to <=1806 behaviour:
disableWallEdges true;
```
Below is a hacked version of the addLayersToFaceZones tutorials where the 'B' faceZone has been shifted to be one
cell to the right of the 'A' faceZone.
1806 (or with `disableWallEdges false`)
![disableWallEdges_on](/uploads/8807b57094525080c75ec7fcaed97a02/disableWallEdges_on.png)
develop:
![disableWallEdges_off](/uploads/f2f9659340c23c698ce8117e8f836850/disableWallEdges_off.png)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1223potentialFoam with -region option2019-02-28T17:05:32ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.compotentialFoam with -region option### Functionality to add/problem to solve
(Brief scope)
Option to run potentialFoam with -region
### Target audience
(Who will benefit from the changes?)
(What type of cases?)
### Proposal
(How are we going to solve the problem?)...### Functionality to add/problem to solve
(Brief scope)
Option to run potentialFoam with -region
### Target audience
(Who will benefit from the changes?)
(What type of cases?)
### Proposal
(How are we going to solve the problem?)
Add handling of region name as command line argument. Feed through the -dry-run mesh handling.
### What does success look like, and how can we measure that?
(What are the success factors and acceptance criteria? e.g. test cases, error margins)
### Links / references
(Links to literature, supporting information)
### Funding
(Does the functionality already exist/is sponsorship available?)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1227ENH: Inform users that the functionObject in question is disabled when it thr...2019-03-06T10:08:56ZKutalmış BerçinENH: Inform users that the functionObject in question is disabled when it throws FatalErrorInFunction-type warnings### Functionality to add/problem to solve
I initialised a variable in the constructor of a (developing) functionObject via a function call which involves a check with `FatalErrorInFunction`:
```
bool Foam::functionObjects::myFunctionOb...### Functionality to add/problem to solve
I initialised a variable in the constructor of a (developing) functionObject via a function call which involves a check with `FatalErrorInFunction`:
```
bool Foam::functionObjects::myFunctionObject::isTemporalVariant
(
const bool runTimeModifiable
) const
{
if (runTimeModifiable)
{
FatalErrorInFunction
<< "Available only for fixed time-step computations."
<< exit(FatalError);
}
return false;
}
```
```
//... Member initialiser list in the constructor
isTemporalVariant_(isTemporalVariant(runTime.runTimeModifiable())),
//...
```
`FatalErrorInFunction` is called when the user sets `controlDict\runTimeModifiable true`.
`FatalErrorInFunction` throws `FOAM Warning` instead of `FOAM FATAL ERROR`.
```
-> FOAM Warning :
Available only for fixed time-step computations.
From function bool Foam::functionObjects::myFunctionObject::isTemporalVariant(bool) const
in file streamingTotalDMD.C at line 53.
From function bool Foam::functionObjectList::read()
in file db/functionObjects/functionObjectList/functionObjectList.C at line 896
--> while loading function object 'myFunctionObject1'
```
Yet, IMHO, the user was not informed that the functionObject is disabled, and the computation is let to run.
### Target audience
Users of functionObjects.
### Proposal
Append information stating that the relevant functionObject is disabled, and the remaining functionObjects and the computation itself are allowed to continue their run.
### What does success look like, and how can we measure that?
N/A
### Links / references
N/A
### Funding
N/Ahttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1233moveDynamicMesh with -overwrite2019-03-14T12:45:39ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.commoveDynamicMesh with -overwrite### Functionality to add/problem to solve
(Brief scope)
moveDynamicMesh can be used to modify the initial mesh (i.e. as a meshing tool). An option to enforce the points being written to the constant/ directory might be nice.
Attached ...### Functionality to add/problem to solve
(Brief scope)
moveDynamicMesh can be used to modify the initial mesh (i.e. as a meshing tool). An option to enforce the points being written to the constant/ directory might be nice.
Attached is a version that has the -overwrite. Not sure whether it should run to completion or only one timestep (which is useful since now timeValue stays at 0)
[moveDynamicMesh.C](/uploads/fbdffbde320ce6dd99b9d83c55cf4a6e/moveDynamicMesh.C)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1253missing -dict on some utilities2019-03-27T10:40:41ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.commissing -dict on some utilities### Functionality to add/problem to solve
Some utilities are still missing the -dict option to specify an alternative location.
E.g. extrudeMesh.### Functionality to add/problem to solve
Some utilities are still missing the -dict option to specify an alternative location.
E.g. extrudeMesh.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1255snappyHexMesh with sloppy patch following2019-03-27T16:18:23ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsnappyHexMesh with sloppy patch following### Functionality to add/problem to solve
snappyHexMesh will try to merge co-planar faces on a single cell into a single, large face. This minimises the individual distortion and generates more layers. It will not merge faces belonging ...### Functionality to add/problem to solve
snappyHexMesh will try to merge co-planar faces on a single cell into a single, large face. This minimises the individual distortion and generates more layers. It will not merge faces belonging to different patches. Occasionally it would be nice to merge across patches (saving the effort of merging the regions in the surface)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1279fieldToCell does not use lookup; always reads from disk2019-04-11T08:34:11ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comfieldToCell does not use lookup; always reads from disk### Functionality to add/problem to solve
fieldToCell currently always reads from disk. Hence it cannot be used in e.g. a functionObject to select some cells during the run (). Would be nice if it would try lookup first instead.
### Pr...### Functionality to add/problem to solve
fieldToCell currently always reads from disk. Hence it cannot be used in e.g. a functionObject to select some cells during the run (). Would be nice if it would try lookup first instead.
### Proposal
- add database lookup first and loading from disk only if that fails
- move fieldToCell to finiteVolume and use proper fields
Example of desired use: plot all cells where the pressure is between 5 and 1000.
```
vtkWrite1
{
type vtkWrite;
libs ("libutilityFunctionObjects.so");
timeStart 10;
writeControl timeStep;
writeInterval 1;
format binary;
legacy false;
decompose false;
fields (p U);
selection
{
threshold
{
action use;
source fieldToCell;
field p;
min 5;
max 1000;
}
}
}
```
There is currently also a bug in that it searches for the last valid p,U instead of loading them from the current time (and failing).
https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1353topoSet: No warning when using inconsistent setup2019-07-03T04:56:26ZPrashant SonakartopoSet: No warning when using inconsistent setup### Functionality to add/problem to solve
When setup is inconsistent, e.g. type cellSet, while source e.g. boxToFace, there is no warning/ error.
The cellSet is created with faces as labels. This should be checked for consistency.
@mark### Functionality to add/problem to solve
When setup is inconsistent, e.g. type cellSet, while source e.g. boxToFace, there is no warning/ error.
The cellSet is created with faces as labels. This should be checked for consistency.
@markhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1466(wallBounded)streamLine FO does not do bi-directional tracking2019-10-23T15:55:53ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.com(wallBounded)streamLine FO does not do bi-directional tracking### Functionality to add/problem to solve
Add bi-directional tracking to streamlines.
### What does success look like, and how can we measure that?
Put e.g. seeds into recirculation zone and see if we can track back and forwards.### Functionality to add/problem to solve
Add bi-directional tracking to streamlines.
### What does success look like, and how can we measure that?
Put e.g. seeds into recirculation zone and see if we can track back and forwards.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1472dynamicCode should use polling instead of re-checking only once2019-11-27T14:16:35ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comdynamicCode should use polling instead of re-checking only once### Functionality to add/problem to solve
db/dynamicLibrary/dynamicCode/dynamicCode.C in parallel can have that the library does not exist on all slave processors. It first checks at beginning and then waits 'fileModificationSkew' secon...### Functionality to add/problem to solve
db/dynamicLibrary/dynamicCode/dynamicCode.C in parallel can have that the library does not exist on all slave processors. It first checks at beginning and then waits 'fileModificationSkew' seconds and rechecks. If this fails the code will fail. Nicer if the check gets done multiple times before failing.
Alternatively send over the library (is this possible? is it cross-node compatible?)https://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1491SnappyHexMesh: Treat feature edge/cell between different PID for layer addtition2019-11-12T12:09:21ZPrashant SonakarSnappyHexMesh: Treat feature edge/cell between different PID for layer addtition### Functionality to add/problem to solve
Using mutli-region feature edge we can capture in-plane edges. Improve the snapping to help generate layers at this section.
### Links / references
EP#1084### Functionality to add/problem to solve
Using mutli-region feature edge we can capture in-plane edges. Improve the snapping to help generate layers at this section.
### Links / references
EP#1084Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/OpenFOAM-plus/-/issues/1510support specified time for trasformPoints2019-11-25T18:34:03ZPrashant Sonakarsupport specified time for trasformPoints### Functionality to add/problem to solve
transformPoints reads time from points instance. But it might be nice to operate on given time.
### Proposal
As discussed with @mark Use given time or default to constant### Functionality to add/problem to solve
transformPoints reads time from points instance. But it might be nice to operate on given time.
### Proposal
As discussed with @mark Use given time or default to constantMark OLESENMark OLESEN