diff --git a/applications/solvers/combustion/fireFoam/Make/options b/applications/solvers/combustion/fireFoam/Make/options index 4854f5d34af989353dc22dfba84268f25a38b4ac..168acd3d4a8c6938dc1db9be25144d21239f6bd1 100644 --- a/applications/solvers/combustion/fireFoam/Make/options +++ b/applications/solvers/combustion/fireFoam/Make/options @@ -1,8 +1,8 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/distributionModels/lnInclude \ diff --git a/applications/solvers/lagrangian/coalChemistryFoam/Make/options b/applications/solvers/lagrangian/coalChemistryFoam/Make/options index 67ee0526674c26bb80f37d3054e3185a61cbbc7c..4ad101ffd25ccafe2531167680cce17307e55570 100644 --- a/applications/solvers/lagrangian/coalChemistryFoam/Make/options +++ b/applications/solvers/lagrangian/coalChemistryFoam/Make/options @@ -1,7 +1,7 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/basic/lnInclude \ diff --git a/applications/solvers/lagrangian/reactingParcelFoam/Make/options b/applications/solvers/lagrangian/reactingParcelFoam/Make/options index 81dbe56372533a6d9fa7fbf4f444f617ffc11560..44f50c4dfd498dd9cd9a2b03211ca98aeb881504 100644 --- a/applications/solvers/lagrangian/reactingParcelFoam/Make/options +++ b/applications/solvers/lagrangian/reactingParcelFoam/Make/options @@ -2,10 +2,10 @@ EXE_INC = \ -I../reactingParcelFoam \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/dynamicMesh/lnInclude \ -I$(LIB_SRC)/dynamicFvMesh/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/distributionModels/lnInclude \ diff --git a/applications/solvers/lagrangian/reactingParcelFoam/reactingHeterogenousParcelFoam/Make/options b/applications/solvers/lagrangian/reactingParcelFoam/reactingHeterogenousParcelFoam/Make/options index d2b25e0a671098bac1402eb0d5536798881eeeed..92af84338a44b29c17b862eb6569a0fd3c944b21 100644 --- a/applications/solvers/lagrangian/reactingParcelFoam/reactingHeterogenousParcelFoam/Make/options +++ b/applications/solvers/lagrangian/reactingParcelFoam/reactingHeterogenousParcelFoam/Make/options @@ -2,8 +2,8 @@ EXE_INC = \ -I.. \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/dynamicMesh/lnInclude \ -I$(LIB_SRC)/dynamicFvMesh/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ diff --git a/applications/solvers/lagrangian/reactingParcelFoam/simpleReactingParcelFoam/Make/options b/applications/solvers/lagrangian/reactingParcelFoam/simpleReactingParcelFoam/Make/options index 3e1485606fd80215326ef8a68b0c8b876cfffd97..dd75d29d96047f15e2243dad7715e0ee94b42696 100644 --- a/applications/solvers/lagrangian/reactingParcelFoam/simpleReactingParcelFoam/Make/options +++ b/applications/solvers/lagrangian/reactingParcelFoam/simpleReactingParcelFoam/Make/options @@ -1,7 +1,7 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ diff --git a/applications/solvers/lagrangian/simpleCoalParcelFoam/Make/options b/applications/solvers/lagrangian/simpleCoalParcelFoam/Make/options index 2b0ed56ead2d05080ec3539d72c2d03a1631708f..4b4a37ba5a2cfb3b56a59b4c078c8735cf2965b6 100644 --- a/applications/solvers/lagrangian/simpleCoalParcelFoam/Make/options +++ b/applications/solvers/lagrangian/simpleCoalParcelFoam/Make/options @@ -2,7 +2,7 @@ EXE_INC = \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ -I$(LIB_SRC)/fvOptions/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/basic/lnInclude \ diff --git a/applications/solvers/lagrangian/sprayFoam/Make/options b/applications/solvers/lagrangian/sprayFoam/Make/options index 7ec29ea7dc8f26ab7545cfb4afe52744211674ce..bc58479e9da8bfad1b18ade2b689412dda97d941 100644 --- a/applications/solvers/lagrangian/sprayFoam/Make/options +++ b/applications/solvers/lagrangian/sprayFoam/Make/options @@ -2,8 +2,8 @@ EXE_INC = \ -I../reactingParcelFoam \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/basic/lnInclude \ diff --git a/applications/solvers/lagrangian/sprayFoam/engineFoam/Make/options b/applications/solvers/lagrangian/sprayFoam/engineFoam/Make/options index 4f13ec336452f60c9d4d9d660c7985d1e37c2526..519f8e499638440564aa865ec5516508f4fb8209 100644 --- a/applications/solvers/lagrangian/sprayFoam/engineFoam/Make/options +++ b/applications/solvers/lagrangian/sprayFoam/engineFoam/Make/options @@ -4,8 +4,8 @@ EXE_INC = \ -I../../reactingParcelFoam \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/basic/lnInclude \ diff --git a/applications/solvers/lagrangian/sprayFoam/simpleSprayFoam/Make/options b/applications/solvers/lagrangian/sprayFoam/simpleSprayFoam/Make/options index 44c94feb023b9e0f89ecd1936d80ee5491439f92..f1c12cccaee00a1329a173ce61b22b2819508a96 100644 --- a/applications/solvers/lagrangian/sprayFoam/simpleSprayFoam/Make/options +++ b/applications/solvers/lagrangian/sprayFoam/simpleSprayFoam/Make/options @@ -2,7 +2,7 @@ EXE_INC = \ -I$(FOAM_SOLVERS)/lagrangian/reactingParcelFoam/simpleReactingParcelFoam \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ diff --git a/applications/solvers/lagrangian/sprayFoam/sprayDyMFoam/Make/options b/applications/solvers/lagrangian/sprayFoam/sprayDyMFoam/Make/options index 879780b5e089feb214a2170d528fcd050caba0c3..288d31ce721ef4a911d86ced3a65b68f356fe7e0 100644 --- a/applications/solvers/lagrangian/sprayFoam/sprayDyMFoam/Make/options +++ b/applications/solvers/lagrangian/sprayFoam/sprayDyMFoam/Make/options @@ -4,8 +4,8 @@ EXE_INC = \ -I../../../compressible/rhoPimpleFoam \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ - -I${LIB_SRC}/sampling/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude \ + -I$(LIB_SRC)/sampling/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/turbulenceModels/lnInclude \ -I$(LIB_SRC)/TurbulenceModels/compressible/lnInclude \ -I$(LIB_SRC)/lagrangian/basic/lnInclude \ diff --git a/applications/test/Hashing1/Make/options b/applications/test/Hashing1/Make/options index 7dba39797af85b1eab2a90d719c7d43abc2309f1..ab5895cb5cc2b231f8b668b1fd18a08737377b71 100644 --- a/applications/test/Hashing1/Make/options +++ b/applications/test/Hashing1/Make/options @@ -1,3 +1,3 @@ -EXE_INC = ${c++LESSWARN} +EXE_INC = $(c++LESSWARN) /* EXE_LIBS = */ diff --git a/applications/test/Hashing2/Make/options b/applications/test/Hashing2/Make/options index 7dba39797af85b1eab2a90d719c7d43abc2309f1..ab5895cb5cc2b231f8b668b1fd18a08737377b71 100644 --- a/applications/test/Hashing2/Make/options +++ b/applications/test/Hashing2/Make/options @@ -1,3 +1,3 @@ -EXE_INC = ${c++LESSWARN} +EXE_INC = $(c++LESSWARN) /* EXE_LIBS = */ diff --git a/applications/test/HashingSpeed/Make/options b/applications/test/HashingSpeed/Make/options index 7dba39797af85b1eab2a90d719c7d43abc2309f1..ab5895cb5cc2b231f8b668b1fd18a08737377b71 100644 --- a/applications/test/HashingSpeed/Make/options +++ b/applications/test/HashingSpeed/Make/options @@ -1,3 +1,3 @@ -EXE_INC = ${c++LESSWARN} +EXE_INC = $(c++LESSWARN) /* EXE_LIBS = */ diff --git a/applications/test/faceHashing/Make/options b/applications/test/faceHashing/Make/options index 7dba39797af85b1eab2a90d719c7d43abc2309f1..ab5895cb5cc2b231f8b668b1fd18a08737377b71 100644 --- a/applications/test/faceHashing/Make/options +++ b/applications/test/faceHashing/Make/options @@ -1,3 +1,3 @@ -EXE_INC = ${c++LESSWARN} +EXE_INC = $(c++LESSWARN) /* EXE_LIBS = */ diff --git a/applications/test/fieldTypes/Make/options b/applications/test/fieldTypes/Make/options index 3a7088aeeac0f70aca2914ffce68963629f3efca..2526f4eb0e6970a6cc43123f2c5c752687ceb3e9 100644 --- a/applications/test/fieldTypes/Make/options +++ b/applications/test/fieldTypes/Make/options @@ -1,7 +1,7 @@ EXE_INC = \ -I$(LIB_SRC)/finiteArea/lnInclude \ - -I${LIB_SRC}/finiteVolume/lnInclude \ - -I${LIB_SRC}/meshTools/lnInclude \ + -I$(LIB_SRC)/finiteVolume/lnInclude \ + -I$(LIB_SRC)/meshTools/lnInclude EXE_LIBS = \ -lfiniteArea \ diff --git a/applications/test/openmp/Make/options b/applications/test/openmp/Make/options index 9c1cb59980fc47cffd7dac5118ab031247ab6c36..5094191b4d2c8ab3a212ababb6aaf0f14284316f 100644 --- a/applications/test/openmp/Make/options +++ b/applications/test/openmp/Make/options @@ -1,4 +1,4 @@ -EXE_INC = ${COMP_OPENMP} /* -UUSE_OMP */ +EXE_INC = $(COMP_OPENMP) /* -UUSE_OMP */ /* Mostly do not need to explicitly link openmp libraries */ -/* EXE_LIBS = ${LINK_OPENMP} */ +/* EXE_LIBS = $(LINK_OPENMP) */ diff --git a/applications/utilities/mesh/manipulation/renumberMesh/Make/options b/applications/utilities/mesh/manipulation/renumberMesh/Make/options index 7956e8e8dc2e1674bce2e701b5f30ccfbb1c20c5..2faf0b8ed1c9cdb453e06522af29a109745e1cf9 100644 --- a/applications/utilities/mesh/manipulation/renumberMesh/Make/options +++ b/applications/utilities/mesh/manipulation/renumberMesh/Make/options @@ -3,7 +3,7 @@ */ EXE_INC = \ - ${COMP_FLAGS} \ + $(COMP_FLAGS) \ -I$(LIB_SRC)/finiteVolume/lnInclude \ -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/dynamicMesh/lnInclude \ diff --git a/src/OpenFOAM/primitives/ints/label/label.C b/src/OpenFOAM/primitives/ints/label/label.C index 61a25437898d390caab4daa13c3689d8a78d7914..cde1cd2b05a6d536e160ba67113b44f40460fd84 100644 --- a/src/OpenFOAM/primitives/ints/label/label.C +++ b/src/OpenFOAM/primitives/ints/label/label.C @@ -151,7 +151,7 @@ Foam::label Foam::factorial(label n) }; #ifdef FULLDEBUG - if (n > 12 && n < 0) + if (n < 0 || n > 12) { FatalErrorInFunction << "n value out of range" diff --git a/src/renumber/SloanRenumber/Make/options b/src/renumber/SloanRenumber/Make/options index 23dc9dd623f5e4bcc44ea852b39050c2517d8aaa..5af9c713eeecdfb186321cd1633795c5fa38e122 100644 --- a/src/renumber/SloanRenumber/Make/options +++ b/src/renumber/SloanRenumber/Make/options @@ -1,5 +1,5 @@ EXE_INC = \ - ${c++LESSWARN} \ + $(c++LESSWARN) \ -I$(BOOST_INC_DIR) \ -I$(LIB_SRC)/meshTools/lnInclude \ -I$(LIB_SRC)/parallel/decompose/decompositionMethods/lnInclude \ diff --git a/src/renumber/zoltanRenumber/Make/options b/src/renumber/zoltanRenumber/Make/options index cf3b1e72266efd6d160f615bb14336374ac0e334..589a3edc8b56484dbbe4de6d3b33f3d2eec0fb34 100644 --- a/src/renumber/zoltanRenumber/Make/options +++ b/src/renumber/zoltanRenumber/Make/options @@ -3,7 +3,7 @@ include $(GENERAL_RULES)/mpi-rules EXE_INC = \ -I$(ZOLTAN_INC_DIR) \ $(PFLAGS) $(PINC) \ - ${c++LESSWARN} \ + $(c++LESSWARN) \ -I$(LIB_SRC)/renumber/renumberMethods/lnInclude \ -I$(LIB_SRC)/meshTools/lnInclude