diff --git a/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.C b/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.C index 7888ec234739944f9a4c6ed210ee3509270a23bb..67b142151d2a092e5badce68e8d225b75d4d81ac 100644 --- a/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.C +++ b/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.C @@ -53,13 +53,7 @@ Foam::surfaceTensionModels::liquidProperties::liquidProperties ) : surfaceTensionModel(mesh), - phaseName_(dict.lookup("phase")) -{} - - -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -Foam::surfaceTensionModels::liquidProperties::~liquidProperties() + phaseName_(dict.get<word>("phase")) {} diff --git a/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.H b/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.H index 7c1e4940acf4f88099bce855eed246beb3a636d1..511797f73302060746dfd2c7c7bad0aeb5633193 100644 --- a/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.H +++ b/applications/solvers/multiphase/compressibleInterFoam/surfaceTensionModels/liquidProperties/liquidPropertiesSurfaceTension.H @@ -95,7 +95,7 @@ public: //- Destructor - virtual ~liquidProperties(); + virtual ~liquidProperties() = default; // Member Functions diff --git a/applications/solvers/multiphase/compressibleMultiphaseInterFoam/multiphaseMixtureThermo/phaseModel/phaseModel.H b/applications/solvers/multiphase/compressibleMultiphaseInterFoam/multiphaseMixtureThermo/phaseModel/phaseModel.H index 53a429f7ca89a85c1cde1fe180275b452d9542f7..e7bfc144b1e5994407c681bd00adc5c04f61d585 100644 --- a/applications/solvers/multiphase/compressibleMultiphaseInterFoam/multiphaseMixtureThermo/phaseModel/phaseModel.H +++ b/applications/solvers/multiphase/compressibleMultiphaseInterFoam/multiphaseMixtureThermo/phaseModel/phaseModel.H @@ -98,7 +98,7 @@ public: autoPtr<phaseModel> operator()(Istream& is) const { - return autoPtr<phaseModel>::New(is, p_, T_); + return autoPtr<phaseModel>::New(word(is), p_, T_); } }; diff --git a/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/MultiComponentPhaseModel/MultiComponentPhaseModel.C b/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/MultiComponentPhaseModel/MultiComponentPhaseModel.C index c22527c60bfc1990930e4f77f23e2012f74f3f2d..f07ecf7ba5cabfc7aa73b826df4b98bc5b44949d 100644 --- a/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/MultiComponentPhaseModel/MultiComponentPhaseModel.C +++ b/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/MultiComponentPhaseModel/MultiComponentPhaseModel.C @@ -72,7 +72,7 @@ MultiComponentPhaseModel species_ = thermoPtr_->composition().species(); - inertIndex_ = species_[thermoPtr_().lookup("inertSpecie")]; + inertIndex_ = species_[thermoPtr_->getWord("inertSpecie")]; X_.setSize(thermoPtr_->composition().species().size()); @@ -104,7 +104,6 @@ MultiComponentPhaseModel // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // - template<class BasePhaseModel, class phaseThermo> void Foam::MultiComponentPhaseModel<BasePhaseModel, phaseThermo> ::calculateVolumeFractions() diff --git a/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/phaseModel/phaseModel.C b/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/phaseModel/phaseModel.C index 359cf3b0aa1ef8d11865eff54096235c6e771581..f19e3419dad406404cdd013d352e2b18670ece7e 100644 --- a/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/phaseModel/phaseModel.C +++ b/applications/solvers/multiphase/icoReactingMultiphaseInterFoam/phasesSystem/phaseModel/phaseModel/phaseModel.C @@ -53,7 +53,7 @@ Foam::phaseModel::phaseModel IOobject::AUTO_WRITE ), fluid.mesh(), - dimensionedScalar("alpha", dimless, 0) + dimensionedScalar(dimless, Zero) ), fluid_(fluid), name_(phaseName) diff --git a/applications/utilities/postProcessing/dataConversion/smapToFoam/smapToFoam.C b/applications/utilities/postProcessing/dataConversion/smapToFoam/smapToFoam.C index af9ea3918751e00de413bdde9af1cce63d474f60..76af6283ef0dccb66acde42edd3100df2410805e 100644 --- a/applications/utilities/postProcessing/dataConversion/smapToFoam/smapToFoam.C +++ b/applications/utilities/postProcessing/dataConversion/smapToFoam/smapToFoam.C @@ -122,46 +122,29 @@ int main(int argc, char *argv[]) { if (nameMap.found(starFieldNames[i])) { + IOobject io + ( + nameMap.get<word>(starFieldNames[i]), + runTime.timeName(), + mesh, + IOobject::MUST_READ, + IOobject::AUTO_WRITE + ); + if (starFieldNames[i] == "SU") { - vFields[i] = - new volVectorField - ( - IOobject - ( - nameMap.lookup(starFieldNames[i]), - runTime.timeName(), - mesh, - IOobject::MUST_READ, - IOobject::AUTO_WRITE - ), - mesh - ); - + vFields[i] = new volVectorField(io, mesh); i += 3; } else { - sFields[i] = - new volScalarField - ( - IOobject - ( - nameMap.lookup(starFieldNames[i]), - runTime.timeName(), - mesh, - IOobject::MUST_READ, - IOobject::AUTO_WRITE - ), - mesh - ); - - i++; + sFields[i] = new volScalarField(io, mesh); + ++i; } } else { - i++; + ++i; } } diff --git a/src/OpenFOAM/db/dictionary/dictionary.H b/src/OpenFOAM/db/dictionary/dictionary.H index b031835b00bf448a3bbf90297dbd6cb793988915..700b32a827c40ad9e191a78240276f8f57d1e1a1 100644 --- a/src/OpenFOAM/db/dictionary/dictionary.H +++ b/src/OpenFOAM/db/dictionary/dictionary.H @@ -1297,6 +1297,7 @@ public: defineDictionaryGetter(getBool, bool); defineDictionaryGetter(getLabel, label); defineDictionaryGetter(getScalar, scalar); + defineDictionaryGetter(getString, string); defineDictionaryGetter(getWord, word); defineDictionaryGetter(getFileName, fileName); diff --git a/src/OpenFOAM/fields/pointPatchFields/derived/fixedNormalSlip/fixedNormalSlipPointPatchField.C b/src/OpenFOAM/fields/pointPatchFields/derived/fixedNormalSlip/fixedNormalSlipPointPatchField.C index c5941fade46ec4693e6fed7156ba55526f5c8092..eac103d06924730ab089cd3d0a9b707dc982f913 100644 --- a/src/OpenFOAM/fields/pointPatchFields/derived/fixedNormalSlip/fixedNormalSlipPointPatchField.C +++ b/src/OpenFOAM/fields/pointPatchFields/derived/fixedNormalSlip/fixedNormalSlipPointPatchField.C @@ -48,7 +48,7 @@ Foam::fixedNormalSlipPointPatchField<Type>::fixedNormalSlipPointPatchField ) : slipPointPatchField<Type>(p, iF, dict), - n_(dict.lookup("n")) + n_(dict.get<vector>("n")) {} diff --git a/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCCCG/PBiCCCG.C b/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCCCG/PBiCCCG.C index ad61ed9cc05768f91a9567dde21a0fe4f74c9db9..a79e230ced9adb4894069d6b238bb5a382193aeb 100644 --- a/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCCCG/PBiCCCG.C +++ b/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCCCG/PBiCCCG.C @@ -53,7 +53,7 @@ Foam::PBiCCCG<Type, DType, LUType>::solve Field<Type>& psi ) const { - word preconditionerName(this->controlDict_.lookup("preconditioner")); + const word preconditionerName(this->controlDict_.getWord("preconditioner")); // --- Setup class containing solver performance data SolverPerformance<Type> solverPerf diff --git a/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCICG/PBiCICG.C b/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCICG/PBiCICG.C index ff437a850ab6a57c85a2102fe688debaa7f0b817..9f232e652337ed4c8766409a1f0a8c1df03ee874 100644 --- a/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCICG/PBiCICG.C +++ b/src/OpenFOAM/matrices/LduMatrix/Solvers/PBiCICG/PBiCICG.C @@ -50,7 +50,7 @@ template<class Type, class DType, class LUType> Foam::SolverPerformance<Type> Foam::PBiCICG<Type, DType, LUType>::solve(Field<Type>& psi) const { - word preconditionerName(this->controlDict_.lookup("preconditioner")); + const word preconditionerName(this->controlDict_.getWord("preconditioner")); // --- Setup class containing solver performance data SolverPerformance<Type> solverPerf diff --git a/src/OpenFOAM/matrices/LduMatrix/Solvers/PCICG/PCICG.C b/src/OpenFOAM/matrices/LduMatrix/Solvers/PCICG/PCICG.C index 5e97b21b76d850d078131af1fc81af61ad27b98f..e947e2cbc3515f6d03b9f35ebae3695125a40367 100644 --- a/src/OpenFOAM/matrices/LduMatrix/Solvers/PCICG/PCICG.C +++ b/src/OpenFOAM/matrices/LduMatrix/Solvers/PCICG/PCICG.C @@ -50,7 +50,7 @@ template<class Type, class DType, class LUType> typename Foam::SolverPerformance<Type> Foam::PCICG<Type, DType, LUType>::solve(Field<Type>& psi) const { - word preconditionerName(this->controlDict_.lookup("preconditioner")); + const word preconditionerName(this->controlDict_.getWord("preconditioner")); // --- Setup class containing solver performance data SolverPerformance<Type> solverPerf diff --git a/src/OpenFOAM/matrices/lduMatrix/solvers/GAMG/GAMGAgglomerations/GAMGAgglomeration/GAMGAgglomeration.C b/src/OpenFOAM/matrices/lduMatrix/solvers/GAMG/GAMGAgglomerations/GAMGAgglomeration/GAMGAgglomeration.C index b507253a199f86104df0135be773f54cf2a961b7..c993cf137882b655bc0d19b40a36e5dcfbd651c7 100644 --- a/src/OpenFOAM/matrices/lduMatrix/solvers/GAMG/GAMGAgglomerations/GAMGAgglomeration/GAMGAgglomeration.C +++ b/src/OpenFOAM/matrices/lduMatrix/solvers/GAMG/GAMGAgglomerations/GAMGAgglomeration/GAMGAgglomeration.C @@ -248,7 +248,7 @@ Foam::GAMGAgglomeration::GAMGAgglomeration ) ? GAMGProcAgglomeration::New ( - controlDict.lookup("processorAgglomerator"), + controlDict.get<word>("processorAgglomerator"), *this, controlDict ) diff --git a/src/OpenFOAM/primitives/Pair/Pair.H b/src/OpenFOAM/primitives/Pair/Pair.H index 123347fb8fc10ce5fa5c19bc779d5c63ac020cd3..07020574b4ceb226218318021bbe75eb49723e75 100644 --- a/src/OpenFOAM/primitives/Pair/Pair.H +++ b/src/OpenFOAM/primitives/Pair/Pair.H @@ -77,7 +77,7 @@ public: inline Pair(const FixedList<T, 2>& lst, const bool doSort); //- Construct from Istream - inline Pair(Istream& is); + inline explicit Pair(Istream& is); // Member Functions diff --git a/src/OpenFOAM/primitives/Tuple2/Tuple2.H b/src/OpenFOAM/primitives/Tuple2/Tuple2.H index 195f74044ce0ec9e1d21e40f26590a514b68e060..5f7744cc4f6ab035fd95d685a319553279169d23 100644 --- a/src/OpenFOAM/primitives/Tuple2/Tuple2.H +++ b/src/OpenFOAM/primitives/Tuple2/Tuple2.H @@ -44,7 +44,7 @@ See also namespace Foam { -// Forward declaration of friend functions and operators +// Forward declarations template<class Type1, class Type2> class Tuple2; @@ -93,7 +93,7 @@ public: {} //- Construct from Istream - inline Tuple2(Istream& is) + inline explicit Tuple2(Istream& is) { is >> *this; } diff --git a/src/OpenFOAM/primitives/bools/Switch/Switch.H b/src/OpenFOAM/primitives/bools/Switch/Switch.H index d755b2dc268caec2fbdb665b2f44b5c09e7ddb4f..2a164124fc18a4c5c70b98c1d51717105e455928 100644 --- a/src/OpenFOAM/primitives/bools/Switch/Switch.H +++ b/src/OpenFOAM/primitives/bools/Switch/Switch.H @@ -153,7 +153,7 @@ public: {} //- Construct from Istream - Switch(Istream& is); + explicit Switch(Istream& is); // Helpers diff --git a/src/OpenFOAM/primitives/strings/fileName/fileName.H b/src/OpenFOAM/primitives/strings/fileName/fileName.H index 78892c584bb2f6efe97fd46f5a3b1db6e4408fb5..b5dfae58385986b9277332171dbd81f268d31208 100644 --- a/src/OpenFOAM/primitives/strings/fileName/fileName.H +++ b/src/OpenFOAM/primitives/strings/fileName/fileName.H @@ -137,9 +137,8 @@ public: //- Construct by concatenating words separated by '/' explicit fileName(std::initializer_list<word> list); - //- Construct from Istream - fileName(Istream& is); + explicit fileName(Istream& is); // Member Functions diff --git a/src/OpenFOAM/primitives/strings/keyType/keyType.H b/src/OpenFOAM/primitives/strings/keyType/keyType.H index cf9db5128f9f44ca98123af4d1b0cdec290737f7..6655db7473cefd5235d3b405edb4b57cd29270dc 100644 --- a/src/OpenFOAM/primitives/strings/keyType/keyType.H +++ b/src/OpenFOAM/primitives/strings/keyType/keyType.H @@ -130,7 +130,7 @@ public: //- Construct from Istream // Treat as regular expression if surrounded by quotation marks. - keyType(Istream& is); + explicit keyType(Istream& is); // Member Functions diff --git a/src/OpenFOAM/primitives/strings/parsing/parsing.H b/src/OpenFOAM/primitives/strings/parsing/parsing.H index 925de3ccdbac58539fbd8d4897109c11e4b5e5c2..ee069c5d017636b2f14027bad075c5f98f65c487 100644 --- a/src/OpenFOAM/primitives/strings/parsing/parsing.H +++ b/src/OpenFOAM/primitives/strings/parsing/parsing.H @@ -49,8 +49,6 @@ namespace Foam namespace parsing { - // Enumerations - //- Enumeration for possible parsing error enum class errorType { diff --git a/src/OpenFOAM/primitives/strings/string/string.H b/src/OpenFOAM/primitives/strings/string/string.H index 17fce9c385829b2d48ff109184e7a8ee1f2e82c5..e306bfba65c214a7877913955ed86144f0ac178d 100644 --- a/src/OpenFOAM/primitives/strings/string/string.H +++ b/src/OpenFOAM/primitives/strings/string/string.H @@ -182,7 +182,7 @@ public: inline string(const size_type len, const char c); //- Construct from Istream - string(Istream& is); + explicit string(Istream& is); // Member Functions diff --git a/src/OpenFOAM/primitives/strings/word/word.H b/src/OpenFOAM/primitives/strings/word/word.H index 7f07140e355cebe53738893f85d683127dc5285d..34e3b9375a6082fd7cc894ffb0efdff967b4d036 100644 --- a/src/OpenFOAM/primitives/strings/word/word.H +++ b/src/OpenFOAM/primitives/strings/word/word.H @@ -109,7 +109,7 @@ public: inline word(const char* s, size_type len, bool doStrip); //- Construct from Istream - word(Istream& is); + explicit word(Istream& is); // Member Functions diff --git a/src/OpenFOAM/primitives/strings/wordRe/wordRe.H b/src/OpenFOAM/primitives/strings/wordRe/wordRe.H index 5b83bda346eb9f8b11b3e270ed756ba2f0df65ba..01f8fd8885590ae7ef1aca90f028a3fb30b842ed 100644 --- a/src/OpenFOAM/primitives/strings/wordRe/wordRe.H +++ b/src/OpenFOAM/primitives/strings/wordRe/wordRe.H @@ -162,7 +162,7 @@ public: //- Construct from Istream // Words are treated as literals, strings with an auto-test - wordRe(Istream& is); + explicit wordRe(Istream& is); // Member Functions diff --git a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C index a870da6462d11f760d7ff3868d4785529f09b9f9..21cf6dddf647a6093f447a4ab58af8aea45703eb 100644 --- a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C +++ b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C @@ -69,7 +69,7 @@ outletMachNumberPressureFvPatchScalarField phiName_(dict.lookupOrDefault<word>("phi", "phi")), rhoName_(dict.lookupOrDefault<word>("rho", "rho")), UName_(dict.lookupOrDefault<word>("U", "U")), - choked_(dict.lookup("choked")), + choked_(dict.get<Switch>("choked")), relax_(dict.lookupOrDefault<scalar>("relax", 0)) {} diff --git a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMappedUniformInletHeatAddition/outletMappedUniformInletHeatAdditionFvPatchField.C b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMappedUniformInletHeatAddition/outletMappedUniformInletHeatAdditionFvPatchField.C index 28b3f220f1ace7deebb228db6f211a6c9e76d459..8a25315086c446cb3c9504c092f40459ad8b0c21 100644 --- a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMappedUniformInletHeatAddition/outletMappedUniformInletHeatAdditionFvPatchField.C +++ b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/outletMappedUniformInletHeatAddition/outletMappedUniformInletHeatAdditionFvPatchField.C @@ -74,7 +74,7 @@ outletMappedUniformInletHeatAdditionFvPatchField ) : fixedValueFvPatchScalarField(p, iF, dict), - outletPatchName_(dict.lookup("outletPatch")), + outletPatchName_(dict.get<word>("outletPatch")), phiName_(dict.lookupOrDefault<word>("phi", "phi")), Q_(dict.get<scalar>("Q")), TMin_(dict.lookupOrDefault<scalar>("TMin", 0)), diff --git a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C index e3b6a88015419c83ab93534d2c6d264ce222f450..e48bdf7f42a14f6bf7028fae4759cc3a9e2322b4 100644 --- a/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C +++ b/src/TurbulenceModels/compressible/turbulentFluidThermoModels/derivedFvPatchFields/turbulentTemperatureCoupledBaffleMixed/turbulentTemperatureCoupledBaffleMixedFvPatchScalarField.C @@ -86,7 +86,7 @@ turbulentTemperatureCoupledBaffleMixedFvPatchScalarField : mixedFvPatchScalarField(p, iF), temperatureCoupledBase(patch(), dict), - TnbrName_(dict.lookup("Tnbr")), + TnbrName_(dict.get<word>("Tnbr")), thicknessLayers_(0), kappaLayers_(0), contactRes_(0.0) diff --git a/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.C b/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.C index 1d69b010a2d957ceeae5f5bceb5b88e7e56b569b..1edc0a97500fb35af7c77e05e6520b65cea284ba 100644 --- a/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.C +++ b/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.C @@ -65,7 +65,7 @@ Foam::LESModel<BasicTurbulenceModel>::LESModel ), LESDict_(this->subOrEmptyDict("LES")), - turbulence_(LESDict_.lookup("turbulence")), + turbulence_(LESDict_.get<Switch>("turbulence")), printCoeffs_(LESDict_.lookupOrDefault<Switch>("printCoeffs", false)), coeffDict_(LESDict_.optionalSubDict(type + "Coeffs")), diff --git a/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.H b/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.H index cc6f7353d0f87586038209c179b32ac85dce46e0..ba29c6ba9dd3abf3ca3d893ba9b95f309bb01ed8 100644 --- a/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.H +++ b/src/TurbulenceModels/turbulenceModels/LES/LESModel/LESModel.H @@ -93,11 +93,6 @@ protected: //- Print model coefficients virtual void printCoeffs(const word& type); - -private: - - // Private Member Functions - //- No copy construct LESModel(const LESModel&) = delete; @@ -168,8 +163,7 @@ public: //- Destructor - virtual ~LESModel() - {} + virtual ~LESModel() = default; // Member Functions diff --git a/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.C b/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.C index 928b99aa813ad0d6d130aa635c696ed97202b7ae..f094d989b8ed416494e6bd310ebe048dc9dc85ac 100644 --- a/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.C +++ b/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.C @@ -65,7 +65,7 @@ Foam::RASModel<BasicTurbulenceModel>::RASModel ), RASDict_(this->subOrEmptyDict("RAS")), - turbulence_(RASDict_.lookup("turbulence")), + turbulence_(RASDict_.get<Switch>("turbulence")), printCoeffs_(RASDict_.lookupOrDefault<Switch>("printCoeffs", false)), coeffDict_(RASDict_.optionalSubDict(type + "Coeffs")), diff --git a/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.H b/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.H index 4b6d908cd528aac9ef63909e757c082d9ed8a52b..36bf9a97e3b14554ba7ed8554987f6965e8cee07 100644 --- a/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.H +++ b/src/TurbulenceModels/turbulenceModels/RAS/RASModel/RASModel.H @@ -83,11 +83,6 @@ protected: //- Print model coefficients virtual void printCoeffs(const word& type); - -private: - - // Private Member Functions - //- No copy construct RASModel(const RASModel&) = delete; @@ -158,8 +153,7 @@ public: //- Destructor - virtual ~RASModel() - {} + virtual ~RASModel() = default; // Member Functions diff --git a/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.C b/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.C index b48b35099e7da572e019324802324d34e6c4b1d0..45967c085c26e933d3e2aeb2df395e1a3b3f3b0e 100644 --- a/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.C +++ b/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.C @@ -100,7 +100,7 @@ Foam::TurbulenceModel<Alpha, Rho, BasicTurbulenceModel, TransportModel>::New IOobject::NO_WRITE, false ) - ).lookup("simulationType") + ).get<word>("simulationType") ); Info<< "Selecting turbulence model type " << modelType << endl; diff --git a/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.H b/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.H index 8a820626e2c2b215318d491aed54751b059610fc..83c609a756c903ab28193b5477a1e711e59decbb 100644 --- a/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.H +++ b/src/TurbulenceModels/turbulenceModels/TurbulenceModel/TurbulenceModel.H @@ -75,9 +75,7 @@ protected: const transportModel& transport_; -private: - - // Private Member Functions + // Protected Member Functions //- No copy construct TurbulenceModel(const TurbulenceModel&) = delete; @@ -139,8 +137,7 @@ public: //- Destructor - virtual ~TurbulenceModel() - {} + virtual ~TurbulenceModel() = default; // Member Functions diff --git a/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.C b/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.C index b40581055c04747816fc5975b59aed65391d70a3..72a133198e1cfffa3fd540d45d4ec6249dcd9630 100644 --- a/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.C +++ b/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/wallFunctions/nutWallFunctions/nutUTabulatedWallFunction/nutUTabulatedWallFunctionFvPatchScalarField.C @@ -134,7 +134,7 @@ nutUTabulatedWallFunctionFvPatchScalarField ) : nutWallFunctionFvPatchScalarField(p, iF, dict), - uPlusTableName_(dict.lookup("uPlusTable")), + uPlusTableName_(dict.get<word>("uPlusTable")), uPlusTable_ ( IOobject diff --git a/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.C b/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.C index b6bbdbaf050c50093af3b62490a249c6b04e8add..4900c690213493205bee3261584e35131bea9427 100644 --- a/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.C +++ b/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.C @@ -109,7 +109,7 @@ Foam::laminarModel<BasicTurbulenceModel>::New // otherwise it is registered in the database twice const word modelType ( - modelDict.subDict("laminar").lookup("laminarModel") + modelDict.subDict("laminar").get<word>("laminarModel") ); Info<< "Selecting laminar stress model " << modelType << endl; diff --git a/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.H b/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.H index dbfb440c228972a309c826210e001136e95f6579..6674f1058486f1313a9a2b84f8fa46f175b65c4f 100644 --- a/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.H +++ b/src/TurbulenceModels/turbulenceModels/laminar/laminarModel/laminarModel.H @@ -71,11 +71,6 @@ protected: //- Print model coefficients virtual void printCoeffs(const word& type); - -private: - - // Private Member Functions - //- No copy construct laminarModel(const laminarModel&) = delete; @@ -146,8 +141,7 @@ public: //- Destructor - virtual ~laminarModel() - {} + virtual ~laminarModel() = default; // Member Functions diff --git a/src/dynamicMesh/motionSolvers/velocity/velocityDisplacement/velocityDisplacementMotionSolver.C b/src/dynamicMesh/motionSolvers/velocity/velocityDisplacement/velocityDisplacementMotionSolver.C index ca8f2b1c816b5d6211bf08977a5ff790be5412a7..1e3d293b6ccac059ae9f04e4554d12a4d69d9a03 100644 --- a/src/dynamicMesh/motionSolvers/velocity/velocityDisplacement/velocityDisplacementMotionSolver.C +++ b/src/dynamicMesh/motionSolvers/velocity/velocityDisplacement/velocityDisplacementMotionSolver.C @@ -98,7 +98,7 @@ Foam::velocityDisplacementMotionSolver::velocityDisplacementMotionSolver ( displacementMotionSolver::New ( - coeffDict().lookup("solver"), + coeffDict().get<word>("solver"), mesh, IOdictionary ( diff --git a/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.C b/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.C index 6b4136d384865713664c69cb0ef8f48f6dc29f23..688bcd275871ea3a2d9e32df26eb01110924734a 100644 --- a/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.C +++ b/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.C @@ -50,6 +50,7 @@ namespace functionObjects } } + // * * * * * * * * * * * * Protected Member Functions * * * * * * * * * * * // void Foam::functionObjects::codedFunctionObject::prepare @@ -194,9 +195,10 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) dict.readCompat<word>("name", {{"redirectType", 1706}}, name_); const entry* dataPtr = dict.findEntry("codeData", keyType::LITERAL); + if (dataPtr) { - codeData_ = stringOps::trim(dataPtr->stream()); + dataPtr->readEntry(codeData_); stringOps::inplaceExpand(codeData_, dict); dynamicCodeContext::addLineDirective ( @@ -207,9 +209,10 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) } const entry* readPtr = dict.findEntry("codeRead", keyType::LITERAL); + if (readPtr) { - codeRead_ = stringOps::trim(readPtr->stream()); + readPtr->readEntry(codeRead_); stringOps::inplaceExpand(codeRead_, dict); dynamicCodeContext::addLineDirective ( @@ -220,9 +223,10 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) } const entry* execPtr = dict.findEntry("codeExecute", keyType::LITERAL); + if (execPtr) { - codeExecute_ = stringOps::trim(execPtr->stream()); + execPtr->readEntry(codeExecute_); stringOps::inplaceExpand(codeExecute_, dict); dynamicCodeContext::addLineDirective ( @@ -233,9 +237,10 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) } const entry* writePtr = dict.findEntry("codeWrite", keyType::LITERAL); + if (writePtr) { - codeWrite_ = stringOps::trim(writePtr->stream()); + writePtr->readEntry(codeWrite_); stringOps::inplaceExpand(codeWrite_, dict); dynamicCodeContext::addLineDirective ( @@ -246,9 +251,10 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) } const entry* endPtr = dict.findEntry("codeEnd", keyType::LITERAL); + if (endPtr) { - codeEnd_ = stringOps::trim(endPtr->stream()); + endPtr->readEntry(codeEnd_); stringOps::inplaceExpand(codeEnd_, dict); dynamicCodeContext::addLineDirective ( @@ -260,10 +266,8 @@ bool Foam::functionObjects::codedFunctionObject::read(const dictionary& dict) if (!dataPtr && !readPtr && !execPtr && !writePtr && !endPtr) { - IOWarningInFunction - ( - dict - ) << "No critical \"code\" prefixed keywords were found." + IOWarningInFunction(dict) + << "No critical \"code\" prefixed keywords were found." << " Please check the code documentation for more details." << nl << endl; } diff --git a/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.H b/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.H index 9a909f261334dba883c9a1fc6e184e740822be00..522e940c42607f51333627fc5dd10dd0184794fb 100644 --- a/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.H +++ b/src/functionObjects/utilities/codedFunctionObject/codedFunctionObject.H @@ -134,8 +134,6 @@ protected: virtual const dictionary& codeDict() const; -private: - //- No copy construct codedFunctionObject(const codedFunctionObject&) = delete; diff --git a/src/fvMotionSolver/fvMotionSolvers/componentDisplacement/componentLaplacian/displacementComponentLaplacianFvMotionSolver.C b/src/fvMotionSolver/fvMotionSolvers/componentDisplacement/componentLaplacian/displacementComponentLaplacianFvMotionSolver.C index 859ce93389f113c60eece7b2ead95b32f1b16c55..7a30aa30274a469044714795ca760daf378abf43 100644 --- a/src/fvMotionSolver/fvMotionSolvers/componentDisplacement/componentLaplacian/displacementComponentLaplacianFvMotionSolver.C +++ b/src/fvMotionSolver/fvMotionSolvers/componentDisplacement/componentLaplacian/displacementComponentLaplacianFvMotionSolver.C @@ -85,20 +85,14 @@ displacementComponentLaplacianFvMotionSolver frozenPointsZone_ ( coeffDict().found("frozenPointsZone") - ? fvMesh_.pointZones().findZoneID(coeffDict().lookup("frozenPointsZone")) + ? fvMesh_.pointZones().findZoneID + ( + coeffDict().get<word>("frozenPointsZone") + ) : -1 ) { - Switch applyPointLocation - ( - coeffDict().lookupOrDefault - ( - "applyPointLocation", - true - ) - ); - - if (applyPointLocation) + if (coeffDict().lookupOrDefault("applyPointLocation", true)) { pointLocation_.reset ( diff --git a/src/fvMotionSolver/fvMotionSolvers/displacement/laplacian/displacementLaplacianFvMotionSolver.C b/src/fvMotionSolver/fvMotionSolvers/displacement/laplacian/displacementLaplacianFvMotionSolver.C index 59e83177a1da07a10fa9e8481576bbb84d98566f..9f47f72b9b7ee3fb34d5165923d7205846840d0e 100644 --- a/src/fvMotionSolver/fvMotionSolvers/displacement/laplacian/displacementLaplacianFvMotionSolver.C +++ b/src/fvMotionSolver/fvMotionSolvers/displacement/laplacian/displacementLaplacianFvMotionSolver.C @@ -93,7 +93,10 @@ Foam::displacementLaplacianFvMotionSolver::displacementLaplacianFvMotionSolver frozenPointsZone_ ( coeffDict().found("frozenPointsZone") - ? fvMesh_.pointZones().findZoneID(coeffDict().lookup("frozenPointsZone")) + ? fvMesh_.pointZones().findZoneID + ( + coeffDict().get<word>("frozenPointsZone") + ) : -1 ) { @@ -178,7 +181,10 @@ displacementLaplacianFvMotionSolver frozenPointsZone_ ( coeffDict().found("frozenPointsZone") - ? fvMesh_.pointZones().findZoneID(coeffDict().lookup("frozenPointsZone")) + ? fvMesh_.pointZones().findZoneID + ( + coeffDict().get<word>("frozenPointsZone") + ) : -1 ) { diff --git a/src/fvMotionSolver/fvMotionSolvers/displacement/solidBodyDisplacementLaplacian/solidBodyDisplacementLaplacianFvMotionSolver.C b/src/fvMotionSolver/fvMotionSolvers/displacement/solidBodyDisplacementLaplacian/solidBodyDisplacementLaplacianFvMotionSolver.C index df0a060c00aaeccd15ff0da8a4d6cb3ce751f71f..e208f53959535cdea56a3c8844e09cd0554a47aa 100644 --- a/src/fvMotionSolver/fvMotionSolvers/displacement/solidBodyDisplacementLaplacian/solidBodyDisplacementLaplacianFvMotionSolver.C +++ b/src/fvMotionSolver/fvMotionSolvers/displacement/solidBodyDisplacementLaplacian/solidBodyDisplacementLaplacianFvMotionSolver.C @@ -97,7 +97,10 @@ solidBodyDisplacementLaplacianFvMotionSolver frozenPointsZone_ ( coeffDict().found("frozenPointsZone") - ? fvMesh_.pointZones().findZoneID(coeffDict().lookup("frozenPointsZone")) + ? fvMesh_.pointZones().findZoneID + ( + coeffDict().get<word>("frozenPointsZone") + ) : -1 ) { @@ -183,7 +186,10 @@ solidBodyDisplacementLaplacianFvMotionSolver frozenPointsZone_ ( coeffDict().found("frozenPointsZone") - ? fvMesh_.pointZones().findZoneID(coeffDict().lookup("frozenPointsZone")) + ? fvMesh_.pointZones().findZoneID + ( + coeffDict().get<word>("frozenPointsZone") + ) : -1 ) { diff --git a/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.C b/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.C index 1eb531470eefd101103334be8c7a50266fa6665e..8924c5b5efbfe09132ce3d10144ee5187f92f319 100644 --- a/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.C +++ b/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.C @@ -316,10 +316,10 @@ surfaceDisplacementPointPatchVectorField ) : fixedValuePointPatchVectorField(p, iF, dict), - velocity_(dict.lookup("velocity")), + velocity_(dict.get<vector>("velocity")), surfacesDict_(dict.subDict("geometry")), projectMode_(projectModeNames_.get("projectMode", dict)), - projectDir_(dict.lookup("projectDirection")), + projectDir_(dict.get<vector>("projectDirection")), wedgePlane_(dict.lookupOrDefault("wedgePlane", -1)), frozenPointsZone_(dict.lookupOrDefault("frozenPointsZone", word::null)) { diff --git a/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.H b/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.H index 5ea535a8e5eb63c09dcf5b9aa020348be0d3c878..469e2c3f56b86fab502f769506cd7b22641701a5 100644 --- a/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.H +++ b/src/fvMotionSolver/pointPatchFields/derived/surfaceDisplacement/surfaceDisplacementPointPatchVectorField.H @@ -110,7 +110,7 @@ private: //- Plane for 2D wedge case or -1. const label wedgePlane_; - //- pointZone with frozen points + //- Name of pointZone with frozen points const word frozenPointsZone_; //- Demand driven: surface to project diff --git a/src/fvMotionSolver/pointPatchFields/derived/surfaceSlipDisplacement/surfaceSlipDisplacementPointPatchVectorField.C b/src/fvMotionSolver/pointPatchFields/derived/surfaceSlipDisplacement/surfaceSlipDisplacementPointPatchVectorField.C index 0be591f508c14b575aa44e21c30359c2dc6bc43b..89100524c35a84686e19bd9328d49e52aa092f74 100644 --- a/src/fvMotionSolver/pointPatchFields/derived/surfaceSlipDisplacement/surfaceSlipDisplacementPointPatchVectorField.C +++ b/src/fvMotionSolver/pointPatchFields/derived/surfaceSlipDisplacement/surfaceSlipDisplacementPointPatchVectorField.C @@ -317,7 +317,7 @@ surfaceSlipDisplacementPointPatchVectorField pointPatchVectorField(p, iF, dict), surfacesDict_(dict.subDict("geometry")), projectMode_(projectModeNames_.get("projectMode", dict)), - projectDir_(dict.lookup("projectDirection")), + projectDir_(dict.get<vector>("projectDirection")), wedgePlane_(dict.lookupOrDefault("wedgePlane", -1)), frozenPointsZone_(dict.lookupOrDefault("frozenPointsZone", word::null)) {} diff --git a/src/fvOptions/sources/general/codedSource/CodedSource.C b/src/fvOptions/sources/general/codedSource/CodedSource.C index 618bb30f65b686db359c187f63e0ddc2135afd27..cde6b2d369497049117100cec1c50b2261b5f8b7 100644 --- a/src/fvOptions/sources/general/codedSource/CodedSource.C +++ b/src/fvOptions/sources/general/codedSource/CodedSource.C @@ -153,11 +153,9 @@ void Foam::fv::CodedSource<Type>::correct GeometricField<Type, fvPatchField, volMesh>& field ) { - if (debug) - { - Info<< "CodedSource<"<< pTraits<Type>::typeName - << ">::correct for source " << name_ << endl; - } + DebugInfo + << "CodedSource<" << pTraits<Type>::typeName + << ">::correct for source " << name_ << endl; updateLibrary(name_); redirectFvOption().correct(field); @@ -171,11 +169,9 @@ void Foam::fv::CodedSource<Type>::addSup const label fieldi ) { - if (debug) - { - Info<< "CodedSource<"<< pTraits<Type>::typeName - << ">::addSup for source " << name_ << endl; - } + DebugInfo + << "CodedSource<" << pTraits<Type>::typeName + << ">::addSup for source " << name_ << endl; updateLibrary(name_); redirectFvOption().addSup(eqn, fieldi); @@ -190,11 +186,9 @@ void Foam::fv::CodedSource<Type>::addSup const label fieldi ) { - if (debug) - { - Info<< "CodedSource<"<< pTraits<Type>::typeName - << ">::addSup for source " << name_ << endl; - } + DebugInfo + << "CodedSource<" << pTraits<Type>::typeName + << ">::addSup for source " << name_ << endl; updateLibrary(name_); redirectFvOption().addSup(rho, eqn, fieldi); @@ -208,11 +202,9 @@ void Foam::fv::CodedSource<Type>::constrain const label fieldi ) { - if (debug) - { - Info<< "CodedSource<"<< pTraits<Type>::typeName - << ">::constrain for source " << name_ << endl; - } + DebugInfo + << "CodedSource<" << pTraits<Type>::typeName + << ">::constrain for source " << name_ << endl; updateLibrary(name_); redirectFvOption().constrain(eqn, fieldi); diff --git a/src/fvOptions/sources/general/codedSource/CodedSourceIO.C b/src/fvOptions/sources/general/codedSource/CodedSourceIO.C index 8cbeeecda217a3a797da6e44f9e037b959fd284c..f577dc7d6e16f351b0fb057a1045d7d9ee26e7d7 100644 --- a/src/fvOptions/sources/general/codedSource/CodedSourceIO.C +++ b/src/fvOptions/sources/general/codedSource/CodedSourceIO.C @@ -43,7 +43,8 @@ bool Foam::fv::CodedSource<Type>::read(const dictionary& dict) const entry& e = coeffs_.lookupEntry("codeCorrect", keyType::LITERAL); - codeCorrect_ = stringOps::trim(e.stream()); + e.readEntry(codeCorrect_); + stringOps::inplaceTrim(codeCorrect_); stringOps::inplaceExpand(codeCorrect_, coeffs_); dynamicCodeContext::addLineDirective ( @@ -57,7 +58,8 @@ bool Foam::fv::CodedSource<Type>::read(const dictionary& dict) const entry& e = coeffs_.lookupEntry("codeAddSup", keyType::LITERAL); - codeAddSup_ = stringOps::trim(e.stream()); + e.readEntry(codeAddSup_); + stringOps::inplaceTrim(codeAddSup_); stringOps::inplaceExpand(codeAddSup_, coeffs_); dynamicCodeContext::addLineDirective ( @@ -71,7 +73,8 @@ bool Foam::fv::CodedSource<Type>::read(const dictionary& dict) const entry& e = coeffs_.lookupEntry("codeSetValue", keyType::LITERAL); - codeSetValue_ = stringOps::trim(e.stream()); + e.readEntry(codeSetValue_); + stringOps::inplaceTrim(codeSetValue_); stringOps::inplaceExpand(codeSetValue_, coeffs_); dynamicCodeContext::addLineDirective ( diff --git a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/FieldActivatedInjection/FieldActivatedInjection.C b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/FieldActivatedInjection/FieldActivatedInjection.C index 6b0c5f099a88a45c7ad78e12fc7fad2adaf6d285..ecce1a6a72bb1e03c81a544dbc9fc57c0a22435d 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/FieldActivatedInjection/FieldActivatedInjection.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/FieldActivatedInjection/FieldActivatedInjection.C @@ -45,17 +45,17 @@ Foam::FieldActivatedInjection<CloudType>::FieldActivatedInjection ( owner.db().objectRegistry::template lookupObject<volScalarField> ( - this->coeffDict().lookup("referenceField") + this->coeffDict().getWord("referenceField") ) ), thresholdField_ ( owner.db().objectRegistry::template lookupObject<volScalarField> ( - this->coeffDict().lookup("thresholdField") + this->coeffDict().getWord("thresholdField") ) ), - positionsFile_(this->coeffDict().lookup("positionsFile")), + positionsFile_(this->coeffDict().getWord("positionsFile")), positions_ ( IOobject @@ -74,8 +74,11 @@ Foam::FieldActivatedInjection<CloudType>::FieldActivatedInjection ( this->coeffDict().getLabel("parcelsPerInjector") ), - nParcelsInjected_(positions_.size(), 0), - U0_(this->coeffDict().lookup("U0")), + nParcelsInjected_(positions_.size(), Zero), + U0_ + ( + this->coeffDict().template get<vector>("U0") + ), diameters_(positions_.size()), sizeDistribution_ ( diff --git a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchFlowRateInjection/PatchFlowRateInjection.C b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchFlowRateInjection/PatchFlowRateInjection.C index e6d35f9894567f0d947791b1906a18c935de5cdd..17e23eacf1490afb4d8abb00c2409dd100c040df 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchFlowRateInjection/PatchFlowRateInjection.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchFlowRateInjection/PatchFlowRateInjection.C @@ -40,7 +40,7 @@ Foam::PatchFlowRateInjection<CloudType>::PatchFlowRateInjection ) : InjectionModel<CloudType>(dict, owner, modelName,typeName), - patchInjectionBase(owner.mesh(), this->coeffDict().lookup("patch")), + patchInjectionBase(owner.mesh(), this->coeffDict().getWord("patch")), phiName_(this->coeffDict().template lookupOrDefault<word>("phi", "phi")), rhoName_(this->coeffDict().template lookupOrDefault<word>("rho", "rho")), duration_(this->coeffDict().getScalar("duration")), diff --git a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/PatchInjection.C b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/PatchInjection.C index 3c5563532c1723e47546ab799d70d3cdeb623809..bc685f92c7826313c6a7efd53580281871f77463 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/PatchInjection.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/PatchInjection.C @@ -38,7 +38,7 @@ Foam::PatchInjection<CloudType>::PatchInjection ) : InjectionModel<CloudType>(dict, owner, modelName, typeName), - patchInjectionBase(owner.mesh(), this->coeffDict().lookup("patch")), + patchInjectionBase(owner.mesh(), this->coeffDict().getWord("patch")), duration_(this->coeffDict().getScalar("duration")), parcelsPerSecond_ ( diff --git a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.C b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.C index a0c012704343ac424693267954c50c25338c75a0..8a8a1ab11f9515c3000895f2200862fd88cacab9 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.C @@ -75,12 +75,6 @@ Foam::patchInjectionBase::patchInjectionBase(const patchInjectionBase& pib) {} -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -Foam::patchInjectionBase::~patchInjectionBase() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // void Foam::patchInjectionBase::updateMesh(const polyMesh& mesh) diff --git a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.H b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.H index 29b1107055d495002fd24815f02825473dd82950..15dd03f6105f22ab0aafc4591cec0c8810502541 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.H +++ b/src/lagrangian/intermediate/submodels/Kinematic/InjectionModel/PatchInjection/patchInjectionBase.H @@ -51,7 +51,7 @@ SourceFiles namespace Foam { -// Forward class declarations +// Forward declarations class polyMesh; class fvMesh; class Random; @@ -106,7 +106,7 @@ public: //- Destructor - virtual ~patchInjectionBase(); + virtual ~patchInjectionBase() = default; // Member Functions diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C index de17e609660f962f979fc5ee70711ba878b2670d..3e8e7f82f160371fef480d2a2a3691c73f12521b 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/ErgunWenYuDrag/ErgunWenYuDragForce.C @@ -60,7 +60,7 @@ Foam::ErgunWenYuDragForce<CloudType>::ErgunWenYuDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} @@ -77,7 +77,7 @@ Foam::ErgunWenYuDragForce<CloudType>::ErgunWenYuDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C index 632d9b42625fbce996dbe3783efc8a6f85896ec3..bce388480b105c3033c1b1c24fa8e8e853cd1254 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/PlessisMasliyahDrag/PlessisMasliyahDragForce.C @@ -60,7 +60,7 @@ Foam::PlessisMasliyahDragForce<CloudType>::PlessisMasliyahDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} @@ -77,7 +77,7 @@ Foam::PlessisMasliyahDragForce<CloudType>::PlessisMasliyahDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} diff --git a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C index 7fe9d28e2bdbf20eadc110793c5bc0d11acacb56..c507dde82a89f15d9f6d7d6b00dc68ca3dcb1da0 100644 --- a/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C +++ b/src/lagrangian/intermediate/submodels/Kinematic/ParticleForces/Drag/WenYuDrag/WenYuDragForce.C @@ -57,7 +57,7 @@ Foam::WenYuDragForce<CloudType>::WenYuDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} @@ -74,7 +74,7 @@ Foam::WenYuDragForce<CloudType>::WenYuDragForce ( this->mesh().template lookupObject<volScalarField> ( - this->coeffs().lookup("alphac") + this->coeffs().getWord("alphac") ) ) {} diff --git a/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.C b/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.C index 1a037fe3c7ecf293e22f07bd4b9e706496b92f67..96de521470a32bbb4421fac33e080b83a9e13c7c 100644 --- a/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.C +++ b/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.C @@ -95,19 +95,12 @@ Foam::PhaseChangeModel<CloudType>::PhaseChangeModel CloudSubModelBase<CloudType>(owner, dict, typeName, type), enthalpyTransfer_ ( - wordToEnthalpyTransfer(this->coeffDict().lookup("enthalpyTransfer")) + wordToEnthalpyTransfer(this->coeffDict().getWord("enthalpyTransfer")) ), dMass_(0.0) {} -// * * * * * * * * * * * * * * * * Destructor * * * * * * * * * * * * * * * // - -template<class CloudType> -Foam::PhaseChangeModel<CloudType>::~PhaseChangeModel() -{} - - // * * * * * * * * * * * * * * * Member Functions * * * * * * * * * * * * * // template<class CloudType> diff --git a/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.H b/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.H index e04c3cf53bae9f81f96db3efab3fe2ed7659d62c..1ac0fbc383d1c1207beda3f7d0fbc1b4dc447d64 100644 --- a/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.H +++ b/src/lagrangian/intermediate/submodels/Reacting/PhaseChangeModel/PhaseChangeModel/PhaseChangeModel.H @@ -60,7 +60,7 @@ class PhaseChangeModel { public: - // Public enumerations + // Public Enumerations //- Enthalpy transfer type enum enthalpyTransferType @@ -70,7 +70,7 @@ public: }; //- Name representations of enthalpy transfer types - static const Foam::wordList enthalpyTransferTypeNames; + static const wordList enthalpyTransferTypeNames; protected: @@ -136,7 +136,7 @@ public: //- Destructor - virtual ~PhaseChangeModel(); + virtual ~PhaseChangeModel() = default; //- Selector diff --git a/src/lagrangian/intermediate/submodels/Thermodynamic/SurfaceFilmModel/ThermoSurfaceFilm/ThermoSurfaceFilm.C b/src/lagrangian/intermediate/submodels/Thermodynamic/SurfaceFilmModel/ThermoSurfaceFilm/ThermoSurfaceFilm.C index dd7627397b4483b262f26d387978ed651afe8569..ff3872f766dc09936306ffb5d5fc1c84b5d0aeac 100644 --- a/src/lagrangian/intermediate/submodels/Thermodynamic/SurfaceFilmModel/ThermoSurfaceFilm/ThermoSurfaceFilm.C +++ b/src/lagrangian/intermediate/submodels/Thermodynamic/SurfaceFilmModel/ThermoSurfaceFilm/ThermoSurfaceFilm.C @@ -489,7 +489,7 @@ Foam::ThermoSurfaceFilm<CloudType>::ThermoSurfaceFilm CpFilmPatch_(0), interactionType_ ( - interactionTypeEnum(this->coeffDict().lookup("interactionType")) + interactionTypeEnum(this->coeffDict().getWord("interactionType")) ), deltaWet_(0.0), splashParcelType_(0), diff --git a/src/mesh/snappyHexMesh/externalDisplacementMeshMover/displacementMotionSolverMeshMover.C b/src/mesh/snappyHexMesh/externalDisplacementMeshMover/displacementMotionSolverMeshMover.C index 4b2e868af6bc3323424dea2a8a2254e8630172ae..5fd4aa2af6f4d686d7ea90f28db697c60582765a 100644 --- a/src/mesh/snappyHexMesh/externalDisplacementMeshMover/displacementMotionSolverMeshMover.C +++ b/src/mesh/snappyHexMesh/externalDisplacementMeshMover/displacementMotionSolverMeshMover.C @@ -118,7 +118,7 @@ Foam::displacementMotionSolverMeshMover::displacementMotionSolverMeshMover ( displacementMotionSolver::New ( - dict.lookup("solver"), + dict.get<word>("solver"), pointDisplacement.mesh()(), IOdictionary ( diff --git a/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.C b/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.C index 229e64ae3f5a654a93c5d6b2765987efa3cf0e4e..e334fc4b97f25c4421629702c1172f3aaea13b2a 100644 --- a/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.C +++ b/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.C @@ -48,7 +48,7 @@ Foam::RBD::restraint::restraint ) : name_(name), - bodyID_(model.bodyID(dict.lookup("body"))), + bodyID_(model.bodyID(dict.get<word>("body"))), bodyIndex_(model.master(bodyID_)), coeffs_(dict), model_(model) diff --git a/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.H b/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.H index b9533c050c7eb9fb62479145a349a5193d528398..bc53dfd13697a7330e1025065b44a856617b8a1f 100644 --- a/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.H +++ b/src/rigidBodyDynamics/restraints/restraint/rigidBodyRestraint.H @@ -60,7 +60,7 @@ namespace RBD class rigidBodyModel; /*---------------------------------------------------------------------------*\ - Class restraint Declaration + Class restraint Declaration \*---------------------------------------------------------------------------*/ class restraint diff --git a/src/rigidBodyDynamics/rigidBodyModel/rigidBodyModel.C b/src/rigidBodyDynamics/rigidBodyModel/rigidBodyModel.C index c20ad255eb9b947af3d23220b587e25b693133eb..84ff1d0af6a8f96135bca65c65cffc3da6f6c9d1 100644 --- a/src/rigidBodyDynamics/rigidBodyModel/rigidBodyModel.C +++ b/src/rigidBodyDynamics/rigidBodyModel/rigidBodyModel.C @@ -194,7 +194,7 @@ Foam::RBD::rigidBodyModel::rigidBodyModel { merge ( - bodyID(bodyDict.lookup("mergeWith")), + bodyID(bodyDict.get<word>("mergeWith")), bodyDict.lookup("transform"), rigidBody::New(key, bodyDict) ); @@ -203,7 +203,7 @@ Foam::RBD::rigidBodyModel::rigidBodyModel { join ( - bodyID(bodyDict.lookup("parent")), + bodyID(bodyDict.get<word>("parent")), bodyDict.lookup("transform"), joint::New(bodyDict.subDict("joint")), rigidBody::New(key, bodyDict) diff --git a/src/thermophysicalModels/chemistryModel/chemistryModel/basicChemistryModel/basicChemistryModelTemplates.C b/src/thermophysicalModels/chemistryModel/chemistryModel/basicChemistryModel/basicChemistryModelTemplates.C index f3d9424e2bd58144fa2914f4639c60ed1f69e8b7..f79a4342b14d1ddbb1b166120c3ffd1af6cbd612 100644 --- a/src/thermophysicalModels/chemistryModel/chemistryModel/basicChemistryModel/basicChemistryModelTemplates.C +++ b/src/thermophysicalModels/chemistryModel/chemistryModel/basicChemistryModel/basicChemistryModelTemplates.C @@ -64,16 +64,16 @@ Foam::autoPtr<ChemistryModel> Foam::basicChemistryModel::New const dictionary& chemistryTypeDict = chemistryDict.subDict("chemistryType"); - const word& solverName + const word solverName ( - chemistryTypeDict.found("solver") - ? chemistryTypeDict.lookup("solver") - : chemistryTypeDict.found("chemistrySolver") - ? chemistryTypeDict.lookup("chemistrySolver") - : chemistryTypeDict.lookup("solver") // error if neither entry is found + chemistryTypeDict.getCompat<word> + ( + "solver", + {{"chemistrySolver", -1712}} + ) ); - const word& methodName + const word methodName ( chemistryTypeDict.lookupOrDefault<word> ( @@ -90,8 +90,7 @@ Foam::autoPtr<ChemistryModel> Foam::basicChemistryModel::New Info<< "Selecting chemistry solver " << chemistryTypeDictNew << endl; - typedef typename ChemistryModel::thermoConstructorTable cstrTableType; - cstrTableType* cstrTable = ChemistryModel::thermoConstructorTablePtr_; + auto* cstrTable = ChemistryModel::thermoConstructorTablePtr_; const word chemSolverCompThermoName = solverName + '<' + methodName + '<' @@ -106,7 +105,7 @@ Foam::autoPtr<ChemistryModel> Foam::basicChemistryModel::New << "Unknown " << typeName_() << " type " << solverName << endl << endl; - const wordList names(cstrTable->toc()); + const wordList names(cstrTable->sortedToc()); wordList thisCmpts; thisCmpts.append(word::null); @@ -123,7 +122,7 @@ Foam::autoPtr<ChemistryModel> Foam::basicChemistryModel::New const wordList cmpts(basicThermo::splitThermoName(names[i], 8)); bool isValid = true; - for (label i = 2; i < cmpts.size() && isValid; ++ i) + for (label i = 2; i < cmpts.size() && isValid; ++i) { isValid = isValid && cmpts[i] == thisCmpts[i]; } diff --git a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanAbsorptionEmission/greyMeanAbsorptionEmission.C b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanAbsorptionEmission/greyMeanAbsorptionEmission.C index 5068caa1875bf88c31026d8646609e05b314ba13..7a305c4d53e8dab5858f5daeeea10e78b952f114 100644 --- a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanAbsorptionEmission/greyMeanAbsorptionEmission.C +++ b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/greyMeanAbsorptionEmission/greyMeanAbsorptionEmission.C @@ -91,28 +91,28 @@ Foam::radiation::greyMeanAbsorptionEmission::greyMeanAbsorptionEmission nFunc++; } - if (coeffsDict_.found("lookUpTableFileName")) + if + ( + coeffsDict_.found("lookUpTableFileName") + && "none" != coeffsDict_.get<word>("lookUpTableFileName") + ) { - const word name = coeffsDict_.lookup("lookUpTableFileName"); - if (name != "none") - { - lookUpTablePtr_.reset + lookUpTablePtr_.reset + ( + new interpolationLookUpTable<scalar> ( - new interpolationLookUpTable<scalar> - ( - fileName(coeffsDict_.lookup("lookUpTableFileName")), - mesh.time().constant(), - mesh - ) - ); - - if (!mesh.foundObject<volScalarField>("ft")) - { - FatalErrorInFunction - << "specie ft is not present to use with " - << "lookUpTableFileName " << nl - << exit(FatalError); - } + coeffsDict_.get<fileName>("lookUpTableFileName"), + mesh.time().constant(), + mesh + ) + ); + + if (!mesh.foundObject<volScalarField>("ft")) + { + FatalErrorInFunction + << "specie ft is not present to use with " + << "lookUpTableFileName " << nl + << exit(FatalError); } } @@ -213,7 +213,7 @@ Foam::radiation::greyMeanAbsorptionEmission::aCont(const label bandI) const forAll(a, celli) { - forAllConstIter(HashTable<label>, speciesNames_, iter) + forAllConstIters(speciesNames_, iter) { label n = iter(); scalar Xipi = 0.0; diff --git a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/wideBandAbsorptionEmission/wideBandAbsorptionEmission.C b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/wideBandAbsorptionEmission/wideBandAbsorptionEmission.C index f8990de13741e0ca073271766b7061dd62345f62..a9e1768f25853b6f656d5ee2255ceb4b0381e5f5 100644 --- a/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/wideBandAbsorptionEmission/wideBandAbsorptionEmission.C +++ b/src/thermophysicalModels/radiation/submodels/absorptionEmissionModel/wideBandAbsorptionEmission/wideBandAbsorptionEmission.C @@ -102,28 +102,28 @@ Foam::radiation::wideBandAbsorptionEmission::wideBandAbsorptionEmission } nBands_ = nBand; - if (coeffsDict_.found("lookUpTableFileName")) + if + ( + coeffsDict_.found("lookUpTableFileName") + && "none" != coeffsDict_.get<word>("lookUpTableFileName") + ) { - const word name = coeffsDict_.lookup("lookUpTableFileName"); - if (name != "none") - { - lookUpTablePtr_.set + lookUpTablePtr_.set + ( + new interpolationLookUpTable<scalar> ( - new interpolationLookUpTable<scalar> - ( - fileName(coeffsDict_.lookup("lookUpTableFileName")), - mesh.time().constant(), - mesh - ) - ); - - if (!mesh.foundObject<volScalarField>("ft")) - { - FatalErrorInFunction - << "specie ft is not present to use with " - << "lookUpTableFileName " << nl - << exit(FatalError); - } + coeffsDict_.get<fileName>("lookUpTableFileName"), + mesh.time().constant(), + mesh + ) + ); + + if (!mesh.foundObject<volScalarField>("ft")) + { + FatalErrorInFunction + << "specie ft is not present to use with " + << "lookUpTableFileName " << nl + << exit(FatalError); } } @@ -224,7 +224,7 @@ Foam::radiation::wideBandAbsorptionEmission::aCont(const label bandi) const forAll(a, celli) { - forAllConstIter(HashTable<label>, speciesNames_, iter) + forAllConstIters(speciesNames_, iter) { const label n = iter(); scalar Xipi = 0; diff --git a/src/thermophysicalModels/reactionThermo/mixtures/singleStepReactingMixture/singleStepReactingMixture.C b/src/thermophysicalModels/reactionThermo/mixtures/singleStepReactingMixture/singleStepReactingMixture.C index 4a4219882b6255993c2a0f854790df151f27f3f4..01b48e5dbdc1c278ca353c6c474431687f12615b 100644 --- a/src/thermophysicalModels/reactionThermo/mixtures/singleStepReactingMixture/singleStepReactingMixture.C +++ b/src/thermophysicalModels/reactionThermo/mixtures/singleStepReactingMixture/singleStepReactingMixture.C @@ -51,7 +51,7 @@ void Foam::singleStepReactingMixture<ThermoType>::calculateqFuel() specieProd_[speciei] = -1; } - Info << "Fuel heat of combustion :" << qFuel_.value() << endl; + Info<< "Fuel heat of combustion :" << qFuel_.value() << endl; } @@ -73,9 +73,9 @@ void Foam::singleStepReactingMixture<ThermoType>::massAndAirStoichRatios() * mag(specieStoichCoeffs_[O2Index])) / (Wu*mag(specieStoichCoeffs_[fuelIndex_])); - Info << "stoichiometric air-fuel ratio :" << stoicRatio_.value() << endl; + Info<< "stoichiometric air-fuel ratio :" << stoicRatio_.value() << endl; - Info << "stoichiometric oxygen-fuel ratio :" << s_.value() << endl; + Info<< "stoichiometric oxygen-fuel ratio :" << s_.value() << endl; } @@ -108,7 +108,7 @@ void Foam::singleStepReactingMixture<ThermoType>::calculateMaxProducts() Yprod0_[speciei] = this->speciesData()[speciei].W()/Wm*Xi[i]; } - Info << "Maximum products mass concentrations:" << nl; + Info<< "Maximum products mass concentrations:" << nl; forAll(Yprod0_, i) { if (Yprod0_[i] > 0) @@ -202,8 +202,8 @@ Foam::singleStepReactingMixture<ThermoType>::singleStepReactingMixture specieStoichCoeffs_(this->species_.size(), Zero), Yprod0_(this->species_.size(), Zero), fres_(Yprod0_.size()), - inertIndex_(this->species()[thermoDict.lookup("inertSpecie")]), - fuelIndex_(this->species()[thermoDict.lookup("fuel")]), + inertIndex_(this->species()[thermoDict.get<word>("inertSpecie")]), + fuelIndex_(this->species()[thermoDict.get<word>("fuel")]), specieProd_(Yprod0_.size(), 1) { if (this->size() == 1) diff --git a/src/thermophysicalModels/solidSpecie/reaction/Reactions/solidReaction/solidReaction.C b/src/thermophysicalModels/solidSpecie/reaction/Reactions/solidReaction/solidReaction.C index da945226ce33727cce0d7c576c5a5760b28bdd82..e476dd3b23ad71a1d55531e4c3bdfb2003061717 100644 --- a/src/thermophysicalModels/solidSpecie/reaction/Reactions/solidReaction/solidReaction.C +++ b/src/thermophysicalModels/solidSpecie/reaction/Reactions/solidReaction/solidReaction.C @@ -74,7 +74,7 @@ Foam::solidReaction<ReactionThermo>::solidReaction { this->setLRhs ( - IStringStream(dict.lookup("reaction"))(), + IStringStream(dict.getString("reaction"))(), pyrolisisGases_, glhs_, grhs_ diff --git a/src/thermophysicalModels/specie/reaction/Reactions/Reaction/Reaction.C b/src/thermophysicalModels/specie/reaction/Reactions/Reaction/Reaction.C index 66c944a8eb94070544213efe153d2b07f6fa328f..2b6778f3f511da6ea7d2f800d6f5eb1c08a798da 100644 --- a/src/thermophysicalModels/specie/reaction/Reactions/Reaction/Reaction.C +++ b/src/thermophysicalModels/specie/reaction/Reactions/Reaction/Reaction.C @@ -335,7 +335,7 @@ Foam::Reaction<ReactionThermo>::Reaction { setLRhs ( - IStringStream(dict.lookup("reaction"))(), + IStringStream(dict.getString("reaction"))(), species_, lhs_, rhs_