From 522f3b43a782a163da90b5b3b305e6bf3fe4e529 Mon Sep 17 00:00:00 2001
From: Andrew Heather <>
Date: Mon, 11 Feb 2019 12:19:39 +0000
Subject: [PATCH] BUG: Corrected debug output for solarLoad.  Fixes #1195

---
 .../solarLoad/faceShading/faceShading.C       | 22 +++++--------------
 .../externalSolarLoad/Allclean                |  1 -
 2 files changed, 5 insertions(+), 18 deletions(-)

diff --git a/src/thermophysicalModels/radiation/radiationModels/solarLoad/faceShading/faceShading.C b/src/thermophysicalModels/radiation/radiationModels/solarLoad/faceShading/faceShading.C
index 4c0785eb118..da762b641de 100644
--- a/src/thermophysicalModels/radiation/radiationModels/solarLoad/faceShading/faceShading.C
+++ b/src/thermophysicalModels/radiation/radiationModels/solarLoad/faceShading/faceShading.C
@@ -3,7 +3,7 @@
   \\      /  F ield         | OpenFOAM: The Open Source CFD Toolbox
    \\    /   O peration     |
     \\  /    A nd           | Copyright (C) 2015 OpenFOAM Foundation
-     \\/     M anipulation  | Copyright (C) 2017-2018 OpenCFD Ltd.
+     \\/     M anipulation  | Copyright (C) 2017-2019 OpenCFD Ltd.
 -------------------------------------------------------------------------------
 License
     This file is part of OpenFOAM.
@@ -26,11 +26,10 @@ License
 #include "faceShading.H"
 #include "fvMesh.H"
 #include "boundaryRadiationProperties.H"
-#include "OFstream.H"
 #include "cyclicAMIPolyPatch.H"
 #include "volFields.H"
 #include "distributedTriSurfaceMesh.H"
-
+#include "OBJstream.H"
 
 // * * * * * * * * * * * * * * Static Data Members * * * * * * * * * * * * * //
 
@@ -49,25 +48,14 @@ void Foam::faceShading::writeRays
     const pointField& myFc
 )
 {
-    OFstream str(fName);
-    label vertI = 0;
+    OBJstream os(fName);
 
-    Pout<< "Dumping rays to " << str.name() << endl;
+    Pout<< "Dumping rays to " << os.name() << endl;
 
     forAll(myFc, faceI)
     {
-        meshTools::writeOBJ(str, myFc[faceI]);
-        vertI++;
-        meshTools::writeOBJ(str, endCf[faceI]);
-        vertI++;
-        str << "l " << vertI-1 << ' ' << vertI << nl;
+        os.write(linePointRef(myFc[faceI], endCf[faceI]));
     }
-    str.flush();
-
-    Pout<< "cmd: objToVTK " << fName.c_str() << endl;
-
-    stringList cmd({"objToVTK", fName, fName.lessExt().ext("vtk")});
-    Foam::system(cmd);
 }
 
 
diff --git a/tutorials/heatTransfer/chtMultiRegionFoam/externalSolarLoad/Allclean b/tutorials/heatTransfer/chtMultiRegionFoam/externalSolarLoad/Allclean
index 9e53e2850bd..d4a9953c511 100755
--- a/tutorials/heatTransfer/chtMultiRegionFoam/externalSolarLoad/Allclean
+++ b/tutorials/heatTransfer/chtMultiRegionFoam/externalSolarLoad/Allclean
@@ -4,7 +4,6 @@ cd ${0%/*} || exit 1                        # Run from this directory
 
 cleanCase0
 
-rm -rf VTK
 rm -rf constant/cellToRegion
 rm -rf constant/*/polyMesh  # region meshes
 
-- 
GitLab