From c0fad3be099ffeae37e37486663fc627c14d04c3 Mon Sep 17 00:00:00 2001
From: Mark Olesen <Mark.Olesen@esi-group.com>
Date: Thu, 18 Jul 2019 10:28:40 +0200
Subject: [PATCH] BUG: fix suspicious ordering in polyTopoChange::getCellOrder
(#1376)
---
.../polyTopoChange/polyTopoChange/polyTopoChange.C | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/dynamicMesh/polyTopoChange/polyTopoChange/polyTopoChange.C b/src/dynamicMesh/polyTopoChange/polyTopoChange/polyTopoChange.C
index 007343334e5..63f724373dd 100644
--- a/src/dynamicMesh/polyTopoChange/polyTopoChange/polyTopoChange.C
+++ b/src/dynamicMesh/polyTopoChange/polyTopoChange/polyTopoChange.C
@@ -665,9 +665,8 @@ Foam::label Foam::polyTopoChange::getCellOrder
nbrs.clear();
weights.clear();
- forAll(neighbours, nI)
+ for (const label nbr : neighbours)
{
- label nbr = neighbours[nI];
if (!cellRemoved(nbr) && !visited.test(nbr))
{
// not visited, add to the list
@@ -678,9 +677,9 @@ Foam::label Foam::polyTopoChange::getCellOrder
// 2. Sort
sortedOrder(weights, order);
// 3. Add in sorted order
- forAll(order, i)
+ for (const label nbri : order)
{
- nextCell.append(nbrs[i]);
+ nextCell.append(nbrs[nbri]);
}
}
}
--
GitLab