From ed8fb0aa99a82c7155edcb8ae0937730f0ac2313 Mon Sep 17 00:00:00 2001 From: henry <Henry Weller h.weller@opencfd.co.uk> Date: Tue, 6 Apr 2010 16:28:59 +0100 Subject: [PATCH] UEqn: Removed "Sp" term from the momentum equation of the steady-state solvers. It is not clear that this "correction" term has provided any benefit and there are cases for which it has proved detrimental to stability and convergence. --- applications/solvers/compressible/rhoPorousSimpleFoam/UEqn.H | 1 - applications/solvers/compressible/rhoSimpleFoam/UEqn.H | 1 - applications/solvers/compressible/rhoSimplecFoam/UEqn.H | 1 - .../solvers/heatTransfer/buoyantBoussinesqSimpleFoam/UEqn.H | 1 - applications/solvers/heatTransfer/buoyantSimpleFoam/UEqn.H | 1 - .../solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/UEqn.H | 1 - applications/solvers/incompressible/porousSimpleFoam/UEqn.H | 1 - .../incompressible/MRFSimpleFoam/MRFSimpleFoam/MRFSimpleFoam.C | 1 - 8 files changed, 8 deletions(-) diff --git a/applications/solvers/compressible/rhoPorousSimpleFoam/UEqn.H b/applications/solvers/compressible/rhoPorousSimpleFoam/UEqn.H index 4150cd7503f..54609442885 100644 --- a/applications/solvers/compressible/rhoPorousSimpleFoam/UEqn.H +++ b/applications/solvers/compressible/rhoPorousSimpleFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevRhoReff(U) ); diff --git a/applications/solvers/compressible/rhoSimpleFoam/UEqn.H b/applications/solvers/compressible/rhoSimpleFoam/UEqn.H index c41bc9b6c7b..401e1203d26 100644 --- a/applications/solvers/compressible/rhoSimpleFoam/UEqn.H +++ b/applications/solvers/compressible/rhoSimpleFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevRhoReff(U) ); diff --git a/applications/solvers/compressible/rhoSimplecFoam/UEqn.H b/applications/solvers/compressible/rhoSimplecFoam/UEqn.H index c41bc9b6c7b..401e1203d26 100644 --- a/applications/solvers/compressible/rhoSimplecFoam/UEqn.H +++ b/applications/solvers/compressible/rhoSimplecFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevRhoReff(U) ); diff --git a/applications/solvers/heatTransfer/buoyantBoussinesqSimpleFoam/UEqn.H b/applications/solvers/heatTransfer/buoyantBoussinesqSimpleFoam/UEqn.H index a813a2d8b7a..bcf99e16680 100644 --- a/applications/solvers/heatTransfer/buoyantBoussinesqSimpleFoam/UEqn.H +++ b/applications/solvers/heatTransfer/buoyantBoussinesqSimpleFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevReff(U) ); diff --git a/applications/solvers/heatTransfer/buoyantSimpleFoam/UEqn.H b/applications/solvers/heatTransfer/buoyantSimpleFoam/UEqn.H index aa476b4dc80..0170d6e3844 100644 --- a/applications/solvers/heatTransfer/buoyantSimpleFoam/UEqn.H +++ b/applications/solvers/heatTransfer/buoyantSimpleFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevRhoReff(U) ); diff --git a/applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/UEqn.H b/applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/UEqn.H index 1cbafe368aa..7f317cc2e6b 100644 --- a/applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/UEqn.H +++ b/applications/solvers/heatTransfer/chtMultiRegionSimpleFoam/fluid/UEqn.H @@ -2,7 +2,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turb.divDevRhoReff(U) ); diff --git a/applications/solvers/incompressible/porousSimpleFoam/UEqn.H b/applications/solvers/incompressible/porousSimpleFoam/UEqn.H index c1925c7708c..688120809a1 100644 --- a/applications/solvers/incompressible/porousSimpleFoam/UEqn.H +++ b/applications/solvers/incompressible/porousSimpleFoam/UEqn.H @@ -3,7 +3,6 @@ tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevReff(U) ); diff --git a/tutorials/incompressible/MRFSimpleFoam/MRFSimpleFoam/MRFSimpleFoam.C b/tutorials/incompressible/MRFSimpleFoam/MRFSimpleFoam/MRFSimpleFoam.C index c727a74d65c..0941f035287 100644 --- a/tutorials/incompressible/MRFSimpleFoam/MRFSimpleFoam/MRFSimpleFoam.C +++ b/tutorials/incompressible/MRFSimpleFoam/MRFSimpleFoam/MRFSimpleFoam.C @@ -64,7 +64,6 @@ int main(int argc, char *argv[]) tmp<fvVectorMatrix> UEqn ( fvm::div(phi, U) - - fvm::Sp(fvc::div(phi), U) + turbulence->divDevReff(U) ); mrfZones.addCoriolis(UEqn()); -- GitLab