GitLab

- makes for clearer code

ENH: make writeIfDifferent part of Ostream

GeometricField: Renamed internalField() -> primitiveField() and dimensionedInternalField() -> internalField()

These new names are more consistent and logical because:

primitiveField():
primitiveFieldRef():
    Provides low-level access to the Field<Type> (primitive field)
    without dimension or mesh-consistency checking.  This should only be
    used in the low-level functions where dimensional consistency is
    ensured by careful programming and computational efficiency is
    paramount.

internalField():
internalFieldRef():
    Provides access to the DimensionedField<Type, GeoMesh> of values on
    the internal mesh-type for which the GeometricField is defined and
    supports dimension and checking and mesh-consistency checking.

To be used instead of zeroGradientFvPatchField for temporary fields for
which zero-gradient extrapolation is use to evaluate the boundary field
but avoiding fields derived from temporary field using field algebra
inheriting the zeroGradient boundary condition by the reuse of the
temporary field storage.

zeroGradientFvPatchField should not be used as the default patch field
for any temporary fields and should be avoided for non-temporary fields
except where it is clearly appropriate;
extrapolatedCalculatedFvPatchField and calculatedFvPatchField are
generally more suitable defaults depending on the manner in which the
boundary values are specified or evaluated.

The entire OpenFOAM-dev code-base has been updated following the above
recommendations.

Henry G. Weller
CFD Direct

valuePointPatchField: Change assignment to use the object's internalField rather than that of the argument

Avoids dependency on the state of the argument pointPatchField the
internalField of which may have been de-allocated

This reverts commit c5bea524.

This reverts commit b18f6cc1.

eg,
    - makePatchTypeField -> makeTemplatePatchTypeField
    - makeNonTemplatedPatchTypeField -> makePatchTypeField

non constraint patchFields on constraint patch types (all fields)

- removed globalPointPatch*
- removed pointPatchInterpolate*
since all is now inside volPointInterpolation.