1. 05 Oct, 2018 1 commit
    • Mark Olesen's avatar
      ENH: use dictionary::readEntry for detection of input errors (#762, #1033) · 13778f76
      Mark Olesen authored
      - instead of   dict.lookup(name) >> val;
        can use      dict.readEntry(name, val);
      
        for checking of input token sizes.
        This helps catch certain types of input errors:
      
        {
      
            key1 ;                // <- Missing value
            key2 1234             // <- Missing ';' terminator
            key3 val;
        }
      
      STYLE: readIfPresent() instead of 'if found ...' in a few more places.
      13778f76
  2. 30 May, 2018 1 commit
  3. 28 Mar, 2018 1 commit
  4. 21 Mar, 2018 1 commit
  5. 26 Feb, 2018 3 commits
    • Mark Olesen's avatar
    • Mark Olesen's avatar
      ENH: cleanup tmp class (issue #639) · 52b36f84
      Mark Olesen authored
      Improve alignment of its behaviour with std::shared_ptr
      
        - element_type typedef
        - swap, reset methods
      
      * additional reference access methods:
      
      cref()
          returns a const reference, synonymous with operator().
          This provides a more verbose alternative to using the '()' operator
          when that is desired.
      
              Mnemonic: a const form of 'ref()'
      
      constCast()
          returns a non-const reference, regardless if the underlying object
          itself is a managed pointer or a const object.
          This is similar to ref(), but more permissive.
      
              Mnemonic: const_cast<>
      
          Using the constCast() method greatly reduces the amount of typing
          and reading. And since the data type is already defined via the tmp
          template parameter, the type deduction is automatically known.
      
          Previously,
      
              const tmp<volScalarField>& tfld;
      
              const_cast<volScalarField&>(tfld()).rename("name");
              volScalarField& fld = const_cast<volScalarField&>(tfld());
      
          Now,
      
              tfld.constCast().rename("name");
              auto& fld = tfld.constCast();
      
      --
      
      BUG: attempts to move tmp value that may still be shared.
      
      - old code simply checked isTmp() to decide if the contents could be
        transfered. However, this means that the content of a shared tmp
        would be removed, leaving other instances without content.
      
      * movable() method checks that for a non-null temporary that is
        unique (not shared).
      52b36f84
    • Mark Olesen's avatar
      ENH: cleanup autoPtr class (issue #639) · 660f3e54
      Mark Olesen authored
      Improve alignment of its behaviour with std::unique_ptr
      
        - element_type typedef
        - release() method - identical to ptr() method
        - get() method to get the pointer without checking and without releasing it.
        - operator*() for dereferencing
      
      Method name changes
      
        - renamed rawPtr() to get()
        - renamed rawRef() to ref(), removed unused const version.
      
      Removed methods/operators
      
        - assignment from a raw pointer was deleted (was rarely used).
          Can be convenient, but uncontrolled and potentially unsafe.
          Do allow assignment from a literal nullptr though, since this
          can never leak (and also corresponds to the unique_ptr API).
      
      Additional methods
      
        - clone() method: forwards to the clone() method of the underlying
          data object with argument forwarding.
      
        - reset(autoPtr&&) as an alternative to operator=(autoPtr&&)
      
      STYLE: avoid implicit conversion from autoPtr to object type in many places
      
      - existing implementation has the following:
      
           operator c...
      660f3e54
  6. 22 Nov, 2017 1 commit
  7. 19 Nov, 2017 1 commit
  8. 05 Jun, 2018 1 commit
  9. 17 Jan, 2018 1 commit
  10. 16 Jan, 2018 1 commit
    • Andrew Heather's avatar
      ENH: residuals function object - extended to write residual fields · 6312f809
      Andrew Heather authored
      Residual fields can be written using the new 'writeFields' entry, e.g.
      
          functions
          {
              residual
              {
                  type            residuals;
                  libs            ("libutilityFunctionObjects.so");
                  fields          (".*");
                  writeControl    writeTime;
                  writeFields     true;
              }
          }
      
      Fields currently correspond to the initial residual for the last solver
      iteration.
      6312f809
  11. 24 Oct, 2017 1 commit
  12. 01 Sep, 2017 1 commit
  13. 09 Oct, 2017 1 commit
  14. 03 Jul, 2017 1 commit
  15. 14 Jun, 2017 1 commit
    • mattijs's avatar
      ENH: overset: Initial release of overset capability. · fd665b4a
      mattijs authored
      Adds overset discretisation to selected physics:
      - diffusion : overLaplacianDyMFoam
      - incompressible steady : overSimpleFoam
      - incompressible transient : overPimpleDyMFoam
      - compressible transient: overRhoPimpleDyMFoam
      - two-phase VOF: overInterDyMFoam
      
      The overset method chosen is a parallel, fully implicit implementation
      whereby the interpolation (from donor to acceptor) is inserted as an
      adapted discretisation on the donor cells, such that the resulting matrix
      can be solved using the standard linear solvers.
      
      Above solvers come with a set of tutorials, showing how to create and set-up
      simple simulations from scratch.
      fd665b4a
  16. 26 May, 2017 1 commit
  17. 19 May, 2017 1 commit
  18. 27 Apr, 2017 1 commit
  19. 18 Apr, 2017 1 commit
  20. 10 Mar, 2017 1 commit
  21. 03 Mar, 2017 1 commit
  22. 28 Feb, 2017 1 commit
  23. 03 Feb, 2017 1 commit
    • Henry Weller's avatar
      PBiCG: Suggest changing to the more robust PBiCGStab solver · 23809f7a
      Henry Weller authored
      if convergence is not achieved within the maximum number of iterations.
      
      Sometimes, particularly running in parallel, PBiCG fails to converge or diverges
      without warning or obvious cause leaving a solution field containing significant
      errors which can cause divergence of the application.  PBiCGStab is more robust
      and does not suffer from the problems encountered with PBiCG.
      23809f7a
  24. 19 Jan, 2017 1 commit
  25. 11 Jan, 2017 1 commit
  26. 09 Dec, 2016 1 commit
  27. 28 Nov, 2016 1 commit
  28. 16 Sep, 2016 1 commit
  29. 10 Sep, 2016 1 commit
  30. 06 Sep, 2016 2 commits
  31. 05 Sep, 2016 3 commits
    • Henry Weller's avatar
      Solvers: Corrected typo · e86688a5
      Henry Weller authored
      e86688a5
    • Henry Weller's avatar
      Updated header · 4502b7a5
      Henry Weller authored
      4502b7a5
    • Henry Weller's avatar
      PBiCGStab: New preconditioned bi-conjugate gradient stabilized solver for asymmetric lduMatrices · 0857f479
      Henry Weller authored
      using a run-time selectable preconditioner
      
      References:
          Van der Vorst, H. A. (1992).
          Bi-CGSTAB: A fast and smoothly converging variant of Bi-CG
          for the solution of nonsymmetric linear systems.
          SIAM Journal on scientific and Statistical Computing, 13(2), 631-644.
      
          Barrett, R., Berry, M. W., Chan, T. F., Demmel, J., Donato, J.,
          Dongarra, J., Eijkhout, V., Pozo, R., Romine, C. & Van der Vorst, H.
          (1994).
          Templates for the solution of linear systems:
          building blocks for iterative methods
          (Vol. 43). Siam.
      
      See also: https://en.wikipedia.org/wiki/Biconjugate_gradient_stabilized_method
      
      Tests have shown that PBiCGStab with the DILU preconditioner is more
      robust, reliable and shows faster convergence (~2x) than PBiCG with
      DILU, in particular in parallel where PBiCG occasionally diverges.
      
      This remarkable improvement over PBiCG prompted the update of all
      tutorial cases currently using PBiCG to use PBiCGStab instead.  If any
      issues arise with this update please report on Mantis: http://bugs.openfoam.org
      0857f479
  32. 05 Aug, 2016 1 commit
  33. 20 Jun, 2016 1 commit
  34. 17 Jun, 2016 2 commits