1. 15 Dec, 2021 2 commits
  2. 13 Dec, 2021 1 commit
  3. 09 Dec, 2021 1 commit
  4. 26 Nov, 2021 1 commit
  5. 05 Nov, 2021 1 commit
  6. 28 Oct, 2021 1 commit
  7. 03 Aug, 2021 1 commit
  8. 16 Jul, 2021 1 commit
  9. 15 Jul, 2021 1 commit
  10. 12 Jul, 2021 1 commit
  11. 08 Jul, 2021 2 commits
  12. 29 Jun, 2021 2 commits
  13. 07 Jun, 2021 1 commit
    • Mark OLESEN's avatar
      ENH: protected method fa/fv option::resetApplied() · 2f6739b1
      Mark OLESEN authored
      - resizes to current fieldNames_ size and assigns everything to
        false to avoid any "stickiness" if the field ordering changes
        between reads.
      ENH: additional debugging faOption/fvOption (#2110)
      - aids tracing which sources are being used/ignored
      - update code style
      STYLE: rename CodedSource -> CodedFvSource
      - avoid future name clashes with CodedFaSource
  14. 19 Apr, 2021 1 commit
    • Mark OLESEN's avatar
      ENH: improve hashing overloads of string-types and HashTable/HashSet · 95cd8ee7
      Mark OLESEN authored and Andrew Heather's avatar Andrew Heather committed
      - additional dummy template parameter to assist with supporting
        derived classes. Currently just used for string types, but can be
      - provide hash specialization for various integer types.
        Removes the need for any forwarding.
      - change default hasher for HashSet/HashTable from 'string::hash'
        to `Hash<Key>`. This avoids questionable hashing calls and/or
        avoids compiler resolution problems.
        For example,
        HashSet<label>::hasher and labelHashSet::hasher now both properly
        map to Hash<label> whereas previously HashSet<label> would have
        persistently mapped to string::hash, which was incorrect.
      - standardize internal hashing functors.
        Functor name is 'hasher', as per STL set/map and the OpenFOAM
        HashSet/HashTable definitions.
        Older code had a local templated name, which added unnecessary
        clutter and the template parameter was always defaulted.
        For example,
            Old:  `FixedList<label, 3>::Hash<>()`
            New:  `FixedList<label, 3>::hasher()`
            Unchanged:  `labelHashSet::hasher()`
        Existing `Hash<>` functor namings are still supported,
        but deprecated.
      - define hasher and Hash specialization for bitSet and PackedList
      - add symmetric hasher for 'face'.
        Starts with lowest vertex value and walks in the direction
        of the next lowest value. This ensures that the hash code is
        independent of face orientation and face rotation.
        - some of keys for multiphase handling (eg, phasePairKey)
          still use yet another function naming: `hash` and `symmHash`.
          This will be targeted for alignment in the future.
  15. 15 Apr, 2021 1 commit
  16. 24 Mar, 2021 1 commit
    • sergio's avatar
      ENH: new solvers: overCompressibleInterDyMFoam and overInterPhaseChangeDyMFoam · ad35fea7
      sergio authored and Kutalmış Berçin's avatar Kutalmış Berçin committed
      - overCompressibleInterDyMFoam: Overset solver for two compressible,
      non-isothermal, immiscible fluids using a VOF (i.e. volume of fluid)
      phase-fraction based interface capturing approach.
      - overInterPhaseChangeDyMFoam: Overset solver for two incompressible,
      isothermal, immiscible fluids with phase-change (e.g. cavitation) using
      VoF (i.e. volume of fluid) phase-fraction based interface capturing approach.
      - adds new tutorials:
        - multiphase/overCompressibleInterDyMFoam/compressibleTwoSimpleRotors
        - multiphase/overInterPhaseChangeDyMFoam/twoSimpleRotors
      Signed-off-by: Kutalmış Berçin's avatarKutalmis Bercin <kutalmis.bercin@esi-group.com>
  17. 18 Mar, 2021 2 commits
  18. 17 Mar, 2021 1 commit
    • sergio's avatar
      ENH: Improvement to overset that allows multiple motion solvers · da1e6ea8
      sergio authored and Andrew Heather's avatar Andrew Heather committed
           to operate with overset
      1) Adding zoneMotion to rigidBodyMotion
      2) Introducing PID to prescribedRotation restraint
      3) Making drivenLinearMotion read total displacement
      4) When drivenLinearMotion is used sixDof and rigid-body solvers
         write total displacement
  19. 15 Feb, 2021 1 commit
  20. 21 Dec, 2020 1 commit
  21. 16 Dec, 2020 2 commits
    • sergio's avatar
    • Sergio Ferraris's avatar
      ENH: adding non-uniform rho to incompressible two-phase turbulent models · 3db12bbd
      Sergio Ferraris authored and Andrew Heather's avatar Andrew Heather committed
      1) PhaseIncompressibleTurbulenceModel class was changed to use
         uniform alpha and non-uniform rho templates. This fits the need
         of incompressible two phase turbulence models.
      2) A new type DPMIncompressibleTurbulenceModel was created for
         non-uniform alpha and uniform rho. It is  used in single phase flows
         in DPM solvers where alpha represents the volumen occupancy.
      3) A new type incompressibleRhoTurbulenceModel  was created where
         non-uniform rho is allowed.
      4) A new base templated turbulent class for two-phase VOF named
         VoFphaseTurbulentTransportModel was implemented which is created
         templating on PhaseIncompressibleTurbulenceModel and
      5) In order to make the chnage to rho based VOF turbulence a help
         class was added incompressibleInterPhaseTransportModel templated
         on the mixing.
  22. 18 Nov, 2020 1 commit
  23. 10 Nov, 2020 1 commit
  24. 15 Oct, 2020 1 commit
  25. 28 Sep, 2020 1 commit
    • Mark OLESEN's avatar
      ENH: add UPstream::allProcs() method · e18ff114
      Mark OLESEN authored
      - returns a range of `int` values that can be iterated across.
        For example,
            for (const int proci : Pstream::allProcs()) { ... }
        instead of
            for (label proci = 0; proci < Pstream::nProcs(); ++proci) { ... }
  26. 07 Aug, 2020 1 commit
  27. 05 Aug, 2020 3 commits
    • Mark OLESEN's avatar
    • Mark OLESEN's avatar
      ENH: avoid phaseSystem cyclic dependencies, reduce number of libraries · 915c0785
      Mark OLESEN authored
      Reduce the number of phaseSystems libraries:
      - phaseSystems previously had a number of smaller libraries to provide
        interface and model properties, etc. This potential flexibility was
        never actually used anywhere, but causes cyclic dependencies between
        phaseSystem and the models (and turbulence) that causes extreme
        difficulty for mingw linking (issue #1238).
      - libincompressibleMultiphaseSystems
        - removed: libmassTransferModels
      - libmultiphaseSystem
        - removed: libcompressibleMultiphaseEulerianInterfacialModels
      - libreactingMultiphaseSystem
        - removed: libreactingPhaseSystem
        - removed: libreactingEulerianFvPatchFields
        - removed: libreactingEulerianInterfacialCompositionModels
        - removed: libreactingEulerianInterfacialModels
        - removed: libmultiphaseReactingTurbulenceModels
      - libreactingTwoPhaseSystem
        - removed: libreactingPhaseSystem
        - removed: libreactingEulerianFvPatchFields
        - removed: libreactingEulerianInterfacialCompositionModels
        - removed: libreactingEulerianInterfacialModels
      Avoid duplicate symbol for phaseCompressibleTurbulenceModels
        Common turbulence models are defined in libreactingMultiphaseSystem,
        and libmultiphaseReactingTurbulenceModels is now redundant.
        The libtwoPhaseReactingTurbulenceModels extends the common models
        for reactingTwoPhaseSystem.
    • Mark OLESEN's avatar
      ENH: centralize more libraries in src/phaseSystemModels · 03526e20
      Mark OLESEN authored
      - prelude to code refactoring
          no source code change in this commit, only relocation,
          renaming and adjustment of Make/{files,options}
  28. 03 Aug, 2020 1 commit
  29. 16 Jul, 2020 2 commits
    • Mark OLESEN's avatar
      STYLE: check autoPtr as plain bool instead of valid() · 12c91b94
      Mark OLESEN authored
      - cleaner code, more similarity with unique_ptr
            if (ptr)
            if (!ptr)
            if (ptr.valid())
            if (!ptr.valid())
    • Mark OLESEN's avatar
      STYLE: simplify short-circuit involving autoPtr (#1775) · 9af3f85c
      Mark OLESEN authored
      - with '&&' conditions, often better to check for non-null autoPtr
        first (it is cheap)
      - check as bool instead of valid() method for cleaner code, especially
        when the wrapped item itself has a valid/empty or good.
        Also when handling multiple checks.
            if (ptr && ptr->valid())
            if (ptr1 || ptr2)
            if (ptr.valid() && ptr->valid())
            if (ptr1.valid() || ptr2.valid())
  30. 17 Jun, 2020 1 commit
  31. 16 Jun, 2020 1 commit
  32. 15 Jun, 2020 1 commit