1. 05 Jun, 2020 1 commit
  2. 02 Jun, 2020 1 commit
    • Mark OLESEN's avatar
      ENH: unify use of dictionary method names · 3e43edf0
      Mark OLESEN authored
      - previously introduced `getOrDefault` as a dictionary _get_ method,
        now complete the transition and use it everywhere instead of
        `lookupOrDefault`. This avoids mixed usage of the two methods that
        are identical in behaviour, makes for shorter names, and promotes
        the distinction between "lookup" access (ie, return a token stream,
        locate and return an entry) and "get" access (ie, the above with
        conversion to concrete types such as scalar, label etc).
  3. 31 Oct, 2019 1 commit
  4. 09 Sep, 2019 2 commits
  5. 21 Aug, 2019 1 commit
  6. 06 Feb, 2019 1 commit
  7. 05 Dec, 2018 1 commit
  8. 03 Dec, 2018 1 commit
  9. 16 Nov, 2018 1 commit
  10. 28 Mar, 2018 1 commit
  11. 26 Feb, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: cleanup autoPtr class (issue #639) · 660f3e54
      Mark OLESEN authored
      Improve alignment of its behaviour with std::unique_ptr
        - element_type typedef
        - release() method - identical to ptr() method
        - get() method to get the pointer without checking and without releasing it.
        - operator*() for dereferencing
      Method name changes
        - renamed rawPtr() to get()
        - renamed rawRef() to ref(), removed unused const version.
      Removed methods/operators
        - assignment from a raw pointer was deleted (was rarely used).
          Can be convenient, but uncontrolled and potentially unsafe.
          Do allow assignment from a literal nullptr though, since this
          can never leak (and also corresponds to the unique_ptr API).
      Additional methods
        - clone() method: forwards to the clone() method of the underlying
          data object with argument forwarding.
        - reset(autoPtr&&) as an alternative to operator=(autoPtr&&)
      STYLE: avoid implicit conversion from autoPtr to object type in many places
      - existing implementation has the following:
           operator const T&() const { return operator*(); }
        which means that the following code works:
             autoPtr<mapPolyMesh> map = ...;
             updateMesh(*map);    // OK: explicit dereferencing
             updateMesh(map());   // OK: explicit dereferencing
             updateMesh(map);     // OK: implicit dereferencing
        for clarity it may preferable to avoid the implicit dereferencing
      - prefer operator* to operator() when deferenced a return value
        so it is clearer that a pointer is involve and not a function call
        etc    Eg,   return *meshPtr_;  vs.  return meshPtr_();
  12. 07 Nov, 2017 1 commit
  13. 22 Nov, 2017 1 commit
  14. 27 Feb, 2018 1 commit
  15. 04 Jan, 2018 1 commit
    • Will Bainbridge's avatar
      BUG: writeFile: Increased the number of value characters · 4272820f
      Will Bainbridge authored and Andrew Heather's avatar Andrew Heather committed
      The number of characters needed to print a double in scientific format
      is 8 plus the number of decimal places; e.g., -6.453452e-231 (6 decimal
      places, 14 characters). This has been set in writeFile.C, replacing a
      value of 7. Presumably, the case of three digits in the exponent was not
      considered when this was first implemented. This change ensures at least
      one character of whitespace between tabulated numbers.
      This resolves bug report https://bugs.openfoam.org/view.php?id=2801
  16. 07 Jul, 2017 1 commit
    • Andrew Heather's avatar
      INT: Integration of Mattijs' collocated parallel IO additions · d8d6030a
      Andrew Heather authored
      Original commit message:
      Parallel IO: New collated file format
      When an OpenFOAM simulation runs in parallel, the data for decomposed fields and
      mesh(es) has historically been stored in multiple files within separate
      directories for each processor.  Processor directories are named 'processorN',
      where N is the processor number.
      This commit introduces an alternative "collated" file format where the data for
      each decomposed field (and mesh) is collated into a single file, which is
      written and read on the master processor.  The files are stored in a single
      directory named 'processors'.
      The new format produces significantly fewer files - one per field, instead of N
      per field.  For large parallel cases, this avoids the restriction on the number
      of open files imposed by the operating system limits.
      The file writing can be threaded allowing the simulation to continue running
      while the data is being written to file.  NFS (Network File System) is not
      needed when using the the collated format and additionally, there is an option
      to run without NFS with the original uncollated approach, known as
      The controls for the file handling are in the OptimisationSwitches of
          //- Parallel IO file handler
          //  uncollated (default), collated or masterUncollated
          fileHandler uncollated;
          //- collated: thread buffer size for queued file writes.
          //  If set to 0 or not sufficient for the file size threading is not used.
          //  Default: 2e9
          maxThreadFileBufferSize 2e9;
          //- masterUncollated: non-blocking buffer size.
          //  If the file exceeds this buffer size scheduled transfer is used.
          //  Default: 2e9
          maxMasterFileBufferSize 2e9;
      When using the collated file handling, memory is allocated for the data in the
      thread.  maxThreadFileBufferSize sets the maximum size of memory in bytes that
      is allocated.  If the data exceeds this size, the write does not use threading.
      When using the masterUncollated file handling, non-blocking MPI communication
      requires a sufficiently large memory buffer on the master node.
      maxMasterFileBufferSize sets the maximum size in bytes of the buffer.  If the
      data exceeds this size, the system uses scheduled communication.
      The installation defaults for the fileHandler choice, maxThreadFileBufferSize
      and maxMasterFileBufferSize (set in etc/controlDict) can be over-ridden within
      the case controlDict file, like other parameters.  Additionally the fileHandler
      can be set by:
      - the "-fileHandler" command line argument;
      - a FOAM_FILEHANDLER environment variable.
      A foamFormatConvert utility allows users to convert files between the collated
      and uncollated formats, e.g.
          mpirun -np 2 foamFormatConvert -parallel -fileHandler uncollated
      An example case demonstrating the file handling methods is provided in:
      The work was undertaken by Mattijs Janssens, in collaboration with Henry Weller.
  17. 25 Apr, 2017 1 commit
  18. 21 Mar, 2017 2 commits
  19. 29 Nov, 2016 1 commit
  20. 01 Nov, 2016 1 commit
  21. 23 Sep, 2016 1 commit
  22. 24 Aug, 2016 1 commit
  23. 07 Aug, 2016 1 commit
  24. 24 May, 2016 1 commit
  25. 16 May, 2016 1 commit
  26. 15 May, 2016 1 commit
    • Henry Weller's avatar
      functionObjects: rewritten to all be derived from 'functionObject' · 78d2971b
      Henry Weller authored
        - Avoids the need for the 'OutputFilterFunctionObject' wrapper
        - Time-control for execution and writing is now provided by the
          'timeControlFunctionObject' which instantiates the processing
          'functionObject' and controls its operation.
        - Alternative time-control functionObjects can now be written and
          selected at run-time without the need to compile wrapped version of
          EVERY existing functionObject which would have been required in the
          old structure.
        - The separation of 'execute' and 'write' functions is now formalized in the
          'functionObject' base-class and all derived classes implement the
          two functions.
        - Unnecessary implementations of functions with appropriate defaults
          in the 'functionObject' base-class have been removed reducing
          clutter and simplifying implementation of new functionObjects.
        - The 'coded' 'functionObject' has also been updated, simplified and tested.
        - Further simplification is now possible by creating some general
          intermediate classes derived from 'functionObject'.
  27. 30 Apr, 2016 1 commit
  28. 08 Dec, 2015 1 commit
  29. 20 Nov, 2015 1 commit
  30. 08 Nov, 2015 1 commit
  31. 05 Oct, 2015 2 commits
    • Andrew Heather's avatar
      ENH: Refactored functionObjectFile class · 9a9f32ea
      Andrew Heather authored
      Class now provides helper functions to generate files on-the-fly by
      function objects, as opposed to attempting to control all files needed
      by the function object (earlier implementation lead to over-complication
      and was error prone)
    • Andrew Heather's avatar
      ENH: Refactored functionObjectFile class · bbc25cb4
      Andrew Heather authored
      Class now provides helper functions to generate files on-the-fly by
      function objects, as opposed to attempting to control all files needed
      by the function object (earlier implementation lead to over-complication
      and was error prone)
  32. 05 Aug, 2015 1 commit
  33. 26 Apr, 2015 1 commit
  34. 12 May, 2014 1 commit
  35. 25 Nov, 2013 2 commits
  36. 26 Jul, 2013 1 commit