1. 17 Dec, 2020 1 commit
    • Mark Olesen's avatar
      ENH: make PDRsetField ground, outer patch names configurable · 7f17a71f
      Mark Olesen authored
      - previously hard-coded, now adjustable within PDRsetFieldsDict
      
          // Change some predefined patch names
          patchNames
          {
              ground      ground;
              outer       outer;
          }
      
      ENH: additions to PDRutils, improve comments
      
      - expose enumerated expansion names and gridControl (PDRblock).
        Not commonly needed, but useful to have access when defining
        other grid generators
      
      TUT: update PDRsetFieldsDict and tutorials to use "ground"
      
      - remove tutorial references to unused types and legacy obstacles
      
      - use "ground" for the boundary conditions instead of "seaGround".
        Consistent with PDRblockMesh
      7f17a71f
  2. 15 Dec, 2020 1 commit
  3. 11 Dec, 2020 3 commits
  4. 25 Nov, 2020 2 commits
  5. 19 Nov, 2020 1 commit
  6. 16 Nov, 2020 1 commit
  7. 13 Nov, 2020 1 commit
  8. 28 Oct, 2020 3 commits
    • Mark Olesen's avatar
      BUG: PDRsetFields fails with non-orthogonal outer region (fixes #1907) · 3b7100a9
      Mark Olesen authored
      - first sort the cells into their ijk bins, and restrict testing for
        face orientation to those faces with an owner or neighbour that has
        an ijk bin.
      
      ENH: ensure polyMesh from PDRblockMesh is marked as AUTO_WRITE
      
      - the particular polyMesh constructor inherits the writeOpt, which
        makes is dependent on the caller and thus somewhat fragile for the
        top level caller.
      3b7100a9
    • Mark Olesen's avatar
      ENH: use static to define default blockMesh verbosity · f999013f
      Mark Olesen authored
      - make handling of verbosity more consistent.
      
        Make all setter return the old value, remove (unused) default
        parameter as being counter-intuitive.  This makes it easier to
        restore the original values.
      
        For example,
      
           const bool oldVerbose = sampler.verbose(false);
           ...
           sampler.verbose(oldVerbose);
      f999013f
    • Mark Olesen's avatar
      ENH: generate local orientation vectors for blockMesh VTK output (#1903) · f959c8eb
      Mark Olesen authored
      - can help when designing/debugging blockMesh layouts
      
      - propagate low-level cellModel methods face() and edge() to cellShape
      
      STYLE: relocate blockMesh OBJ output to application only
      
      - remove blockTopology files in cleanCase function
      
      - improve code consistency in top-level blockMesh, PDRblockMesh
        generation.
      f959c8eb
  9. 22 Oct, 2020 2 commits
  10. 07 Oct, 2020 1 commit
  11. 05 Oct, 2020 2 commits
    • Mark Olesen's avatar
      ENH: support arc edge specification with origin point · 1d08ed9b
      Mark Olesen authored
      - The arc will frequently enclose an angle less than 180 degrees.
        For the case, it is possible to define the arc by its endpoints
        and its centre (origin) point. For example,
      
            arc 0 1 origin (0 0 0);
      
        When defined in the way, any discrepancy in the arc radius for the
        endpoints is resolved by adjusting the origin to ensure that the
        average radius is satisfied.
      
        It is also possible to specify a \em flatness factor as a multiplier
        of the radius. For example,
      
            arc 0 1 origin 1.1 (0 0 0);
      
      ENH: minor code cleanup for block edges
      
      ENH: expose point appending as polyList::concat
      1d08ed9b
    • Mark Olesen's avatar
      ENH: relocate blockMesh polyMesh generation into library (for code reuse) · 8939a556
      Mark Olesen authored
      STYLE: adjust blockMesh advanced/non-advanced options
      
      - make -merge-points "non-advanced" (for better exposure)
      - make -write-obj "advanced" (-write-vtk is preferred)
      8939a556
  12. 28 Sep, 2020 1 commit
    • Mark Olesen's avatar
      ENH: add UPstream::allProcs() method · e18ff114
      Mark Olesen authored
      - returns a range of `int` values that can be iterated across.
        For example,
      
            for (const int proci : Pstream::allProcs()) { ... }
      
        instead of
      
            for (label proci = 0; proci < Pstream::nProcs(); ++proci) { ... }
      e18ff114
  13. 16 Sep, 2020 2 commits
  14. 10 Sep, 2020 1 commit
    • mattijs's avatar
      BUG: snappyHexMesh: fixes #1836. · ab551573
      mattijs authored
      When truncating layers in one go (nBufferCellsNoExtrude -1) it
      should set the nCells per face to be the min of the number of points
      per edge.
      ab551573
  15. 16 Jul, 2020 2 commits
    • Mark Olesen's avatar
      STYLE: check autoPtr as plain bool instead of valid() · 12c91b94
      Mark Olesen authored
      - cleaner code, more similarity with unique_ptr
      
        Now
            if (ptr)
            if (!ptr)
      
        instead
            if (ptr.valid())
            if (!ptr.valid())
      12c91b94
    • Mark Olesen's avatar
      STYLE: simplify short-circuit involving autoPtr (#1775) · 9af3f85c
      Mark Olesen authored
      - with '&&' conditions, often better to check for non-null autoPtr
        first (it is cheap)
      
      - check as bool instead of valid() method for cleaner code, especially
        when the wrapped item itself has a valid/empty or good.
        Also when handling multiple checks.
      
        Now
            if (ptr && ptr->valid())
            if (ptr1 || ptr2)
      
        instead
            if (ptr.valid() && ptr->valid())
            if (ptr1.valid() || ptr2.valid())
      9af3f85c
  16. 13 Jul, 2020 2 commits
  17. 08 Jul, 2020 1 commit
  18. 17 Jun, 2020 1 commit
  19. 10 Jun, 2020 1 commit
  20. 02 Jun, 2020 1 commit
    • Mark Olesen's avatar
      ENH: unify use of dictionary method names · 3e43edf0
      Mark Olesen authored
      - previously introduced `getOrDefault` as a dictionary _get_ method,
        now complete the transition and use it everywhere instead of
        `lookupOrDefault`. This avoids mixed usage of the two methods that
        are identical in behaviour, makes for shorter names, and promotes
        the distinction between "lookup" access (ie, return a token stream,
        locate and return an entry) and "get" access (ie, the above with
        conversion to concrete types such as scalar, label etc).
      3e43edf0
  21. 26 May, 2020 1 commit
  22. 18 May, 2020 1 commit
    • mattijs's avatar
      ENH: leak-detection. Fixes #1572. · 3d746e8a
      mattijs authored
      The final leak can only be decided once all cells have been
      deleted. So only exit on final invocation and give warning-only
      beforehand. This avoids a lot of false positives.
      The tutorial itself didn't actually produce a mesh with leakage
      with the old settings. Upped the refinement level to force it
      to go through the hole in the geometry.
      3d746e8a
  23. 13 May, 2020 1 commit
    • Mark Olesen's avatar
      ENH: add blockMeshDict "mergeType" keyword (#1589) · 44b22560
      Mark Olesen authored
      - enumerated values are (points | topology) which can be optionally
        specified in the blockMeshDict. Default is 'topology'.
      
        If the command-line option `blockMesh -merge-points` is specified,
        this has absolute priority over any blockMeshDict entry.
      
      STYLE: changed blockMesh "-blockTopology" option to "-write-obj"
      
      - this is more specific to what it does. Potentially wish to add a
        "-write-vtk" option in the future.
      
      TUT: adjust tutorials to use preferred or necessary merge strategies:
      
        * channel395DFSEM - topology
        * nozzleFlow2D - points
        * pipeCyclic - points
      44b22560
  24. 04 May, 2020 2 commits
  25. 24 Apr, 2020 1 commit
  26. 31 Mar, 2020 1 commit
  27. 30 Mar, 2020 2 commits
  28. 13 Mar, 2020 1 commit