GitLab

- otherwise gets flagged as an error by clang

This is to access the face/edge/point status of the nearest at the
same time to ensure a consistent result.

Using getVolumeType query in distanceSurface, not simple normal
dot-product comparison, fails on edges.

Squashed merge of particleInteractions up to
commit e7cb5bcf0315c359539ef1e715e1d51991343391

structuredDecomp uses finiteVolume which uses meshTools which
used to use decompositionMethods

- in preparation for using PackedBoolList

picked up by a copyright change.

STYLE: use findIndices instead of findAll for coordinateSystems

- findAll() method returns a labelList of all matching names
- find() method returns the index to the first matching name

  For example, use a regex to specify alternative coordinate systems
  in porousZones
  (
      "cat1?(Back|Front)*"
      {
          coordinateSystem    "(cat1|system_10)";
          porosity    0.781;
          ...
      }
  )

Adapted meshSearch and sampledTriSurfaceMesh to use it.

- both versions handle the same input words.
  Only need the <Switch> version when the destination variable is
  also a Switch and we need to output the word later.

- affected: polyBoundary, fvBoundaryMesh, ZoneMesh, searchableSurfaces

  before:
      const label zoneI = mesh.cellZones().findZoneID(zoneName);
      const cellZone& cz = mesh.cellZones()[zoneI];
  after:
      const cellZone& cz = mesh.cellZones()[zoneName];

- "cpp -traditional-cpp" doesn't strip C++-style comments
  Probably need a workaround with sed -e 's@^ *//@@' if we
  wish to support C++-style comments in Make/{files,options}

- lduMatrixTests.C:121:1:
  error: ‘Foam::lduMatrix::solverPerformance::solverPerformance’ names
  the constructor, not the type

- edgeFaceCirculatorI.H:355:1:
  error: ‘Foam::edgeFaceCirculator::edgeFaceCirculator’ names the
  constructor, not the type

- patchPointEdgeCirculatorI.H:236:1:
  error: ‘Foam::patchPointEdgeCirculator::patchPointEdgeCirculator’
  names the constructor, not the type

- objToVTK.C:116:5:
  error: ‘Foam::argList::argList’ names the constructor, not the type

  same in surfaceClean.C, surfaceRefineRedGreen.C, surfaceSplitByPatch.C

- fireFoam/createFields.H:74:41:
  error: type/value mismatch at argument 1 in template parameter list
  for ‘template<class T> class Foam::autoPtr’

- accept some violations of the coding guidelines though
- perhaps adding a style exception would be simpler.