1. 30 Apr, 2016 5 commits
    • Henry Weller's avatar
      Updated headers · 81f31acb
      Henry Weller authored
      81f31acb
    • Henry Weller's avatar
      GeometricField: Renamed internalField() -> primitiveField() and... · 3c053c2f
      Henry Weller authored
      GeometricField: Renamed internalField() -> primitiveField() and dimensionedInternalField() -> internalField()
      
      These new names are more consistent and logical because:
      
      primitiveField():
      primitiveFieldRef():
          Provides low-level access to the Field<Type> (primitive field)
          without dimension or mesh-consistency checking.  This should only be
          used in the low-level functions where dimensional consistency is
          ensured by careful programming and computational efficiency is
          paramount.
      
      internalField():
      internalFieldRef():
          Provides access to the DimensionedField<Type, GeoMesh> of values on
          the internal mesh-type for which the GeometricField is defined and
          supports dimension and checking and mesh-consistency checking.
      3c053c2f
    • Henry Weller's avatar
      GeometricField::dimensionedInteralFieldRef() -> GeometricField::ref() · ccd958a8
      Henry Weller authored
      In order to simplify expressions involving dimensioned internal field it
      is preferable to use a simpler access convention.  Given that
      GeometricField is derived from DimensionedField it is simply a matter of
      de-referencing this underlying type unlike the boundary field which is
      peripheral information.  For consistency with the new convention in
      "tmp"  "dimensionedInteralFieldRef()" has been renamed "ref()".
      ccd958a8
    • Henry Weller's avatar
      CrankNicolsonDdtScheme: Use the new GeometricField constructor from... · 68b69a25
      Henry Weller authored
      CrankNicolsonDdtScheme: Use the new GeometricField constructor from DimensionedField and boundary FieldField
      68b69a25
    • Henry Weller's avatar
      GeometricField::internalField() -> GeometricField::internalFieldRef() · 5df2b964
      Henry Weller authored
      Non-const access to the internal field now obtained from a specifically
      named access function consistent with the new names for non-canst access
      to the boundary field boundaryFieldRef() and dimensioned internal field
      dimensionedInternalFieldRef().
      
      See also commit 22f4ad32
      5df2b964
  2. 28 Apr, 2016 2 commits
  3. 27 Apr, 2016 1 commit
    • Henry Weller's avatar
      GeometricField: Rationalized and simplified access to the dimensioned internal field · 4a57b9be
      Henry Weller authored
      Given that the type of the dimensioned internal field is encapsulated in
      the GeometricField class the name need not include "Field"; the type
      name is "Internal" so
      
      volScalarField::DimensionedInternalField -> volScalarField::Internal
      
      In addition to the ".dimensionedInternalField()" access function the
      simpler "()" de-reference operator is also provided to greatly simplify
      FV equation source term expressions which need not evaluate boundary
      conditions.  To demonstrate this kEpsilon.C has been updated to use
      dimensioned internal field expressions in the k and epsilon equation
      source terms.
      4a57b9be
  4. 26 Apr, 2016 2 commits
  5. 25 Apr, 2016 3 commits
    • Henry Weller's avatar
      Completed boundaryField() -> boundaryFieldRef() · 22f4ad32
      Henry Weller authored
      Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1938
      
      Because C++ does not support overloading based on the return-type there
      is a problem defining both const and non-const member functions which
      are resolved based on the const-ness of the object for which they are
      called rather than the intent of the programmer declared via the
      const-ness of the returned type.  The issue for the "boundaryField()"
      member function is that the non-const version increments the
      event-counter and checks the state of the stored old-time fields in case
      the returned value is altered whereas the const version has no
      side-effects and simply returns the reference.  If the the non-const
      function is called within the patch-loop the event-counter may overflow.
      To resolve this it in necessary to avoid calling the non-const form of
      "boundaryField()" if the results is not altered and cache the reference
      outside the patch-loop when mutation of the patch fields is needed.
      
      The most straight forward way of resolving this problem is to name the
      const and non-const forms of the member functions differently e.g. the
      non-const form could be named:
      
          mutableBoundaryField()
          mutBoundaryField()
          nonConstBoundaryField()
          boundaryFieldRef()
      
      Given that in C++ a reference is non-const unless specified as const:
      "T&" vs "const T&" the logical convention would be
      
          boundaryFieldRef()
          boundaryFieldConstRef()
      
      and given that the const form which is more commonly used is it could
      simply be named "boundaryField()" then the logical convention is
      
          GeometricBoundaryField& boundaryFieldRef();
      
          inline const GeometricBoundaryField& boundaryField() const;
      
      This is also consistent with the new "tmp" class for which non-const
      access to the stored object is obtained using the ".ref()" member function.
      
      This new convention for non-const access to the components of
      GeometricField will be applied to "dimensionedInternalField()" and "internalField()" in the
      future, i.e. "dimensionedInternalFieldRef()" and "internalFieldRef()".
      22f4ad32
    • Henry Weller's avatar
    • Henry Weller's avatar
      43beb060
  6. 24 Apr, 2016 1 commit
  7. 23 Apr, 2016 5 commits
    • Henry Weller's avatar
      boundaryField() -> boundaryFieldRef() · d8f8498c
      Henry Weller authored
      d8f8498c
    • Henry Weller's avatar
      boundaryField() -> boundaryFieldRef() · 7c12f774
      Henry Weller authored
      7c12f774
    • Henry Weller's avatar
      GeometricField: New non-const access function boundaryFieldRef() · 45f73bf6
      Henry Weller authored
      There is a need to specify const or non-const access to a non-const
      object which is not currently possible with the "boundaryField()" access
      function the const-ness of the return of which is defined by the
      const-ness of the object for which it is called.  For consistency with
      the latest "tmp" storage class in which non-const access is obtained
      with the "ref()" function it is proposed to replace the non-const form
      of "boundaryField()" with "boundaryFieldRef()".
      
      Thanks to Mattijs Janssens for starting the process of migration to
      "boundaryFieldRef()" and providing a patch for the OpenFOAM and
      finiteVolume libraries.
      45f73bf6
    • Henry Weller's avatar
      plenumPressureFvPatchScalarField: New plenum pressure boundary condition · 88561eea
      Henry Weller authored
      This condition creates a zero-dimensional model of an enclosed volume of
      gas upstream of the inlet. The pressure that the boundary condition
      exerts on the inlet boundary is dependent on the thermodynamic state of
      the upstream volume.  The upstream plenum density and temperature are
      time-stepped along with the rest of the simulation, and momentum is
      neglected. The plenum is supplied with a user specified mass flow and
      temperature.
      
      The result is a boundary condition which blends between a pressure inlet
      condition condition and a fixed mass flow. The smaller the plenum
      volume, the quicker the pressure responds to a deviation from the supply
      mass flow, and the closer the model approximates a fixed mass flow. As
      the plenum size increases, the model becomes more similar to a specified
      pressure.
      
      The expansion from the plenum to the inlet boundary is controlled by an
      area ratio and a discharge coefficient. The area ratio can be used to
      represent further acceleration between a sub-grid blockage such as fins.
      The discharge coefficient represents a fractional deviation from an
      ideal expansion process.
      
      This condition is useful for simulating unsteady internal flow problems
      for which both a mass flow boundary is unrealistic, and a pressure
      boundary is susceptible to flow reversal. It was developed for use in
      simulating confined combustion.
      
      tutorials/compressible/rhoPimpleFoam/laminar/helmholtzResonance:
          helmholtz resonance tutorial case for plenum pressure boundary
      
      This development was contributed by Will Bainbridge
      88561eea
    • Henry Weller's avatar
      fireFoam: Added optional hydrostatic initialization of the pressure and density · 673e0d17
      Henry Weller authored
      Also added the new prghTotalHydrostaticPressure p_rgh BC which uses the
      hydrostatic pressure field as the reference state for the far-field
      which provides much more accurate entrainment is large open domains
      typical of many fire simulations.
      
      The hydrostatic field solution is controlled by the optional entries in
      the fvSolution.PIMPLE dictionary, e.g.
      
          hydrostaticInitialization yes;
          nHydrostaticCorrectors 5;
      
      and the solver must also be specified for the hydrostatic p_rgh field
      ph_rgh e.g.
      
          ph_rgh
          {
              $p_rgh;
          }
      
      Suitable boundary conditions for ph_rgh cannot always be derived from
      those for p_rgh and so the ph_rgh is read to provide them.
      
      To avoid accuracy issues with IO, restart and post-processing the p_rgh
      and ph_rgh the option to specify a suitable reference pressure is
      provided via the optional pRef file in the constant directory, e.g.
      
          dimensions      [1 -1 -2 0 0 0 0];
          value           101325;
      
      which is used in the relationship between p_rgh and p:
      
          p = p_rgh + rho*gh + pRef;
      
      Note that if pRef is specified all pressure BC specifications in the
      p_rgh and ph_rgh files are relative to the reference to avoid round-off
      errors.
      
      For examples of suitable BCs for p_rgh and ph_rgh for a range of
      fireFoam cases please study the tutorials in
      tutorials/combustion/fireFoam/les which have all been updated.
      
      Henry G. Weller
      CFD Direct Ltd.
      673e0d17
  8. 16 Apr, 2016 1 commit
  9. 06 Apr, 2016 2 commits
    • Henry Weller's avatar
      Specialized dotInterpolate for the efficient calculation of flux fields · 77b03e2e
      Henry Weller authored
      e.g. (fvc::interpolate(HbyA) & mesh.Sf()) -> fvc::flux(HbyA)
      
      This removes the need to create an intermediate face-vector field when
      computing fluxes which is more efficient, reduces the peak storage and
      improved cache coherency in addition to providing a simpler and cleaner
      API.
      77b03e2e
    • Henry Weller's avatar
      surfaceInterpolationScheme: Added dotInterpolate member-function · 4dedba47
      Henry Weller authored
      dotInterpolate interpolates the field and "dots" the resulting
      face-values with the vector field provided which removes the need to
      create a temporary field for the interpolate.  This reduces the peak
      storage of OpenFOAM caused by the divergence of the gradient of vector
      fields, improves memory management and under some conditions decreases
      run-time.
      
      This development is based on a patch contributed by Paul Edwards, Intel.
      4dedba47
  10. 03 Apr, 2016 1 commit
    • Henry Weller's avatar
      UList: Rationalize assignment (shallow-copy vs deep-copy) · 6e573ad7
      Henry Weller authored
          //- Disallow default shallow-copy assignment
          //
          //  Assignment of UList<T> may need to be either shallow (copy pointer)
          //  or deep (copy elements) depending on context or the particular type
          //  of list derived from UList and it is confusing and prone to error
          //  for the default assignment to be either.  The solution is to
          //  disallow default assignment and provide separate 'shallowCopy' and
          //  'deepCopy' member functions.
          void operator=(const UList<T>&) = delete;
      
          //- Copy the pointer held by the given UList.
          inline void shallowCopy(const UList<T>&);
      
          //- Copy elements of the given UList.
          void deepCopy(const UList<T>&);
      6e573ad7
  11. 22 Mar, 2016 3 commits
  12. 20 Mar, 2016 1 commit
  13. 14 Mar, 2016 1 commit
  14. 10 Mar, 2016 1 commit
  15. 07 Mar, 2016 1 commit
    • Henry Weller's avatar
      SRFWallVelocityFvPatchVectorField: New BC for walls rotating in the SRF · ea159347
      Henry Weller authored
          Wall-velocity condition to be used in conjunction with the single rotating
          frame (SRF) model (see: FOAM::SRFModel)
      
          The condition applies the appropriate rotation transformation in time and
          space to determine the local SRF velocity of the wall.
      
              \f[
                  U_p = - U_{p,srf}
              \f]
      
          where
          \vartable
              U_p     = patch velocity [m/s]
              U_{p,srf} = SRF velocity
          \endvartable
      
          The normal component of \f$ U_p \f$ is removed to ensure 0 wall-flux even
          if the wall patch faces are irregular.
      
          \heading Patch usage
      
          Example of the boundary condition specification:
          \verbatim
          myPatch
          {
              type            SRFWallVelocity;
              value           uniform (0 0 0);    // Initial value
          }
          \endverbatim
      ea159347
  16. 29 Feb, 2016 3 commits
  17. 28 Feb, 2016 1 commit
  18. 26 Feb, 2016 2 commits
  19. 25 Feb, 2016 2 commits
  20. 24 Feb, 2016 2 commits