1. 21 Dec, 2020 1 commit
  2. 16 Dec, 2020 1 commit
    • Sergio Ferraris's avatar
      ENH: adding non-uniform rho to incompressible two-phase turbulent models · 3db12bbd
      Sergio Ferraris authored and Andrew Heather's avatar Andrew Heather committed
      1) PhaseIncompressibleTurbulenceModel class was changed to use
         uniform alpha and non-uniform rho templates. This fits the need
         of incompressible two phase turbulence models.
      
      2) A new type DPMIncompressibleTurbulenceModel was created for
         non-uniform alpha and uniform rho. It is  used in single phase flows
         in DPM solvers where alpha represents the volumen occupancy.
      
      3) A new type incompressibleRhoTurbulenceModel  was created where
         non-uniform rho is allowed.
      
      4) A new base templated turbulent class for two-phase VOF named
         VoFphaseTurbulentTransportModel was implemented which is created
         templating on PhaseIncompressibleTurbulenceModel and
         incompressibleRhoTurbulenceModel
      
      5) In order to make the chnage to rho based VOF turbulence a help
         class was added incompressibleInterPhaseTransportModel templated
         on the mixing.
      3db12bbd
  3. 10 Dec, 2020 1 commit
  4. 28 Nov, 2020 1 commit
  5. 19 Nov, 2020 1 commit
    • Mark Olesen's avatar
      STYLE: can add compile-time deprecated message for autoPtr::set() · 6e3bc1f7
      Mark Olesen authored
      - deprecated Feb-2018, but not marked as such.
      
        The set() method originally enforce an additional run-time check
        (Fatal if pointer was already set), but this was rarely used.
        In fact, the set() method was invariably used in constructors
        where the pointer by definition was unset.
      
        Can now mark as deprecated to catch the last of these.
        We prefer reset() for similarity with std::unique_ptr
      
        Eg,
        FOAM_EXTRA_CXXFLAGS="-DFoam_autoPtr_deprecate_setMethod"  wmake
      6e3bc1f7
  6. 05 Aug, 2020 5 commits
    • Mark Olesen's avatar
      a192095c
    • Mark Olesen's avatar
      ENH: combine some phaseSystem selectors into regular .C files · 99e20b3b
      Mark Olesen authored
      - reduces the number of files, eases code refactoring
      99e20b3b
    • Mark Olesen's avatar
    • Mark Olesen's avatar
      ENH: avoid phaseSystem cyclic dependencies, reduce number of libraries · 915c0785
      Mark Olesen authored
      Reduce the number of phaseSystems libraries:
      
      - phaseSystems previously had a number of smaller libraries to provide
        interface and model properties, etc. This potential flexibility was
        never actually used anywhere, but causes cyclic dependencies between
        phaseSystem and the models (and turbulence) that causes extreme
        difficulty for mingw linking (issue #1238).
      
      - libincompressibleMultiphaseSystems
        - removed: libmassTransferModels
      
      - libmultiphaseSystem
        - removed: libcompressibleMultiphaseEulerianInterfacialModels
      
      - libreactingMultiphaseSystem
        - removed: libreactingPhaseSystem
        - removed: libreactingEulerianFvPatchFields
        - removed: libreactingEulerianInterfacialCompositionModels
        - removed: libreactingEulerianInterfacialModels
        - removed: libmultiphaseReactingTurbulenceModels
      
      - libreactingTwoPhaseSystem
        - removed: libreactingPhaseSystem
        - removed: libreactingEulerianFvPatchFields
        - removed: libreactingEulerianInterfacialCompositionModels
        - removed: libreactingEulerianInterfacialModels
      
      Avoid duplicate symbol for phaseCompressibleTurbulenceModels
      
        Common turbulence models are defined in libreactingMultiphaseSystem,
        and libmultiphaseReactingTurbulenceModels is now redundant.
      
        The libtwoPhaseReactingTurbulenceModels extends the common models
        for reactingTwoPhaseSystem.
      915c0785
    • Mark Olesen's avatar
      ENH: centralize more libraries in src/phaseSystemModels · 03526e20
      Mark Olesen authored
      - prelude to code refactoring
      
      NOTE
          no source code change in this commit, only relocation,
          renaming and adjustment of Make/{files,options}
      03526e20
  7. 03 Aug, 2020 1 commit
  8. 28 Jul, 2020 1 commit
  9. 16 Jul, 2020 2 commits
    • Mark Olesen's avatar
      STYLE: check autoPtr as plain bool instead of valid() · 12c91b94
      Mark Olesen authored
      - cleaner code, more similarity with unique_ptr
      
        Now
            if (ptr)
            if (!ptr)
      
        instead
            if (ptr.valid())
            if (!ptr.valid())
      12c91b94
    • Mark Olesen's avatar
      STYLE: simplify short-circuit involving autoPtr (#1775) · 9af3f85c
      Mark Olesen authored
      - with '&&' conditions, often better to check for non-null autoPtr
        first (it is cheap)
      
      - check as bool instead of valid() method for cleaner code, especially
        when the wrapped item itself has a valid/empty or good.
        Also when handling multiple checks.
      
        Now
            if (ptr && ptr->valid())
            if (ptr1 || ptr2)
      
        instead
            if (ptr.valid() && ptr->valid())
            if (ptr1.valid() || ptr2.valid())
      9af3f85c
  10. 24 Jun, 2020 1 commit
  11. 17 Jun, 2020 1 commit
  12. 11 Jun, 2020 1 commit
    • Kutalmis Bercin's avatar
      INT: various integrations from openfoam.org · 5cbdb7a3
      Kutalmis Bercin authored and Andrew Heather's avatar Andrew Heather committed
        ENH: add log FO
        ENH: improve log with scale, and offset entries
        BUG: ensure extrueMesh does not fail in parallel with wedge extrusion
        BUG: add missing clone and mapping funcs to copiedFixedValue, fixedMultiPhaseHeatFlux
        ENH: meshToMesh0::cellAddressing slight speed up for some geometries
        BUG:0003495: Divide-by-zero in SHF particle break-up model
        BUG:0003492: The formula in the OF is inconsistent with the Rosin-Rammler distribution theory formula
      5cbdb7a3
  13. 03 Jun, 2020 2 commits
    • sergio's avatar
      COM: Separate htc FO from general FO and reactingEuler solvers (#1714) · 95f7ed03
      sergio authored and Mark Olesen's avatar Mark Olesen committed
      The phase systems tables for multiphase solvers create conflict
      between each other as they are defined in the same namespace and using
      similar class names.
      
      Therefore a special htc function object for reactingEulerSolver was
      added (reactingEulerHtcModel), located under
      src/phaseSystemModels/reactingEulerFoam/functionObjects/
      
      This commit includes the following:
      
      - Relocate solvers/reactingEulerFoam functionObjects to
        src/phaseSystemModels
      - Remove links for fieldFunctionObject to multiphase libs to avoid
        conflicts
      - New FO for htc for reactingEulerFoam called reactingEulerHtcModel
      95f7ed03
    • Mark Olesen's avatar
      STYLE: adjust return branching · 84d7141e
      Mark Olesen authored
      84d7141e
  14. 02 Jun, 2020 1 commit
    • Mark Olesen's avatar
      ENH: unify use of dictionary method names · 3e43edf0
      Mark Olesen authored
      - previously introduced `getOrDefault` as a dictionary _get_ method,
        now complete the transition and use it everywhere instead of
        `lookupOrDefault`. This avoids mixed usage of the two methods that
        are identical in behaviour, makes for shorter names, and promotes
        the distinction between "lookup" access (ie, return a token stream,
        locate and return an entry) and "get" access (ie, the above with
        conversion to concrete types such as scalar, label etc).
      3e43edf0
  15. 22 May, 2020 2 commits
    • OpenFOAM bot's avatar
      STYLE: remove trailing space, tabs · 59933555
      OpenFOAM bot authored and Mark Olesen's avatar Mark Olesen committed
      COMP: deletion of incomplete type
      59933555
    • sergio's avatar
      COMP: Avoiding double entry in runTime table TurbulenceModel · 11965904
      sergio authored
      multiphaseReactingTurbulenceModels and twoPhaseReactingTurbulenceModels
      add models to the same table TurbulenceModel. These two libs were removed
      from libreactingPhaseSystem which created the conflict.
      
      The multiphaseReactingTurbulenceModels was added to
      reactingMultiPhaseEulerFoam solver and twoPhaseReactingTurbulenceModels to
      twoPhaseReactingEulerFoam solver
      
      The FO heatTransferCoeffs for libfieldFunctionObjects needs
      twoPhaseReactingTurbulenceModels.
      
      These change avoids linking conflict from multiphaseReactingTurbulenceModels
      and twoPhaseReactingTurbulenceModels being linked in the same lib.
      11965904
  16. 21 May, 2020 1 commit
  17. 13 May, 2020 1 commit
  18. 04 May, 2020 1 commit
  19. 01 May, 2020 1 commit
  20. 28 Apr, 2020 1 commit
  21. 21 Apr, 2020 1 commit
  22. 12 Mar, 2020 1 commit
  23. 11 Mar, 2020 1 commit
  24. 28 Feb, 2020 1 commit
  25. 23 Dec, 2019 1 commit
  26. 20 Dec, 2019 1 commit
  27. 18 Dec, 2019 1 commit
  28. 17 Dec, 2019 1 commit
    • sergio's avatar
      INT: org integration · 6e8f0dbe
      sergio authored and Andrew Heather's avatar Andrew Heather committed
      1) rPolynomial Eq of State
      2) externalForce and softWall in rigidBodyDynamics
      
      INT: Several minor bug fixes plus
      6e8f0dbe
  29. 13 Nov, 2019 1 commit
  30. 31 Oct, 2019 1 commit
  31. 06 Nov, 2019 1 commit
  32. 28 Oct, 2019 1 commit
  33. 24 Sep, 2019 1 commit