1. 18 Jun, 2021 1 commit
  2. 04 May, 2020 1 commit
  3. 31 Oct, 2019 1 commit
  4. 06 Feb, 2019 1 commit
  5. 11 Dec, 2018 1 commit
  6. 13 Dec, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: consolidate handling of mandatory/optional command arguments · 5d9e278e
      Mark OLESEN authored
      - for some special cases we wish to mark command-line arguments as
        being optional, in order to do our own treatment. For example,
        when an arbitrary number of arguments should be allowed.
      
        Now tag this situation with argList::noMandatoryArgs().
        The argList::argsMandatory() query can then be used in any further
        logic, including the standard default argument checking.
      
      - with the new default check, can consolidate the special-purpose
      
            "setRootCaseNonMandatoryArgs.H"
      
        into the regular
      
            "setRootCase.H"
      
      - revert to a simple "setRootCase.H" and move all the listing related
        bits to a "setRootCaseLists.H" file. This leaves the information
        available for solvers, or whoever else wishes, without being
        introduced everywhere.
      
      - add include guards and scoping to the listing files and rename to
        something less generic.
      
           listOptions.H -> setRootCaseListOptions.H
           listOutput.H  -> setRootCaseListOutput.H
      5d9e278e
  7. 01 Jun, 2018 1 commit
    • Mark OLESEN's avatar
      STYLE: reduced usage of Switch · 84b10921
      Mark OLESEN authored
      - Since 'bool' and 'Switch' use the _identical_ input mechanism
        (ie, both accept true/false, on/off, yes/no, none, 1/0), the main
        reason to prefer one or the other is the output.
      
        The output for Switch is as text (eg, "true"), whereas for bool
        it is label (0 or 1). If the output is required for a dictionary,
        Switch may be appropriate. If the output is not required, or is only
        used for Pstream exchange, bool can be more appropriate.
      84b10921
  8. 27 Apr, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: make format of ExecutionTime = ... output configurable (issue #788) · dd8341f6
      Mark OLESEN authored
      - controlled by the the 'printExecutionFormat' InfoSwitch in
        etc/controlDict
      
            // Style for "ExecutionTime = " output
            // - 0 = seconds (with trailing 's')
            // - 1 = day-hh:mm:ss
      
         ExecutionTime = 112135.2 s  ClockTime = 113017 s
      
         ExecutionTime = 1-07:08:55.20  ClockTime = 1-07:23:37
      
      - Callable via the new Time::printExecutionTime() method,
        which also helps to reduce clutter in the applications.
        Eg,
      
           runTime.printExecutionTime(Info);
      
        vs
      
           Info<< "ExecutionTime = " << runTime.elapsedCpuTime() << " s"
               << "  ClockTime = " << runTime.elapsedClockTime() << " s"
               << nl << endl;
      
      --
      
      ENH: return elapsedClockTime() and clockTimeIncrement as double
      
      - previously returned as time_t, which is less portable.
      dd8341f6
  9. 02 Jul, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: improve controls for Time (issue #910) · 2662042d
      Mark OLESEN authored
      - relocate some standard functionality to TimePaths to allow a lighter
        means of managing time directories without using the entire Time
        mechanism.
      
      - optional enableLibs for Time construction (default is on)
        and a corresponding argList::noLibs() and "-no-libs" option
      
      STYLE:
      
      - mark Time::outputTime() as deprecated MAY-2016
      
      - use pre-increment for runTime, although there is no difference in
        behaviour or performance.
      2662042d
  10. 11 Jan, 2018 1 commit
  11. 23 Oct, 2017 1 commit
  12. 09 May, 2016 1 commit
  13. 01 May, 2016 1 commit
  14. 03 Dec, 2015 1 commit
  15. 02 Dec, 2015 1 commit
    • Henry Weller's avatar
      fvOptions: Reorganized and updated to simplify use in sub-models and maintenance · 736621b9
      Henry Weller authored
      fvOptions are transferred to the database on construction using
      fv::options::New which returns a reference.  The same function can be
      use for construction and lookup so that fvOptions are now entirely
      demand-driven.
      
      The abstract base-classes for fvOptions now reside in the finiteVolume
      library simplifying compilation and linkage.  The concrete
      implementations of fvOptions are still in the single monolithic
      fvOptions library but in the future this will be separated into smaller
      libraries based on application area which may be linked at run-time in
      the same manner as functionObjects.
      736621b9
  16. 01 Dec, 2015 1 commit
  17. 19 Jul, 2015 1 commit
  18. 29 May, 2015 1 commit
    • Henry's avatar
      MRF: Separate MRF from fvOptions · c3ee2348
      Henry authored
      fvOptions does not have the appropriate structure to support MRF as it
      is based on option selection by user-specified fields whereas MRF MUST
      be applied to all velocity fields in the particular solver.  A
      consequence of the particular design choices in fvOptions made it
      difficult to support MRF for multiphase and it is easier to support
      frame-related and field related options separately.
      
      Currently the MRF functionality provided supports only rotations but
      the structure will be generalized to support other frame motions
      including linear acceleration, SRF rotation and 6DoF which will be
      run-time selectable.
      c3ee2348
  19. 09 Feb, 2015 1 commit
  20. 21 Jan, 2015 1 commit
    • Henry's avatar
      Updated the whole of OpenFOAM to use the new templated TurbulenceModels library · 2aec2496
      Henry authored
      The old separate incompressible and compressible libraries have been removed.
      
      Most of the commonly used RANS and LES models have been upgraded to the
      new framework but there are a few missing which will be added over the
      next few days, in particular the realizable k-epsilon model.  Some of
      the less common incompressible RANS models have been introduced into the
      new library instantiated for incompressible flow only.  If they prove to
      be generally useful they can be templated for compressible and
      multiphase application.
      
      The Spalart-Allmaras DDES and IDDES models have been thoroughly
      debugged, removing serious errors concerning the use of S rather than
      Omega.
      
      The compressible instances of the models have been augmented by a simple
      backward-compatible eddyDiffusivity model for thermal transport based on
      alphat and alphaEff.  This will be replaced with a separate run-time
      selectable thermal transport model framework in a few weeks.
      
      For simplicity and ease of maintenance and further development the
      turbulent transport and wall modeling is based on nut/nuEff rather than
      mut/muEff for compressible models so that all forms of turbulence models
      can use the same wall-functions and other BCs.
      
      All turbulence model selection made in the constant/turbulenceProperties
      dictionary with RAS and LES as sub-dictionaries rather than in separate
      files which added huge complexity for multiphase.
      
      All tutorials have been updated so study the changes and update your own
      cases by comparison with similar cases provided.
      
      Sorry for the inconvenience in the break in backward-compatibility but
      this update to the turbulence modeling is an essential step in the
      future of OpenFOAM to allow more models to be added and maintained for a
      wider range of cases and physics.  Over the next weeks and months more
      turbulence models will be added of single and multiphase flow, more
      additional sub-models and further development and testing of existing
      models.  I hope this brings benefits to all OpenFOAM users.
      
      Henry G. Weller
      2aec2496
  21. 23 Sep, 2012 1 commit
  22. 30 May, 2012 2 commits
    • Henry's avatar
      Thermodynamics: Rationalization · dead8ec0
      Henry authored
      At the specie level:
          hs = sensible enthalpy
          ha = absolute (what was total) enthalpy
          es = sensibly internal energy
          ea = absolute (what was total) internal energy
      
      At top-level
          Rename total enthalpy h -> ha
          Rename sensible enthalpy hs -> h
      
      Combined h, hs, e and es thermo packages into a single structure.
      
      Thermo packages now provide "he" function which may return either enthalpy or
      internal energy, sensible or absolute according to the run-time selected form
      
      alphaEff now returns the effective diffusivity for the particular energy which
      the thermodynamics package is selected to solve for.
      dead8ec0
    • Henry's avatar
      Thermodynamics: Rationalization · 63da3e9a
      Henry authored
      At the specie level:
          hs = sensible enthalpy
          ha = absolute (what was total) enthalpy
          es = sensibly internal energy
          ea = absolute (what was total) internal energy
      
      At top-level
          Rename total enthalpy h -> ha
          Rename sensible enthalpy hs -> h
      
      Combined h, hs, e and es thermo packages into a single structure.
      
      Thermo packages now provide "he" function which may return either enthalpy or
      internal energy, sensible or absolute according to the run-time selected form
      
      alphaEff now returns the effective diffusivity for the particular energy which
      the thermodynamics package is selected to solve for.
      63da3e9a
  23. 26 Oct, 2011 1 commit
  24. 14 Aug, 2011 1 commit
  25. 18 Apr, 2011 2 commits
  26. 04 Mar, 2011 1 commit
  27. 19 Jan, 2011 1 commit
  28. 14 Jan, 2011 1 commit
  29. 07 Jan, 2011 1 commit
  30. 05 Jan, 2011 2 commits
  31. 27 Jul, 2010 1 commit
  32. 29 Mar, 2010 1 commit
  33. 22 Jul, 2009 1 commit
  34. 08 Jul, 2009 1 commit
  35. 01 Jul, 2009 1 commit
  36. 15 Jun, 2009 1 commit
  37. 18 Feb, 2009 1 commit
    • Mark Olesen's avatar
      use while (runTime.loop() { .. } where possible in solvers · 4b60453c
      Mark Olesen authored
      - change system/controlDict to use functions {..} instead of functions (..);
        * This is internally more efficient
      - fixed formatting of system/controlDict functions entry
      
      - pedantic change: use 'return 0' instead of 'return(0)' in the applications,
        since return is a C/C++ keyword, not a function.
      4b60453c