1. 30 Oct, 2018 1 commit
  2. 29 Oct, 2018 1 commit
  3. 19 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      STYLE: use range-for when looping dictionary entries. · 07dafe7b
      Mark OLESEN authored
      - as part of the cleanup of dictionary access methods (c6520033)
        made the dictionary class single inheritance from IDLList<entry>.
      
        This eliminates any ambiguities for iterators and allows
        for simple use of range-for looping.
      
        Eg,
            for (const entry& e : topDict))
            {
                Info<< "entry:" << e.keyword() << " is dict:" << e.isDict() << nl;
            }
      
         vs
      
            forAllConstIter(dictionary, topDict, iter))
            {
                Info<< "entry:" << iter().keyword()
                    << " is dict:" << iter().isDict() << nl;
            }
      07dafe7b
  4. 18 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: cleanup of Enum class · 3b745122
      Mark OLESEN authored
      - more dictionary-like methods, enforce keyType::LITERAL for all
        lookups to avoid any spurious keyword matching.
      
      - new readEntry, readIfPresent methods
      
      - The get() method replaces the now deprecate lookup() method.
      
      - Deprecate lookupOrFailsafe()
        Failsafe behaviour is now an optional parameter for lookupOrDefault,
        which makes it easier to tailor behaviour at runtime.
      
      - output of the names is now always flatted without line-breaks.
        Thus,
      
           os << flatOutput(someEnumNames.names()) << nl;
           os << someEnumNames << nl;
      
        both generate the same output.
      
      - Constructor now uses C-string (const char*) directly instead of
        Foam::word in its initializer_list.
      
      - Remove special enum + initializer_list constructor form since
        it can create unbounded lookup indices.
      
      - Removd old hasEnum, hasName forms that were provided during initial
        transition from NamedEnum.
      
      - Added static_assert on Enum contents to restrict to enum or
        integral values.  Should not likely be using this class to enumerate
        other things since it internally uses an 'int' for its values.
      
        Changed volumeType accordingly to enumerate on its type (enum),
        not the class itself.
      3b745122
  5. 17 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: simplify objectRegistry access names (issue #322) · 8fabc325
      Mark OLESEN authored
        New name:  findObject(), cfindObject()
        Old name:  lookupObjectPtr()
      
            Return a const pointer or nullptr on failure.
      
        New name:  findObject()
        Old name:  --
      
            Return a non-const pointer or nullptr on failure.
      
        New name:  getObjectPtr()
        Old name:  lookupObjectRefPtr()
      
            Return a non-const pointer or nullptr on failure.
            Can be called on a const object and it will perform a
            const_cast.
      
      - use these updated names and functionality in more places
      
      NB: The older methods names are deprecated, but continue to be defined.
      8fabc325
  6. 15 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: rationalize dictionary access methods · c6520033
      Mark OLESEN authored
      - use keyType::option enum to consolidate searching options.
        These enumeration names should be more intuitive to use
        and improve code readability.
      
          Eg,   lookupEntry(key, keyType::REGEX);
          vs    lookupEntry(key, false, true);
      
        or
      
          Eg,   lookupEntry(key, keyType::LITERAL_RECURSIVE);
          vs    lookupEntry(key, true, false);
      
      - new findEntry(), findDict(), findScoped() methods with consolidated
        search options for shorter naming and access names more closely
        aligned with other components. Behave simliarly to the
        methods lookupEntryPtr(), subDictPtr(), lookupScopedEntryPtr(),
        respectively. Default search parameters consistent with lookupEntry().
      
          Eg, const entry* e = dict.findEntry(key);
          vs  const entry* e = dict.lookupEntryPtr(key, false, true);
      
      - added '*' and '->' dereference operators to dictionary searchers.
      c6520033
  7. 12 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: avoid readScalar, readLabel etc from dictionary (#762, #1033) · 8eddcc07
      Mark OLESEN authored
      - use the dictionary 'get' methods instead of readScalar for
        additional checking
      
           Unchecked:  readScalar(dict.lookup("key"));
           Checked:    dict.get<scalar>("key");
      
      - In templated classes that also inherit from a dictionary, an additional
        'template' keyword will be required. Eg,
      
           this->coeffsDict().template get<scalar>("key");
      
        For this common use case, the predefined getXXX shortcuts may be
        useful. Eg,
      
           this->coeffsDict().getScalar("key");
      8eddcc07
  8. 10 Oct, 2018 1 commit
  9. 08 Oct, 2018 1 commit
  10. 01 Oct, 2018 1 commit
  11. 04 Oct, 2018 3 commits
  12. 01 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: improve, simplify, rationalize coordinate system handling (issue #863) · 6697bb47
      Mark OLESEN authored
      Previously the coordinate system functionality was split between
      coordinateSystem and coordinateRotation. The coordinateRotation stored
      the rotation tensor and handled all tensor transformations.
      
      The functionality has now been revised and consolidated into the
      coordinateSystem classes. The sole purpose of coordinateRotation
      is now just to provide a selectable mechanism of how to define the
      rotation tensor (eg, axis-angle, euler angles, local axes) for user
      input, but after providing the appropriate rotation tensor it has
      no further influence on the transformations.
      
      --
      
      The coordinateSystem class now contains an origin and a base rotation
      tensor directly and various transformation methods.
      
        - The origin represents the "shift" for a local coordinate system.
      
        - The base rotation tensor represents the "tilt" or orientation
          of the local coordinate system in general (eg, for mapping
          positions), but may require position-dependent tensors when
          transforming vectors and tensors.
      
      For some coordinate systems (currently the cylindrical coordinate system),
      the rotation tensor required for rotating a vector or tensor is
      position-dependent.
      
      The new coordinateSystem and its derivates (cartesian, cylindrical,
      indirect) now provide a uniform() method to define if the rotation
      tensor is position dependent/independent.
      
      The coordinateSystem transform and invTransform methods are now
      available in two-parameter forms for obtaining position-dependent
      rotation tensors. Eg,
      
            ... = cs.transform(globalPt, someVector);
      
      In some cases it can be useful to use query uniform() to avoid
      storage of redundant values.
      
            if (cs.uniform())
            {
                vector xx = cs.transform(someVector);
            }
            else
            {
                List<vector> xx = cs.transform(manyPoints, someVector);
            }
      
      Support transform/invTransform for common data types:
         (scalar, vector, sphericalTensor, symmTensor, tensor).
      
      ====================
        Breaking Changes
      ====================
      
      - These changes to coordinate systems and rotations may represent
        a breaking change for existing user coding.
      
      - Relocating the rotation tensor into coordinateSystem itself means
        that the coordinate system 'R()' method now returns the rotation
        directly instead of the coordinateRotation. The method name 'R()'
        was chosen for consistency with other low-level entities (eg,
        quaternion).
      
        The following changes will be needed in coding:
      
            Old:  tensor rot = cs.R().R();
            New:  tensor rot = cs.R();
      
            Old:  cs.R().transform(...);
            New:  cs.transform(...);
      
        Accessing the runTime selectable coordinateRotation
        has moved to the rotation() method:
      
            Old:  Info<< "Rotation input: " << cs.R() << nl;
            New:  Info<< "Rotation input: " << cs.rotation() << nl;
      
      - Naming consistency changes may also cause code to break.
      
            Old:  transformVector()
            New:  transformPrincipal()
      
        The old method name transformTensor() now simply becomes transform().
      
      ====================
        New methods
      ====================
      
      For operations requiring caching of the coordinate rotations, the
      'R()' method can be used with multiple input points:
      
             tensorField rots(cs.R(somePoints));
      
         and later
      
             Foam::transformList(rots, someVectors);
      
      The rotation() method can also be used to change the rotation tensor
      via a new coordinateRotation definition (issue #879).
      
      The new methods transformPoint/invTransformPoint provide
      transformations with an origin offset using Cartesian for both local
      and global points. These can be used to determine the local position
      based on the origin/rotation without interpreting it as a r-theta-z
      value, for example.
      
      ================
        Input format
      ================
      
      - Streamline dictionary input requirements
      
        * The default type is cartesian.
        * The default rotation type is the commonly used axes rotation
          specification (with e1/e2/3), which is assumed if the 'rotation'
          sub-dictionary does not exist.
      
          Example,
      
          Compact specification:
      
              coordinateSystem
              {
                  origin  (0 0 0);
                  e2      (0 1 0);
                  e3      (0.5 0 0.866025);
              }
      
          Full specification (also accepts the longer 'coordinateRotation'
          sub-dictionary name):
      
              coordinateSystem
              {
                  type    cartesian;
                  origin  (0 0 0);
      
                  rotation
                  {
                      type    axes;
                      e2      (0 1 0);
                      e3      (0.5 0 0.866025);
                  }
              }
      
         This simplifies the input for many cases.
      
      - Additional rotation specification 'none' (an identity rotation):
      
            coordinateSystem
            {
                origin  (0 0 0);
                rotation { type none; }
            }
      
      - Additional rotation specification 'axisAngle', which is similar
        to the -rotate-angle option for transforming points (issue #660).
        For some cases this can be more intuitive.
      
        For example,
      
            rotation
            {
                type    axisAngle;
                axis    (0 1 0);
                angle   30;
            }
        vs.
            rotation
            {
                type    axes;
                e2      (0 1 0);
                e3      (0.5 0 0.866025);
            }
      
      - shorter names (or older longer names) for the coordinate rotation
        specification.
      
           euler         EulerRotation
           starcd        STARCDRotation
           axes          axesRotation
      
      ================
        Coding Style
      ================
      - use Foam::coordSystem namespace for categories of coordinate systems
        (cartesian, cylindrical, indirect). This reduces potential name
        clashes and makes a clearer declaration. Eg,
      
            coordSystem::cartesian csys_;
      
        The older names (eg, cartesianCS, etc) remain available via typedefs.
      
      - added coordinateRotations namespace for better organization and
        reduce potential name clashes.
      6697bb47
  13. 28 Sep, 2018 2 commits
    • Mark OLESEN's avatar
      ENH: add globalPath() to argList and TimePaths · 69f6f638
      Mark OLESEN authored
      - simply combines (rootPath()/globalCaseName())
      69f6f638
    • Will Bainbridge's avatar
      meshSearch: Prevent hang in calculation of line-boundary intersections · 911ea108
      Will Bainbridge authored
      This fix changes how the intersections loop ignores previously
      intersected faces. It now marks them by their index so that subsequent
      iterations ignore them.
      
      Before this change, after an intersection was found the start point was
      advanced by a small amount to move the past the intersection. The
      problem with this was if multiple boundary faces or the end point were
      in close proximity to the intersection then the move forward might span
      them. This could lead to intersections being missed or counted multiple
      times, in some cases indefinitely.
      
      Based on a patch contributed by Mattijs Janssens
      Resolves bug report https://bugs.openfoam.org/view.php?id=1147
      911ea108
  14. 27 Sep, 2018 1 commit
    • Mark OLESEN's avatar
      STYLE: add nBoundaryFaces() method to primitiveMesh · 64c3e484
      Mark OLESEN authored
      - nBoundaryFaces() is often used and is identical to
        (nFaces() - nInternalFaces()).
      
      - forward the mesh nInternalFaces() and nBoundaryFaces() to
        polyBoundaryMesh as nFaces() and start() respectively,
        for use when operating on a polyBoundaryMesh.
      
      STYLE:
      
      - use identity() function with starting offset when creating boundary maps.
      
           labelList map
           (
               identity(mesh.nBoundaryFaces(), mesh.nInternalFaces())
           );
      
        vs.
      
           labelList map(mesh.nBoundaryFaces());
           forAll(map, i)
           {
               map[i] = mesh.nInternalFaces() + i;
           }
      64c3e484
  15. 24 Sep, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: cylindricalCS is now in radians only (issue #863) · dcc1dc13
      Mark OLESEN authored
      - this provides internal consistency and allows direct use of the
        coordinate angle with sin(), cos() functions.
        It eliminates potential issues that could otherwise arise from
        alternative user input.
      
        Eg, in mixerFvMesh it would have previously been possible to specify
        the coordinate system to use degrees or radians, but these units were
        not checked when determining the tangential sweep positions.
      
      NOTE: this may represent a breaking change if user coding has been
      relying on cylindrical coordinate system in degrees.
      dcc1dc13
  16. 08 Aug, 2018 1 commit
  17. 03 Aug, 2018 3 commits
    • Mark OLESEN's avatar
      ENH: additional methods and improvements to plane · de2eed3e
      Mark OLESEN authored
      - signedDistance() method is like distance() but retains
        the positive/negative sign for the side of the plane.
      
      - the sign() method returns the sign as -1,0,+1 integer for
        classification purposes where it is important to distinguish between
        a zero value and a positive value (eg, for cutting). Optional
        tolerance can be supplied to round for zero.
      
      - refactor and inlined simple and frequently used methods.
      
      - add boundBox faceCentre() method, which can be useful for creating
        clipping planes from a bounding box.
        Relocated treeBoundBox faceNormals to boundBox since they apply
        equally there - the meaning of the faces (x-min, x-max, etc)
        is the same, even if the point addressing for the faces differs.
      de2eed3e
    • Mark OLESEN's avatar
      ENH: added ZoneMesh indices(), selection() with wordRes matcher · 84e2df49
      Mark OLESEN authored
      - rationalized code dealing with extraction of name or indices from
        coordinateSystems, polyBoundaryMesh, faBoundaryMesh, fvBoundaryMesh,
        ZoneMesh to use internal implementations that allow direct
        searching/matching without building an intermediate list of names.
      
      - simpler and more efficient handling of patch group matching.
      84e2df49
    • Mark OLESEN's avatar
      ENH: avoid blockMesh removal of files for special cases (issue #963) · 319e09e3
      Mark OLESEN authored
      - do not remove if the dictionary failed to load.
      - do not remove if -blockTopology was used.
      319e09e3
  18. 30 Jul, 2018 1 commit
  19. 26 Jul, 2018 3 commits
  20. 25 Jul, 2018 1 commit
  21. 05 Oct, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: use dictionary::readEntry for detection of input errors (#762, #1033) · 13778f76
      Mark OLESEN authored
      - instead of   dict.lookup(name) >> val;
        can use      dict.readEntry(name, val);
      
        for checking of input token sizes.
        This helps catch certain types of input errors:
      
        {
      
            key1 ;                // <- Missing value
            key2 1234             // <- Missing ';' terminator
            key3 val;
        }
      
      STYLE: readIfPresent() instead of 'if found ...' in a few more places.
      13778f76
  22. 11 Jul, 2018 1 commit
  23. 04 Jul, 2018 1 commit
  24. 26 Jun, 2018 1 commit
  25. 25 Jun, 2018 1 commit
  26. 19 Jun, 2018 1 commit
  27. 10 Aug, 2018 3 commits
  28. 21 Jun, 2018 1 commit
    • Mark OLESEN's avatar
      ENH: use double for VTK legacy output (issue #891) · 1f953b80
      Mark OLESEN authored
      - some paraview versions (eg, on windows) don't support float, only double.
      
        This mostly affected the vtkSurfaceWriter.
      
        The foamToVTK is also affected, but since it also supports the XML
        output formats (vtp, vtu) these can be used instead.
      1f953b80
  29. 19 Jun, 2018 1 commit
  30. 15 Jun, 2018 1 commit
  31. 08 Jun, 2018 1 commit