openfoam issueshttps://develop.openfoam.com/Development/openfoam/-/issues2023-12-07T19:03:31Zhttps://develop.openfoam.com/Development/openfoam/-/issues/793adjust paraview library paths2023-12-07T19:03:31ZMark OLESENadjust paraview library pathsVersion 5.5.0 was just released. Looks like the `lib/` dir itself should now be part of the `LD_LIBRARY_PATH`.
In 5.4.x and earlier:
lib/cmake/
lib/paraview-5.4/libvtkPVCommon-pv5.4.so.1
In 5.5.0:
lib/cmake/
lib/parav...Version 5.5.0 was just released. Looks like the `lib/` dir itself should now be part of the `LD_LIBRARY_PATH`.
In 5.4.x and earlier:
lib/cmake/
lib/paraview-5.4/libvtkPVCommon-pv5.4.so.1
In 5.5.0:
lib/cmake/
lib/paraview
lib/libvtkPVCommon-pv5.5.so.1
The `lib/paraview-5.5` only contains a `plugins` directory.
In both cases used the same `./makeParaView` script from ThirdParty:
./makeParaView -suffix mpipy -mpi -python -qt-5.9.3 5.4.1
./makeParaView -suffix mpipy -mpi -python -qt-5.9.3 5.5.0
Will need to check (hint @acbauer) if this change is intentional or if something went wrong with our configuration, or if there is an additional cmake parameter that we are missing.
The flattening does make some sense, since all the library names are versioned with`*-pv5.5.so.1` etc, but can't really see how plain `paraview`, `paraview-config` in the lib/ directory are going to work.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/792provide additional text expansion shortcuts2023-12-07T19:03:31ZMark OLESENprovide additional text expansion shortcutsIn many places we use the string expansion to provide filenames.
Eg,
"${FOAM_CASE}/comms"
"$FOAM_CASE/constant/reactions"
...
And then using the `fileName::expand()` method or `stringOps::expand()` to resolve them.
Propose ...In many places we use the string expansion to provide filenames.
Eg,
"${FOAM_CASE}/comms"
"$FOAM_CASE/constant/reactions"
...
And then using the `fileName::expand()` method or `stringOps::expand()` to resolve them.
Propose to provide some tag short cuts for less clutter.
Eg,
"<case>/comms"
"<constant>/reactions"
...
The total number of tags is fairly limited in scope:
<etc>/ => user/group/other OpenFOAM directory
<case>/ => FOAM_CASE directory
<constant>/ => FOAM_CASE/constant directory
<system>/ => FOAM_CASE/system directory
We may consider alternative tag delimiters such as `[case]/`,
but it should be easy to read/type and we should avoid `{}` delimiters
since a simple typo has different meaning and would be a hard to trace
input error (eg, `${case}` vs `{case}`).v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/778snappy has issues with degenerate mesh distributions2023-12-07T19:03:27ZMark OLESENsnappy has issues with degenerate mesh distributionsTo reproduce:
- blockMesh
- manual decomposition with all cells on single processor
- snappy: fails during castellate
partial log:
Feature refinement iteration 0
------------------------------
[4] #0 Foam::error::printSta...To reproduce:
- blockMesh
- manual decomposition with all cells on single processor
- snappy: fails during castellate
partial log:
Feature refinement iteration 0
------------------------------
[4] #0 Foam::error::printStack(Foam::Ostream&)[5] #0 Foam::error::printStack(Foam::Ostream&)[1] #0 Foam::error::printStack(Foam::Ostream&)[2] #0 Foam::error::printStack(Foam::Ostream&)[3] #0 Foam::error::printStack(Foam::Ostream&) at ??:?
@Mattijs @Landmann @sma
[snappyMultiRegionHeater-debug.tar.bz2](/uploads/68eae17311da335e7f57d07b8099519e/snappyMultiRegionHeater-debug.tar.bz2)v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/907provide separate source tar files for modules2021-07-06T13:05:03ZMark OLESENprovide separate source tar files for modulesSimone @sbna is working with packaging our catalyst module with spack. It is very useful to have the the catalyst adaptor reside outside of the main OpenFOAM source tree and thus be able to combine one particular installation of OpenFOAM...Simone @sbna is working with packaging our catalyst module with spack. It is very useful to have the the catalyst adaptor reside outside of the main OpenFOAM source tree and thus be able to combine one particular installation of OpenFOAM with various ParaView and Catalyst flavours (mpi, mesa, gpu rendering, etc).
For this to package smoothly in spack, EasyBuilder etc, there should be a downloadable tar file to be used when packaging.
I think that Modules-v1806.tar.gz with the identical contents of the `modules/` tree (avalanche, catalyst, cfmesh), would be quite useful. I think that is OK to bundle the three together and have the packager decide which sub-directory is relevant.
@Pawanv1806Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/issues/860foamLog extract min, max, avg2021-07-06T12:57:16ZMark OLESENfoamLog extract min, max, avg- can currently only extract min value (EP 690), and foamLog is not sophisticated enough to handle arbitrary parsing.
- adjust AMI reporting as `min = ... max = ...` instead of `min/max/average = ...` for easier parsing.
@Prashant- can currently only extract min value (EP 690), and foamLog is not sophisticated enough to handle arbitrary parsing.
- adjust AMI reporting as `min = ... max = ...` instead of `min/max/average = ...` for easier parsing.
@Prashantv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/669reduce verbosity for decomposition methods2021-07-06T11:41:56ZMark OLESENreduce verbosity for decomposition methodsAs reported by @Prashant, causes unnecessarily noisy output and can be confused with SHM imbalance.As reported by @Prashant, causes unnecessarily noisy output and can be confused with SHM imbalance.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/555refinements for lumped movement2021-07-06T11:10:14ZMark OLESENrefinements for lumped movement- could add the current simulation time to the forces/moments file, to allow for movement that is time-dependent only (ie, ignores forces). Allowing the boundary condition to provide a forced movement only.
- may need additional handlin...- could add the current simulation time to the forces/moments file, to allow for movement that is time-dependent only (ie, ignores forces). Allowing the boundary condition to provide a forced movement only.
- may need additional handling of clamping at (0,0,0) - fixed, interpolate etc.
Ref: telephone with @Roger on 2-Aug-2017v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/639cleanup autoPtr, tmp, xfer2020-10-20T16:23:38ZMark OLESENcleanup autoPtr, tmp, xfer- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/722getApplication does not work with #calc statements in the controlDict2020-05-23T11:04:36ZRoger AlmenargetApplication does not work with #calc statements in the controlDictWhen there are #calc statements in the controlDict (either directly or as an #include), the function getApplication fails because the output from foamDictionary includes all the output statements from #calc.
This is fixed by adding a ta...When there are #calc statements in the controlDict (either directly or as an #include), the function getApplication fails because the output from foamDictionary includes all the output statements from #calc.
This is fixed by adding a tail -1 as follows to the getApplication function:
*foamDictionary -entry application -value system/controlDict | tail -1*
Examples of issue shown below:
[controlDict](/uploads/a24ecfdd4fc33ecb3b708d568a567744/controlDict)[input.txt](/uploads/adacd8e356f3237544fac31a6ab01ee3/input.txt)v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/772simplify inplace ListOps2020-03-13T14:28:58ZMark OLESENsimplify inplace ListOpsWith all list types being movable, can now collapse out the code duplication of things like `inplaceReorder`.
Eg,
template<unsigned Width>
void Foam::inplaceReorder
(
const labelUList& oldToNew,
PackedList<Wi...With all list types being movable, can now collapse out the code duplication of things like `inplaceReorder`.
Eg,
template<unsigned Width>
void Foam::inplaceReorder
(
const labelUList& oldToNew,
PackedList<Width>& input,
const bool prune
)
{
input = reorder(oldToNew, input, prune);
}
since the rvalue returned from `reorder()` now hooks into the move assignment operatorv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/679redistributePar fails for faMesh2020-01-07T16:32:23ZMark OLESENredistributePar fails for faMeshv1806Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/issues/701Missing info in header file2020-01-03T11:31:50ZRoger AlmenarMissing info in header fileFile: velocityDampingConstraint.H.
selectionMode is missing from the header file information, and it is required by the solver, otherwise it will crash. User should set it, like in "selectionMode all;"File: velocityDampingConstraint.H.
selectionMode is missing from the header file information, and it is required by the solver, otherwise it will crash. User should set it, like in "selectionMode all;"v1806https://develop.openfoam.com/Development/openfoam/-/issues/859STYLE: correct syntax in header file of noise.C2019-12-09T22:18:11ZvilfayeauSTYLE: correct syntax in header file of noise.CHi,
Could you update the syntax in the noise.C header file? Headerfile of noise.C and noiseDict should be consistent.
https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/applications/utilities/postProcessing/noise/noise...Hi,
Could you update the syntax in the noise.C header file? Headerfile of noise.C and noiseDict should be consistent.
https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/applications/utilities/postProcessing/noise/noise.C
`// Input file
inputFile "postProcessing/faceSource1/surface/patch/patch.case";
`
should be
`// Input file
files ( "postProcessing/faceSource1/surface/patch/patch.case");
`
Best,
Sebastienv1806https://develop.openfoam.com/Development/openfoam/-/issues/867Medium Test - 12.06.20182019-12-09T22:18:11ZPrashant SonakarMedium Test - 12.06.2018All cases could be accessed at: /home/alex4/prashant/SUPPORT/ESI/MEDIUM_TEST/tutorials_1806
- [x] DNS/dnsFoam/boxTurb16 - solver crash
- [x] IO/fileHandler/machineA/fileHandler - re-verify if we need `cp -r` while copying constant, line ...All cases could be accessed at: /home/alex4/prashant/SUPPORT/ESI/MEDIUM_TEST/tutorials_1806
- [x] DNS/dnsFoam/boxTurb16 - solver crash
- [x] IO/fileHandler/machineA/fileHandler - re-verify if we need `cp -r` while copying constant, line 36; 90 of Allrun
- [x] combustion/PDRFoam/flamePropagationWithObstacles - solver crash
- [x] mesh/foamyHexMesh/mixerVessel - solver crash
- [x] compressible/rhoSimpleFoam/gasMixing/injectorPipe - solver crash
- [x] compressible/sonicFoam/RAS/nacaAirfoil - solver crash
- [x] incompressible/pimpleFoam/LES/vortexShed - surface noise failed 'expected word error'
- [x] multiphase/compressibleInterFoam/laminar/climbingRod - solver failure
- [x] multiphase/driftFluxFoam/RAS/dahl - solver failure
- [x] multiphase/reactingTwoPhaseEulerFoam/RAS/LBend - solver failure
- [x] multiphase/compressibleInterFoam/laminar/depthCharge2D - solver failure
- [x] multiphase/interFoam/RAS/DTCHullMoving - solver failure
- [ ] ~~multiphase/interFoam/RAS/DTCHullWave - decomposePar failure 'missing entry value'~~ REMOVED
- [x] multiphase/interFoam/RAS/motorBike - rename solver in controlDict_nextWrite
- [x] multiphase/interFoam/laminar/vofToLagrangian/lagrangian* - both cases replace combustionModel type noCombustion to none
@andy @Mattijs @Sergio @markv1806https://develop.openfoam.com/Development/openfoam/-/issues/742simpleCoalParcelFoam - incorrect dimensions for Qdot2019-12-09T22:18:10ZAdminsimpleCoalParcelFoam - incorrect dimensions for QdotAdding on behalf of M. Richter:
I get a dimension error while running the simpleCoalParcelFoam solver. I think all my dimensions in the 0-folder are correct so I had a look at the source code. I found the line dimEnergy/dimTime for Q...Adding on behalf of M. Richter:
I get a dimension error while running the simpleCoalParcelFoam solver. I think all my dimensions in the 0-folder are correct so I had a look at the source code. I found the line dimEnergy/dimTime for Qdot in the createFields.H file. The other lagrangian solvers use instead dimEnergy/dimVolume/dimTime . When I correct this line and compile the code the solver ist running. Is this an error in the source code or do I have a wrong setup?v1806AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/issues/710Tutorials - test mode not respected for a number of cases2019-12-09T22:18:10ZAdminTutorials - test mode not respected for a number of casesv1806AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/issues/711sixDoFRigidBodyState function object not built2019-12-09T22:18:10ZAdminsixDoFRigidBodyState function object not builtAs title - code also requires further integration updates re: `writeFile` class usage and would benefit from using enums for angle typesAs title - code also requires further integration updates re: `writeFile` class usage and would benefit from using enums for angle typesv1806https://develop.openfoam.com/Development/openfoam/-/issues/885improve consistency of 'normal' methods2019-06-28T09:51:34ZMark OLESENimprove consistency of 'normal' methodsIn various places `normal()` can be a unit normal or an area normal. In places where there can be ambiguity, propose to provide explicit `areaNormal()` or `unitNormal()` methods. In the next version (1812), phase out `normal()` in favour...In various places `normal()` can be a unit normal or an area normal. In places where there can be ambiguity, propose to provide explicit `areaNormal()` or `unitNormal()` methods. In the next version (1812), phase out `normal()` in favour of these and deprecate `normal()`. In following version (1906), mark normal as `= delete` or otherwise tag its usage to finalize changeover.
For the first step, I propose adding these new names, but not yet changing code to use them. This will get them into place for early adopters and also make it easier with bugfixes/backports between 1806 and the 1812-develop.
@Nilsson @johan\_roenbyv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/868fragile ensight surface reader2018-12-11T10:42:03ZMark OLESENfragile ensight surface readerexpects the following only:
model: 1 xxx.000.mesh
which means that any of the following (correct input) will break it:
model: xxx.000.mesh
model: data/000/geomexpects the following only:
model: 1 xxx.000.mesh
which means that any of the following (correct input) will break it:
model: xxx.000.mesh
model: data/000/geomv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/890Style: overset - files2018-11-20T22:24:52ZPrashant SonakarStyle: overset - filesSolvers with corresponding file names:
1) solvers/incompressible/pimpleFoam/overPimpleDyMFoam
- solvers/incompressible/pimpleFoam/overPimpleDyMFoam/overPimpleDyMFoam.C -> OK
2) solvers/incompressible/simpleFoam/overSimpleFoam
- solve...Solvers with corresponding file names:
1) solvers/incompressible/pimpleFoam/overPimpleDyMFoam
- solvers/incompressible/pimpleFoam/overPimpleDyMFoam/overPimpleDyMFoam.C -> OK
2) solvers/incompressible/simpleFoam/overSimpleFoam
- solvers/incompressible/simpleFoam/overSimpleFoam/overSimpleFoam.C -> OK
3) solvers/multiphase/interFoam/overInterDyMFoam
- solvers/multiphase/interFoam/overInterDyMFoam/interDyMFoam.C -> Please check
4) solvers/basic/potentialFoam/overPotentialFoam
- solvers/basic/potentialFoam/overPotentialFoam/potentialFoam.C -> Please check
5) solvers/basic/laplacianFoam/overLaplacianDyMFoam
- solvers/basic/laplacianFoam/overLaplacianDyMFoam/overLaplacianDyMFoam.C -> OK
6) solvers/compressible/rhoPimpleFoam/overRhoPimpleDyMFoam
- solvers/compressible/rhoPimpleFoam/overRhoPimpleDyMFoam/rhoPimpleDyMFoam.C -> Please check
7) solvers/compressible/rhoSimpleFoam/overRhoSimpleFoam
- solvers/compressible/rhoSimpleFoam/overRhoSimpleFoam/rhoSimpleFoam.C-> Please check
@andy @Sergio @Mattijs @markv1806Mark OLESENMark OLESEN