Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 420
    • Issues 420
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #1215
Closed
Open
Issue created Feb 22, 2019 by Admin@OpenFOAM-adminMaintainer

develop branch blockMesh creates bad 1D meshes (but not master)

Summary

It seems that the current develop branch generates a blockMesh which differs from the current master branch. For me, I found that this was causing 1D evaporation problems' pressure solves to fail.

Steps to reproduce

Check out master, compile, make a simple 1D mesh. Rename the polyMesh to polyMesh.bak, checkout develop, compile, now make the blockMesh again. Not only are the meshes different, the one on develop causes 1D apps to fail. I imagine it doesn't have issues with higher dimensional meshes, otherwise someone would have caught this. Also, I cannot pinpoint which commit did this. I tried cherry picking 22891065698f3793033862c7c3031b43241df595 thinking that seemed suspect, but it seems to not be it.

This is the kind of thing which unit tests could catch. From what I read online, your all's sentiment on that is that you don't have the time to write these, right? That's understandable in every way. If given the opportunity, I would absolutely write some unit tests and make a merge request.

Edited Feb 22, 2019 by Admin
Assignee
Assign to
Time tracking