parProfiling output cleanup

parProfiling output is not very clear.

• negative numbers
• gets output twice

parProfiling:
	reduce    : avg = 77.2517s
	            min = -97.6182% (processor 0)
	            max = +21.4343% (processor 4)
	all-all   : avg = 13.3667s
	            min = -18.3042% (processor 5)
	            max = +11.6958% (processor 4)
parProfiling:
	reduce    : avg = 77.2517s
	            min = -97.6182% (processor 0)
	            max = +21.4343% (processor 4)
	all-all   : avg = 13.3667s
	            min = -18.3042% (processor 5)
	            max = +11.6958% (processor 4)

The double output is a bit interesting. In normal cases, I would imagine it would be nice to have the summary only on exit, so this is included in parProfiling::end(). If we try to disable all other output

executeControl none;
writeControl   none;

This seems to effectively disable the function object entirely. The next idea would be just to have this:

executeControl none;
writeControl   writeTime;

Although the function object doesn't actually do anything on write(), it seems to invoke the execute() method when writing. Since we often write before exit, we get doubled output.

Problem is in functionObjects::timeControl::end() :

    if (active() && (executeControl_.execute() || writeControl_.execute()))
    {

mentioned in commit 6b69a245ee73e7b3ce5a9d665fc3d2a41d1199e2

mentioned in commit c7505cba38af40b0fed09e2766676c938e31ee99

As @Prashant noted, it seems that the 'write()' may also being hit by the 'end()' - had a similar discussion a few weeks back with @andy.

closed