Add OpenQBMM

As per discussions with @andy and @albertop - aim to add OpenQBMM in as a submodule for 1912.

Alberto has rejiged some bits to compile will 1906 (only some deprecation warnings for dimensionedType that can be safely ignored). I've recompiled his branch with the 1912 develop and nothing came up with gcc-7.4. May need to recheck with gcc-4.8.5, but probably not too bad.

As soon as we get a mostly finalized branch (even better, tagged) can add the submodule.

Q: The subdirectory name as under modules/OpenQBMM, modules/open-qbmm ...? We are flexible.

changed milestone to %v1912

added contribution enhancement feature integration: third party labels

mentioned in commit dc2f4519

Added github issue #137.

Was playing with an idea in commit dc2f4519 (code-review.mol branch) that we could target FOAM_LIBBIN etc in the module Make/files, but provide a wmake -user means to override.

We have a slight conflict in the requirements. If we want to package as a module, the libraries and applications should land in the main OpenFOAM directories, not the user directories. However, it someone wants to download or update OpenQBMM completely independently, they will likely wish to target their own directories.

As a quick solution (perhaps not the best one), I tried simply exporting to override the values and made it more convenient with a -user option. Seems to work, but not sure if there are any other side-effects that I haven't considered.

For @andy, to cross-link the off-line communication, the target github branch is openfoam.com.

Thanks

changed milestone to %v2006

mentioned in commit 447ca941

mentioned in merge request !330 (merged)

mentioned in commit 54f80980

mentioned in commit a48d258a

I spotted a relatively minor issue with some tutorials in OpenQBMM. We relied on the automatic reading of .orig files from .org, which hasn't been ported. I'll have to modify these tutorials so that no manual intervention is needed when the are run.

closed