BUG: incorrect dimensions for pressureTools

The attached case replicates the issue.

• dimensions are incorrect for second iteration.

cavity.tgz

@Sergio @andy @Mattijs

What is happening:

• volScalarField prTools (resultName_) gets created (indirectly) as copy of p
• since there is a p_0 we also get a prTools_0
• (and this one gets the pressure dimensions)
• then next time round it tries to shift the current prTools to the prTools_0 and we get the dimension conflicts.

Solutions:

• create the prTools stand-alone so not inherit old-time (but also not the bcs)
• clear the old-time prTools_0. This is currently not possible.
• create prTools before there is a p_0?
• reset the dimensions of prTools_0 to avoid the error.

(note: set the debug flag of volScalarField to 2 to debug this behaviour. It will print a stacktrace every time a _0 field gets created)

Also, is it OK to use zeroGradient BC as mentioned in OpenFOAM-plus@dacbf0a1 (comment 5391)

cross reference EP#581

mentioned in commit f7bb2dd2d90b6525fe0bbf0a1407e2900b24d36c

Resolved by f7bb2dd2

By Andrew Heather on 2017-12-30T21:27:46 (imported from GitLab project)

closed

By Andrew Heather on 2017-12-30T21:27:47 (imported from GitLab project)