openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2018-06-22T15:44:53Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/169Feature ico reacting multiphase inter foam dev2018-06-22T15:44:53ZSergio FerrarisFeature ico reacting multiphase inter foam devhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/209verify manual input for labelToCell. labelToFace, labelToPoint2018-07-20T06:00:55ZMark OLESENverify manual input for labelToCell. labelToFace, labelToPointMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/221WIP: Resolve "blockMesh -time accepts any value"2018-11-26T10:33:10ZMark OLESENWIP: Resolve "blockMesh -time accepts any value"Closes #1093Closes #1093https://develop.openfoam.com/Development/openfoam/-/merge_requests/227Enh/tutorials/channel395 dfsem2018-12-21T08:57:21ZKutalmış BerçinEnh/tutorials/channel395 dfsemhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/214WIP: wip 20181019 sampledsurfaces.up12019-02-06T23:25:53ZMark OLESENWIP: wip 20181019 sampledsurfaces.up1scratch space for discussion purposes only - NEVER merge thisscratch space for discussion purposes only - NEVER merge thisMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/233WIP: Refactoring dnsfoam2019-02-11T18:05:12ZKutalmış BerçinWIP: Refactoring dnsfoam### Summary
dnsFoam is refactored, and its external behaviour is verified through dnsFoam/boxTurb16 tutorial.
diff all the fields of {enstrophy,graphs,p,phi,U} from the original tutorial, and refactored dnsfoam yielded no change.
### ...### Summary
dnsFoam is refactored, and its external behaviour is verified through dnsFoam/boxTurb16 tutorial.
diff all the fields of {enstrophy,graphs,p,phi,U} from the original tutorial, and refactored dnsfoam yielded no change.
### Resolved bugs (If applicable)
N/A
### Details of new models (If applicable)
N/A
### Risks
N/Ahttps://develop.openfoam.com/Development/openfoam/-/merge_requests/237WIP: ENH: Function Object: Lamb Vector2019-02-13T09:09:03ZKutalmış BerçinWIP: ENH: Function Object: Lamb Vectorhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/238WIP: functionObject: Lamb Vector and its Divergence2019-02-14T12:10:31ZKutalmış BerçinWIP: functionObject: Lamb Vector and its Divergence### Summary
Potential VW Sub-Project: Lamb Vector and its Divergence functionObject.
Lamb vector is the cross-product of vorticity and velocity.
The motivation to do so stems from the close connection between the Lamb vector div...### Summary
Potential VW Sub-Project: Lamb Vector and its Divergence functionObject.
Lamb vector is the cross-product of vorticity and velocity.
The motivation to do so stems from the close connection between the Lamb vector divergence and the motions in a flow, especially those instantaneous motions in turbulent flows, having a distinctively high capacity to effect a time rate of change of momentum, and generate forces such as drag.
### Resolved bugs (If applicable)
N/A
### Details of new models (If applicable)
Verification, hence pictures, will be provided based on the plane channel flow cases reported the journal paper below:
The Lamb vector divergence in Navier–Stokes flows, J. Fluid Mech. (2008), vol. 610, pp. 261–284., doi:10.1017/S0022112008002760O
### Risks
Not that I know of.https://develop.openfoam.com/Development/openfoam/-/merge_requests/239WIP: Refactoring dnsfoam2019-02-18T15:00:31ZKutalmış BerçinWIP: Refactoring dnsfoamUEqn.H file is created.
Its content is moved from dnsFoam.C
STYLE: Newline is removed.
ENH: Delete globalProperties.H.
Its content is appropriately moved into UEqn.H
ENH: pEqn.H is created. Its content is moved from dnsFoam.C.
ENH:...UEqn.H file is created.
Its content is moved from dnsFoam.C
STYLE: Newline is removed.
ENH: Delete globalProperties.H.
Its content is appropriately moved into UEqn.H
ENH: pEqn.H is created. Its content is moved from dnsFoam.C.
ENH: UEqn.H and pEqn.H are added.
ENH: Contents of readTurbulenceProperties.H and readTransportProperties.H are added.
ENH: Delete readTurbulenceProperties.H. Content is moved into createFields.H
ENH: Delete readTransportProperties.H Content is moved into createFields.H
ENH: Note is added for highlighting the requirement for optional FFTW lib.
ENH: Update dnsFoam.C.
Content between createFields and the first while-loop is moved into createFields.H.
ENH: Code move into createFields.H
Content between createFields and the first while-loop in dnsFoam.C is moved into createFields.H.
STYLE: Remove redundant tabs
ENH: Remove redundant tabs in UEqn.H
ENH: Add newline to UEqn.H to avoid wmkdepend warning
ENH: Add last new line into createFields.H to avoid wmkdepend warning
ENH: Add last new line into pEqn.H to avoid wmkdepend warning
ENH: include preprocessor directives are correctedMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/248ENH: Add reconstructPar into Allrun (Issue #1244)2019-03-22T20:02:29ZKutalmış BerçinENH: Add reconstructPar into Allrun (Issue #1244)- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/247ENH: Function1 type support for rpm specification. Fixes #12452019-03-26T05:48:05ZPrashant SonakarENH: Function1 type support for rpm specification. Fixes #1245https://develop.openfoam.com/Development/openfoam/-/merge_requests/250WIP: ENH: Reforms QRMatrix class2019-03-28T10:15:45ZKutalmış BerçinWIP: ENH: Reforms QRMatrix class* If applied:
* Fixes issue #1240
* New Test-QRMatrix.C for 3 input scenarios
* Class output verified via NumPy, aka LAPACAK routines
* Improves header documentation
* Corrects Doxygen parsing problems, i.e. //-
* Alig...* If applied:
* Fixes issue #1240
* New Test-QRMatrix.C for 3 input scenarios
* Class output verified via NumPy, aka LAPACAK routines
* Improves header documentation
* Corrects Doxygen parsing problems, i.e. //-
* Aligns code style with the code style guide
* Applicable to Foam::complex template
* Verification: See [QRMatrix_Verifications.pdf](/uploads/1d645aa179f043a51aea6302aed254f4/QRMatrix_Verifications.pdf) for NumPy comparisons.
* Future work:
* Refactoring is possible if new Matrix class functions applied
* For few matrix elements, NumPy and OpenFOAM yielded few-decimal point differences
* //Info<< "M*x - b:" << nl << (M*x - source) << endl; affects the subsequent program states despite encapsulation. Memory leak might be the reason, will be checked
@markAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/241ENH: use cellPoint interpolation directly for surfaceFieldValue (#1212)2019-06-05T14:59:10ZMark OLESENENH: use cellPoint interpolation directly for surfaceFieldValue (#1212)- prior to sampledSurface supporting different interpolation schemes a
workaround means was used to simulate cellPoint -> face
interpolation, with averaging of vertex interpolation.
We instead now use cellPoint interpolation direc...- prior to sampledSurface supporting different interpolation schemes a
workaround means was used to simulate cellPoint -> face
interpolation, with averaging of vertex interpolation.
We instead now use cellPoint interpolation directly for the face
values when 'interpolation' is on.https://develop.openfoam.com/Development/openfoam/-/merge_requests/251WIP: Feature matrix cleanup2019-06-12T11:17:39ZKutalmış BerçinWIP: Feature matrix cleanupAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/276BUG: Add writeDivider to foamDictionary (#1444)2019-09-23T14:47:27ZKutalmış BerçinBUG: Add writeDivider to foamDictionary (#1444)Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/275TUT: add static surface pressure coefficient sampling and plotting (#1438)2019-10-02T17:35:40ZKutalmış BerçinTUT: add static surface pressure coefficient sampling and plotting (#1438)AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/261BUG: resolve issue #1313 | stabilise SVDinv2019-10-02T17:36:02ZKutalmış BerçinBUG: resolve issue #1313 | stabilise SVDinvAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/240WIP: Refactor dnsFoam2019-10-02T17:36:08ZKutalmış BerçinWIP: Refactor dnsFoam### Summary
- If applied: This commit will restructure dnsFoam in line with other
solvers, e.g. pisoFoam, without changing its external
behaviour.
- Why: Prior to this change, dnsFoam structu...### Summary
- If applied: This commit will restructure dnsFoam in line with other
solvers, e.g. pisoFoam, without changing its external
behaviour.
- Why: Prior to this change, dnsFoam structure reflected v.2.x and older
solver style.
- How: This change collects naked dnsFoam code parts under general file
structure, e.g. via UEqn.H.
### Resolved bugs (If applicable)
N/A
### Details of new models (If applicable)
N/A
### Risks
- Verification: No change in any output of dnsFoam tutorial case.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/182WIP: Integration of IH Cantabria wave modelling contributions2019-10-03T10:38:02ZAdminWIP: Integration of IH Cantabria wave modelling contributions## New code
New wave generation model:
- `streamFunction`: based on Fenton's Fourier approximation
New interFoam-based solver:
- `interPorousFoam`: alternative method to include porosity effects, to be used with new `fvOptions` (se...## New code
New wave generation model:
- `streamFunction`: based on Fenton's Fourier approximation
New interFoam-based solver:
- `interPorousFoam`: alternative method to include porosity effects, to be used with new `fvOptions` (see below)
New `fvOptions`:
- `multiphasePorositySource`: porosity for multiphase flows
- `mangrovesSource`: mangrove interaction, i.e. drag and turbulence contributions for k-epsilon based models
## Test cases:
- interPorousFoam/porousDamBreak
- interPorousFoam/mangroves
## References:
Solitary wave attenuation by vegetation patches.
Maza, M, Lara, J.L., & Losada, I.J. (2016)
Advances in Water Resources. Vol.98, pp. 159-172
https://doi.org/10.1016/j.advwatres.2016.10.021
Tsunami wave interaction with mangrove forests: A 3-D numerical approach.
Maza, M, Lara, J.L., & Losada, I.J. (2015)
Coastal Engineering. Vol.98, pp. 33-54
https://doi.org/10.1016/j.coastaleng.2015.01.002
## Code integration
- Initial code supplied in commits e0682d67 and 2124eb88; and integrated into OpenFOAM by OpenCFDv1712AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/262STYLE: consistent Main Program horizontal line across Test*.C2019-10-07T16:30:51ZKutalmış BerçinSTYLE: consistent Main Program horizontal line across Test*.CMark OLESENMark OLESEN