openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2019-11-12T20:35:20Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/281WIP: TUT: renovate Allrun in backwardFacingStep2D (#1438)2019-11-12T20:35:20ZKutalmış BerçinWIP: TUT: renovate Allrun in backwardFacingStep2D (#1438)- adds devReff(uu,vv,uv), U, Cp, Cf sampling and plotting (#1438)
- adds benchmark data to constant/benchmark
- reads plot data in gnuplot directly from bash arrays rather than text files- adds devReff(uu,vv,uv), U, Cp, Cf sampling and plotting (#1438)
- adds benchmark data to constant/benchmark
- reads plot data in gnuplot directly from bash arrays rather than text filesAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/282BUG: fix simpleFoam/T3A.nut refCast error | fixedValue to type nutWallFunctio...2019-10-10T11:50:34ZKutalmış BerçinBUG: fix simpleFoam/T3A.nut refCast error | fixedValue to type nutWallFunction (#1457)Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/283WIP: Issue 11142019-11-12T20:35:07ZKutalmış BerçinWIP: Issue 1114AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/284Issue 1454 post process2019-10-17T12:26:30ZAdminIssue 1454 post processUpdated `postProcess` for mesh changes to update the function objects instead of performing a full clear-outUpdated `postProcess` for mesh changes to update the function objects instead of performing a full clear-outv1912AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/285WIP: CourantNo FO2019-11-12T20:34:45ZKutalmış BerçinWIP: CourantNo FOAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/286WIP: ENH: renovate v2-f turbulence closure model2019-11-12T20:34:33ZKutalmış BerçinWIP: ENH: renovate v2-f turbulence closure model- Implementation-related:
- corrects strain rate and tke production term to enable consistent
compressible formulation
- corrects Ts and Ls function expressions according to the original paper
- corrects the transpo...- Implementation-related:
- corrects strain rate and tke production term to enable consistent
compressible formulation
- corrects Ts and Ls function expressions according to the original paper
- corrects the transport equation terms to enable consistent compressible
formulation
- adds protections against floating-point exceptions
- Usage-related:
- updates the header documentation
- allows the hard-coded constants to be tuned by users
- adds tags to easily track the implementations' expressions in the
original papersAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/287WIP: TUT: bump2d2019-11-03T10:10:42ZKutalmış BerçinWIP: TUT: bump2dMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/288BUG: ensure cleanCase cleans postProcessing* (#1475)2019-11-03T10:10:16ZKutalmış BerçinBUG: ensure cleanCase cleans postProcessing* (#1475)Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/289WIP: TUT: generalise and expand turbulentFlatPlate2019-11-12T20:34:21ZKutalmış BerçinWIP: TUT: generalise and expand turbulentFlatPlateMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/290Issue 11082019-11-12T20:34:06ZKutalmış BerçinIssue 1108AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/291ENH: interpolationTable improvements2019-11-08T15:45:19ZMark OLESENENH: interpolationTable improvements- reduce code duplication, support returning multiple interpolations
as a Field- reduce code duplication, support returning multiple interpolations
as a FieldAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/292bug-1108-turbulentDFSEMInlet2019-11-13T12:55:48ZKutalmış Berçinbug-1108-turbulentDFSEMInletAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/293Feature single precision solve type2019-11-19T11:10:08ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comFeature single precision solve typeAdds functionality to SPDP mode:
- all (field) summations done in double precision (end result still single precision)
- mesh face areas, face centres, cell volumes and cell centres calculated in double precision (but still stored in sin...Adds functionality to SPDP mode:
- all (field) summations done in double precision (end result still single precision)
- mesh face areas, face centres, cell volumes and cell centres calculated in double precision (but still stored in single precision)
- some mesh checks done in double precisionAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/294WIP: bug-1261-QRMatrix2019-12-12T07:36:25ZKutalmış BerçinWIP: bug-1261-QRMatrix@mark@markAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/295bug-1459-turbulentInflow2019-11-14T14:35:14ZKutalmış Berçinbug-1459-turbulentInflowpassed regression tests except inletCell sampling where I have changed the sampling method from face to midPoint to enable sampling from the cell centres thereat.passed regression tests except inletCell sampling where I have changed the sampling method from face to midPoint to enable sampling from the cell centres thereat.AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/296BUG: RASModelVariables::SpalartAllmaras cannot be combined with an...2019-11-19T11:09:23ZVaggelis PapoutsisBUG: RASModelVariables::SpalartAllmaras cannot be combined with an...BUG: RASModelVariables::SpalartAllmaras cannot be combined with an fvMotionSolver diffusivity which depends on wall distances (fixes #1501)BUG: RASModelVariables::SpalartAllmaras cannot be combined with an fvMotionSolver diffusivity which depends on wall distances (fixes #1501)v1912AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/297BUG: adjointSolverName not set correctly in adjointWallVelocityLowRe (fixes #...2019-11-19T11:08:58ZVaggelis PapoutsisBUG: adjointSolverName not set correctly in adjointWallVelocityLowRe (fixes #1502)v1912AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/298Feature zipfields2019-11-18T09:35:31ZMark OLESENFeature zipfieldsAdds _"zip" fields_ function for combining component fields together and _"unzip" fields_ function for splitting a field into its component parts.Adds _"zip" fields_ function for combining component fields together and _"unzip" fields_ function for splitting a field into its component parts.v1912AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/299TUT: generalise planarPoiseuille for all laminar models (#1509)2019-12-12T07:36:18ZKutalmış BerçinTUT: generalise planarPoiseuille for all laminar models (#1509)@andy@andyMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/300Feature expressions2019-12-10T12:10:28ZMark OLESENFeature expressions### Summary
This branch represents an implementation of what is considered to be the most useful aspects of swak4Foam ([Swiss-Army-Knife for FOAM](https://openfoamwiki.net/index.php/Contrib/swak4Foam)) from Bernhard Gschaider, namely ...### Summary
This branch represents an implementation of what is considered to be the most useful aspects of swak4Foam ([Swiss-Army-Knife for FOAM](https://openfoamwiki.net/index.php/Contrib/swak4Foam)) from Bernhard Gschaider, namely the ability to use text-based expressions instead of coding in C++ for the following cases:
- expression-based boundary conditions (also known as _groovy_ boundary conditions)
- expression-based setFields (also known as _funky_ set fields)
The idea of what we currently term *expressions* was pioneered by
(Bernhard Gschaider) and is now firmly established in `swak4Foam`.
Among other things, expressions attempt to bridge the gap between
using standard, predefined boundary conditions and writing dedicated,
special-purpose ones. Although part of this gap is now covered within
OpenFOAM by using dynamically compiled user coding (eg, coded boundary
conditions), there remains substantial areas where it can be
significantly more convenient to have a series of predefined functions
and expression sytax with some access to base OpenFOAM field
functionality that enables rapid deployment of boundary conditions, or
custom-defined `setFields` without writing code.
A significant portion of `swak4Foam` expressions has been adapted for
direct integration into OpenFOAM. During the integration and rewrite,
we have tried to pare things down to a smaller subset with the aim of
covering 90% or more of the common cases. The remaining cases are left
to be reassessed for extending the *expressions* functionality in the
future, but they also may be better served with other approaches (eg,
with coded conditions) that were not available when `swak4Foam` was
originally conceived.
To the greatest extent possible, the integrated *expressions* have
been designed to avoid name clashes with `swak` so it should remain
possible to use the most recent versions of `swak` without problem.
### Risks
- New functionality, so low chance of regression.
- The scope of the functionality will be revised in the future
### Naming (for `swak4Foam` users)
The following are the *expressions* correspondences to `swak`:
- The `exprFixedValue` and `exprGradient` boundary conditions are
roughly equivalent to the _groovy_ boundary conditions.
- The utilities `setExprFields` and `setExprBoundaryFields` are
roughly equivalent to the _funky_ utilities of similar name.
The naming of the boundary conditions and utilities not only reflects
the slightly different input requirements, but simultaneously seeks to
avoid any potential name-clash with `swak4Foam` in a mixed
environment.
The names for the boundary condition dictionary entries tend be
shorter and slightly different (eg, `valueExpr` vs `valueExpression`)
to serve as a small reminder that the *expressions* syntax is slightly
different than the *groovy* equivalents. It also allows the user to
fashion dictionary entries that are sufficient for **both** boundary
condition variants and quickly toggle between them simply by changing
the boundary condition `type`.v1912Andrew HeatherAndrew Heather