openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2017-09-25T17:28:48Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/146improve consistency in parsing primitives from strings2017-09-25T17:28:48ZMark OLESENimprove consistency in parsing primitives from stringsThe motivation is to provide a simpler and safer means of extracting integers and labels from strings. There are several benefits:
- catch bad label/scalar input for command-line options/arguments which may be human generated or via s...The motivation is to provide a simpler and safer means of extracting integers and labels from strings. There are several benefits:
- catch bad label/scalar input for command-line options/arguments which may be human generated or via scripts.
- easier/clear to work with when input has already been lexed, without using an IStringStream()
- work directly with C++ strings instead of C-string.
@andyv1712Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/116Feature paraview vtk2017-06-14T13:16:19ZMark OLESENFeature paraview vtkLongstanding changes to OpenFOAM infrastructure for improving the handling of VTK output and paraview interfaces.
Follows up on work started with 1612 (the vtk output formatters). At that stage, we had introduced foam-vtk-cells in the...Longstanding changes to OpenFOAM infrastructure for improving the handling of VTK output and paraview interfaces.
Follows up on work started with 1612 (the vtk output formatters). At that stage, we had introduced foam-vtk-cells in the attempt to consolidate vtkTopo (from foamToVTK), some bits and pieces from a foamToVTU utility and of course the paraview reader module. Each of these did something somewhat similar: namely convert OpenFOAM volume meshes into VTK formats, plus some additional management of polyhedral decomposition (since VTK still isn't the best with these).
However, each of the applications have very slightly different requirements on the output format (legacy vs xml etc). Reducing the memory overhead and improving the overall performance of the paraview reader module was an additional driving factor. The latter becoming quite important if we wish to target a catalyst interface.
The key points of the updated infrastructure:
* dimensioning analysis for OpenFOAM -> VTK conversion now stored and encapsulated as foamVtuSizing.
* copying of OpenFOAM mesh types to VTK types is now done as a service method (algorithm) from foamVtuSizing, with storage being administer elsewhere outside of the class. This lets us target various combinations of output format (legacy, xml, vtk-internal) and storage primitives (int32, int64) and storage types (OpenFOAM List, std::vector, VTK storage classes) without code duplication. This lets us leverage the OpenFOAM infrastructure when populating the VTK classes and handle the different API sizings (eg, OpenFOAM label vs VTK vtkIdType) and the different mesh layouts with the minimal level of overhead.
* Revamped paraview reader module to cache the VTK grid and only shallow copy it when changing time-steps (when the OpenFOAM mesh itself doesn't change). The storage change also makes it easier to understand what the reader module is actually doing.
* Extended the formatting support for legacy and also xml formats.
* Now possible to emit VTU, VTP files from foamToVTK. This makes for easier loading of results and with xml formats we can start grouping multiblock files etc in the future.
* propagated the newer formatting options to reduce overall code clutter in most places where vtk output was being generated. This will still need more attention, but is largely complete.
@Sergio @Prashant - extra testing would be nice.Version v1706AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/249Snappy hex mesh proximity check2019-03-25T16:49:51ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comSnappy hex mesh proximity checkAdds snappyHexMesh functionality to remove cells in small gaps (instead of refining them).
See mesh/snappyHexMesh/opposite_walls tutorial.Adds snappyHexMesh functionality to remove cells in small gaps (instead of refining them).
See mesh/snappyHexMesh/opposite_walls tutorial.AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/129Regression icc2017-07-21T15:04:18ZMark OLESENRegression icc- C++11 user-defined conversions appear to present issues for some intel compilers.
- the _deg conversion (issue #544) causes compilation to crash.- C++11 user-defined conversions appear to present issues for some intel compilers.
- the _deg conversion (issue #544) causes compilation to crash.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/104Initial attempt to track oriented surface fields2017-05-24T13:30:52ZAdminInitial attempt to track oriented surface fieldsThese changes are an attempt to cleanly identify oriented surface fields, i.e. those where the value is signed according to the owner->neighbour direction e.g. the face flux.
Still to do:
* [x] propagate through field mapping - read...These changes are an attempt to cleanly identify oriented surface fields, i.e. those where the value is signed according to the owner->neighbour direction e.g. the face flux.
Still to do:
* [x] propagate through field mapping - ready to test
* [x] simplify surfaceFieldValue function object - passed tests
* [x] check other uses, .e.g. AMI?
* [x] clean-up of dev statements
Checks
* [x] rhoCentral[DyM]Foam solvers
@MattijsVersion v1706AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/115ccm conversion bugfixes2017-05-31T10:51:10ZMark OLESENccm conversion bugfixesPesky bug with ccm conversion (issue #421) traced to off-by-one in inplace reorder/prune of face,owner,neighbour lists.
* Fixed and merged into ListOpTemplates
* Combine normal UList and UIndirectList versions of mergePoints
* Deleted p...Pesky bug with ccm conversion (issue #421) traced to off-by-one in inplace reorder/prune of face,owner,neighbour lists.
* Fixed and merged into ListOpTemplates
* Combine normal UList and UIndirectList versions of mergePoints
* Deleted previous fragile combine-boundaries options (was commented out in 1612), since it is only "nice-to-have", but the underlying problem with boundaries being multiply connected via different interfaces is not solvable in an obvious manner.
* Other misc cleanup.Version v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/96Fixes #4162017-03-02T08:57:52ZPrashant SonakarFixes #416AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/90added optional argument description (Fixes #347)2016-12-16T07:13:24ZPrashant Sonakaradded optional argument description (Fixes #347)Optional argument listed.
@andy @mark Could you confirm/merge?Optional argument listed.
@andy @mark Could you confirm/merge?Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/93Flat list output2017-02-20T18:47:25ZMark OLESENFlat list outputConvenience for situations where you'd like to output list content (eg, choices of models) as a single-line of output - as also discussed with @andy earlier this week.Convenience for situations where you'd like to output list content (eg, choices of models) as a single-line of output - as also discussed with @andy earlier this week.Version v1706Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/216Feature topo set improvements (issue #1060)2018-11-01T11:12:13ZMark OLESENFeature topo set improvements (issue #1060)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/75Feature keep sampled pids2016-11-09T14:58:43ZMark OLESENFeature keep sampled pidsRebased version of merge request !58, following ticket closure for issue #104 .Rebased version of merge request !58, following ticket closure for issue #104 .Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/101BUG: adding case path to support parallel execution (Fixes #449)2017-04-19T07:40:54ZPrashant SonakarBUG: adding case path to support parallel execution (Fixes #449)Fixes #449Fixes #449AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/24ENH: functionObjects: call execute on last time step2015-12-07T15:26:53ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comENH: functionObjects: call execute on last time step- old convention was that on last time step it would only call end()
and not execute()
- however this meant that e.g. the functionObjectProperties file
did not get written
- and almost all functionObjects were doing an execute() insi...- old convention was that on last time step it would only call end()
and not execute()
- however this meant that e.g. the functionObjectProperties file
did not get written
- and almost all functionObjects were doing an execute() inside of end()
- new convention: call execute() on last time step, just before doing end()AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/34Feature lagrangian2016-06-03T15:14:54ZMark OLESENFeature lagrangianMinor adjustments to static information attached to lagrangian parcels/particles.
Fixes #108 (duplicate of http://www.openfoam.org/mantisbt/view.php?id=1990), #109, #110, #111.
Future reworking would require a better mechanism to als...Minor adjustments to static information attached to lagrangian parcels/particles.
Fixes #108 (duplicate of http://www.openfoam.org/mantisbt/view.php?id=1990), #109, #110, #111.
Future reworking would require a better mechanism to also deal with dynamic information such as particle collisions etc.
Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/223ENH: momentum field function (issue #1105)2018-12-04T14:26:43ZMark OLESENENH: momentum field function (issue #1105)Calculates linear/angular momentum, reporting integral values
and optionally writing the fields.
Example
```
momentum1
{
type momentum;
libs ("libfieldFunctionObjects.so");
...
...Calculates linear/angular momentum, reporting integral values
and optionally writing the fields.
Example
```
momentum1
{
type momentum;
libs ("libfieldFunctionObjects.so");
...
selectionMode all;
writeMomentum yes;
writeVelocity no;
cylindrical true;
origin (0 0 0);
e1 (1 0 0);
e3 (0 0 1);
}
```AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/45ENH: Update tutorial for features directionalPressureGradient, Global file ha...2016-06-13T08:30:19ZPrashant SonakarENH: Update tutorial for features directionalPressureGradient, Global file handling- Activate directionalPressureGradient source
- Check for Global/Share file handling- Activate directionalPressureGradient source
- Check for Global/Share file handlingSergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/22ENH: Updated lagrangian libraries from internal development line2015-12-08T17:55:52ZAdminENH: Updated lagrangian libraries from internal development lineFunctionality migration from internal development lineMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/28CONTRIBUTION: Turbulence - updated SpalartAlmaras & kOmegaSST DES, DDES and I...2015-12-22T22:14:56ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comCONTRIBUTION: Turbulence - updated SpalartAlmaras & kOmegaSST DES, DDES and IDDESCode supplied by CFD Software E+F GmbHCode supplied by CFD Software E+F GmbHAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/25Merge foundation2015-12-09T10:52:15ZAdminMerge foundationFoundation code merged
- all compiles - was not all clean and needed to resolve many conflicts
- updated InfoIn, WarningIn, ErrorIn messaging
- removed fluxRequired from tutorials
- currently testing tutorialsFoundation code merged
- all compiles - was not all clean and needed to resolve many conflicts
- updated InfoIn, WarningIn, ErrorIn messaging
- removed fluxRequired from tutorials
- currently testing tutorialsFunctionality migration from internal development lineMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/23ENH: Updated regionModels from internal development line2015-12-11T20:45:30ZAdminENH: Updated regionModels from internal development lineFunctionality migration from internal development lineMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.com