openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2021-04-29T08:18:24Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/444improve flexiblity of IOdictionary construction, use of ITstream, Function12021-04-29T08:18:24ZMark OLESENimprove flexiblity of IOdictionary construction, use of ITstream, Function1- simplify/improve use of ITstream as a string parser/scanner
- consolidate handling of fallback IOdictionary content to reduce code
- extend some Function1/PatchFunction1 to accept dictionary input.- simplify/improve use of ITstream as a string parser/scanner
- consolidate handling of fallback IOdictionary content to reduce code
- extend some Function1/PatchFunction1 to accept dictionary input.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/445add multi-region handling for checkMesh etc, centralized the region handling...2024-01-05T16:57:08ZMark OLESENadd multi-region handling for checkMesh etc, centralized the region handling #2072Introduces a few new include files that simplify and improve the code structure for multi-region utilities
- addAllRegionOptions.H
- getAllRegionOptions.H
- createNamedMeshes.HIntroduces a few new include files that simplify and improve the code structure for multi-region utilities
- addAllRegionOptions.H
- getAllRegionOptions.H
- createNamedMeshes.Hv2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/446collected changes for Lists, faces and PrimitivePatch2021-05-13T10:53:04ZMark OLESENcollected changes for Lists, faces and PrimitivePatchv2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/447STYLE: PDRFOAM End of Program was inconsistent with other applications2021-06-18T13:18:00ZHenning ScheuflerSTYLE: PDRFOAM End of Program was inconsistent with other applicationsfixes issue #2091fixes issue #2091v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/448ENH: splitMeshRegions: combine cellZones. See #20462021-07-01T09:37:56ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comENH: splitMeshRegions: combine cellZones. See #2046### Summary
In splitMeshRegions keep multiple cellZones in the same region
### Resolved bugs (If applicable)
#2046### Summary
In splitMeshRegions keep multiple cellZones in the same region
### Resolved bugs (If applicable)
#2046Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/449refactor and extend handling of faSchemes/fvSchemes2021-05-14T18:36:39ZMark OLESENrefactor and extend handling of faSchemes/fvSchemesv2106Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/450ENH: update geoVoF module (#2076)2021-06-24T16:48:11ZHenning ScheuflerENH: update geoVoF module (#2076)@johan_roenby
Changes:
* renamed interface fields recon::centre -> interfaceCentre.{phaseName}
* interface fields are not written by default
* compatible with AMR and load balancing
Status:
* all tests and tutorial cases pass
the test...@johan_roenby
Changes:
* renamed interface fields recon::centre -> interfaceCentre.{phaseName}
* interface fields are not written by default
* compatible with AMR and load balancing
Status:
* all tests and tutorial cases pass
the testsuite is not included in the commits but is available in issue #2076.v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/451TUT: finiteArea: clean up tutorials2021-06-09T13:41:55ZKutalmış BerçinTUT: finiteArea: clean up tutorials[old-testLoopReport.gz](/uploads/9cba8c30d2af84df40afefabf33a3565/old-testLoopReport.gz)
[new-testLoopReport.gz](/uploads/e9a555b45ae7beb188d78198e359ba56/new-testLoopReport.gz)
[old-logs.gz](/uploads/b51c81ef8a656bf373b5d76c3a31d395/o...[old-testLoopReport.gz](/uploads/9cba8c30d2af84df40afefabf33a3565/old-testLoopReport.gz)
[new-testLoopReport.gz](/uploads/e9a555b45ae7beb188d78198e359ba56/new-testLoopReport.gz)
[old-logs.gz](/uploads/b51c81ef8a656bf373b5d76c3a31d395/old-logs.gz)
[new-logs.gz](/uploads/217a781a7a9a5a1845de65dc7ae4acfb/new-logs.gz)v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/452ENH: adjust tokenizing2021-05-19T16:11:52ZMark OLESENENH: adjust tokenizingSergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/453INT: splineEdge: allowing usage in extrudeMesh. See #1983.2021-05-26T12:22:26ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comINT: splineEdge: allowing usage in extrudeMesh. See #1983.Allows use of spline in extrudeMesh extrusion path. See commented
code in tutorials/mesh/extrudeMesh/polyline/blockMeshDict
Contribution by Guanyang XueAllows use of spline in extrudeMesh extrusion path. See commented
code in tutorials/mesh/extrudeMesh/polyline/blockMeshDict
Contribution by Guanyang XueAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/454ENH: turbulentDFSEMInlet: various improvements2021-06-22T09:18:22ZKutalmış BerçinENH: turbulentDFSEMInlet: various improvements### Summary
- ENH: Input entries of `R`, `L` and `U` are now `PatchFunction1` type.
- ENH: Adds two scalar normalisation factors for input `R`, `L` and `U`: `Uref` and `Lref` (default=1).
- ENH: Adds a scalar factor to enable users to t...### Summary
- ENH: Input entries of `R`, `L` and `U` are now `PatchFunction1` type.
- ENH: Adds two scalar normalisation factors for input `R`, `L` and `U`: `Uref` and `Lref` (default=1).
- ENH: Adds a scalar factor to enable users to tune the C1 normalisation coefficient: `scale` (default=1).
- BUG: MappedFile: separates scopes of entries.
- TUT: Replaces `chan395DFSEM` and `PCF` tutorials with `planeChannel` and `oneCellThickPlaneChannel` tutorials.
- Corrects the integral-length scale input files.
- Updates the [Extended Code Guide's channel flow](https://www.openfoam.com/documentation/guides/latest/doc/verification-validation-turbulent-plane-channel-flow.html) case, and allows users to reproduce the results.
### Resolved bugs (If applicable)
#2098
#2097
#2090
#1004
#1744
#2089
### Details of new models (If applicable)
A set of results obtained from the `planeChannel` tutorial (and its plot script available to users) with a different set of settings can be seen below:
##### Ruv vs y
![Ruv_vs_y](/uploads/0a9a5a8b41f5c19a8ccacc3d1614d554/Ruv_vs_y.png)
##### u vs y
![u_vs_y](/uploads/e43ae1708a96ba6c77955d33e4ebf5ca/u_vs_y.png)
##### Ruu vs y
![Ruu_vs_y](/uploads/d30bcba9424ab2cf2fd63f9ebcb41285/Ruu_vs_y.png)
##### x vs Cf
![x_vs_cf](/uploads/c7f25cfb42129756c84d9a76ce010170/x_vs_cf.png)
##### Rvv vs y
![Rvv_vs_y](/uploads/aa956075682e9331172a0ddbd92ab727/Rvv_vs_y.png)
##### Rww vs y
![Rww_vs_y](/uploads/00cdcd67ba65659f8469c59415a46d23/Rww_vs_y.png)
### Risks
##### User input
Users (my apologies) will have to change the input syntax for `R`, `L` and `U` entries. For example, for reading the input files in `constant/boundaryData/inlet/0/`, users were using the following minimal syntax:
```
inlet
{
type turbulentDFSEMInlet;
delta 1;
mapMethod nearestCell;
value $internalField;
}
```
For the same effect, one of the syntax examples could be as follows:
```
inlet
{
type turbulentDFSEMInlet;
delta 1;
U mappedFile;
R mappedFile;
L mappedFile;
mapMethod nearest;
value $internalField;
}
```
or as follows:
```
inlet
{
type turbulentDFSEMInlet;
delta 1;
U
{
type mappedFile;
mapMethod nearest;
}
R
{
type mappedFile;
mapMethod nearest;
}
L
{
type mappedFile;
mapMethod nearest;
}
value $internalField;
}
```
Users can, however, use any of the `PatchFunction1` input syntax exemplified in this [link](https://www.openfoam.com/news/main-news/openfoam-v1812/core#core-patch-function1) and this [link](https://www.openfoam.com/news/main-news/openfoam-v20-06/pre-processing#pre-processing-expression-patchfunction1).
##### Regressions
- ~~The default value of `nCellPerEddy` entry was changed from 5 to 1, which is the default value corresponding to the original journal paper.~~
- The default value of `nCellPerEddy` entry was kept the same as 5.
##### Remaining issues
- Arguably, the DFSEM method has various theoretical issues that need to be addressed (see #2090). We have been trying to reach the originators of the method during the last couple of years; and we will continue our efforts, if possible, to cooperate with them to resolve some of these issues.v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/455BUG: normalResidual has the potential to contain uninitialized values2021-05-27T09:01:14ZHenning ScheuflerBUG: normalResidual has the potential to contain uninitialized valuesmerge request !436 (fixing issue #2016) introduced a critical bug potentially causing uninitialized values in the calcResidual-functionmerge request !436 (fixing issue #2016) introduced a critical bug potentially causing uninitialized values in the calcResidual-functionAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/456Support AMI for multi-world operation2021-05-26T08:27:33ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comSupport AMI for multi-world operation### Summary
Multi-world operation now supports AMI (`nearestPatchFaceAMI`)
Fixes #2099### Summary
Multi-world operation now supports AMI (`nearestPatchFaceAMI`)
Fixes #2099v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/457support parallel creation of finiteArea meshes with on-the-fly decomposition ...2021-05-28T18:14:55ZMark OLESENsupport parallel creation of finiteArea meshes with on-the-fly decomposition of fields #2084v2106Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/458TUT: heatTransfer: clean up tutorials2021-05-26T11:36:22ZKutalmış BerçinTUT: heatTransfer: clean up tutorials- elementwise the same:
[logs-old.gz](/uploads/fabc366885ebda688028a1bc92bb8e9f/logs.gz)
[testLoopReport-old.gz](/uploads/62469080cea9f65e91ba275a970ed733/testLoopReport.gz)
[logs-new.gz](/uploads/ef7706e0e8477642d874f4bacd5ac091/logs...- elementwise the same:
[logs-old.gz](/uploads/fabc366885ebda688028a1bc92bb8e9f/logs.gz)
[testLoopReport-old.gz](/uploads/62469080cea9f65e91ba275a970ed733/testLoopReport.gz)
[logs-new.gz](/uploads/ef7706e0e8477642d874f4bacd5ac091/logs.gz)
[testLoopReport-new.gz](/uploads/4bafc00041f330ef89341b7a0c1afee4/testLoopReport.gz)
- the environment of the old setup:
```
base0 = base
base1 = develop
api = 2103
patch = 210414
HEAD = 9a3d27e3df
version = com
compiler = Clang (system)
= clang version 9.0.1
mpi = SYSTEMOPENMPI
= mpirun (Open MPI) 1.10.7.0.5e373bf1fd
OS = Description: openSUSE Leap 15.1
opts = linux64ClangDPInt32Opt
```v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/459TUT: compressible: clean up tutorials2021-05-27T09:00:24ZKutalmış BerçinTUT: compressible: clean up tutorials- elementwise the same:
[logs-old.gz](/uploads/ef3824e69f7dd916a3ed322b0d80b739/logs.gz)
[testLoopReport-old.gz](/uploads/ac9d00a5b8c1780571564b96ceed799d/testLoopReport.gz)
[logs-new.gz](/uploads/a874d039d99ec0f730e1c4a54098356c/logs...- elementwise the same:
[logs-old.gz](/uploads/ef3824e69f7dd916a3ed322b0d80b739/logs.gz)
[testLoopReport-old.gz](/uploads/ac9d00a5b8c1780571564b96ceed799d/testLoopReport.gz)
[logs-new.gz](/uploads/a874d039d99ec0f730e1c4a54098356c/logs.gz)
[testLoopReport-new.gz](/uploads/1e90d330490264b02a7206c2f2857026/testLoopReport.gz)
- the environment of the old setup:
```
base0 = base
base1 = develop
api = 2103
patch = 210414
HEAD = 3273e6c21a
version = com
compiler = Clang (system)
= clang version 9.0.1
mpi = SYSTEMOPENMPI
= mpirun (Open MPI) 1.10.7.0.5e373bf1fd
OS = Description: openSUSE Leap 15.1
opts = linux64ClangDPInt32Opt
```v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/460ENH: add proximityRegions filter to distanceSurface (#2108)2021-07-05T13:29:15ZMark OLESENENH: add proximityRegions filter to distanceSurface (#2108)- combines region-based and proximity-based filtering
proxityRegions (post-filter):
Checks the resulting faces against the original search surface
as well as checking the cut cells for topological connectivity.
If the area...- combines region-based and proximity-based filtering
proxityRegions (post-filter):
Checks the resulting faces against the original search surface
as well as checking the cut cells for topological connectivity.
If the area-weighted distance for a region is greater than
\c absProximity, the region is discarded.
STYLE: support 'proxityFaces' as synonym for 'proximity' filterAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/461TUT: combustion: clean up tutorials2021-06-08T20:24:35ZKutalmış BerçinTUT: combustion: clean up tutorials[logs-old.gz](/uploads/513e7e4ff9bed9427dd13afacc98e567/logs.gz)
[testLoopReport-old.gz](/uploads/04bd97a0bbde7f6a999bd870b1a54679/testLoopReport.gz)
[logs-new.gz](/uploads/2343b658ce058efe1e802d0ad3326d9d/logs.gz)
[testLoopReport-new...[logs-old.gz](/uploads/513e7e4ff9bed9427dd13afacc98e567/logs.gz)
[testLoopReport-old.gz](/uploads/04bd97a0bbde7f6a999bd870b1a54679/testLoopReport.gz)
[logs-new.gz](/uploads/2343b658ce058efe1e802d0ad3326d9d/logs.gz)
[testLoopReport-new.gz](/uploads/4f49690308dd869e533dae50a0af2964/testLoopReport.gz)
```
base0 = work
base1 = tutorial-combustion
api = 2103
patch = 210414
HEAD = cf6b675a8b
version = com
compiler = Clang (system)
= clang version 9.0.1
mpi = SYSTEMOPENMPI
= mpirun (Open MPI) 1.10.7.0.5e373bf1fd
OS = Description: openSUSE Leap 15.1
opts = linux64ClangDPInt32Opt
```v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/462TUT: incompressible: clean up tutorials2021-06-08T20:17:01ZKutalmış BerçinTUT: incompressible: clean up tutorials[testLoopReport-old.gz](/uploads/fd21c57a06667a0e7b7cc011a7439440/testLoopReport.gz)
[testLoopReport-new.gz](/uploads/6541448fcc63a08614a149ce886731b3/testLoopReport.gz)
Additionally, `Allrun` was executed for both (including the adjoi...[testLoopReport-old.gz](/uploads/fd21c57a06667a0e7b7cc011a7439440/testLoopReport.gz)
[testLoopReport-new.gz](/uploads/6541448fcc63a08614a149ce886731b3/testLoopReport.gz)
Additionally, `Allrun` was executed for both (including the adjoint), resulting in pass.v2106Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/463ENH: Adding subMesh option to momentumError and div FOs2021-07-03T19:59:35ZSergio FerrarisENH: Adding subMesh option to momentumError and div FOs- Adding subMesh capabilities to momentumError and div FOs.
- A subMesh is created from cellZones to compute FOs.
- The operators (div, etc) are only calculated in the subMesh.
- Zero field is written in the non-subMesh cells.
- Op...- Adding subMesh capabilities to momentumError and div FOs.
- A subMesh is created from cellZones to compute FOs.
- The operators (div, etc) are only calculated in the subMesh.
- Zero field is written in the non-subMesh cells.
- Optionally, halo cells can be added to the cellZones.
- New helper class to handle the subMesh creation and field mapping.
- TUT: add an example to `tutorials/compressible/rhoSimpleFoam/aerofoilNACA0012`v2106Andrew HeatherAndrew Heather