openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2021-08-05T12:41:26Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/479ENH: enable custom input of U for devRhoReff and devReff2021-08-05T12:41:26ZKutalmış BerçinENH: enable custom input of U for devRhoReff and devReff### Summary
* 874bc33fe6 - BUG: forces: ensure UName entry can be used (fixes #2093) <Kutalmis Bercin>
* 2cd6071c9b - ENH: enable custom input of U for devRhoReff and devReff <Kutalmis Bercin>
Previously, for basic incompressible and c...### Summary
* 874bc33fe6 - BUG: forces: ensure UName entry can be used (fixes #2093) <Kutalmis Bercin>
* 2cd6071c9b - ENH: enable custom input of U for devRhoReff and devReff <Kutalmis Bercin>
Previously, for basic incompressible and compressible simulations, the "force" function object has not been using the user-specified "UName" for the "devRhoReff" computation (affecting the tangential component), but using the "U" of the latest available step. In contrast, the user-specified "pName" has always been being used correctly.
This has been causing issues for users when they wish to use a specific "UMean" field in various force and forceCoeff function object computations.
Also, the set of commits can allow the usage of custom `U` for other function objects, such as `yPlus`, `wallShearStress` etc.
### Resolved bugs (If applicable)
#2093
EP#1224
### Risks
No risk expected.
### Test cases
See 41c0fa3b in t-repo.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/460ENH: add proximityRegions filter to distanceSurface (#2108)2021-07-05T13:29:15ZMark OLESENENH: add proximityRegions filter to distanceSurface (#2108)- combines region-based and proximity-based filtering
proxityRegions (post-filter):
Checks the resulting faces against the original search surface
as well as checking the cut cells for topological connectivity.
If the area...- combines region-based and proximity-based filtering
proxityRegions (post-filter):
Checks the resulting faces against the original search surface
as well as checking the cut cells for topological connectivity.
If the area-weighted distance for a region is greater than
\c absProximity, the region is discarded.
STYLE: support 'proxityFaces' as synonym for 'proximity' filterAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/455BUG: normalResidual has the potential to contain uninitialized values2021-05-27T09:01:14ZHenning ScheuflerBUG: normalResidual has the potential to contain uninitialized valuesmerge request !436 (fixing issue #2016) introduced a critical bug potentially causing uninitialized values in the calcResidual-functionmerge request !436 (fixing issue #2016) introduced a critical bug potentially causing uninitialized values in the calcResidual-functionAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/453INT: splineEdge: allowing usage in extrudeMesh. See #1983.2021-05-26T12:22:26ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comINT: splineEdge: allowing usage in extrudeMesh. See #1983.Allows use of spline in extrudeMesh extrusion path. See commented
code in tutorials/mesh/extrudeMesh/polyline/blockMeshDict
Contribution by Guanyang XueAllows use of spline in extrudeMesh extrusion path. See commented
code in tutorials/mesh/extrudeMesh/polyline/blockMeshDict
Contribution by Guanyang XueAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/452ENH: adjust tokenizing2021-05-19T16:11:52ZMark OLESENENH: adjust tokenizingSergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/448ENH: splitMeshRegions: combine cellZones. See #20462021-07-01T09:37:56ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comENH: splitMeshRegions: combine cellZones. See #2046### Summary
In splitMeshRegions keep multiple cellZones in the same region
### Resolved bugs (If applicable)
#2046### Summary
In splitMeshRegions keep multiple cellZones in the same region
### Resolved bugs (If applicable)
#2046Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/444improve flexiblity of IOdictionary construction, use of ITstream, Function12021-04-29T08:18:24ZMark OLESENimprove flexiblity of IOdictionary construction, use of ITstream, Function1- simplify/improve use of ITstream as a string parser/scanner
- consolidate handling of fallback IOdictionary content to reduce code
- extend some Function1/PatchFunction1 to accept dictionary input.- simplify/improve use of ITstream as a string parser/scanner
- consolidate handling of fallback IOdictionary content to reduce code
- extend some Function1/PatchFunction1 to accept dictionary input.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/439ENH: snappyHexMesh: block walk through other surfaces.2021-04-19T09:28:55ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comENH: snappyHexMesh: block walk through other surfaces.### Summary
`blockLevel` detects small gaps. This change prevents walking through existing 'walls'.
### Resolved bugs (If applicable)
https://exchange.openfoam.com/node/1001### Summary
`blockLevel` detects small gaps. This change prevents walking through existing 'walls'.
### Resolved bugs (If applicable)
https://exchange.openfoam.com/node/1001Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/438INT: reacting*EulerFoam: correct handling of K for energy equation (#2033)2021-03-31T10:16:50ZKutalmış BerçinINT: reacting*EulerFoam: correct handling of K for energy equation (#2033)- Integration from OpenFOAM.org: ([link](https://bugs.openfoam.org/view.php?id=3634)).
- It was reported in #2033 that `reactingTwoPhaseEulerFoam` and `reactingMultiphaseEulerFoam`could not reproduce the closed-form solutions available f...- Integration from OpenFOAM.org: ([link](https://bugs.openfoam.org/view.php?id=3634)).
- It was reported in #2033 that `reactingTwoPhaseEulerFoam` and `reactingMultiphaseEulerFoam`could not reproduce the closed-form solutions available for [Sod's shock tube](https://en.wikipedia.org/wiki/Sod_shock_tube) test case.
- To this end, two test cases were setup (the link will be broken in the future):
- [reactingTwoPhaseEulerFoam](https://develop.openfoam.com/OpenCFD/OpenFOAM-test/-/tree/VV-Sod-shock-tube/validation/multiphase/reactingTwoPhaseEulerFoam/SodShockTube)
- [reactingMultiphaseEulerFoam](https://develop.openfoam.com/OpenCFD/OpenFOAM-test/-/tree/VV-Sod-shock-tube/validation/multiphase/reactingMultiphaseEulerFoam/SodShockTube)
- Effects of the bug fix on these test cases are illustrated below (left: previous state, right: new state):
#### reactingTwoPhaseEulerFoam
<p float="middle">
<img src="/uploads/35bc462626c9986b106a14e434f65185/pressure.png" width="300" />
<img src="/uploads/c442deba03e8df5ab24c0bc5dfcb0154/pressure.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/129cdd20b51345f8f9ad13caf9630676/temperature.png" width="300" />
<img src="/uploads/346954d4e7d02877636f14dfe25039a9/temperature.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/622532f8ca144a1f34ee5ac4ba149a54/rho.png" width="300" />
<img src="/uploads/56f3c3e43924a6e6aee8b8d6be7f322d/rho.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/03cc2a1950ca64ab065592a816788179/velocity.png" width="300" />
<img src="/uploads/8e9b2c62e461388a7326d4d3df8b8b3a/velocity.png" width="300" />
</p>
#### reactingMultiphaseEulerFoam
<p float="middle">
<img src="/uploads/b75945b92c264d6e8fa6bc48aa8af1d2/pressure.png" width="300" />
<img src="/uploads/093bbab2265592630b0a4522e93261ce/pressure.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/5b74fdb97bbcede6f55c754a64dfd9ec/temperature.png" width="300" />
<img src="/uploads/03351a6b3f86cc05f186128d8a32578f/temperature.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/b0ef61e27a6e64e6c3073c051a1f0881/rho.png" width="300" />
<img src="/uploads/a508e2a65b672c4d4d9f67228c84d8c8/rho.png" width="300" />
</p>
<p float="middle">
<img src="/uploads/b17303f99ff9f03e0dca11f537a4840a/velocity.png" width="300" />
<img src="/uploads/7f00dddeae12a09f30ab55c164661d30/velocity.png" width="300" />
</p>
#### Tutorials
- The bug fix changes the output of the existing tutorials:
[new-logs.gz](/uploads/ceb9ede8ffde674efb17c7b183fd8645/new-logs.gz)
[old-logs.gz](/uploads/0feb2adb61e93de26c1e1cbc0fc26632/old-logs.gz)
[new-testLoopReport.gz](/uploads/e0e06fd3efccdab2bba258eab22838ae/new-testLoopReport.gz)
[old-testLoopReport.gz](/uploads/c212deb4a1e1517feacbb1cc69267461/old-testLoopReport.gz)
##### Environment (development)
```
base0 = base
base1 = develop
api = 2102
patch = 210210
HEAD = 8abac1dc4d
version = com
compiler = Clang (system)
= clang version 9.0.1
mpi = SYSTEMOPENMPI
= mpirun (Open MPI) 1.10.7.0.5e373bf1fd
OS = Description: openSUSE Leap 15.1
opts = linux64ClangDPInt32Opt
```Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/437TUT: DNS, electromagnetics, financial, stressAnalysis: clean up tutorials2021-03-31T10:14:59ZKutalmış BerçinTUT: DNS, electromagnetics, financial, stressAnalysis: clean up tutorials[new-testLoopReport.gz](/uploads/08e10f23e3d60d6233884fc7053abd4a/new-testLoopReport.gz)
[old-testLoopReport.gz](/uploads/f13296edfa9d3975229bac5c0ac66fb5/old-testLoopReport.gz)
[new-logs.gz](/uploads/dc427e614716c3390bd706644e67e7f6/n...[new-testLoopReport.gz](/uploads/08e10f23e3d60d6233884fc7053abd4a/new-testLoopReport.gz)
[old-testLoopReport.gz](/uploads/f13296edfa9d3975229bac5c0ac66fb5/old-testLoopReport.gz)
[new-logs.gz](/uploads/dc427e614716c3390bd706644e67e7f6/new-logs.gz)
[old-logs.gz](/uploads/ac024df92b1c2470511ac6f5638b686c/old-logs.gz)Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/436BUG: possible infinteloop in plicRDF and isoAdvector - Fixes #20162021-05-19T14:23:29ZHenning ScheuflerBUG: possible infinteloop in plicRDF and isoAdvector - Fixes #2016BUG: possible infinteloop in plicRDF and isoAdvector - Fixes #2016BUG: possible infinteloop in plicRDF and isoAdvector - Fixes #2016https://develop.openfoam.com/Development/openfoam/-/merge_requests/434Handle layer addition on acmi2021-03-31T14:30:05ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comHandle layer addition on acmi### Summary
1) When extruding an edge to a patch face make sure to extrude
all the patch faces connected to that edge and cell. This
will handle cyclicACMI (has duplicate patches - AMI and non-overlap)
2) handle fvMesh::readUpdate of c...### Summary
1) When extruding an edge to a patch face make sure to extrude
all the patch faces connected to that edge and cell. This
will handle cyclicACMI (has duplicate patches - AMI and non-overlap)
2) handle fvMesh::readUpdate of cyclicACMI cases. These were clearing out the polyMesh level data so calculating with original, unadapted faceAreas so reporting open cells in e.g. checkMesh where there weren't any:
```
***Boundary openness (-0.0105688 -3.02042e-16 -7.87935e-18) possible hole in boundary description.
***Open cells found, max cell openness: 0.333333, number of open cells 61
```
### Resolved bugs (If applicable)
Fixes #1988. Fixes #2036
### Risks
- cannot see any side-effects - if duplicate faces they both need extruding
- requires extra check for boundary edges so little overheadAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/432TUT: discreteMethods: cleanup tutorials2021-03-24T13:17:16ZKutalmış BerçinTUT: discreteMethods: cleanup tutorials[old.logs.gz](/uploads/32aea84ffb289f0931c27158e53ee881/logs.gz)
[old.testLoopReport.gz](/uploads/544aa6c5b45ef0105d61e8bcc27189f2/testLoopReport.gz)
[new.logs.gz](/uploads/84a5e6c785e838bc12a3df8d618b5141/logs.gz)
[new.testLoopReport.g...[old.logs.gz](/uploads/32aea84ffb289f0931c27158e53ee881/logs.gz)
[old.testLoopReport.gz](/uploads/544aa6c5b45ef0105d61e8bcc27189f2/testLoopReport.gz)
[new.logs.gz](/uploads/84a5e6c785e838bc12a3df8d618b5141/logs.gz)
[new.testLoopReport.gz](/uploads/82725d18f75299ca9be4188d03a45152/testLoopReport.gz)
The same element wise apart from the cases where execution was changed from serial to parallel operation.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/429TUT: lagrangian: clean up tutorials2021-03-12T11:40:22ZKutalmış BerçinTUT: lagrangian: clean up tutorialsyielding the same output in comparison to the previous state:
[logs-old.zip](/uploads/c368115643488cfb2a67d43aaca5cc92/logs-old.zip)
[testLoopReport-old.zip](/uploads/e83898a6a863deba573ed101f2b4d472/testLoopReport-old.zip)
[logs-new.z...yielding the same output in comparison to the previous state:
[logs-old.zip](/uploads/c368115643488cfb2a67d43aaca5cc92/logs-old.zip)
[testLoopReport-old.zip](/uploads/e83898a6a863deba573ed101f2b4d472/testLoopReport-old.zip)
[logs-new.zip](/uploads/5a008be3e36db9de559d19d458dfd7b7/logs-new.zip)
[testLoopReport-new.zip](/uploads/86147bb1b485117995a3606555af05c7/testLoopReport-new.zip)Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/427COMP: objective manager masks regIOobject::write function (#2005)2024-01-11T18:45:47ZVaggelis PapoutsisCOMP: objective manager masks regIOobject::write function (#2005)objectiveManager::write was hiding the regIOobject::write function.
Solved by renaming to objectiveManager::writeObjectivesobjectiveManager::write was hiding the regIOobject::write function.
Solved by renaming to objectiveManager::writeObjectivesMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/426Improve the Lagrangian distribution models2021-09-06T13:07:05ZKutalmış BerçinImprove the Lagrangian distribution models### Summary
- Consolidate min/max operands by migrating local min/max operands to the parent class
- Add new sanity checks
- Modernise the code style
- Replace input variable names with the corresponding de facto conventions in statisti...### Summary
- Consolidate min/max operands by migrating local min/max operands to the parent class
- Add new sanity checks
- Modernise the code style
- Replace input variable names with the corresponding de facto conventions in statistics
- Fix `sample` and `mean` function predictions for the `normal`, `multiNormal`, `RosinRammler` and `massRosinRammler` distributions
- Add cumulative distribution function into the `general` distribution
- Improve header file documentation
### Resolved bugs
Closes #1996
### Risks
- No changes in output except for bug fixes in `normal` and `multiNormal` distributions
- No changes to user input
- Ensured backward compatibility for new input entries
### Tests
- [x] Compilation (incl. submodules):
- [x] `linux64ClangDPInt32Opt` (clang11)
- [x] `linux64GccDPInt32Opt`
- [x] `linux64GccSPDPInt64Debug`
- [x] Alltest: No change in output + no error
- [x] Verification: [distribution models without CFD](https://tinyurl.com/szjvw7ut)Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/425ENH: new solvers: overPhaseChangeInterFoam and overCompressibleInterDyMFoam2021-03-24T13:15:23ZSergio FerrarisENH: new solvers: overPhaseChangeInterFoam and overCompressibleInterDyMFoamKutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/424Thermo ext2021-02-22T16:49:02ZSergio FerrarisThermo extAdding pair of thermos for Lee model and adding tabulated thermo to thermoPhysicalTypeAdding pair of thermos for Lee model and adding tabulated thermo to thermoPhysicalTypeKutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/423Two new overset solvers2021-02-19T05:08:31ZSergio FerrarisTwo new overset solversTwo new overset solvers: overInterPhaseChangeDyMFoam and overCompressibleInterDyMFoam and their respective tutorials. A variation of the two simple rotors.Two new overset solvers: overInterPhaseChangeDyMFoam and overCompressibleInterDyMFoam and their respective tutorials. A variation of the two simple rotors.https://develop.openfoam.com/Development/openfoam/-/merge_requests/421WIP: ENH: fixedNormalSlip BC: add 'value' keyword (#1980,#1981)2021-04-15T14:22:30ZKutalmış BerçinWIP: ENH: fixedNormalSlip BC: add 'value' keyword (#1980,#1981)DOC: improve header-file contentDOC: improve header-file contentAndrew HeatherAndrew Heather