openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2020-06-08T12:50:48Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/366Feature flexible install paths2020-06-08T12:50:48ZMark OLESENFeature flexible install pathsAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/365Adding PIMPLE option finalOnLastPimpleIterOnly2020-06-08T14:42:54ZSergio FerrarisAdding PIMPLE option finalOnLastPimpleIterOnlyThe PIMPLE option finalOnLastPimpleIterOnly allows the call the Final
solver only in the last PIMPLE loop. The default is false which is
the present behavior.The PIMPLE option finalOnLastPimpleIterOnly allows the call the Final
solver only in the last PIMPLE loop. The default is false which is
the present behavior.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/358ENH: improve cmake/ParaView config handling2020-05-05T16:50:50ZMark OLESENENH: improve cmake/ParaView config handlingInfrastructure for handling user-specfied installation paths for cmake-based code
- the `wmake/scripts/wmake.cmake-args` handler traps `-prefix=???` options and exports them as `CMAKE_INSTALL_PATH`, which can be used by cmake.
- the mak...Infrastructure for handling user-specfied installation paths for cmake-based code
- the `wmake/scripts/wmake.cmake-args` handler traps `-prefix=???` options and exports them as `CMAKE_INSTALL_PATH`, which can be used by cmake.
- the make sentinel file now tracks a variety of parameters (previously just ParaView_DIR and VTK_DIR)
- support plugin builds without predefining a PV_PLUG_PATH environment. Try harder to resolve the paraview-api value if the first attempt fails.
- Unbundle the cmake configuration from the paraview configuration file. Use the `have_cmake` wmake/script to access during build only (avoids affecting the PATH).Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/357Update primitive patch templating and storage2020-05-01T06:10:08ZMark OLESENUpdate primitive patch templating and storageAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/346WIP: Feature surface handling2020-12-04T07:19:32ZMark OLESENWIP: Feature surface handlingMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/345INT: fix bug-ID=00033112020-03-10T20:04:56ZKutalmış BerçinINT: fix bug-ID=0003311~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log....~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log.linux64GccDPInt32Opt.gz) (GCC 7.4.1)
Integration of the Foundation [bug-fix](https://bugs.openfoam.org/view.php?id=3311&nbn=1) to v1812-dev due to an external request.
The bug-fix is already present in dev via 6e8f0dbe761d2b2fe7b15f610ffac4dd8d4e67ce. but in fixed version #1617 Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/341Feature write object2020-02-19T09:26:37ZMark OLESENFeature write objectMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/339Feature ensight parts2020-02-18T11:10:43ZMark OLESENFeature ensight partsAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/338Feature.interPCFoam2020-02-19T15:33:41ZSergio FerrarisFeature.interPCFoamENH: Adding features for phase change solvers
1) Adding interfaceHeight FO
2) Adding interfaceHeatResistance mass transfer model to
interCondensatingEvaporatingFoam with spread source approach
3) Reworking fr...ENH: Adding features for phase change solvers
1) Adding interfaceHeight FO
2) Adding interfaceHeatResistance mass transfer model to
interCondensatingEvaporatingFoam with spread source approach
3) Reworking framework for icoReactingMultiphaseInterFoamMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/336COMP: backport of updates for gcc-92 compilation2020-01-29T16:54:18ZMark OLESENCOMP: backport of updates for gcc-92 compilationAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/335Generated methods2020-01-30T12:39:49ZMark OLESENGenerated methodsExplicit define generated methods where the pairing (constructor/assignment) is partly broken by the existence of user-defined methods.
In some cases, it can be sufficient to simply remove the user definition and rely entirely on genera...Explicit define generated methods where the pairing (constructor/assignment) is partly broken by the existence of user-defined methods.
In some cases, it can be sufficient to simply remove the user definition and rely entirely on generated methods. In other cases, the user-defined methods are useful to retain. So we need to declare defaulted versions. This change is largely driven by new warnings from gcc-9.2.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/334ENH: lduMatrix: new matrix solvers: PPCG,PPCR2020-03-11T13:53:05ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comENH: lduMatrix: new matrix solvers: PPCG,PPCRPPCG is pipelined version of PCG, PPCR is conjugate
residual version.PPCG is pipelined version of PCG, PPCR is conjugate
residual version.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/333support eulersolver heat transfer fo2020-05-21T14:21:40ZSergio Ferrarissupport eulersolver heat transfer foThe lib in src/phaseSystemModels/reactingEulerFoam/phaseSystems/
was not fully linked due to cyclic dependencies. When used in 'fieldFunctionObject' (to get the
HTC for multiphase), created a problem of linking in two apps:
appli...The lib in src/phaseSystemModels/reactingEulerFoam/phaseSystems/
was not fully linked due to cyclic dependencies. When used in 'fieldFunctionObject' (to get the
HTC for multiphase), created a problem of linking in two apps:
applications/utilities/preProcessing/createExternalCoupledPatchGeometry/Make/options
applications/solvers/multiphase/reactingEulerFoam/functionObjects/Make/options
And surely when called from controlDict in the tutorials.
Previously the missing libs were provided in the solvers (Euler solvers).
As we need a fully linked phaseSystems lib. I compiled last this lib in rc/phaseSystemModels/reactingEulerFoam/Allwmake. This creates a complete lib usable in fieldFunctionObject.
Some changes were needed in the intermediate libs as well for compilation.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/332ENH: stream adjustments2020-01-23T15:43:57ZMark OLESENENH: stream adjustments- make stream constructors explicit
- remove "using std::ifstream", "using std::iofstream" statements
for a cleaner namespace.
* copy/move assignments for ITstream
* IStringStream: default construct and construct from std::string
...- make stream constructors explicit
- remove "using std::ifstream", "using std::iofstream" statements
for a cleaner namespace.
* copy/move assignments for ITstream
* IStringStream: default construct and construct from std::string
instead of Foam::string
- reduce some overhead in masterOFstream
- simplify Pstream handling of string variants (#1525)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/331Submodule visualization2020-01-23T14:24:33ZMark OLESENSubmodule visualizationThis finalises the work done to collect visualization-related items:
- catalyst
- paraview-plugins
- runTimePostProcessing
into a single place.
- Makes it easier to make related code changes.
- Makes it easier to mix and match differen...This finalises the work done to collect visualization-related items:
- catalyst
- paraview-plugins
- runTimePostProcessing
into a single place.
- Makes it easier to make related code changes.
- Makes it easier to mix and match different combinations of VTK/ParaView versions and capabilities (Eg, MESA, MPI etc).
Replaces the standalone catalyst submodule.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/326ENH: regIOobject store() now also registers the object2020-01-13T15:42:55ZMark OLESENENH: regIOobject store() now also registers the object- previously the store() method just set the ownedByRegistry flag.
Now ensure that it is indeed registered first.
- support register/store of tmp<> items.
The tmp parameter is not cleared, but changed from PTR to CREF
to allow fur...- previously the store() method just set the ownedByRegistry flag.
Now ensure that it is indeed registered first.
- support register/store of tmp<> items.
The tmp parameter is not cleared, but changed from PTR to CREF
to allow further use.
The implicit registration allows code simplification using the
GeometricField::New factory method, for example.
Old Code
========
volScalarField* ptr = new volScalarField
(
IOobject
(
fieldName,
mesh.time().timeName(),
mesh,
IOobject::NO_READ,
IOobject::NO_WRITE,
true // Register
),
mesh,
dimless,
zeroGradientFvPatchField<scalar>::typeName
);
ptr->store();
New Code
========
auto tptr = volScalarField::New
(
fieldName,
mesh,
dimless,
zeroGradientFvPatchField<scalar>::typeName
);
regIOobject::store(tptr);
or even
regIOobject::store
(
volScalarField::New
(
fieldName,
mesh,
dimless,
zeroGradientFvPatchField<scalar>::typeName
)
);Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/325BUG: wrong bounding of sensitivity contituents in case of many control boxes ...2020-01-09T21:04:42ZVaggelis PapoutsisBUG: wrong bounding of sensitivity contituents in case of many control boxes (Fixes #1549)When more than one volumetric B-Splines control boxes are present, the
sensitivity constituents corresponding to the non-active design
variables were not bounded(zeroed) correctly. The resultant
sensitivities, used in the optimization, w...When more than one volumetric B-Splines control boxes are present, the
sensitivity constituents corresponding to the non-active design
variables were not bounded(zeroed) correctly. The resultant
sensitivities, used in the optimization, were bounded correctly, so this
was more a bug pertaining to the output file of the sensitivities rather
than a functional one.Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/322BUG: continuation of updateMethods with empty activeDesignVariables (#1540)2020-01-03T09:43:15ZVaggelis PapoutsisBUG: continuation of updateMethods with empty activeDesignVariables (#1540)When activeDesignVariables are not set explicitly, all design variables
are treated as active. These were allocated properly when starting from
0 but not when starting from an intermediate optimisation cycle
(e.g. running 5 optimisation ...When activeDesignVariables are not set explicitly, all design variables
are treated as active. These were allocated properly when starting from
0 but not when starting from an intermediate optimisation cycle
(e.g. running 5 optimisation cycles, stopping and restarting).
TUT: added a new tutorial including the restart of an optimisation run
to help identify future regressionAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/321BUG: writeMorpherCPs expects a controlBoxes entry (#1538)2020-01-03T09:43:42ZVaggelis PapoutsisBUG: writeMorpherCPs expects a controlBoxes entry (#1538)The *controlBoxes* wordList was removed from NURBS3DVolume in the
pre-release phase but *writeMorpherCPs* was not updated accordingly.
TUT: added the invocation of *writeMorpherCPs* in one of the tutorials to
help identify future re...The *controlBoxes* wordList was removed from NURBS3DVolume in the
pre-release phase but *writeMorpherCPs* was not updated accordingly.
TUT: added the invocation of *writeMorpherCPs* in one of the tutorials to
help identify future regressionAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/320BUG: Wrong FatalIOError message in displacementMethod and optMeshMovement (#1...2020-01-03T09:44:03ZVaggelis PapoutsisBUG: Wrong FatalIOError message in displacementMethod and optMeshMovement (#1537)- The core of the FatalIOError message was not printed due to exiting
with FatalError instead of FatalIOError
- Changed the TypeName in all derived classes of displacementMethod so
that the toc printed by the FatalIOError correspo...- The core of the FatalIOError message was not printed due to exiting
with FatalError instead of FatalIOError
- Changed the TypeName in all derived classes of displacementMethod so
that the toc printed by the FatalIOError corresponds to what the user
should add in dynamicMeshDictAndrew HeatherAndrew Heather