openfoam merge requests
https://develop.openfoam.com/Development/openfoam/-/merge_requests
2017-08-02T15:28:43Z
https://develop.openfoam.com/Development/openfoam/-/merge_requests/136
Style string methods
2017-08-02T15:28:43Z
Mark OLESEN
Style string methods
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/132
BUG: Correct viscosity in simpleFoam motorBike tutorial (fixes #550)
2017-07-29T10:31:39Z
Admin
BUG: Correct viscosity in simpleFoam motorBike tutorial (fixes #550)
https://develop.openfoam.com/Development/openfoam/-/merge_requests/128
Consistent use of string methods
2017-07-21T15:04:37Z
Mark OLESEN
Consistent use of string methods
- use more standard forms of string access. Eg, substr() instead of the operator()(...) form, or even resize().
- turn off underscore prefixing by default for word::validated()
- new SubStrings container and associated stringOps::split...
- use more standard forms of string access. Eg, substr() instead of the operator()(...) form, or even resize().
- turn off underscore prefixing by default for word::validated()
- new SubStrings container and associated stringOps::split operator. This container may also be useful for writing simple parsers.
v1712
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/129
Regression icc
2017-07-21T15:04:18Z
Mark OLESEN
Regression icc
- C++11 user-defined conversions appear to present issues for some intel compilers.
- the _deg conversion (issue #544) causes compilation to crash.
- C++11 user-defined conversions appear to present issues for some intel compilers.
- the _deg conversion (issue #544) causes compilation to crash.
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/127
Feature streams cleanup
2017-07-18T11:48:32Z
Mark OLESEN
Feature streams cleanup
* Resolves issues encountered with rewinding input file streams and output string streams.
* Make the coding for allocated streams more consistent, which makes their cleanup less messy.
* Resolves issues encountered with rewinding input file streams and output string streams.
* Make the coding for allocated streams more consistent, which makes their cleanup less messy.
v1712
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/125
STYLE: checkMesh: remove duplicate writeSets entry from header (resolves #293)
2017-07-18T11:18:24Z
Admin
STYLE: checkMesh: remove duplicate writeSets entry from header (resolves #293)
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/126
Feature external file coupler
2017-07-18T10:12:06Z
Mark OLESEN
Feature external file coupler
* Promoted code from `lumpedPointMotion` into the `cfdTools` directory
* refactored the `externalCoupler` into `externalFileCoupler`
* Promoted code from `lumpedPointMotion` into the `cfdTools` directory
* refactored the `externalCoupler` into `externalFileCoupler`
v1712
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/123
Feature post release cleaning
2017-07-11T11:45:21Z
Mark OLESEN
Feature post release cleaning
A few commits that somehow slipped through a rebase
A few commits that somehow slipped through a rebase
v1712
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/122
Feature post release cleaning
2017-07-07T16:29:09Z
Mark OLESEN
Feature post release cleaning
Various code tidying up to use newer C++11 and 1706 features but would have been too late for the June code-freeze.
- FoamArch : combine from argList and regIOobject
- cleanup run-time selectables to use auto and cfind
- remove Name...
Various code tidying up to use newer C++11 and 1706 features but would have been too late for the June code-freeze.
- FoamArch : combine from argList and regIOobject
- cleanup run-time selectables to use auto and cfind
- remove NamedEnum from loads of places.
- ABORT function object using a sub-list of Time stopAtControls enumeration
- degToRad() user literals and eliminate duplicate code
- streams :: name() - non-virtual
- MPI_BUFFER_SIZE, NAN, FPE setting via etc/controlDict, optionally via env-variables
- clamp handling for various tables (duplicate and untidy code)
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/121
Merge develop into master for v1706 release
2017-06-29T20:10:12Z
Admin
Merge develop into master for v1706 release
Version v1706
https://develop.openfoam.com/Development/openfoam/-/merge_requests/118
Integration of rhoPimpleAdiabaticFoam from CFD Sofware E+F GmbH
2017-06-29T20:02:26Z
Sergio Ferraris
Integration of rhoPimpleAdiabaticFoam from CFD Sofware E+F GmbH
Solver for low Mach no. flows with adiabatic thermodynamics and updated
pressure-velocity coupling given by the RCM interpolation procedure
described in
Knacke, T. (2013).
Potential effects of Rhie & Chow type interpolation...
Solver for low Mach no. flows with adiabatic thermodynamics and updated
pressure-velocity coupling given by the RCM interpolation procedure
described in
Knacke, T. (2013).
Potential effects of Rhie & Chow type interpolations in airframe
noise simulations. In: Schram, C., Dénos, R., Lecomte E. (ed):
Accurate and efficient aeroacoustic prediction approaches for
airframe noise, VKI LS 2013-03.
Original code supplied by Thilo Knacke, CFD Software E+F GmbH
contact: info@cfd-berlin.com
Integrated into OpenFOAM by OpenCFD Ltd.
Version v1706
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/119
INT: Integration of isoAdvector and supporting material
2017-06-21T16:22:26Z
Admin
INT: Integration of isoAdvector and supporting material
Community contribution from Johan Roenby, DHI
IsoAdvector is a geometric Volume-of-Fluid method for advection of a
sharp interface between two incompressible fluids. It works on both
structured and unstructured meshes with no requir...
Community contribution from Johan Roenby, DHI
IsoAdvector is a geometric Volume-of-Fluid method for advection of a
sharp interface between two incompressible fluids. It works on both
structured and unstructured meshes with no requirements on cell shapes.
IsoAdvector is as an alternative choice for the interface compression
treatment with the MULES limiter implemented in the interFoam family
of solvers.
The isoAdvector concept and code was developed at DHI and was funded
by a Sapere Aude postdoc grant to Johan Roenby from The Danish Council
for Independent Research | Technology and Production Sciences (Grant-ID:
DFF - 1337-00118B - FTP).
Co-funding is also provided by the GTS grant to DHI from the Danish
Agency for Science, Technology and Innovation.
The ideas behind and performance of the isoAdvector scheme is
documented in:
Roenby J, Bredmose H, Jasak H. 2016 A computational method for sharp
interface advection. R. Soc. open sci. 3: 160405.
[http://dx.doi.org/10.1098/rsos.160405](http://dx.doi.org/10.1098/rsos.160405)
Videos showing isoAdvector's performance with a number of standard
test cases can be found in this youtube channel:
https://www.youtube.com/channel/UCt6Idpv4C8TTgz1iUX0prAA
Project contributors:
* Johan Roenby <jro@dhigroup.com> (Inventor and main developer)
* Hrvoje Jasak <hrvoje.jasak@fsb.hr> (Consistent treatment of
boundary faces including processor boundaries, parallelisation,
code clean up
* Henrik Bredmose <hbre@dtu.dk> (Assisted in the conceptual
development)
* Vuko Vukcevic <vuko.vukcevic@fsb.hr> (Code review, profiling,
porting to foam-extend, bug fixing, testing)
* Tomislav Maric <tomislav@sourceflux.de> (Source file
rearrangement)
* Andy Heather <a.heather@opencfd.co.uk> (Integration into OpenFOAM
for v1706 release)
See the integration repository below for the full set of changes
undertaken as part of the integration into OpenFOAM v1706
https://develop.openfoam.com/Community/Integration-isoAdvector
Version v1706
https://develop.openfoam.com/Development/openfoam/-/merge_requests/114
Feature second order restart
2017-06-21T13:03:32Z
Admin
Feature second order restart
Improved support for second order restart where derived fields (not read from disk) appearing in time derivatives were not properly re-initialised
Still to do:
* chtMultiRegionFoam
* twoPhaseEulerFoam
Improved support for second order restart where derived fields (not read from disk) appearing in time derivatives were not properly re-initialised
Still to do:
* chtMultiRegionFoam
* twoPhaseEulerFoam
Version v1706
https://develop.openfoam.com/Development/openfoam/-/merge_requests/117
Integration of ihc wavemodels
2017-06-15T10:38:26Z
Admin
Integration of ihc wavemodels
New solitary wave models supplied by Gabriel Barajas, IH Cantabria:
- McCowan
- Grimshaw
Updated and integrated into OpenFOAM by OpenCFD
New solitary wave models supplied by Gabriel Barajas, IH Cantabria:
- McCowan
- Grimshaw
Updated and integrated into OpenFOAM by OpenCFD
Version v1706
https://develop.openfoam.com/Development/openfoam/-/merge_requests/116
Feature paraview vtk
2017-06-14T13:16:19Z
Mark OLESEN
Feature paraview vtk
Longstanding changes to OpenFOAM infrastructure for improving the handling of VTK output and paraview interfaces.
Follows up on work started with 1612 (the vtk output formatters). At that stage, we had introduced foam-vtk-cells in the...
Longstanding changes to OpenFOAM infrastructure for improving the handling of VTK output and paraview interfaces.
Follows up on work started with 1612 (the vtk output formatters). At that stage, we had introduced foam-vtk-cells in the attempt to consolidate vtkTopo (from foamToVTK), some bits and pieces from a foamToVTU utility and of course the paraview reader module. Each of these did something somewhat similar: namely convert OpenFOAM volume meshes into VTK formats, plus some additional management of polyhedral decomposition (since VTK still isn't the best with these).
However, each of the applications have very slightly different requirements on the output format (legacy vs xml etc). Reducing the memory overhead and improving the overall performance of the paraview reader module was an additional driving factor. The latter becoming quite important if we wish to target a catalyst interface.
The key points of the updated infrastructure:
* dimensioning analysis for OpenFOAM -> VTK conversion now stored and encapsulated as foamVtuSizing.
* copying of OpenFOAM mesh types to VTK types is now done as a service method (algorithm) from foamVtuSizing, with storage being administer elsewhere outside of the class. This lets us target various combinations of output format (legacy, xml, vtk-internal) and storage primitives (int32, int64) and storage types (OpenFOAM List, std::vector, VTK storage classes) without code duplication. This lets us leverage the OpenFOAM infrastructure when populating the VTK classes and handle the different API sizings (eg, OpenFOAM label vs VTK vtkIdType) and the different mesh layouts with the minimal level of overhead.
* Revamped paraview reader module to cache the VTK grid and only shallow copy it when changing time-steps (when the OpenFOAM mesh itself doesn't change). The storage change also makes it easier to understand what the reader module is actually doing.
* Extended the formatting support for legacy and also xml formats.
* Now possible to emit VTU, VTP files from foamToVTK. This makes for easier loading of results and with xml formats we can start grouping multiblock files etc in the future.
* propagated the newer formatting options to reduce overall code clutter in most places where vtk output was being generated. This will still need more attention, but is largely complete.
@Sergio @Prashant - extra testing would be nice.
Version v1706
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/110
Feature surface feature extract
2017-05-31T15:33:46Z
Mark OLESEN
Feature surface feature extract
awaiting further testing (@Prashant, @landmann)
FYI: @Mattijs
awaiting further testing (@Prashant, @landmann)
FYI: @Mattijs
Version v1706
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/115
ccm conversion bugfixes
2017-05-31T10:51:10Z
Mark OLESEN
ccm conversion bugfixes
Pesky bug with ccm conversion (issue #421) traced to off-by-one in inplace reorder/prune of face,owner,neighbour lists.
* Fixed and merged into ListOpTemplates
* Combine normal UList and UIndirectList versions of mergePoints
* Deleted p...
Pesky bug with ccm conversion (issue #421) traced to off-by-one in inplace reorder/prune of face,owner,neighbour lists.
* Fixed and merged into ListOpTemplates
* Combine normal UList and UIndirectList versions of mergePoints
* Deleted previous fragile combine-boundaries options (was commented out in 1612), since it is only "nice-to-have", but the underlying problem with boundaries being multiply connected via different interfaces is not solvable in an obvious manner.
* Other misc cleanup.
Version v1706
Mark OLESEN
Mark OLESEN
https://develop.openfoam.com/Development/openfoam/-/merge_requests/104
Initial attempt to track oriented surface fields
2017-05-24T13:30:52Z
Admin
Initial attempt to track oriented surface fields
These changes are an attempt to cleanly identify oriented surface fields, i.e. those where the value is signed according to the owner->neighbour direction e.g. the face flux.
Still to do:
* [x] propagate through field mapping - read...
These changes are an attempt to cleanly identify oriented surface fields, i.e. those where the value is signed according to the owner->neighbour direction e.g. the face flux.
Still to do:
* [x] propagate through field mapping - ready to test
* [x] simplify surfaceFieldValue function object - passed tests
* [x] check other uses, .e.g. AMI?
* [x] clean-up of dev statements
Checks
* [x] rhoCentral[DyM]Foam solvers
@Mattijs
Version v1706
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/88
Integration of ihcantabria wave models
2017-05-23T15:12:23Z
Admin
Integration of ihcantabria wave models
Integration of functionality produced by The Environmental Hydraulics Institute "IHCantabria" (http://www.ihcantabria.com/en/)
- Original code introduced in commit f5ae874b
- Restructured and updated by OpenCFD into a new `waveModels...
Integration of functionality produced by The Environmental Hydraulics Institute "IHCantabria" (http://www.ihcantabria.com/en/)
- Original code introduced in commit f5ae874b
- Restructured and updated by OpenCFD into a new `waveModels` library available to the interFoam family of solvers
Main source:
`$FOAM_SRC/waveModels`
Tutorials:
`$FOAM_TUTORIALS/multiphase/interFoam/laminar/waveExample*`
Capabilities include:
- Wave generation
- Solitary wave using Boussinesq theory
- Cnoidal wave theory
- StokesI, StokesII, StokesV wave theory
- Active wave absorption at the inflow/outflow boundaries based on shallow water theory
IHCantabria Authors:
- Javier Lopez Lara (jav.lopez@unican.es)
- Gabriel Barajas (barajasg@unican.es)
- Inigo Losada (losadai@unican.es)
Based on the references
- [Higuera, P., Lara, J.L. and Losada, I.J. Three-Dimensional Interaction of Waves and Porous Coastal Structures using OpenFOAM. Part I: Formulation and Validation, Coastal Engineering, 83:243-258, 2014](http://dx.doi.org/10.1016/j.coastaleng.2013.08.010)
- [Higuera, P., Lara, J.L. and Losada, I.J. Three-Dimensional Interaction of Waves and Porous Coastal Structures using OpenFOAM. Part II: Application, Coastal Engineering, 83:259-270, 2014](http://dx.doi.org/10.1016/j.coastaleng.2013.09.002)
- [Higuera, P., Lara, J.L. and Losada, I.J. Simulating Coastal Engineering Processes with OpenFOAM. Coastal Engineering, 71:119-134, 2013](http://dx.doi.org/10.1016/j.coastaleng.2012.06.002)
- [Higuera, P., Lara, J.L. and Losada, I.J. Realistic Wave Generation and Active Wave Absorption for Navier-Stokes Models, Application to OpenFOAM. Coastal Engineering, 71:102-118, 2013](http://dx.doi.org/10.1016/j.coastaleng.2012.07.002)
Version v1612
Admin
Admin
https://develop.openfoam.com/Development/openfoam/-/merge_requests/99
Integration foundation
2017-05-22T13:06:38Z
Admin
Integration foundation
Integrated Foundation developments to d2a62df:
- externalWallHeatFluxTemperature: Added optional support for radiative flux to the outside 2017-04-26.
Next Foundation commit introduced large changes to the particle tracking algorit...
Integrated Foundation developments to d2a62df:
- externalWallHeatFluxTemperature: Added optional support for radiative flux to the outside 2017-04-26.
Next Foundation commit introduced large changes to the particle tracking algorithm - chosen not to include this change set until the code is more fully tested. Some additional cherry-picks have been integrated to resolve further bugs:
- a7711038d (fnd 1bb7db2b7) - CrankNicolsonDdtScheme: Corrected input of off-centering coefficient of 1 2017-05-11
- 1765b5a4a (fnd d26c6c342) - DPMDyMFoam, DPMDyMFoam: Corrected support for closed-domain simulations 2017-05-04
- 0da6a5f79 (fnd 1328b5be0) - surfaceTensionModels: Resolved warning from Clang concerning virtual function overload 2017-05-03
- 23210323e (fnd 7acfa95ea) - thermophysicalModels: Corrected alphah to be enthalpy based 2017-05-03
Main changes
- abc50e214 Updated thermo libraries to be mass based (was molar based)
- Moved edgeMesh library code inside meshTools library
- Many run-time selectable models can now use in-line dictionary input as opposed to specifying a sub <model>Coeffs dictionary
- Energy source refactored in thermo library (Sh, Qdot Qr->qr)
Other
- distributionModels - top level distributionModel class no longer in the distributionModels namespace
Deprecated
- 55f3e808e sixDoFRigidBodyDisplacementPointPatchVectorField and uncoupledSixDoFRigidBodyDisplacementPointPatchVectorField
Status:
- Tutorial Alltest loop completes except for:
- multiphase/compressibleInterDyMFoam/laminar/sphereDrop/log.compressibleInterDyMFoam: change in set-up required due to deprecation of boundary conditions
- combustion/fireFoam/LES/simplePMMApanel/log.fireFoam: reaction system problem for solid->gas reactions
Version v1706