openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2021-11-10T14:26:44Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/415Draft: Integration of PDRfitMesh2021-11-10T14:26:44ZMark OLESENDraft: Integration of PDRfitMeshhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/392Draft: Feature ep1364 fan curve clipping2020-12-16T17:13:16ZMark OLESENDraft: Feature ep1364 fan curve clippinghttps://develop.openfoam.com/Development/openfoam/-/merge_requests/390draft: Feature streams2023-08-29T11:07:00ZMark OLESENdraft: Feature streamsAndrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/381ENH: yPlus: add option to disable wall function contributions (#1773)2020-09-24T16:31:09ZKutalmış BerçinENH: yPlus: add option to disable wall function contributions (#1773)### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix...### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix.zip) vs [GL1773-post-fix](/uploads/6e82b41f337cf0b251280bffb0eb9b9d/GL1773-post-fix.zip)
Test-case characteristics:
* One-dimensional smooth-wall plane channel flow, ReTau=5200
* Number of cells = 20
* nu = 0.000192827 \[m2/s\]
* The case was designed to produce => -1\*sqrt(mag(wallShearStress)) = 1
* The y1+ set (expected) = {0.05, 0.5, 1, 5, 10, 20, 30, 50, 100, ~~1000~~}
* kOmegaSST/SpalartAllmaras, simpleFoam
Main field of interest:
* mag(wallShearStress) function object returns \~ 1 for all test cases, therefore the expected y1+
* yPlus function object (min) results for `lowerWall` rounded up to 2 decimals:
### y1+ = 0.05:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.12** | 0.05 |
| nutkWallFunction | **0.00025** | 0.05 |
| nutUSpaldingWallFunction | 0.05 | 0.05 |
| nutUBlendedWallFunction | 0.05 | 0.05 |
| nutLowReWallFunction | 0.05 | 0.05 |
### y1+ = 0.5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.18** | 0.50 |
| nutkWallFunction | **0.025** | 0.50 |
| nutUSpaldingWallFunction | 0.50 | 0.50 |
| nutUBlendedWallFunction | 0.50 | 0.50 |
### y1+ = 1:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.34** | 1.00 |
| nutkWallFunction | **0.1** | 1.00 |
| nutUSpaldingWallFunction | 1.00 | 1.00 |
| nutUBlendedWallFunction | 1.00 | 1.00 |
### y1+ = 5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **3.02** | 5.00 |
| nutkWallFunction | **2.75** | 5.00 |
| nutUSpaldingWallFunction | 5.00 | 5.00 |
| nutUBlendedWallFunction | 5.00 | 5.00 |
### y1+ = 10:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **9.12** | 10.00 |
| nutkWallFunction | **8.31** | 10.00 |
| nutUSpaldingWallFunction | 10.00 | 10.00 |
| nutUBlendedWallFunction | 10.00 | 10.00 |
### y1+ = 20:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 20.00 | 20.02 |
| nutkWallFunction | **19.30** | 20.01 |
| nutUSpaldingWallFunction | 20.00 | 20.00 |
| nutUBlendedWallFunction | 20.00 | 20.01 |
### y1+ = 30:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 30.09 | 30.09 |
| nutkWallFunction | 29.91 | 30.12 |
| nutUSpaldingWallFunction | 30.08 | 30.08 |
| nutUBlendedWallFunction | 30.09 | 30.09 |
### y1+ = 50:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 50.16 | 50.16 |
| nutkWallFunction | 50.51 | 50.19 |
| nutUSpaldingWallFunction | 50.17 | 50.17 |
| nutUBlendedWallFunction | 50.16 | 50.16 |
### y1+ = 100:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 100.01 | 100.01 |
| nutkWallFunction | 100.96 | 100.01 |
| nutUSpaldingWallFunction | 100.01 | 100.01 |
| nutUBlendedWallFunction | 100.01 | 100.01 |
### Risks
- Compiled with Gcc-7.4.1/Clang-9.0, DPInt32Opt
- No regression issue: [1-pre-fix-yPlus.zip](/uploads/213187624c831a9322790f83da09bd95/1-pre-fix-yPlus.zip) vs [2-post-fix-yPlus.zip](/uploads/f8ee035a427a3c7ea2fefb5d38a40609/2-post-fix-yPlus.zip) (Test: `incompressible/pisoFoam/RAS/cavity`)
- No changes in the default behaviour.
- User can now select the new behaviour by `useWallFunction=false` which is by default `true`.v2012Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/376WIP:dynamicMotionSolverListFvMesh uses same points0 as reference. Fixes #17022020-08-03T15:33:46ZSergio FerrarisWIP:dynamicMotionSolverListFvMesh uses same points0 as reference. Fixes #1702dynamicMotionSolverListFvMesh uses same points0 as reference. Fixes #1702dynamicMotionSolverListFvMesh uses same points0 as reference. Fixes #1702Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/346WIP: Feature surface handling2020-12-04T07:19:32ZMark OLESENWIP: Feature surface handlingMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/345INT: fix bug-ID=00033112020-03-10T20:04:56ZKutalmış BerçinINT: fix bug-ID=0003311~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log....~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log.linux64GccDPInt32Opt.gz) (GCC 7.4.1)
Integration of the Foundation [bug-fix](https://bugs.openfoam.org/view.php?id=3311&nbn=1) to v1812-dev due to an external request.
The bug-fix is already present in dev via 6e8f0dbe761d2b2fe7b15f610ffac4dd8d4e67ce. but in fixed version #1617 Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/328WIP: Revisiting analytical eigen decompositions and polynomialEqns2020-01-17T21:07:33ZKutalmış BerçinWIP: Revisiting analytical eigen decompositions and polynomialEqnsv2006Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/323WIP: ENH: add 'outputCoeffs' and 'extendedOutput' options to forceCoeffs2020-01-17T21:07:23ZKutalmış BerçinWIP: ENH: add 'outputCoeffs' and 'extendedOutput' options to forceCoeffsENH: add 'extendedOutput' option that allows to output all constitutents
of all force coefficients, i.e. total, pressure, viscous, and porous
ENH: add 'outputCoeffs' option to allow to select coefficients to output
...ENH: add 'extendedOutput' option that allows to output all constitutents
of all force coefficients, i.e. total, pressure, viscous, and porous
ENH: add 'outputCoeffs' option to allow to select coefficients to output
ENH: remove redundant computations for porosity constituent when the option
porosity=false
DOC: improve header file and function declaration docs
BAKW: test backward compatibility and functionality in comparison to
v1906 by using `simpleFoam/motorBike` and `simpleFoam/bump2D`.
Tests have involved:
- Serial runs
- Parallel runs
- Serial restart
- Parallel restart
- Only binData = on (parallel)
- Only writeFields = on (parallel)
- Only extendedOutput = on (parallel)
- binData and extendedOutput = on (parallel)
- writeFields and extendedOutput = on (parallel)
- outputCoeffs and extendedOutput = on for arbitrarily chosen
(Cd CmRoll Cl) (parallel and serial)v2006Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/318ENH: improve BinSum container, and Test-BinSum app2020-01-17T21:07:16ZKutalmış BerçinENH: improve BinSum container, and Test-BinSum app```
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
``````
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
```v2006Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/311Integration foundation2019-12-16T17:33:21ZSergio FerrarisIntegration foundationsoftWall might have conflict with the version in develop. We should keep the one in developsoftWall might have conflict with the version in develop. We should keep the one in developMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/309WIP: code ideas for load/unload functions in dlLibraryTable2021-11-26T11:40:00ZMark OLESENWIP: code ideas for load/unload functions in dlLibraryTablehttps://develop.openfoam.com/Development/openfoam/-/merge_requests/35Feature iotweaks2016-05-13T05:52:16ZMark OLESENFeature iotweaksEnhancements for #114 and #115. Tagged as WIP, since there may be some need for discussion/rework prior to merging.Enhancements for #114 and #115. Tagged as WIP, since there may be some need for discussion/rework prior to merging.https://develop.openfoam.com/Development/openfoam/-/merge_requests/43ENH: Adding interCondensingEvaporatingFoam and tutorial2023-12-07T19:01:57ZSergio FerrarisENH: Adding interCondensingEvaporatingFoam and tutorial Solver for 2 incompressible, isothermal immiscible fluids using a VOF
(volume of fluid) phase-fraction based interface capturing approach.
The momentum and other fluid properties are of the "mixture" and a single
momen... Solver for 2 incompressible, isothermal immiscible fluids using a VOF
(volume of fluid) phase-fraction based interface capturing approach.
The momentum and other fluid properties are of the "mixture" and a single
momentum equation is solved.
Solver:
/applications/solvers/multiphase/interCondensingEvaporatingFoam
Tutorial:
/tutorials/multiphase/interCondensingEvaporatingFoam/condensatingVessel
Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/33Merge foundation2016-05-10T13:33:21ZAdminMerge foundationIntegrating latest code from the OF Foundation - main changes:
Lots of renaming/refactoring:
- to retrieve reference from tmp, now need to use tmp.ref() as opposed to tmp()
- fvc::flux function to replace fvc::interpolate(<field>) &...Integrating latest code from the OF Foundation - main changes:
Lots of renaming/refactoring:
- to retrieve reference from tmp, now need to use tmp.ref() as opposed to tmp()
- fvc::flux function to replace fvc::interpolate(<field>) & mesh.Sf()
- integration of new c++ features: no more spaces between closing template braces, e.g. class1<class2<Type> > becomes class1<class2<Type>>
- DataEntry renamed to Function1
New functionality:
- Updated 6DoF
- fvOptions support in turbulence modelshttps://develop.openfoam.com/Development/openfoam/-/merge_requests/248ENH: Add reconstructPar into Allrun (Issue #1244)2019-03-22T20:02:29ZKutalmış BerçinENH: Add reconstructPar into Allrun (Issue #1244)- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/56ENH: distinguish OpenFOAM version for user-coding (fixes #195)2016-12-23T12:44:52ZMark OLESENENH: distinguish OpenFOAM version for user-coding (fixes #195)The pre-processor macro 'OPENFOAM_PLUS' is defined with a numerical
value equal to the currently compatible version number.
This can be used judiciously within user coding to help with minor
differences between OpenFOAM versions. Fo...The pre-processor macro 'OPENFOAM_PLUS' is defined with a numerical
value equal to the currently compatible version number.
This can be used judiciously within user coding to help with minor
differences between OpenFOAM versions. For example,
#ifdef OPENFOAM_PLUS
#if (OPENFOAM_PLUS >= 1612)
...
#endif
#endif
or simply
#if (OPENFOAM_PLUS >= 1612)
...
#endifAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/130WIP: postProcess: handle errors reading constantObjects2017-07-27T23:49:14ZAdminWIP: postProcess: handle errors reading constantObjectsAddresses #539.
This is probably not a good solution, but it does resolve the issues I was having. Ideally, `selectedFields` would be used to only attempt to read fields named accordingly. Perhaps `IOobjectsList` could accept a list of ...Addresses #539.
This is probably not a good solution, but it does resolve the issues I was having. Ideally, `selectedFields` would be used to only attempt to read fields named accordingly. Perhaps `IOobjectsList` could accept a list of names in a constructor.
Is the test application for `IOobjectsList` considered a good check for any broken functionality?https://develop.openfoam.com/Development/openfoam/-/merge_requests/135Add unit test for IOobjectList robustness enhancement2017-08-09T11:05:05ZAdminAdd unit test for IOobjectList robustness enhancementThere was no unit test in the repo to check for this issue, so I added a script and example file to run one. Test will currently fail on `develop`. Passes on `feature-robuster-ioobjectlist-construction` to verify #539 was fixed by !134.There was no unit test in the repo to check for this issue, so I added a script and example file to run one. Test will currently fail on `develop`. Passes on `feature-robuster-ioobjectlist-construction` to verify #539 was fixed by !134.https://develop.openfoam.com/Development/openfoam/-/merge_requests/53Config file simplification (related to issue #176)2016-09-30T16:42:41ZMark OLESENConfig file simplification (related to issue #176)Cleanup compiler settings, reduce clutter in paraview config files.
Possibly need to discuss further cleanup (cf. issue #183).
@internalCleanup compiler settings, reduce clutter in paraview config files.
Possibly need to discuss further cleanup (cf. issue #183).
@internalAdminAdmin