openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2019-11-12T20:35:38Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/268New QRMatrix, HessenbergMatrix and EigenMatrix2019-11-12T20:35:38ZKutalmış BerçinNew QRMatrix, HessenbergMatrix and EigenMatrixAdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/149Merge branch 'feature-Arrhenius-viscocity-energyFO' into 'master'2017-10-28T15:47:12ZAdminMerge branch 'feature-Arrhenius-viscocity-energyFO' into 'master'ENH: Arrhenius viscocity model for incompressible viscocity,
See merge request !147ENH: Arrhenius viscocity model for incompressible viscocity,
See merge request !147https://develop.openfoam.com/Development/openfoam/-/merge_requests/290Issue 11082019-11-12T20:34:06ZKutalmış BerçinIssue 1108AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/345INT: fix bug-ID=00033112020-03-10T20:04:56ZKutalmış BerçinINT: fix bug-ID=0003311~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log....~~WIP for Clang test.~~
[log.linux64Clang50DPInt32Opt.PASS.gz](/uploads/3a77f7f0f18220e02e2e879316a30dc0/log.linux64Clang50DPInt32Opt.gz) (LLVM-5.0.2) //
[log.linux64GccDPInt32Opt.PASS.gz](/uploads/e6d7f27cce9f990ea3d3cf557909aecb/log.linux64GccDPInt32Opt.gz) (GCC 7.4.1)
Integration of the Foundation [bug-fix](https://bugs.openfoam.org/view.php?id=3311&nbn=1) to v1812-dev due to an external request.
The bug-fix is already present in dev via 6e8f0dbe761d2b2fe7b15f610ffac4dd8d4e67ce. but in fixed version #1617 Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/311Integration foundation2019-12-16T17:33:21ZSergio FerrarisIntegration foundationsoftWall might have conflict with the version in develop. We should keep the one in developsoftWall might have conflict with the version in develop. We should keep the one in developMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/169Feature ico reacting multiphase inter foam dev2018-06-22T15:44:53ZSergio FerrarisFeature ico reacting multiphase inter foam devhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/381ENH: yPlus: add option to disable wall function contributions (#1773)2020-09-24T16:31:09ZKutalmış BerçinENH: yPlus: add option to disable wall function contributions (#1773)### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix...### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix.zip) vs [GL1773-post-fix](/uploads/6e82b41f337cf0b251280bffb0eb9b9d/GL1773-post-fix.zip)
Test-case characteristics:
* One-dimensional smooth-wall plane channel flow, ReTau=5200
* Number of cells = 20
* nu = 0.000192827 \[m2/s\]
* The case was designed to produce => -1\*sqrt(mag(wallShearStress)) = 1
* The y1+ set (expected) = {0.05, 0.5, 1, 5, 10, 20, 30, 50, 100, ~~1000~~}
* kOmegaSST/SpalartAllmaras, simpleFoam
Main field of interest:
* mag(wallShearStress) function object returns \~ 1 for all test cases, therefore the expected y1+
* yPlus function object (min) results for `lowerWall` rounded up to 2 decimals:
### y1+ = 0.05:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.12** | 0.05 |
| nutkWallFunction | **0.00025** | 0.05 |
| nutUSpaldingWallFunction | 0.05 | 0.05 |
| nutUBlendedWallFunction | 0.05 | 0.05 |
| nutLowReWallFunction | 0.05 | 0.05 |
### y1+ = 0.5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.18** | 0.50 |
| nutkWallFunction | **0.025** | 0.50 |
| nutUSpaldingWallFunction | 0.50 | 0.50 |
| nutUBlendedWallFunction | 0.50 | 0.50 |
### y1+ = 1:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.34** | 1.00 |
| nutkWallFunction | **0.1** | 1.00 |
| nutUSpaldingWallFunction | 1.00 | 1.00 |
| nutUBlendedWallFunction | 1.00 | 1.00 |
### y1+ = 5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **3.02** | 5.00 |
| nutkWallFunction | **2.75** | 5.00 |
| nutUSpaldingWallFunction | 5.00 | 5.00 |
| nutUBlendedWallFunction | 5.00 | 5.00 |
### y1+ = 10:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **9.12** | 10.00 |
| nutkWallFunction | **8.31** | 10.00 |
| nutUSpaldingWallFunction | 10.00 | 10.00 |
| nutUBlendedWallFunction | 10.00 | 10.00 |
### y1+ = 20:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 20.00 | 20.02 |
| nutkWallFunction | **19.30** | 20.01 |
| nutUSpaldingWallFunction | 20.00 | 20.00 |
| nutUBlendedWallFunction | 20.00 | 20.01 |
### y1+ = 30:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 30.09 | 30.09 |
| nutkWallFunction | 29.91 | 30.12 |
| nutUSpaldingWallFunction | 30.08 | 30.08 |
| nutUBlendedWallFunction | 30.09 | 30.09 |
### y1+ = 50:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 50.16 | 50.16 |
| nutkWallFunction | 50.51 | 50.19 |
| nutUSpaldingWallFunction | 50.17 | 50.17 |
| nutUBlendedWallFunction | 50.16 | 50.16 |
### y1+ = 100:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 100.01 | 100.01 |
| nutkWallFunction | 100.96 | 100.01 |
| nutUSpaldingWallFunction | 100.01 | 100.01 |
| nutUBlendedWallFunction | 100.01 | 100.01 |
### Risks
- Compiled with Gcc-7.4.1/Clang-9.0, DPInt32Opt
- No regression issue: [1-pre-fix-yPlus.zip](/uploads/213187624c831a9322790f83da09bd95/1-pre-fix-yPlus.zip) vs [2-post-fix-yPlus.zip](/uploads/f8ee035a427a3c7ea2fefb5d38a40609/2-post-fix-yPlus.zip) (Test: `incompressible/pisoFoam/RAS/cavity`)
- No changes in the default behaviour.
- User can now select the new behaviour by `useWallFunction=false` which is by default `true`.v2012Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/241ENH: use cellPoint interpolation directly for surfaceFieldValue (#1212)2019-06-05T14:59:10ZMark OLESENENH: use cellPoint interpolation directly for surfaceFieldValue (#1212)- prior to sampledSurface supporting different interpolation schemes a
workaround means was used to simulate cellPoint -> face
interpolation, with averaging of vertex interpolation.
We instead now use cellPoint interpolation direc...- prior to sampledSurface supporting different interpolation schemes a
workaround means was used to simulate cellPoint -> face
interpolation, with averaging of vertex interpolation.
We instead now use cellPoint interpolation directly for the face
values when 'interpolation' is on.https://develop.openfoam.com/Development/openfoam/-/merge_requests/227Enh/tutorials/channel395 dfsem2018-12-21T08:57:21ZKutalmış BerçinEnh/tutorials/channel395 dfsemhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/318ENH: improve BinSum container, and Test-BinSum app2020-01-17T21:07:16ZKutalmış BerçinENH: improve BinSum container, and Test-BinSum app```
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
``````
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
```v2006Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/247ENH: Function1 type support for rpm specification. Fixes #12452019-03-26T05:48:05ZPrashant SonakarENH: Function1 type support for rpm specification. Fixes #1245https://develop.openfoam.com/Development/openfoam/-/merge_requests/248ENH: Add reconstructPar into Allrun (Issue #1244)2019-03-22T20:02:29ZKutalmış BerçinENH: Add reconstructPar into Allrun (Issue #1244)- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244- If applied: tut/multiphase/interIsoFoam/iobasin/Allrun
will execute 'runApplication reconstructPar'
- Why: Prior to this change, no reconstructPar was executed
despite the parallel run
- Related: Issue #1244Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/103ENH: Addinf weightedSum operation to fieldValues FO2017-04-24T09:42:03ZSergio FerrarisENH: Addinf weightedSum operation to fieldValues FOMark,
This is an small addition to FO. I just added weightedSum. Nice to do Sum(phi*weight). This was for a customer
Thanks
SergioMark,
This is an small addition to FO. I just added weightedSum. Nice to do Sum(phi*weight). This was for a customer
Thanks
Sergiohttps://develop.openfoam.com/Development/openfoam/-/merge_requests/100ENH: 2nd order restart: initialise state variables in thermo if running 2nd o...2017-04-04T11:59:49ZAdminENH: 2nd order restart: initialise state variables in thermo if running 2nd orderSet debug flag to 2 for GeometricField and oldTime will print stacktrace.
If any oldTime auto-creation originates from backwards it needs studying
whether the input should be for the old time as well.Set debug flag to 2 for GeometricField and oldTime will print stacktrace.
If any oldTime auto-creation originates from backwards it needs studying
whether the input should be for the old time as well.https://develop.openfoam.com/Development/openfoam/-/merge_requests/594Draft: use sparse storage and data exchange for PstreamBuffers2023-06-22T12:22:33ZMark OLESENDraft: use sparse storage and data exchange for PstreamBuffersChanges the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.Changes the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.v2306Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/514Draft: Resolve "patchProbes output original point and distance"2021-12-09T08:56:46ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "patchProbes output original point and distance"Closes #2291Closes #2291Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/513Draft: Resolve "patchProbes output original point and distance"2021-12-09T08:56:39ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "patchProbes output original point and distance"Closes #2291Closes #2291Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/526Draft: Resolve "ENH: cyclicACMI have optional search distance"2022-06-01T08:14:25ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "ENH: cyclicACMI have optional search distance"Closes #2378Closes #2378Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/392Draft: Feature ep1364 fan curve clipping2020-12-16T17:13:16ZMark OLESENDraft: Feature ep1364 fan curve clippinghttps://develop.openfoam.com/Development/openfoam/-/merge_requests/517Draft: ENH: PatchInjectionModel - added new parcel initial velocity options2021-12-14T14:15:55ZAndrew HeatherDraft: ENH: PatchInjectionModel - added new parcel initial velocity optionsThe parcel initial velocity can now be set using the new `velocityType`
entry, taking one of the following options:
- fixedValue : (default) same as earlier versions, requires U0
- patchValue : velocity set to seed patch face value
...The parcel initial velocity can now be set using the new `velocityType`
entry, taking one of the following options:
- fixedValue : (default) same as earlier versions, requires U0
- patchValue : velocity set to seed patch face value
- zeroGradient : velocity set to seed patch face adjacent cell value
Example usage:
model1
{
type patchInjection;
massTotal 1;
SOI 0;
parcelBasisType mass;
patch cylinder;
duration 10;
parcelsPerSecond 100;
velocityType patchValue;
//velocityType zeroGradient;
//U0 (-10 0 0);
flowRateProfile constant 1;
sizeDistribution
{
type normal;
normalDistribution
{
expectation 1e-3;
variance 1e-4;
minValue 1e-5;
maxValue 2e-3;
}
}
}
See the new $FOAM_TUTORIALS/lagrangian/kinematicParcelFoam/spinningDisk tutorialv2112