openfoam merge requestshttps://develop.openfoam.com/Development/openfoam/-/merge_requests2016-12-15T15:52:25Zhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/61WIP: ENH: runTimePostProcessing - added option to clear/remove objects after use2016-12-15T15:52:25ZAdminWIP: ENH: runTimePostProcessing - added option to clear/remove objects after useWhen specifying line and surface function-object-based visualisation, use the optional 'clearObjects' flag to indicate that source objects should be removed/cleared after use.
Test case: [cavity.tgz](/uploads/742a7620da483538fecee15e2ca...When specifying line and surface function-object-based visualisation, use the optional 'clearObjects' flag to indicate that source objects should be removed/cleared after use.
Test case: [cavity.tgz](/uploads/742a7620da483538fecee15e2ca79e32/cavity.tgz)
Syntax:
```
surfaces
{
cuttingPlane1
{
type functionObject;
functionObject cuttingPlane;
clearObjects yes; // new option
...
```
Note: only files that have been used will be removed, e.g. if a function object has created multiple surface files, unused files will remain at the end of the run - in the attached case the p surface remains...Version v1612AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/58WIP: Issue 104 keep sampled geo info2016-11-15T10:20:42ZMark OLESENWIP: Issue 104 keep sampled geo infoOriginally slated for the 1606 code base (now master). Should be rebased prior to merging into current development line.Originally slated for the 1606 code base (now master). Should be rebased prior to merging into current development line.Version v1612AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/57WIP: Feature bbox improvements2016-11-15T10:21:43ZMark OLESENWIP: Feature bbox improvementsVersion v1612Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/182WIP: Integration of IH Cantabria wave modelling contributions2019-10-03T10:38:02ZAdminWIP: Integration of IH Cantabria wave modelling contributions## New code
New wave generation model:
- `streamFunction`: based on Fenton's Fourier approximation
New interFoam-based solver:
- `interPorousFoam`: alternative method to include porosity effects, to be used with new `fvOptions` (se...## New code
New wave generation model:
- `streamFunction`: based on Fenton's Fourier approximation
New interFoam-based solver:
- `interPorousFoam`: alternative method to include porosity effects, to be used with new `fvOptions` (see below)
New `fvOptions`:
- `multiphasePorositySource`: porosity for multiphase flows
- `mangrovesSource`: mangrove interaction, i.e. drag and turbulence contributions for k-epsilon based models
## Test cases:
- interPorousFoam/porousDamBreak
- interPorousFoam/mangroves
## References:
Solitary wave attenuation by vegetation patches.
Maza, M, Lara, J.L., & Losada, I.J. (2016)
Advances in Water Resources. Vol.98, pp. 159-172
https://doi.org/10.1016/j.advwatres.2016.10.021
Tsunami wave interaction with mangrove forests: A 3-D numerical approach.
Maza, M, Lara, J.L., & Losada, I.J. (2015)
Coastal Engineering. Vol.98, pp. 33-54
https://doi.org/10.1016/j.coastaleng.2015.01.002
## Code integration
- Initial code supplied in commits e0682d67 and 2124eb88; and integrated into OpenFOAM by OpenCFDv1712AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/173WIP: Style dashed options2019-11-08T15:47:04ZMark OLESENWIP: Style dashed optionsv1806AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/203WIP: Style code style2019-11-08T15:48:10ZMark OLESENWIP: Style code stylev1812AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/244WIP: Feature euler euler solvers. Integration of Euler solvers.2020-07-13T17:38:14ZSergio FerrarisWIP: Feature euler euler solvers. Integration of Euler solvers.### Summary
New chtMultiRegionTwoPhaseEulerFoam solver, plus corresponding BC's
Integrated MULES and CMULES new interfaces and the corresponding multiphase solvers
multiphase tutorials not tested/updated
New library src/phaseSystemModels...### Summary
New chtMultiRegionTwoPhaseEulerFoam solver, plus corresponding BC's
Integrated MULES and CMULES new interfaces and the corresponding multiphase solvers
multiphase tutorials not tested/updated
New library src/phaseSystemModels for all the phases systems, sub-models, BC's, turbulence. This
lib was taken out of the Euler solvers and located on /src
This branch was not rebased on the latest develop as it needs several more updates first
(including headers).
Work to do:
1) Review latest form org for the phases modeling.
2) Review latest tutorial entries
### Details of new models (If applicable)
chtMultiRegionTwoPhaseEulerFoam and the extended alphaBoilingWall BC is designed to deal
with several cooling regimes:
single phase
subcooled nucleate wall boiling
transitional boiling
film boiling.
The wall function uses a partition method to transfer heat either
to the liquid or vapor phase. At the moment, this function works
in a wall temperature fixed mode. i.e, there is no consideration
for the sudden change of heat transfer coefficient (htc) after
reaching TDBN (deviation from nucleate boiling temperature)
More details on alphatWallBoilingWallFunctionFvPatchScalarField.C
### Risks
Need to test all the multiphase tutorials due to significant changes from the last year
and some changes this year from org. This should be done when the merge is completed.v1906AdminAdminhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/328WIP: Revisiting analytical eigen decompositions and polynomialEqns2020-01-17T21:07:33ZKutalmış BerçinWIP: Revisiting analytical eigen decompositions and polynomialEqnsv2006Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/323WIP: ENH: add 'outputCoeffs' and 'extendedOutput' options to forceCoeffs2020-01-17T21:07:23ZKutalmış BerçinWIP: ENH: add 'outputCoeffs' and 'extendedOutput' options to forceCoeffsENH: add 'extendedOutput' option that allows to output all constitutents
of all force coefficients, i.e. total, pressure, viscous, and porous
ENH: add 'outputCoeffs' option to allow to select coefficients to output
...ENH: add 'extendedOutput' option that allows to output all constitutents
of all force coefficients, i.e. total, pressure, viscous, and porous
ENH: add 'outputCoeffs' option to allow to select coefficients to output
ENH: remove redundant computations for porosity constituent when the option
porosity=false
DOC: improve header file and function declaration docs
BAKW: test backward compatibility and functionality in comparison to
v1906 by using `simpleFoam/motorBike` and `simpleFoam/bump2D`.
Tests have involved:
- Serial runs
- Parallel runs
- Serial restart
- Parallel restart
- Only binData = on (parallel)
- Only writeFields = on (parallel)
- Only extendedOutput = on (parallel)
- binData and extendedOutput = on (parallel)
- writeFields and extendedOutput = on (parallel)
- outputCoeffs and extendedOutput = on for arbitrarily chosen
(Cd CmRoll Cl) (parallel and serial)v2006Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/318ENH: improve BinSum container, and Test-BinSum app2020-01-17T21:07:16ZKutalmış BerçinENH: improve BinSum container, and Test-BinSum app```
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
``````
BUG: protect against non-scalar or non-sum template specialisations
DOC: improve header/func docs
ENH: test Binsum constructors and member funcs
```v2006Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/381ENH: yPlus: add option to disable wall function contributions (#1773)2020-09-24T16:31:09ZKutalmış BerçinENH: yPlus: add option to disable wall function contributions (#1773)### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix...### Summary
See the self-explanatory commit messages.
### Resolved bugs (If applicable)
#1773
### Details of new models (If applicable)
Small test cases: [GL1773-pre-fix.zip](/uploads/55a0e0a9f20b72222d7f1710a1f742d9/GL1773-pre-fix.zip) vs [GL1773-post-fix](/uploads/6e82b41f337cf0b251280bffb0eb9b9d/GL1773-post-fix.zip)
Test-case characteristics:
* One-dimensional smooth-wall plane channel flow, ReTau=5200
* Number of cells = 20
* nu = 0.000192827 \[m2/s\]
* The case was designed to produce => -1\*sqrt(mag(wallShearStress)) = 1
* The y1+ set (expected) = {0.05, 0.5, 1, 5, 10, 20, 30, 50, 100, ~~1000~~}
* kOmegaSST/SpalartAllmaras, simpleFoam
Main field of interest:
* mag(wallShearStress) function object returns \~ 1 for all test cases, therefore the expected y1+
* yPlus function object (min) results for `lowerWall` rounded up to 2 decimals:
### y1+ = 0.05:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.12** | 0.05 |
| nutkWallFunction | **0.00025** | 0.05 |
| nutUSpaldingWallFunction | 0.05 | 0.05 |
| nutUBlendedWallFunction | 0.05 | 0.05 |
| nutLowReWallFunction | 0.05 | 0.05 |
### y1+ = 0.5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.18** | 0.50 |
| nutkWallFunction | **0.025** | 0.50 |
| nutUSpaldingWallFunction | 0.50 | 0.50 |
| nutUBlendedWallFunction | 0.50 | 0.50 |
### y1+ = 1:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **0.34** | 1.00 |
| nutkWallFunction | **0.1** | 1.00 |
| nutUSpaldingWallFunction | 1.00 | 1.00 |
| nutUBlendedWallFunction | 1.00 | 1.00 |
### y1+ = 5:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **3.02** | 5.00 |
| nutkWallFunction | **2.75** | 5.00 |
| nutUSpaldingWallFunction | 5.00 | 5.00 |
| nutUBlendedWallFunction | 5.00 | 5.00 |
### y1+ = 10:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | **9.12** | 10.00 |
| nutkWallFunction | **8.31** | 10.00 |
| nutUSpaldingWallFunction | 10.00 | 10.00 |
| nutUBlendedWallFunction | 10.00 | 10.00 |
### y1+ = 20:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 20.00 | 20.02 |
| nutkWallFunction | **19.30** | 20.01 |
| nutUSpaldingWallFunction | 20.00 | 20.00 |
| nutUBlendedWallFunction | 20.00 | 20.01 |
### y1+ = 30:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 30.09 | 30.09 |
| nutkWallFunction | 29.91 | 30.12 |
| nutUSpaldingWallFunction | 30.08 | 30.08 |
| nutUBlendedWallFunction | 30.09 | 30.09 |
### y1+ = 50:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 50.16 | 50.16 |
| nutkWallFunction | 50.51 | 50.19 |
| nutUSpaldingWallFunction | 50.17 | 50.17 |
| nutUBlendedWallFunction | 50.16 | 50.16 |
### y1+ = 100:
| Wall function | Pre-fix yPlus | Post-fix yPlus (when `useWallFunction=false`) |
| --- | ------ |---------:|
| nutUWallFunction | 100.01 | 100.01 |
| nutkWallFunction | 100.96 | 100.01 |
| nutUSpaldingWallFunction | 100.01 | 100.01 |
| nutUBlendedWallFunction | 100.01 | 100.01 |
### Risks
- Compiled with Gcc-7.4.1/Clang-9.0, DPInt32Opt
- No regression issue: [1-pre-fix-yPlus.zip](/uploads/213187624c831a9322790f83da09bd95/1-pre-fix-yPlus.zip) vs [2-post-fix-yPlus.zip](/uploads/f8ee035a427a3c7ea2fefb5d38a40609/2-post-fix-yPlus.zip) (Test: `incompressible/pisoFoam/RAS/cavity`)
- No changes in the default behaviour.
- User can now select the new behaviour by `useWallFunction=false` which is by default `true`.v2012Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/517Draft: ENH: PatchInjectionModel - added new parcel initial velocity options2021-12-14T14:15:55ZAndrew HeatherDraft: ENH: PatchInjectionModel - added new parcel initial velocity optionsThe parcel initial velocity can now be set using the new `velocityType`
entry, taking one of the following options:
- fixedValue : (default) same as earlier versions, requires U0
- patchValue : velocity set to seed patch face value
...The parcel initial velocity can now be set using the new `velocityType`
entry, taking one of the following options:
- fixedValue : (default) same as earlier versions, requires U0
- patchValue : velocity set to seed patch face value
- zeroGradient : velocity set to seed patch face adjacent cell value
Example usage:
model1
{
type patchInjection;
massTotal 1;
SOI 0;
parcelBasisType mass;
patch cylinder;
duration 10;
parcelsPerSecond 100;
velocityType patchValue;
//velocityType zeroGradient;
//U0 (-10 0 0);
flowRateProfile constant 1;
sizeDistribution
{
type normal;
normalDistribution
{
expectation 1e-3;
variance 1e-4;
minValue 1e-5;
maxValue 2e-3;
}
}
}
See the new $FOAM_TUTORIALS/lagrangian/kinematicParcelFoam/spinningDisk tutorialv2112https://develop.openfoam.com/Development/openfoam/-/merge_requests/594Draft: use sparse storage and data exchange for PstreamBuffers2023-06-22T12:22:33ZMark OLESENDraft: use sparse storage and data exchange for PstreamBuffersChanges the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.Changes the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.v2306Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/625defunct: Add error handling for empty surfaces in surfaceFieldValue (#2966)2023-12-12T16:50:30ZMark OLESENdefunct: Add error handling for empty surfaces in surfaceFieldValue (#2966)- defunct merge-request. Items were merged via !627- defunct merge-request. Items were merged via !627v2312Andrew HeatherAndrew Heatherhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/526Draft: Resolve "ENH: cyclicACMI have optional search distance"2022-06-01T08:14:25ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "ENH: cyclicACMI have optional search distance"Closes #2378Closes #2378Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/514Draft: Resolve "patchProbes output original point and distance"2021-12-09T08:56:46ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "patchProbes output original point and distance"Closes #2291Closes #2291Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/513Draft: Resolve "patchProbes output original point and distance"2021-12-09T08:56:39ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comDraft: Resolve "patchProbes output original point and distance"Closes #2291Closes #2291Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/merge_requests/506turbulentTemperatureRadCoupledMixed allow Function1 for kappa2021-12-02T08:53:16ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comturbulentTemperatureRadCoupledMixed allow Function1 for kappa### Summary
- allow PatchFunction1 for kappa, alpha
- allow PatchFunction for thicknessLayer, kappaLayer
### Resolved bugs (If applicable)
#2277
### Risks
New keyword:
'kappaLayer', 'thicknessLayer' to specify a PatchFunction1 fo...### Summary
- allow PatchFunction1 for kappa, alpha
- allow PatchFunction for thicknessLayer, kappaLayer
### Resolved bugs (If applicable)
#2277
### Risks
New keyword:
'kappaLayer', 'thicknessLayer' to specify a PatchFunction1 for additional resistance.Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/merge_requests/423Two new overset solvers2021-02-19T05:08:31ZSergio FerrarisTwo new overset solversTwo new overset solvers: overInterPhaseChangeDyMFoam and overCompressibleInterDyMFoam and their respective tutorials. A variation of the two simple rotors.Two new overset solvers: overInterPhaseChangeDyMFoam and overCompressibleInterDyMFoam and their respective tutorials. A variation of the two simple rotors.https://develop.openfoam.com/Development/openfoam/-/merge_requests/421WIP: ENH: fixedNormalSlip BC: add 'value' keyword (#1980,#1981)2021-04-15T14:22:30ZKutalmış BerçinWIP: ENH: fixedNormalSlip BC: add 'value' keyword (#1980,#1981)DOC: improve header-file contentDOC: improve header-file contentAndrew HeatherAndrew Heather