Development issueshttps://develop.openfoam.com/groups/Development/-/issues2018-02-22T12:16:37Zhttps://develop.openfoam.com/Development/openfoam/-/issues/739avoid implicit conversion of string to regExp in string-list matching2018-02-22T12:16:37ZMark OLESENavoid implicit conversion of string to regExp in string-list matchingCurrently have this type of code:
labelList findStrings(const std::string& re, const UList<StringType>& lst, const bool invert=false)
{
const regExp matcher(re);
return findMatchingStrings(matcher, lst, invert);
...Currently have this type of code:
labelList findStrings(const std::string& re, const UList<StringType>& lst, const bool invert=false)
{
const regExp matcher(re);
return findMatchingStrings(matcher, lst, invert);
}
This means that the seeming innocuous call
findStrings(someWord, listOfString);
actually incurs an additional regExp allocation and then uses this for
performing the match. If the word contains a '.' meta-character, this
could well lead to false positives. In either case, we would be
using the regex matcher when a simple string compare would also work.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/737spray/wall interactions failing in parallel2018-02-22T12:13:56ZMark OLESENspray/wall interactions failing in parallelregression introduced here: f1d42a629b9ed5bda87c6a619f588f2a5d57bd63
@Sergio
- fixedregression introduced here: f1d42a629b9ed5bda87c6a619f588f2a5d57bd63
@Sergio
- fixedMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/729Feature: A new option in systemCall to execute the call with the master proce...2018-02-17T12:47:14ZKutalmış BerçinFeature: A new option in systemCall to execute the call with the master processor onlyIn OpenFOAM 1712, `systemCall` function object can be created and used to execute system calls.
In parallel simulations, however, the same `systemCall` is executed for each processor.
Yet arguably, the usual desire is to make a ***singl...In OpenFOAM 1712, `systemCall` function object can be created and used to execute system calls.
In parallel simulations, however, the same `systemCall` is executed for each processor.
Yet arguably, the usual desire is to make a ***single*** call ***per simulation*** (e.g. sending **an** informative e-mail about the simulation at some point).
Although a shell script wrapping the calls for a single processor should be enough, IMHO, an option which can naturally limit `systemCall` to a single processor might be useful for those who are not familiar with programming.
Kind regardsMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/718snappyHexMesh labelledTri error2018-01-31T09:02:27ZvilfayeausnappyHexMesh labelledTri errorHi,
In 1712, wehn running snappyHexMesh, I have a fatal error due to wrong labelledTri size. See attached log file.
In 2.3.1, the same case is working fine.
Best,
Sebastien
[snappyHexMeshDict](/uploads/172f59c6374c7e1c07d86acb9782a13...Hi,
In 1712, wehn running snappyHexMesh, I have a fatal error due to wrong labelledTri size. See attached log file.
In 2.3.1, the same case is working fine.
Best,
Sebastien
[snappyHexMeshDict](/uploads/172f59c6374c7e1c07d86acb9782a138/snappyHexMeshDict)
1712 log file:
[snappyHexMesh_4401168.log](/uploads/746be00dac64cc8770b0a90b9d628a60/snappyHexMesh_4401168.log)
2.3.1 log file:
[snappyHexMesh.4275735.log](/uploads/750bbf0c579eac1f8f8375cde0da41a7/snappyHexMesh.4275735.log)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/709blended factor is written every time step2018-01-29T09:06:06Zvilfayeaublended factor is written every time stepHi,
When using
```
DebugSwitches
{
blendedSchemeBase 1;
}
```
The blended factor is printed every timestep instead of writeControl/Interval.
Best,
SebastienHi,
When using
```
DebugSwitches
{
blendedSchemeBase 1;
}
```
The blended factor is printed every timestep instead of writeControl/Interval.
Best,
Sebastienhttps://develop.openfoam.com/Development/openfoam/-/issues/673scalarRanges from string could be improved2018-01-23T15:54:43ZMark OLESENscalarRanges from string could be improvedAs noted discovered in #672 the creation of scalarRanges from a string uses an Istream for the intermediate tokens and parses through until it hits an error. This fails when the Istream is an ITstream since for that class the eof trig...As noted discovered in #672 the creation of scalarRanges from a string uses an Istream for the intermediate tokens and parses through until it hits an error. This fails when the Istream is an ITstream since for that class the eof triggers an error.
Would be cleanest to pass through the raw string directly create tokens and then walk through them in a normal loop.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/691A truer warning statement in oversetFvPatchField.C2018-01-22T16:16:40ZKutalmış BerçinA truer warning statement in oversetFvPatchField.CHi,
Consider the following code fragment under `oversetFvPatchField.C`:
```
161 else if
162 (
163 !fvSchemes.found("oversetInterpolation")
164 || !fvSchemes.found("oversetInterpolationRequired")...Hi,
Consider the following code fragment under `oversetFvPatchField.C`:
```
161 else if
162 (
163 !fvSchemes.found("oversetInterpolation")
164 || !fvSchemes.found("oversetInterpolationRequired")
165 )
166 {
167 IOWarningInFunction(fvSchemes)
168 << "Missing required dictionary entries"
169 << " 'oversetInterpolation' and 'oversetInterpolationRequired'"
170 << ". Skipping overset interpolation for field "
171 << fldName << endl;
172 }
```
IMHO, "**and**" in line 169 needs to be changed to "**or**", considering "**||**" in line 164.
Many thankshttps://develop.openfoam.com/Development/openfoam/-/issues/676label64 with FULLDEBUG gives problems2018-01-17T13:27:15ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comlabel64 with FULLDEBUG gives problemsWhen doing WM_LABEL_SIZE=64 and WM_COMPILE_OPTION=Debug there is a problem in reading even the initial controlDict. This traces back to UIPstream::readStringFromBuffer where it tries to read zero bytes from the current pointer (&external...When doing WM_LABEL_SIZE=64 and WM_COMPILE_OPTION=Debug there is a problem in reading even the initial controlDict. This traces back to UIPstream::readStringFromBuffer where it tries to read zero bytes from the current pointer (&externalBuf_[externalBufPosition_]).
If that pointer points to one-beyond the end of the buffer the call will fail.
Workaround: do not use pointer in case of zero bytes. Note that it only affects the fulldebug checking; the library routine handles it ok.
E.g.
inline Foam::Istream& Foam::UIPstream::readStringFromBuffer(std::string& str)
{
// Use std::string::assign() to copy content, including '\0'.
// Stripping (when desired) is the responsibility of the sending side.
size_t len;
readFromBuffer(len);
if (len == 0)
{
str.assign(nullptr, len);
}
else
{
str.assign(&externalBuf_[externalBufPosition_], len);
}https://develop.openfoam.com/Development/openfoam/-/issues/688cfMesh : tutorial failing2018-01-08T15:20:10ZPawan GhildiyalcfMesh : tutorial failingHi Mark
@andy @Prashant @Mattijs
I noticed that cfMesh tutorial is failing with latest dev branch . It is happening for all tutorial
i tested. Prashant mentioned that commit of Dec 18 is working fine but with Dec 21
commit, he is...Hi Mark
@andy @Prashant @Mattijs
I noticed that cfMesh tutorial is failing with latest dev branch . It is happening for all tutorial
i tested. Prashant mentioned that commit of Dec 18 is working fine but with Dec 21
commit, he is also seeing this issue.
See log below for this case
cartesianMesh/asmoOctree
>
> Current cell 53393
> --> FOAM FATAL ERROR:
> 0Face 138577 appears in more than 2 cells!!0Face 140334 appears in more than 2 cells!!
> From function --> FOAM FATAL ERROR:
> virtual void Foam::Module::polyMeshGenCells::calculateOwnersAndNeighbours() const
> 0Face 138577 appears in more than 2 cells!!0Face 140334 appears in more than 2 cells!!
> in file utilities/meshes/polyMeshGen/polyMeshGenCells.C at line 147.
>
> FOAM aborting
>
> From function
> virtual void Foam::Module::polyMeshGenCells::calculateOwnersAndNeighbours() const
> in file utilities/meshes/polyMeshGen/polyMeshGenCells.C at line 147.
>
> FOAM aborting"Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/651bug : tutorial failure2018-01-08T15:19:52ZAdminbug : tutorial failuretutorials/heatTransfer/chtMultiRegionFoam/externalCoupledMultiRegionHeater
Failing in latest develop
[log.chtMultiRegionFoam](/uploads/454c0747c05d70b308d39da5fa7182d9/log.chtMultiRegionFoam)
@marktutorials/heatTransfer/chtMultiRegionFoam/externalCoupledMultiRegionHeater
Failing in latest develop
[log.chtMultiRegionFoam](/uploads/454c0747c05d70b308d39da5fa7182d9/log.chtMultiRegionFoam)
@markMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/630LList constructors not explicit2018-01-04T09:15:12ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comLList constructors not explicitFollowing compiles ok:
vectorList n(vector::zero)
goes through linked list constructor (LList with single arg) and back to straight List.Following compiles ok:
vectorList n(vector::zero)
goes through linked list constructor (LList with single arg) and back to straight List.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/659collated: incorrect checking for thread support2017-12-30T21:30:13ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcollated: incorrect checking for thread supportMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/663BUG: checkMesh - cellZone bounding box incorrect2017-12-30T21:29:04ZPrashant SonakarBUG: checkMesh - cellZone bounding box incorrectangledDuct explicit tutorial in develop branch
- gives incorrect min bounding box limit
```
CellZone Cells Points BoundingBox
inlet 6000 7056 ( -0.15 0 -0.025) (0 0.0353553 0.025)
poro...angledDuct explicit tutorial in develop branch
- gives incorrect min bounding box limit
```
CellZone Cells Points BoundingBox
inlet 6000 7056 ( -0.15 0 -0.025) (0 0.0353553 0.025)
porosity 8000 15876 ( -0.15 0 -0.025) (0.0707107 0.106066 0.025)
outlet 8000 24696 ( -0.15 0 -0.025) (0.141421 0.176777 0.025)
```v1712Prashant SonakarPrashant Sonakarhttps://develop.openfoam.com/Development/openfoam/-/issues/685BUG: incorrect dimensions for pressureTools2017-12-30T21:27:47ZPrashant SonakarBUG: incorrect dimensions for pressureToolsThe attached case replicates the issue.
- dimensions are incorrect for second iteration.
[cavity.tgz](/uploads/484b28a50405eb27e12492834fb953fb/cavity.tgz)
@Sergio @andy @MattijsThe attached case replicates the issue.
- dimensions are incorrect for second iteration.
[cavity.tgz](/uploads/484b28a50405eb27e12492834fb953fb/cavity.tgz)
@Sergio @andy @Mattijshttps://develop.openfoam.com/Development/openfoam/-/issues/687foamToVTK requires system/faSchemes2017-12-30T21:27:06ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comfoamToVTK requires system/faSchemesfoamToVTK on any case:
--> FOAM FATAL ERROR:
cannot find file ".../system/faSchemes"
(foamToEnsight is ok)
foamToVTK on any case:
--> FOAM FATAL ERROR:
cannot find file ".../system/faSchemes"
(foamToEnsight is ok)
Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/682COMP : missing make files for heatTransferCoeff function object2017-12-28T04:51:51ZAdminCOMP : missing make files for heatTransferCoeff function objectMissing
heatTransferCoeff/heatTransferCoeff.C
heatTransferCoeff/heatTransferCoeffModels/fixedReferenceTemperature/fixedReferenceTemperature.C
heatTransferCoeff/heatTransferCoeffModels/localReferenceTemperature/localReferenceTemperature...Missing
heatTransferCoeff/heatTransferCoeff.C
heatTransferCoeff/heatTransferCoeffModels/fixedReferenceTemperature/fixedReferenceTemperature.C
heatTransferCoeff/heatTransferCoeffModels/localReferenceTemperature/localReferenceTemperature.C
heatTransferCoeff/heatTransferCoeffModels/heatTransferCoeffModel/heatTransferCoeffModelNew.C
heatTransferCoeff/heatTransferCoeffModels/heatTransferCoeffModel/heatTransferCoeffModel.C
heatTransferCoeff/heatTransferCoeffModels/ReynoldsAnalogy/ReynoldsAnalogy.C
in Make/files
@andyhttps://develop.openfoam.com/Development/openfoam/-/issues/347surfaceCheck - no outputThreshold option2017-12-22T15:34:47ZMatej FormansurfaceCheck - no outputThreshold optionThe source code of surfaceCheck lists the -outputThreshold option, but the utility is not compiled with the option available.
surfaceCheck returns: Invalid option: -outputThreshold
(both master and develop trees)The source code of surfaceCheck lists the -outputThreshold option, but the utility is not compiled with the option available.
surfaceCheck returns: Invalid option: -outputThreshold
(both master and develop trees)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/680decomposition fails with faMesh2017-12-22T11:54:11ZMark OLESENdecomposition fails with faMeshRunning the wolfsgrube avalanche tutorial. Decomposing with 4 proc OK.
Decomposing with hierarchical (4 4 1)
--> FOAM FATAL ERROR:
Impossible processor label 757738797for face 8
From function Finite area mesh decompositio...Running the wolfsgrube avalanche tutorial. Decomposing with 4 proc OK.
Decomposing with hierarchical (4 4 1)
--> FOAM FATAL ERROR:
Impossible processor label 757738797for face 8
From function Finite area mesh decomposition
in file faMeshDecomposition.C at line 223.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/666Include additional packs in foamConfigurePaths2017-12-21T16:02:06ZRoger AlmenarInclude additional packs in foamConfigurePathsSome packages are missing:
-KaHIP
-gperftoolsSome packages are missing:
-KaHIP
-gperftoolsv1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/678fftw compile problem in single-precision2017-12-21T15:59:45ZMark OLESENfftw compile problem in single-precisionv1712Mark OLESENMark OLESEN