Development issueshttps://develop.openfoam.com/groups/Development/-/issues2017-06-29T20:38:04Zhttps://develop.openfoam.com/Development/openfoam/-/issues/480pointConstraints don't handle coupled points on inside of patch2017-06-29T20:38:04ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.compointConstraints don't handle coupled points on inside of patchThe constraint mechanism (for point motion) assumes that all coupled points are on the outside of 'normal' patches. Very occasionally this is not the case and it causes out-of-bounds access to the list of constraints (patchPatchPointCons...The constraint mechanism (for point motion) assumes that all coupled points are on the outside of 'normal' patches. Very occasionally this is not the case and it causes out-of-bounds access to the list of constraints (patchPatchPointConstraints_)Version v1706https://develop.openfoam.com/Development/openfoam/-/issues/467Feature: histogram FO2017-06-29T20:38:04ZPrashant SonakarFeature: histogram FOenhancements ref : EP#384enhancements ref : EP#384Version v1706Prashant SonakarPrashant Sonakarhttps://develop.openfoam.com/Development/openfoam/-/issues/470surfaceMeshTriangulate does not handle - time selection - moving meshes2017-06-29T20:38:04ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsurfaceMeshTriangulate does not handle - time selection - moving meshesVersion v1706Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/466mesh quality visualisation2017-06-29T20:38:04ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.commesh quality visualisationTicket to output mesh quality parameters using checkMesh.Ticket to output mesh quality parameters using checkMesh.Version v1706Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/463BUG: sampling with optional entry zones - issue in parallel running2017-06-29T20:38:04ZPrashant SonakarBUG: sampling with optional entry zones - issue in parallel runningAttached case (modified tutorial) where sampling plane is restricted to cell zone. [angledDuct_parallel.tgz](/uploads/e24eee115a31244cd392d2111f7f49d5/angledDuct_parallel.tgz)
- works OK if serial
- produces invalid results (vtk) in p...Attached case (modified tutorial) where sampling plane is restricted to cell zone. [angledDuct_parallel.tgz](/uploads/e24eee115a31244cd392d2111f7f49d5/angledDuct_parallel.tgz)
- works OK if serial
- produces invalid results (vtk) in parallel
@Mattijs @markVersion v1706https://develop.openfoam.com/Development/openfoam/-/issues/460odd sizing for hash tables.2017-06-29T20:38:04ZMark OLESENodd sizing for hash tables.Came across a few odd things, especially when copy/copy-constructing from other hash tables.
* HashPtrTable copy from HashPtrTable: uses default size, not related to what it is copying
* HashTable from initializer_list uses list size, n...Came across a few odd things, especially when copy/copy-constructing from other hash tables.
* HashPtrTable copy from HashPtrTable: uses default size, not related to what it is copying
* HashTable from initializer_list uses list size, not 2*list size for its table
* HashSet from HashTable uses number of keys, not the table size.Version v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/462BUG: Several tutorial failures after commit 2d036ca002017-06-29T20:38:04ZAdminBUG: Several tutorial failures after commit 2d036ca00With the change in behaviour of the inverseDistanceDiffusivity (commit 2d036ca00) to use a run-time selectable wall distance, users are now required to add wall dist construction info into the fvSchemes dictionary. Also, the computed dif...With the change in behaviour of the inverseDistanceDiffusivity (commit 2d036ca00) to use a run-time selectable wall distance, users are now required to add wall dist construction info into the fvSchemes dictionary. Also, the computed diffusivity has dimensions of 1/m as opposed to dimensionless.
Tutorials:
```
heatTransfer/buoyantBoussinesqSimpleFoam/iglooWithFridges:
log.snappyHexMesh: keyword patchDist is undefined in dictionary "system/fvSchemes": fvSchemes
mesh/moveDynamicMesh/SnakeRiverCanyon:
log.moveDynamicMesh: keyword patchDist is undefined in dictionary "system/fvSchemes": fvSchemes
mesh/moveDynamicMesh/relativeMotion/box2D_moveDynamicMesh:
log.moveDynamicMesh: keyword patchDist is undefined in dictionary "system/fvSchemes": fvSchemes
multiphase/potentialFreeSurfaceDyMFoam/oscillatingBox:
log.potentialFreeSurfaceDyMFoam: keyword patchDist is undefined in dictionary "system/fvSchemes": fvSchemes
```Version v1706https://develop.openfoam.com/Development/openfoam/-/issues/458FixedList '<' operator using a template parameter2017-06-29T20:38:04ZMark OLESENFixedList '<' operator using a template parameterCannot use comparison of list sizes. Okay for UList, but not here.
- noticing the `operator==` method immediately above, should probably also short-circuit the first time `equal` becomes false.
This won't matter much for fixed lists t...Cannot use comparison of list sizes. Okay for UList, but not here.
- noticing the `operator==` method immediately above, should probably also short-circuit the first time `equal` becomes false.
This won't matter much for fixed lists that would generally have small sizes, but same issue in UILList.C and UList.CVersion v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/452paraFoam inside processor directory always looks for parent2017-06-29T20:38:04ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comparaFoam inside processor directory always looks for parentI've got a processor directory and put a system/ directory in it so it is self-contained. I cannot run paraFoam on it since it looks for ../system/controlDict.
This is a tiny issue since I can just softlink the system to the parent dire...I've got a processor directory and put a system/ directory in it so it is self-contained. I cannot run paraFoam on it since it looks for ../system/controlDict.
This is a tiny issue since I can just softlink the system to the parent directory.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/454refineWallLayer does not run in parallel2017-06-29T20:38:04ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comrefineWallLayer does not run in parallelAt first sight there should be no problem with parallel operation.At first sight there should be no problem with parallel operation.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/453SnappyHexMesh writeFlags error - addedCells not written2017-06-29T20:38:04ZMatej FormanSnappyHexMesh writeFlags error - addedCells not writtenfrom 1612+ when running SHM with:
```
// Write flags
writeFlags
(
layerSets
);
```
Snappy will write to the Info stream:
```
Writing 5328 added cells to cellSet addedCells
Writing 2668 faces inside added layer to faceSet layerFace...from 1612+ when running SHM with:
```
// Write flags
writeFlags
(
layerSets
);
```
Snappy will write to the Info stream:
```
Writing 5328 added cells to cellSet addedCells
Writing 2668 faces inside added layer to faceSet layerFaces
```
This is from iglooWithFridges tutorial, but the sets are actually never written.
The same story for motorBike.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/439Checking to see if the function object is time-based sub-optimal2017-06-29T20:38:04ZAdminChecking to see if the function object is time-based sub-optimalIn `functionObjectList` explicit checks on whether the input dictionary includes the entries `writeControl` or `outputControl` are used to determine whether to instantiate a time-based or plain- function object. This misses local entrie...In `functionObjectList` explicit checks on whether the input dictionary includes the entries `writeControl` or `outputControl` are used to determine whether to instantiate a time-based or plain- function object. This misses local entries used by the `timeControl` class, e.g. `timeStart` and `timeEnd` which are independent of the `*Control` entries.
Suggest moving the logic into the class that knows whether or not the dict will be used to create a time-based function object (or not)Version v1706https://develop.openfoam.com/Development/openfoam/-/issues/450handle multiple surfaces and self-interesection2017-07-03T07:19:53ZMark OLESENhandle multiple surfaces and self-interesectionRef: https://exchange.openfoam.com/node/293
- allow loading of multiple surfaces
- handle self-intersection
@Prashant @Mattijs Ref: https://exchange.openfoam.com/node/293
- allow loading of multiple surfaces
- handle self-intersection
@Prashant @Mattijs Version v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/256remove unneeded lines in list binary output.2017-07-03T07:20:58ZMark OLESENremove unneeded lines in list binary output.Writing an empty list in binary results in unnecessary newlines.Writing an empty list in binary results in unnecessary newlines.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/516foamToVTK produces illegal (binary) files2017-07-04T13:08:27ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comfoamToVTK produces illegal (binary) files[fineMesh.tgz](/uploads/ed96068fdeb0d2f606129fdfdf5a321b/fineMesh.tgz)
I did
- lid driven cavity
- in setSet:
cellSet c0 new labelToCell ( 10 12 5)
cellSet c1 new cellToCell c0
cellSet c1 invert
- foamToVTK -cellSet c0
- foamToVTK -cel...[fineMesh.tgz](/uploads/ed96068fdeb0d2f606129fdfdf5a321b/fineMesh.tgz)
I did
- lid driven cavity
- in setSet:
cellSet c0 new labelToCell ( 10 12 5)
cellSet c1 new cellToCell c0
cellSet c1 invert
- foamToVTK -cellSet c0
- foamToVTK -cellSet c1
and VTK/c0_0.vtk is unreadable. c1_0 is fine.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/520consolidate table bounding2017-07-08T09:14:05ZMark OLESENconsolidate table boundingduplicate or nearly duplicate older code for handling table bounds. Can use Enum instead.duplicate or nearly duplicate older code for handling table bounds. Can use Enum instead.v1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/513consolidate arch and version strings2017-07-08T09:16:54ZMark OLESENconsolidate arch and version stringsv1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/479non-virtual methods on streams2017-07-08T09:17:18ZMark OLESENnon-virtual methods on streamsOFstream::name() and IFstream::name() are (intentionally/non-intentionally?) non-virtual.
- Implemented as virtual in Istream, ISstream, Ostream, OSstream, but not in IFstream, OFstream, ITstream.OFstream::name() and IFstream::name() are (intentionally/non-intentionally?) non-virtual.
- Implemented as virtual in Istream, ISstream, Ostream, OSstream, but not in IFstream, OFstream, ITstream.v1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/512cleanup construction selectors2017-07-10T12:42:23ZMark OLESENcleanup construction selectorsCan use `auto` with that hashtable `cfind` for simpler looking code.Can use `auto` with that hashtable `cfind` for simpler looking code.v1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/521should remove old special treatment for 'include' keyword2017-07-11T13:02:43ZMark OLESENshould remove old special treatment for 'include' keywordprior to the addition of the `#include` dictionary directive (with OpenFOAM 1.5) the special `include` keyword was used. This has been left in since then (for backward compatibility), but I think that it can finally be removed.
Votes pl...prior to the addition of the `#include` dictionary directive (with OpenFOAM 1.5) the special `include` keyword was used. This has been left in since then (for backward compatibility), but I think that it can finally be removed.
Votes please:
@andy @Mattijs @Sergiov1712Mark OLESENMark OLESEN