Development issueshttps://develop.openfoam.com/groups/Development/-/issues2018-06-20T12:06:29Zhttps://develop.openfoam.com/Development/openfoam/-/issues/888bad indexing in regionSizeDistribution function object2018-06-20T12:06:29ZMark OLESENbad indexing in regionSizeDistribution function objectnoted by @Prashantnoted by @Prashantv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/868fragile ensight surface reader2018-12-11T10:42:03ZMark OLESENfragile ensight surface readerexpects the following only:
model: 1 xxx.000.mesh
which means that any of the following (correct input) will break it:
model: xxx.000.mesh
model: data/000/geomexpects the following only:
model: 1 xxx.000.mesh
which means that any of the following (correct input) will break it:
model: xxx.000.mesh
model: data/000/geomv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/726Adjustments for hashset hashtable2018-02-22T12:17:02ZMark OLESENAdjustments for hashset hashtableCurrently have one and two parameter non-const versions of operator() - should be possible to combine using a forwarding variadic. To avoid ambiguities it would be advisable to restrict const access to the dedicated lookup method.
Explic...Currently have one and two parameter non-const versions of operator() - should be possible to combine using a forwarding variadic. To avoid ambiguities it would be advisable to restrict const access to the dedicated lookup method.
Explicitly delete the inherited operator() in hashset instead of relying on masking. v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/781Change default flag for lagrangian post-processing in paraview2018-05-15T10:22:04ZRoger AlmenarChange default flag for lagrangian post-processing in paraviewRequest to change the default flag under $FOAM_ETC/controlDict
```
// Write lagrangian "positions" file in v1706 format (at earlier)
writeLagrangianPositions 0;
```
from 0 to 1. Otherwise it is not possible to post-process lagrangian...Request to change the default flag under $FOAM_ETC/controlDict
```
// Write lagrangian "positions" file in v1706 format (at earlier)
writeLagrangianPositions 0;
```
from 0 to 1. Otherwise it is not possible to post-process lagrangian cases in Paraview, loading directly the OpenFOAM case.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/680decomposition fails with faMesh2017-12-22T11:54:11ZMark OLESENdecomposition fails with faMeshRunning the wolfsgrube avalanche tutorial. Decomposing with 4 proc OK.
Decomposing with hierarchical (4 4 1)
--> FOAM FATAL ERROR:
Impossible processor label 757738797for face 8
From function Finite area mesh decompositio...Running the wolfsgrube avalanche tutorial. Decomposing with 4 proc OK.
Decomposing with hierarchical (4 4 1)
--> FOAM FATAL ERROR:
Impossible processor label 757738797for face 8
From function Finite area mesh decomposition
in file faMeshDecomposition.C at line 223.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/706Fix regressions introduced by #6862018-04-06T10:41:16ZMark OLESENFix regressions introduced by #686v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/711sixDoFRigidBodyState function object not built2019-12-09T22:18:10ZAdminsixDoFRigidBodyState function object not builtAs title - code also requires further integration updates re: `writeFile` class usage and would benefit from using enums for angle typesAs title - code also requires further integration updates re: `writeFile` class usage and would benefit from using enums for angle typesv1806https://develop.openfoam.com/Development/openfoam/-/issues/860foamLog extract min, max, avg2021-07-06T12:57:16ZMark OLESENfoamLog extract min, max, avg- can currently only extract min value (EP 690), and foamLog is not sophisticated enough to handle arbitrary parsing.
- adjust AMI reporting as `min = ... max = ...` instead of `min/max/average = ...` for easier parsing.
@Prashant- can currently only extract min value (EP 690), and foamLog is not sophisticated enough to handle arbitrary parsing.
- adjust AMI reporting as `min = ... max = ...` instead of `min/max/average = ...` for easier parsing.
@Prashantv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/679redistributePar fails for faMesh2020-01-07T16:32:23ZMark OLESENredistributePar fails for faMeshv1806Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/issues/867Medium Test - 12.06.20182019-12-09T22:18:11ZPrashant SonakarMedium Test - 12.06.2018All cases could be accessed at: /home/alex4/prashant/SUPPORT/ESI/MEDIUM_TEST/tutorials_1806
- [x] DNS/dnsFoam/boxTurb16 - solver crash
- [x] IO/fileHandler/machineA/fileHandler - re-verify if we need `cp -r` while copying constant, line ...All cases could be accessed at: /home/alex4/prashant/SUPPORT/ESI/MEDIUM_TEST/tutorials_1806
- [x] DNS/dnsFoam/boxTurb16 - solver crash
- [x] IO/fileHandler/machineA/fileHandler - re-verify if we need `cp -r` while copying constant, line 36; 90 of Allrun
- [x] combustion/PDRFoam/flamePropagationWithObstacles - solver crash
- [x] mesh/foamyHexMesh/mixerVessel - solver crash
- [x] compressible/rhoSimpleFoam/gasMixing/injectorPipe - solver crash
- [x] compressible/sonicFoam/RAS/nacaAirfoil - solver crash
- [x] incompressible/pimpleFoam/LES/vortexShed - surface noise failed 'expected word error'
- [x] multiphase/compressibleInterFoam/laminar/climbingRod - solver failure
- [x] multiphase/driftFluxFoam/RAS/dahl - solver failure
- [x] multiphase/reactingTwoPhaseEulerFoam/RAS/LBend - solver failure
- [x] multiphase/compressibleInterFoam/laminar/depthCharge2D - solver failure
- [x] multiphase/interFoam/RAS/DTCHullMoving - solver failure
- [ ] ~~multiphase/interFoam/RAS/DTCHullWave - decomposePar failure 'missing entry value'~~ REMOVED
- [x] multiphase/interFoam/RAS/motorBike - rename solver in controlDict_nextWrite
- [x] multiphase/interFoam/laminar/vofToLagrangian/lagrangian* - both cases replace combustionModel type noCombustion to none
@andy @Mattijs @Sergio @markv1806https://develop.openfoam.com/Development/openfoam/-/issues/701Missing info in header file2020-01-03T11:31:50ZRoger AlmenarMissing info in header fileFile: velocityDampingConstraint.H.
selectionMode is missing from the header file information, and it is required by the solver, otherwise it will crash. User should set it, like in "selectionMode all;"File: velocityDampingConstraint.H.
selectionMode is missing from the header file information, and it is required by the solver, otherwise it will crash. User should set it, like in "selectionMode all;"v1806https://develop.openfoam.com/Development/openfoam/-/issues/674configuring 3rd party clang and mpfr2018-03-05T15:26:00ZMark OLESENconfiguring 3rd party clang and mpfr- When using third-party compilers, it is currently possible to build gcc with a system or third-party installation of gmp/mpfr. The clang installation does not normally need these. However CGAL does normally build using gmp/mpfr. If the...- When using third-party compilers, it is currently possible to build gcc with a system or third-party installation of gmp/mpfr. The clang installation does not normally need these. However CGAL does normally build using gmp/mpfr. If these are not available on the system, it is also possible to compile without. Eg,
./makeCGAL gmp-none mpfr-none
This mostly solves the problem, but only until the final link stage. The wmake rules for CGAL include `-lmpfr` explicitly. As a workaround, this can be removed, but a better solution may be to check the contents of the CGAL/compiler_config.h for this type of content:
#define CGAL_USE_GMP 1
#define CGAL_USE_MPFR 1
//#define CGAL_USE_GMPXX 1v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/639cleanup autoPtr, tmp, xfer2020-10-20T16:23:38ZMark OLESENcleanup autoPtr, tmp, xfer- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/901system command swallows first argument2018-06-22T14:14:19ZMark OLESENsystem command swallows first argumentThe multi-argument version of Foam::system() inadvertently swallows the first argument.
- Affects dumping of rays (uses objToVTK)
- doxygen browser
- dynamic code (swallows the leading `-s`, meaning that there is additional verbosity)The multi-argument version of Foam::system() inadvertently swallows the first argument.
- Affects dumping of rays (uses objToVTK)
- doxygen browser
- dynamic code (swallows the leading `-s`, meaning that there is additional verbosity)v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/859STYLE: correct syntax in header file of noise.C2019-12-09T22:18:11ZvilfayeauSTYLE: correct syntax in header file of noise.CHi,
Could you update the syntax in the noise.C header file? Headerfile of noise.C and noiseDict should be consistent.
https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/applications/utilities/postProcessing/noise/noise...Hi,
Could you update the syntax in the noise.C header file? Headerfile of noise.C and noiseDict should be consistent.
https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/applications/utilities/postProcessing/noise/noise.C
`// Input file
inputFile "postProcessing/faceSource1/surface/patch/patch.case";
`
should be
`// Input file
files ( "postProcessing/faceSource1/surface/patch/patch.case");
`
Best,
Sebastienv1806https://develop.openfoam.com/Development/openfoam/-/issues/673scalarRanges from string could be improved2018-01-23T15:54:43ZMark OLESENscalarRanges from string could be improvedAs noted discovered in #672 the creation of scalarRanges from a string uses an Istream for the intermediate tokens and parses through until it hits an error. This fails when the Istream is an ITstream since for that class the eof trig...As noted discovered in #672 the creation of scalarRanges from a string uses an Istream for the intermediate tokens and parses through until it hits an error. This fails when the Istream is an ITstream since for that class the eof triggers an error.
Would be cleanest to pass through the raw string directly create tokens and then walk through them in a normal loop.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/705integration for paraview/catalyst2018-07-02T09:38:02ZMark OLESENintegration for paraview/catalystv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/898Adjust derived fields for incompressible2018-07-02T09:33:34ZMark OLESENAdjust derived fields for incompressibleAs tagged on EP645 by @SonVo and discussed with @Prashant - could/should have a `rhoRef` for derived fields in the surfMesh sampler so that `pTotal` and `rhoU` have more physical meanings.As tagged on EP645 by @SonVo and discussed with @Prashant - could/should have a `rhoRef` for derived fields in the surfMesh sampler so that `pTotal` and `rhoU` have more physical meanings.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/904hard-coded name separators in foamCreateVideo2018-07-02T09:39:22ZMark OLESENhard-coded name separators in foamCreateVideo- looks for things like `image.0001.png`, but default Catalyst scripts will generate `image_0001.png`, and with additional amounts of padding (eg, `pressure_00020056.png`) which are needed when generating a higher time resolution visuali...- looks for things like `image.0001.png`, but default Catalyst scripts will generate `image_0001.png`, and with additional amounts of padding (eg, `pressure_00020056.png`) which are needed when generating a higher time resolution visualization.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/907provide separate source tar files for modules2021-07-06T13:05:03ZMark OLESENprovide separate source tar files for modulesSimone @sbna is working with packaging our catalyst module with spack. It is very useful to have the the catalyst adaptor reside outside of the main OpenFOAM source tree and thus be able to combine one particular installation of OpenFOAM...Simone @sbna is working with packaging our catalyst module with spack. It is very useful to have the the catalyst adaptor reside outside of the main OpenFOAM source tree and thus be able to combine one particular installation of OpenFOAM with various ParaView and Catalyst flavours (mpi, mesa, gpu rendering, etc).
For this to package smoothly in spack, EasyBuilder etc, there should be a downloadable tar file to be used when packaging.
I think that Modules-v1806.tar.gz with the identical contents of the `modules/` tree (avalanche, catalyst, cfmesh), would be quite useful. I think that is OK to bundle the three together and have the packager decide which sub-directory is relevant.
@Pawanv1806Andrew HeatherAndrew Heather