Development issueshttps://develop.openfoam.com/groups/Development/-/issues2022-12-13T08:51:32Zhttps://develop.openfoam.com/Development/openfoam/-/issues/2656sampledIsoSurface bug introduced since v21122022-12-13T08:51:32ZLionel GAMETsampledIsoSurface bug introduced since v2112<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
sampledIsoSurface bug introduced since v2112
<!-- Summarize the bug encountered concisely -->
Create a sampledIsoSurface object and apply it to construct the alpha=0.5 isoSurface in a provided example of Spreading Droplet over a flat plate. The isoSurface is different since version v2112.
<!-- How one can reproduce the issue - this is very important -->
Run Provided Spreading droplet case. Look (with paraview / paraFoam) to the isoSurface output in postProcessing/dropletpproc_DEBUG/ at time t=3.9. IsoSurface does not cross anymore the last cell boundary. You need to zoom to that region to see the problem.
<!--
If possible, please create a SMALL example and attach it to your report
If you are using an older version of OpenFOAM this will also determine
whether the bug has been fixed in a more recent version
-->
Attached example of the Spreading Droplet case
<!-- What actually happens -->
The correct behavior can be obtained by running v2106.
<!-- What you should see instead -->
The isoSurface should go accross the last cell containing the gas-liquid interface, at bottom right of the interface.
<!--
Paste any relevant logs - please use code blocks (```) to format console
output, logs, and code as it's very hard to read otherwise.
-->
See attached vtp files
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : Present in v2206|v2112 - But not in v2106
Operating system : CentOS
Hardware info : Xeon Intel Platform
Compiler : gcc|intel|clang any Compiler
- Compiler :
Probably a bug in the sampleIsoSurface class...
<!--
Probably a bug in the
-->[isoInterface_v2106.vtp](/uploads/d0e2d768cf303d92f1a5bcd7e846a6bd/isoInterface_v2106.vtp)
[isoInterface_v2206.vtp](/uploads/1e1d91f1f5250dd39041624c49ab0cb5/isoInterface_v2206.vtp)
[isoInterface_v2112.vtp](/uploads/03094cf69493e67942a7d98b758b4dc1/isoInterface_v2112.vtp)[SpreadingDroplet64.tar](/uploads/55730279cc7cbc5fa6ab6dd54e185eaf/SpreadingDroplet64.tar)Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2655BUG: thermalShell: only T-min/max of the main processor is reported for paral...2022-12-14T11:30:56ZKutalmış BerçinBUG: thermalShell: only T-min/max of the main processor is reported for parallel cases```
Info<< "T min/max = " << min(T_) << ", " << max(T_) << endl;
```
[thermalShell.C#L181](https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/regionFaModels/thermalShell/thermalShell.C#L181)```
Info<< "T min/max = " << min(T_) << ", " << max(T_) << endl;
```
[thermalShell.C#L181](https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/regionFaModels/thermalShell/thermalShell.C#L181)Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2654BUG: velocityFilmShell: restart misses the keyword 'zeroWallVelocity'2022-12-13T12:37:30ZKutalmış BerçinBUG: velocityFilmShell: restart misses the keyword 'zeroWallVelocity'missing the keyword 'zeroWallVelocity_' in [velocityFilmShellFvPatchVectorField.C#L181](https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/regionFaModels/derivedFvPatchFields/filmShell/velocityFilmShellFvPatchVectorFiel...missing the keyword 'zeroWallVelocity_' in [velocityFilmShellFvPatchVectorField.C#L181](https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/regionFaModels/derivedFvPatchFields/filmShell/velocityFilmShellFvPatchVectorField.C#L181)Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2651contactAngleForce: disparate film thicknesses in serial run between v2112 and...2022-12-14T11:31:19ZKutalmış BerçincontactAngleForce: disparate film thicknesses in serial run between v2112 and v2206[(deg=5 + Gamma=31) GL2651.zip](/uploads/2bdcb563e4d83919648d4f43b14a8747/GL2651.zip)
From left to right: v2112 and v2206:
<img src="/uploads/706213b692bdaab0ad9bf438b2d3e566/Screenshot_from_2022-12-06_13-13-53.png" width="50%" height=...[(deg=5 + Gamma=31) GL2651.zip](/uploads/2bdcb563e4d83919648d4f43b14a8747/GL2651.zip)
From left to right: v2112 and v2206:
<img src="/uploads/706213b692bdaab0ad9bf438b2d3e566/Screenshot_from_2022-12-06_13-13-53.png" width="50%" height="50%">
Seems that 8b50f8db252dc3b2d65a5a02f270861839d5e786 (#2451) causes the issue.
@ChiaraKutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2650DiagonalMatrix: clang optimisation upsets the inverse function2022-12-07T13:20:31ZKutalmış BerçinDiagonalMatrix: clang optimisation upsets the inverse functionFor
```
clang version 13.0.1
Target: x86_64-suse-linux-gnu
Thread model: posix
```
The if-block in [DiagonalMatrix.C#L160](https://develop.openfoam.com/Development/openfoam/-/blob/master/src/OpenFOAM/matrices/DiagonalMatrix/DiagonalMat...For
```
clang version 13.0.1
Target: x86_64-suse-linux-gnu
Thread model: posix
```
The if-block in [DiagonalMatrix.C#L160](https://develop.openfoam.com/Development/openfoam/-/blob/master/src/OpenFOAM/matrices/DiagonalMatrix/DiagonalMatrix.C#L160) triggers FPE for `mag(val) < VSMALL`:
```
for (const Type& val : mat)
{
if (mag(val) < VSMALL)
{
*iter = Zero;
}
else
{
*iter = Type(1)/val;
}
++iter;
}
```
The reason is likely that `*iter = Type(1)/val;` and `*iter = Zero;` are evaluated before the condition `mag(val) < VSMALL)`.Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2648wallDist is called every iteration when using vanDriest delta function in tur...2023-10-30T15:50:48ZFlavio GaleazzowallDist is called every iteration when using vanDriest delta function in turbulenceProperties<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
<!-- Summarize the bug encountered concisely -->
The function `wallDist` is called every iteration when using `vanDriest` delta function in `turbulenceProperties`, even if explicitly setting the parameters in fvSchemes, e.g.
```
wallDist
{
method meshWave;
// Optional entry enabling the calculation
// of the normal-to-wall field
nRequired true;
// Optional entry delaying wall distance update to every n steps
// Default is 1 (update every step)
updateInterval 100000;
}
```
This behavior hurts the performance especially in large-scale simulations, using a large number of cores. In some tests we have conducted, almost 50% of the computing time is spent in the `meshWave` function when using more than 1500 cores.
### Steps to reproduce
<!-- How one can reproduce the issue - this is very important -->
It happens when `vanDriest` is selected as `delta` function in `turbulenceProperties`.
### Example case
<!--
If possible, please create a SMALL example and attach it to your report
If you are using an older version of OpenFOAM this will also determine
whether the bug has been fixed in a more recent version
-->
Tutorial case: tutorials/incompressible/pimpleFoam/LES/vortexShed
The calculation of `wallDist` in every time step can be visualized using the corresponding debug switch in `controlDict`
```
DebugSwitches
{
FaceCellWave 1;
}
```
### What is the current *bug* behaviour?
<!-- What actually happens -->
The `wallDist` is called every time step, regardless of the parameters set in the `fvSchemes`, e.g.
```
wallDist
{
method meshWave;
nRequired true;
updateInterval 1000000;
}
```
The behavior does not change if setting `nRequired` to true or false, or changing the `updateInterval` to 0, 5 or 1000000
### What is the expected *correct* behavior?
<!-- What you should see instead -->
I would expect that when setting `updateInterval` to a value greater than 1, that the `wallDist` calculation would be performed only in this interval.
### Relevant logs and/or images
<!--
Paste any relevant logs - please use code blocks (```) to format console
output, logs, and code as it's very hard to read otherwise.
-->
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v2206|v2112|v2106|v2012|v2006 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version : v2206
- Operating system : CentOS/Rocky 8
- Hardware info : AMD EPYC
- Compiler : GCC 10.2
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the
problem
The "/label ~bug" text is a gitlab flag that will add the "bug" label to this
issue
-->v2306Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2645test_openfoam2022-11-26T16:08:30ZElvis Pinzontest_openfoamhttps://develop.openfoam.com/Development/openfoam/-/issues/2640zsh compability for wmake/scripts/sysFunctions2022-12-19T15:51:08ZMarkus Towarazsh compability for wmake/scripts/sysFunctions### Summary
This way of splitting strings does not seem to be ZSH compatible:
https://develop.openfoam.com/Development/openfoam/-/blame/master/wmake/scripts/sysFunctions#L270
leading to errors when searching for libraries (this came...### Summary
This way of splitting strings does not seem to be ZSH compatible:
https://develop.openfoam.com/Development/openfoam/-/blame/master/wmake/scripts/sysFunctions#L270
leading to errors when searching for libraries (this came up for me when looking for scotch-system, where it looks for "libscotch.so .a" which obviously does not exist)
### Steps to reproduce
export SCOTCH_VERSION=scotch-system in etc/config.sh/scotch
run wmake/scripts/have_scotch -debug-test
### Example case
Note how string is not correctly split here: `+findLibrary:58> ext=.a .so`
```
source etc/bashrc
source wmake/scripts/sysFunctions
set -x && findLibrary -prefix="/usr" -name="libfoo"
+zsh:6> findLibrary '-prefix=/usr' '-name=libfoo'
+findLibrary:2> local prefixDir localDir searchDir searchName
+findLibrary:3> local file ext
+findLibrary:5> searchDir=true
+findLibrary:7> [ true '=' true ']'
+findLibrary:7> [ 2 -gt 0 ']'
+findLibrary:9> case -prefix=/usr (-prefix=*)
+findLibrary:11> prefixDir=/usr
+findLibrary:12> shift
+findLibrary:7> [ true '=' true ']'
+findLibrary:7> [ 1 -gt 0 ']'
+findLibrary:9> case -name=libfoo (-prefix=*)
+findLibrary:9> case -name=libfoo (-local=*)
+findLibrary:9> case -name=libfoo (-name=*)
+findLibrary:22> searchName=libfoo
+findLibrary:23> shift
+findLibrary:7> [ true '=' true ']'
+findLibrary:7> [ 0 -gt 0 ']'
+findLibrary:32> [ -n libfoo ']'
+findLibrary:37> : /usr
+findLibrary:38> [ -d /usr ']'
+findLibrary:41> set -- lib lib64 lib/x86_64-linux-gnu lib lib64 lib/x86_64-linux-gnu
+findLibrary:51> [ 0 -gt 1 ']'
+findLibrary:51> shift 3
+findLibrary:55> searchDir=lib
+findLibrary:57> [ -n lib ']'
+findLibrary:58> ext=
+findLibrary:60> file=/usr/lib/libfoo
+findLibrary:61> [ -f /usr/lib/libfoo ']'
+findLibrary:58> ext=.a .so
+findLibrary:60> file='/usr/lib/libfoo.a .so'
+findLibrary:61> [ -f '/usr/lib/libfoo.a .so' ']'
+findLibrary:55> searchDir=lib64
+findLibrary:57> [ -n lib64 ']'
+findLibrary:58> ext=
+findLibrary:60> file=/usr/lib64/libfoo
+findLibrary:61> [ -f /usr/lib64/libfoo ']'
+findLibrary:58> ext=.a .so
+findLibrary:60> file='/usr/lib64/libfoo.a .so'
+findLibrary:61> [ -f '/usr/lib64/libfoo.a .so' ']'
+findLibrary:55> searchDir=lib/x86_64-linux-gnu
+findLibrary:57> [ -n lib/x86_64-linux-gnu ']'
+findLibrary:58> ext=
+findLibrary:60> file=/usr/lib/x86_64-linux-gnu/libfoo
+findLibrary:61> [ -f /usr/lib/x86_64-linux-gnu/libfoo ']'
+findLibrary:58> ext=.a .so
+findLibrary:60> file='/usr/lib/x86_64-linux-gnu/libfoo.a .so'
+findLibrary:61> [ -f '/usr/lib/x86_64-linux-gnu/libfoo.a .so' ']'
+findLibrary:86> return 2
```
### Environment information
- OpenFOAM version : v2112
- Operating system : Debian
- Zsh: zsh 5.7.1
### Possible fixes
I see the following work arounds:
- Refactor string splitting
- If zsh is detected, set bash compability setting "setopt shwordsplit" (locally and reset after or globally in etc/bashrc), or
- Allwmake scripts which use non zsh compatible options are shebanged to /bin/bash instead of /bin/shMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2639allow configurable field send/receive in surfaceNoise2022-11-23T08:15:47ZMark OLESENallow configurable field send/receive in surfaceNoisesimilar pattern as #2402 : cross-ref EP1788
- the ability to switch between nonBlocking and scheduled would be an advantage.
- likely makes sense to reuse the globalIndex handling and avoid PstreamBuffers.similar pattern as #2402 : cross-ref EP1788
- the ability to switch between nonBlocking and scheduled would be an advantage.
- likely makes sense to reuse the globalIndex handling and avoid PstreamBuffers.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2638foamRestoreFields does not handle regions2022-11-25T08:05:19ZMark OLESENfoamRestoreFields does not handle regionscross-ref EP2048cross-ref EP2048Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2637motorBike: snappyHexMesh: increase in cell count2022-12-23T13:52:21ZKutalmış BerçinmotorBike: snappyHexMesh: increase in cell count`$FOAM_TUTORIALS/pisoFoam/LES/motorBike` produces a mesh of considerable difference in cell count when `snappyHexMesh` is executed with 3b0af86448 (develop) vs 76d719d1 (2206):
[log.checkMesh.2206.zip](/uploads/afcbc83f6a92304e6a9f3ac01...`$FOAM_TUTORIALS/pisoFoam/LES/motorBike` produces a mesh of considerable difference in cell count when `snappyHexMesh` is executed with 3b0af86448 (develop) vs 76d719d1 (2206):
[log.checkMesh.2206.zip](/uploads/afcbc83f6a92304e6a9f3ac0190886d8/log.checkMesh.2206.zip)
```
points: 3925080
faces: 10332611
internal faces: 9704338
cells: 3238121
faces per cell: 6.18783
boundary patches: 73 (74 79)
```
vs
[log.checkMesh.develop.zip](/uploads/1bc338633dd293ac732a1f0a0bd2f0be/log.checkMesh.develop.zip)
```
points: 4859321
faces: 12761976
internal faces: 11993902
cells: 3999062
faces per cell: 6.19042
boundary patches: 73 (74 78)
```
@Mattijs @mark @andy @Prashant
Some recent comments made for `snappyHexMesh`:
34d69cad234b2ef5215054205c4276c4f653e42c
f276366a050e99812c5f4fa7e3d0ef13be90c511
c418c28c66a091e3a047f6fd8cb553e1311f4589
5ea365a2be70e216d92fa86b2bb4bfccec887c29
27c3d0c23bbcd11cb1a91cb139dd78d96ec70b5dMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2636pointHistory functionObject creates processor0 directory, even when using col...2022-12-23T16:52:10ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.compointHistory functionObject creates processor0 directory, even when using collated format### Functionality to add/problem to solve
pointHistory in parallel with collated format still creates an (empty) processor0 directory.### Functionality to add/problem to solve
pointHistory in parallel with collated format still creates an (empty) processor0 directory.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2634faceReflecting radiationModel accesses unitialised data (valgrind)2022-11-18T15:03:29ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comfaceReflecting radiationModel accesses unitialised data (valgrind)<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
<!-- Summarize the bug encountered concisely -->
`faceReflecting` radiationModel accesses uninitialised value.
### Steps to reproduce
<!-- How one can reproduce the issue - this is very important -->
Set up any case with faceReflecting.
### Example case
<!--
If possible, please create a SMALL example and attach it to your report
If you are using an older version of OpenFOAM this will also determine
whether the bug has been fixed in a more recent version
-->
`tutorials/heatTransfer/buoyantSimpleFoam/simpleCarSolarPanel`
and run
`valgrind buoyantSimpleFoam`
### What is the current *bug* behaviour?
<!-- What actually happens -->
Tests uninitialised variable. The actual value will not get used though because of additional protection so the simulation proceeds correctly.
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v2206|v2112|v2106|v2012|v2006 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version : v2206
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the
problem
The "/label ~bug" text is a gitlab flag that will add the "bug" label to this
issue
-->
Initialise data to any value:
```
labelList refDirIndex(triangleIndex.size(), -1);
labelList refIndex(triangleIndex.size(), -1);
```Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2631use atomic file creation and updates when writing sampled ensight data2022-11-26T19:06:21ZMark OLESENuse atomic file creation and updates when writing sampled ensight dataIssue raised on EP2007. If, for any reason, the simulation crashes while writing out ensight data, the resulting EnSight case file will very likely reference a truncated or corrupt file (does not make ensight happy).
First change requir...Issue raised on EP2007. If, for any reason, the simulation crashes while writing out ensight data, the resulting EnSight case file will very likely reference a truncated or corrupt file (does not make ensight happy).
First change required is to support an atomic OFstream option. This would create a file with a temporary name and only rename/move it to the final location after all writing is completed. If there is a crash during writing, there will be a few temporary files kicking about, but the expected output (in this case ensight) will not be corrupt.
The next changes would involve adjusting the management of ensight case updates to ensure that only consistent states exist. For the surface writing, this would mean attaching extra behaviour to the beginTime/endTime synchronization points.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2630solidBody motionSolver does not use optional sub dictionary2023-05-30T18:20:15ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsolidBody motionSolver does not use optional sub dictionary<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
<!-- Summarize the bug encountered concisely -->
All motionSolvers should be able to either supply dictionaries inline or in a sub dictionary:
```
motionSolver solidBody;
solidBodyCoeffs
{
cellZone rotor;
solidBodyMotionFunction rotatingMotion;
origin (0 0 0);
axis (0 1 0);
omega 158; // rad/s
}
```
This does not work for solidBody anymore.
### Steps to reproduce
<!-- How one can reproduce the issue - this is very important -->
Attached case.
[testcase-zone-ignored.tgz](/uploads/4ff65b551b1a533d631152b9686bf182/testcase-zone-ignored.tgz)
### What is the current *bug* behaviour?
Does not read the selection of cells from the 'Coeffs' subdictionary. Instead applies motion to whole mesh.
### What is the expected *correct* behavior?
<!-- What you should see instead -->
Same behaviour, independent of dictionary supplied in-line or a a 'solidBodyCoeffs' subdictionary.
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v2206|v2112|v2106|v2012|v2006 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version :v1912 .. v2206
- Operating system :
- Hardware info :
- Compiler :
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the
problem
The "/label ~bug" text is a gitlab flag that will add the "bug" label to this
issue
-->Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2629Tutorial on incompressible RAS eq. and lid-driven cavity not working as expected2023-05-30T18:21:55ZGiorgio GiorgianiTutorial on incompressible RAS eq. and lid-driven cavity not working as expectedRunning pisoFoam on the folder tutorials/incompressible/pisoFoam/RAS/cavity/ (with default input) is expected to run the simulation up to 10s achiving a Courant of ~0.2 max.
However, after time=2.5 the Courant number jumps to 1 and the ...Running pisoFoam on the folder tutorials/incompressible/pisoFoam/RAS/cavity/ (with default input) is expected to run the simulation up to 10s achiving a Courant of ~0.2 max.
However, after time=2.5 the Courant number jumps to 1 and the solution becomes meaningless.
![screens1](/uploads/bf213a5e6908c335ce3831807b355114/screens1.png)
![image](/uploads/f60f5e2348758910c233fffd1702089f/image.png)Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2628Link to source files doesn't work2024-01-10T11:06:28ZTorquil SørensenLink to source files doesn't workWhen using the documentation at https://www.openfoam.com/documentation/guides/latest/api, whenever I click on a link to a source file (*.C), I get a "file not found" web page. E.g, consider the following documentation page:
https://www....When using the documentation at https://www.openfoam.com/documentation/guides/latest/api, whenever I click on a link to a source file (*.C), I get a "file not found" web page. E.g, consider the following documentation page:
https://www.openfoam.com/documentation/guides/latest/api/semiPermeableBaffleMassFractionFvPatchScalarField_8C.html
Under "Detailed Description", there is a link "semiPermeableBaffleMassFractionFvPatchScalarField.C" to https://develop.openfoam.com/Development/OpenFOAM-plus/blob/OpenFOAM-v2112/src/thermoTools/derivedFvPatchFields/semiPermeableBaffle/semiPermeableBaffleMassFraction/semiPermeableBaffleMassFractionFvPatchScalarField.C
But this link doesn't work. I am sent to a "404 page not found" error page.
The same happens when I click on any such link to a *.C-file on any of the documentation pages.
Thankfully, the link further up "Go to the source code of this file" does work.https://develop.openfoam.com/Development/openfoam/-/issues/2627cloud functionObjects not working with collated format2022-11-09T15:32:55ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcloud functionObjects not working with collated format### Functionality to add/problem to solve
In various bits of lagrangian functionObjects it uses a local check to decide if the file needs to be written. This means that processors that hold zero particles never get involved in the IO an...### Functionality to add/problem to solve
In various bits of lagrangian functionObjects it uses a local check to decide if the file needs to be written. This means that processors that hold zero particles never get involved in the IO and this causes problems when using e.g. 'collated' file format.
### Target audience
Lagrangian & parallel & collated file format
### Proposal
Replace checks for `if (c.size())` with a proper parallel decision:
```
const bool haveParticles = c.size();
if (c.time().writeTime() && returnReduce(haveParticles, orOp<bool>()))
{
Nu.write(haveParticles);
}
```
### What does success look like, and how can we measure that?
No hang
Attached a patch that makes the aachenBomb tutorial run through.
[collated_writing.patch](/uploads/857e5685955bec2b84b9ab47795b56a2/collated_writing.patch)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/2626BUG: porousBafflePressure: fixedJump entries are not read2022-11-20T17:22:01ZKutalmış BerçinBUG: porousBafflePressure: fixedJump entries are not readSee the missing `dict` entry in the ctor: [porousBafflePressureFvPatchField.C#L59](https://develop.openfoam.com/Development/openfoam/-/blob/master/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/porousBafflePressure/porousBaff...See the missing `dict` entry in the ctor: [porousBafflePressureFvPatchField.C#L59](https://develop.openfoam.com/Development/openfoam/-/blob/master/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/porousBafflePressure/porousBafflePressureFvPatchField.C#L59)
The entries being not read by `porousBafflePressure` include (but not limited to):
```
jump
jump0
value
minJump
relax
```
```c
jump_(p.size(), Zero),
jump0_(p.size(), Zero),
minJump_(dict.getOrDefault<Type>("minJump", pTraits<Type>::min)),
relaxFactor_(dict.getOrDefault<scalar>("relax", -1)),
timeIndex_(this->db().time().timeIndex())
```Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/2625argList option printing truncates incorrectly2022-11-18T20:24:49ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comargList option printing truncates incorrectly<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
<!-- Summarize the bug encountered concisely -->
### Steps to reproduce
<!-- How one can reproduce the issue - this is very important -->
`mapFieldsPar -help`
outputs
```
-mapMethod <word>
Specify the mapping method
(direct|mapNearest|cellVolumeWeight|correctedCellVolumeWeig
t)
```
(it left out the 'h' in correctedCellVolumeWeight at position 80)
### What is the current *bug* behaviour?
<!-- What actually happens -->
See above
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v2206|v2112|v2106|v2012|v2006 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version : v2206
- Operating system :
- Hardware info :
- Compiler :Mark OLESENMark OLESEN