Development issueshttps://develop.openfoam.com/groups/Development/-/issues2019-12-09T21:29:28Zhttps://develop.openfoam.com/Development/openfoam/-/issues/448added to extendedEdgeMesh fails2019-12-09T21:29:28ZMark OLESENadded to extendedEdgeMesh failsextendedEdgeMesh.C
* lines 1270-1273 -> need sublist to handle zero-sized lists (or segfault)
* line 1274: needs `fem.edgeNormals()` to have the correct size for the looping.
@MattijsextendedEdgeMesh.C
* lines 1270-1273 -> need sublist to handle zero-sized lists (or segfault)
* line 1274: needs `fem.edgeNormals()` to have the correct size for the looping.
@MattijsVersion v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1878add face::copyFace method2020-10-13T12:30:50ZMark OLESENadd face::copyFace methodIdea to replace some repetitive code that occurs when collecting faces from various processors (for example).
Existing code:
```
for (const face& f : allFaces[Pstream::myProcNo()])
{
face& newF = faces[nFaces++];
newF.resize(f.s...Idea to replace some repetitive code that occurs when collecting faces from various processors (for example).
Existing code:
```
for (const face& f : allFaces[Pstream::myProcNo()])
{
face& newF = faces[nFaces++];
newF.resize(f.size());
forAll(f, fp)
{
newF[fp] = f[fp] + nPoints;
}
}
```
With the definition:
```
//- Return a copy of the face with given offset of its labels
inline face copyFace(const label offset) const;
```
This would simplify:
```
for (const face& f : allFaces[Pstream::myProcNo()])
{
faces[nFaces] = f.copyFace(nPoints);
++nFaces;
}
```
Naming similarity to `reverseFace()`Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2591add finite-area support to setFields2022-10-26T07:16:47ZMark OLESENadd finite-area support to setFieldscross-ref EP1960cross-ref EP1960Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/3044add flag to not keep comments in foamDictionary and set default behavior to k...2023-12-21T15:52:40Zfranco otaolaadd flag to not keep comments in foamDictionary and set default behavior to keep them### Functionality to add/problem to solve
foamDictionary when using -set or other flags removes all the comments. this makes almost unsable the tool as a lot of us have pieces of code commented that came from other cases and we want to k...### Functionality to add/problem to solve
foamDictionary when using -set or other flags removes all the comments. this makes almost unsable the tool as a lot of us have pieces of code commented that came from other cases and we want to keep. I would propose that the default behavior would be to keep the comments (as people could loose information) and add a flag to not keep them like -removeComments or something in that logic
### Target audience
users in general
### Proposal
detect the comments and place them in between the entries where it was before.
### What does success look like, and how can we measure that?
if we use it for transportProperties for a dictionary that looks like this:
```
transportModel Newtonian;
//[g m s K kgmol A cd]
nu 1e-05; //[0 2 -1 0 0 0 0]
//comment
//comment2
/* block
of
comment
*/
Sct 0.7; //[0 0 0 0 0 0 0]
//comment3
```
that the resulting dictionary at least look like this (with each time that there is a // a new line is created and the /* */ block comments are kept as they were):
```
transportModel Newtonian;
//[g m s K kgmol A cd]
nu 1;//[0 2 -1 0 0 0 0]
//coment
//comment2
/* block
of
comment
*/
Sct 0.7;//[0 0 0 0 0 0 0]
//comment3
```
even if the final structure is not ideal this would be a great addition to using it.https://develop.openfoam.com/Development/openfoam/-/issues/1320add function object to record execution/clock time2019-05-23T10:08:46ZMark OLESENadd function object to record execution/clock time@ivanspisso@ivanspissoMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2044Add Function suggestion: Add Fujitsu-MPI for A64FX.2021-03-31T06:57:59ZTomoki, KaratsuAdd Function suggestion: Add Fujitsu-MPI for A64FX.Hello, @mark.
Thank you for your cooperation in adding the Fujitsu compiler before. This time I would like to add a process to recognize the Fujitsu MPI library on A64FX.
Can I submit the PR this community? If I don't have the right to ...Hello, @mark.
Thank you for your cooperation in adding the Fujitsu compiler before. This time I would like to add a process to recognize the Fujitsu MPI library on A64FX.
Can I submit the PR this community? If I don't have the right to submit a PR, could you incorporate the following fixes?
```
diff --git a/etc/bashrc b/etc/bashrc
index 763f165..a6daac7 100644
--- a/etc/bashrc
+++ b/etc/bashrc
@@ -90,7 +90,7 @@ export WM_COMPILE_OPTION=Opt
# [WM_MPLIB] - MPI implementation:
# = SYSTEMOPENMPI | OPENMPI | SYSTEMMPI | MPI | MPICH | MPICH-GM |
-# HPMPI | CRAY-MPICH | FJMPI | QSMPI | SGIMPI | INTELMPI | USERMPI
+# HPMPI | CRAY-MPICH | FJMPI | FJMPI-A64FX | QSMPI | SGIMPI | INTELMPI | USERMPI
# Specify SYSTEMOPENMPI1, SYSTEMOPENMPI2 for internal tracking (if desired)
# Can also use INTELMPI-xyz etc and define your own wmake rule
export WM_MPLIB=SYSTEMOPENMPI
diff --git a/etc/config.sh/mpi b/etc/config.sh/mpi
index 69617b1..7531cc8 100644
--- a/etc/config.sh/mpi
+++ b/etc/config.sh/mpi
@@ -297,6 +297,15 @@ FJMPI)
_foamAddLib /opt/FJSVpnidt/lib
;;
+FJMPI-A64FX)
+ export FOAM_MPI=fjmpi-a64fx
+ export MPI_ARCH_PATH="$MPI_ROOT"
+
+ export OPAL_PREFIX="$MPI_ARCH_PATH"
+
+ _foamAddPath "$MPI_ARCH_PATH"/bin
+ _foamAddLib "$MPI_ARCH_PATH"/lib64
+ ;;
QSMPI)
export FOAM_MPI=qsmpi
diff --git a/wmake/rules/General/mplibFJMPI-A64FX b/wmake/rules/General/mplibFJMPI-A64FX
index e69de29..6e2ae4f 100644
--- a/wmake/rules/General/mplibFJMPI-A64FX
+++ b/wmake/rules/General/mplibFJMPI-A64FX
@@ -0,0 +1,7 @@
+#------------------------------------------------------------------------------
+
+PFLAGS = -DMPICH_SKIP_MPICXX -DOMPI_SKIP_MPICXX
+PINC = -isystem $(MPI_ARCH_PATH)/include/mpi/fujitsu/
+PLIBS = -L$(MPI_ARCH_PATH)/lib64 -lmpi
+
+#------------------------------------------------------------------------------
```Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/3108Add globalIndex info to globalMeshData2024-03-09T18:31:08ZMark OLESENAdd globalIndex info to globalMeshDataRequested by @Mattijs - replace the total point/face/cell information with globalIndex to allow reuse in various other places without requiring communication each subsequent time.Requested by @Mattijs - replace the total point/face/cell information with globalIndex to allow reuse in various other places without requiring communication each subsequent time.v2406Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1197Add grids to foamMonitor (gnuplot)2019-12-18T16:20:34ZRoger AlmenarAdd grids to foamMonitor (gnuplot)It would be good to add an option to foamMonitor, like "-g|--grid", to plot the background grid to the monitoring plots, so that it is easier to identify the trends and values.
In gnuplot, it is enough to add a "set grid" line to the gnu...It would be good to add an option to foamMonitor, like "-g|--grid", to plot the background grid to the monitoring plots, so that it is easier to identify the trends and values.
In gnuplot, it is enough to add a "set grid" line to the gnuplot file.v1912Kutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/361Add in architecture checking IOobjects read.2020-01-03T10:00:50ZMark OLESENAdd in architecture checking IOobjects read.Placeholder for topics related to "arch" handling (endian, label and scalar sizes) that was added for v1612.
We now emit arch hints such "LSB,label=32,scalar=64", but don't do anything with them on input.
The first point is to simply to...Placeholder for topics related to "arch" handling (endian, label and scalar sizes) that was added for v1612.
We now emit arch hints such "LSB,label=32,scalar=64", but don't do anything with them on input.
The first point is to simply to check their types on input: "arch" exists and is identical to the current OpenFOAM configuration.
The next would be a special-purpose foam-convert utility. Handling a change from int64 to int32 might only work in very special cases. For example, when snappy needs 64-bit labels because the input surfaces have so many points and faces, but the resulting mesh would still fit with int32.Version v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2677Adding functionobjects/expression to Openfoam v19122023-01-16T00:36:44ZHaitham OsmanAdding functionobjects/expression to Openfoam v1912I have OP v1912 installed on a server. However, expression/fvExpressionField (exprField) utility is NOT installed in the OP v1912. I wonder what is the way to add this feature to OP v1912.
Thanks in advanceI have OP v1912 installed on a server. However, expression/fvExpressionField (exprField) utility is NOT installed in the OP v1912. I wonder what is the way to add this feature to OP v1912.
Thanks in advancehttps://develop.openfoam.com/Development/openfoam/-/issues/2170Add inGroups support for zones2021-09-09T16:15:20ZMark OLESENAdd inGroups support for zonesOne of the topics that has been discussed with @Mattijs is having overlapping zones. This would be convenient for many things, but would also violate a one-to-one mapping that zones currently have.
One possibility would to reuse/refacto...One of the topics that has been discussed with @Mattijs is having overlapping zones. This would be convenient for many things, but would also violate a one-to-one mapping that zones currently have.
One possibility would to reuse/refactor the patchIdentifier for zones and use its inGroup grouping.v2112Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1779additional handling of function object failure2022-05-29T15:09:02ZMark OLESENadditional handling of function object failureAs raised in EP1338, the change of sampled surfaces causes a different in later OpenFOAM versions.
In the earlier versions, if the surface was out-of-domain (wrong location, but most likely incorrect scaling), this would fail on constru...As raised in EP1338, the change of sampled surfaces causes a different in later OpenFOAM versions.
In the earlier versions, if the surface was out-of-domain (wrong location, but most likely incorrect scaling), this would fail on construction which would emit a warning and discard the function object.
More recent updates for sampling are much _"lazier"_ - they only construct the surface as required. This is particularly useful in cases of an iso-surface for a field that does not exist until later in the simulation.
However, as a side-effect of this, the failure can now occur during execute() or write() of the functionObject, which means that even if the dry-run was successful, the job can crash because of the bad function object.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2229additional info string for sampled surfaces2021-10-31T16:27:38ZMark OLESENadditional info string for sampled surfacesraised on EP1631 - could be useful to output additional information (filter types etc) for sampled surface.
Would need to add in a top-level info() method and dispatch from there.raised on EP1631 - could be useful to output additional information (filter types etc) for sampled surface.
Would need to add in a top-level info() method and dispatch from there.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/804additional input/output parameters for lumped point motion2018-06-07T05:58:53ZMark OLESENadditional input/output parameters for lumped point motion- input or output scaling of values. Eg when the structures model uses `mm`, `ton` units etc.
- logging of input/output. To track the information exchange throughout the entire simulation- input or output scaling of values. Eg when the structures model uses `mm`, `ton` units etc.
- logging of input/output. To track the information exchange throughout the entire simulationv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2114additional patch expressions functions2021-07-08T07:04:32ZMark OLESENadditional patch expressions functionsas noted in EP1558 - the missing `internalField(..)` function is neededas noted in EP1558 - the missing `internalField(..)` function is neededMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/747Additional time control to functionObjects2021-07-06T11:50:37ZAdminAdditional time control to functionObjectsHi,
I am missing a flavour of time control in the function objects, namely an approximate output interval. For some of the applications that I am running, it is restrictive to use adjustableRunTime, because it affects the execution too ...Hi,
I am missing a flavour of time control in the function objects, namely an approximate output interval. For some of the applications that I am running, it is restrictive to use adjustableRunTime, because it affects the execution too much and the time steps become integer ratios of the output interval, however, the timeStep output provides too much data. Often, I do not care that the output time axis is non-equidistant.
I have added a new flavour which I call "approximateFixedInterval" and it simply outputs the sampling, if the time is greater than or equal to an integer times the output interval (the integer being larger than the one at the previous output time). Could the addition be adopted (perhaps with a nicer name) in the next release? The required modifications to functionObjects/timeControl/timeControl.[C,H] is attached to this report.
Thank you
Niels
P.S. I know that it is not really an issue, but it seemed to be the only way of making a request.
[timeControl.H](/uploads/c49e31d1d8fda3eb9662f68ed05132b3/timeControl.H)
[timeControl.C](/uploads/f28679a18ddd72a438b6b5c6615dfd63/timeControl.C)
\## Reattaching the author to the issue ticket: @ngj ##https://develop.openfoam.com/Development/openfoam/-/issues/1044Add lagrangianTools functionality to develop branch2018-11-24T14:58:40ZRoger AlmenarAdd lagrangianTools functionality to develop branchIs it possible to add the functionality available under lagrangianTools to the develop branch, towards release with v1812?Is it possible to add the functionality available under lagrangianTools to the develop branch, towards release with v1812?Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/ThirdParty-common/-/issues/23Add LLVM_ARC_PATH simular MESA_ARC_PATH2018-12-19T11:26:17ZPawan GhildiyalAdd LLVM_ARC_PATH simular MESA_ARC_PATHSince osmesa is usually build with llvm , it will be better have similar
option for llvm as for mesa i.e in config.sh/vtk add LLVM_ARCH_PATH
similar to MESA_ARCJ_PATHSince osmesa is usually build with llvm , it will be better have similar
option for llvm as for mesa i.e in config.sh/vtk add LLVM_ARCH_PATH
similar to MESA_ARCJ_PATHMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2358add min/max/average/size results for probes2022-05-11T09:48:38ZMark OLESENadd min/max/average/size results for probesMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2080add multi-region support for foamToEnsight2021-07-08T07:05:25ZMark OLESENadd multi-region support for foamToEnsightMark OLESENMark OLESEN