Development issueshttps://develop.openfoam.com/groups/Development/-/issues2023-12-07T19:03:31Zhttps://develop.openfoam.com/Development/openfoam/-/issues/792provide additional text expansion shortcuts2023-12-07T19:03:31ZMark OLESENprovide additional text expansion shortcutsIn many places we use the string expansion to provide filenames.
Eg,
"${FOAM_CASE}/comms"
"$FOAM_CASE/constant/reactions"
...
And then using the `fileName::expand()` method or `stringOps::expand()` to resolve them.
Propose ...In many places we use the string expansion to provide filenames.
Eg,
"${FOAM_CASE}/comms"
"$FOAM_CASE/constant/reactions"
...
And then using the `fileName::expand()` method or `stringOps::expand()` to resolve them.
Propose to provide some tag short cuts for less clutter.
Eg,
"<case>/comms"
"<constant>/reactions"
...
The total number of tags is fairly limited in scope:
<etc>/ => user/group/other OpenFOAM directory
<case>/ => FOAM_CASE directory
<constant>/ => FOAM_CASE/constant directory
<system>/ => FOAM_CASE/system directory
We may consider alternative tag delimiters such as `[case]/`,
but it should be easy to read/type and we should avoid `{}` delimiters
since a simple typo has different meaning and would be a hard to trace
input error (eg, `${case}` vs `{case}`).v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/793adjust paraview library paths2023-12-07T19:03:31ZMark OLESENadjust paraview library pathsVersion 5.5.0 was just released. Looks like the `lib/` dir itself should now be part of the `LD_LIBRARY_PATH`.
In 5.4.x and earlier:
lib/cmake/
lib/paraview-5.4/libvtkPVCommon-pv5.4.so.1
In 5.5.0:
lib/cmake/
lib/parav...Version 5.5.0 was just released. Looks like the `lib/` dir itself should now be part of the `LD_LIBRARY_PATH`.
In 5.4.x and earlier:
lib/cmake/
lib/paraview-5.4/libvtkPVCommon-pv5.4.so.1
In 5.5.0:
lib/cmake/
lib/paraview
lib/libvtkPVCommon-pv5.5.so.1
The `lib/paraview-5.5` only contains a `plugins` directory.
In both cases used the same `./makeParaView` script from ThirdParty:
./makeParaView -suffix mpipy -mpi -python -qt-5.9.3 5.4.1
./makeParaView -suffix mpipy -mpi -python -qt-5.9.3 5.5.0
Will need to check (hint @acbauer) if this change is intentional or if something went wrong with our configuration, or if there is an additional cmake parameter that we are missing.
The flattening does make some sense, since all the library names are versioned with`*-pv5.5.so.1` etc, but can't really see how plain `paraview`, `paraview-config` in the lib/ directory are going to work.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/794OSspecific highResLastModified uses wrong struct field2023-12-07T19:03:31ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comOSspecific highResLastModified uses wrong struct fieldhighResLastModified uses stat(3) system call. It should use st_mtim, not st_atim.highResLastModified uses stat(3) system call. It should use st_mtim, not st_atim.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/795createPatch deletes cellSets/cellZones2024-01-16T05:40:42ZAdmincreatePatch deletes cellSets/cellZonesI have a simple porous media in a duct, and use insideCells to create a cellZoneSet, which is then turned into a cellZone by topoSet. checkMesh reports the number of cells and bounding box of this cellZone correctly.
However, after runn...I have a simple porous media in a duct, and use insideCells to create a cellZoneSet, which is then turned into a cellZone by topoSet. checkMesh reports the number of cells and bounding box of this cellZone correctly.
However, after running createPatch -overwrite, the cellZone is empty. Is this desired behavior, or a bug?
I can create a very small test case is needed.
\## Reattaching the author to the issue ticket: @aerogt3 ##Prashant SonakarPrashant Sonakarhttps://develop.openfoam.com/Development/openfoam/-/issues/796decompositionMethod::decompose functions are non-const2023-12-07T19:03:32ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comdecompositionMethod::decompose functions are non-constI cannot immediately see why the decompose member functions are non-const.I cannot immediately see why the decompose member functions are non-const.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/797subTriSurfaceMesh does not work with distributedTriSurfaceMesh2018-06-08T22:52:16ZAdminsubTriSurfaceMesh does not work with distributedTriSurfaceMeshI'm testing out the feature "subTriSurfaceMesh" as described at: https://www.openfoam.com/releases/openfoam-v3.0+/meshing.php
The issue is that it does not work for distirbutedTriSurfaceMesh. I am not sure if it was intended to work wit...I'm testing out the feature "subTriSurfaceMesh" as described at: https://www.openfoam.com/releases/openfoam-v3.0+/meshing.php
The issue is that it does not work for distirbutedTriSurfaceMesh. I am not sure if it was intended to work with all triSurfaceMesh types; if the behavior is as intended I would suggest it as a feature request.https://develop.openfoam.com/Development/openfoam/-/issues/798paraFoam crashes upon trying to read an illegal field2023-12-07T19:03:31ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comparaFoam crashes upon trying to read an illegal fieldWould be really nice for paraFoam not to crash if it cannot read a field.
Should have try/catch block like functionObjectList reading:
[vtkPVFoamFieldTemplates.C](/uploads/8fd0f0712740afb37171eb718289de88/vtkPVFoamFieldTemplates.C)Would be really nice for paraFoam not to crash if it cannot read a field.
Should have try/catch block like functionObjectList reading:
[vtkPVFoamFieldTemplates.C](/uploads/8fd0f0712740afb37171eb718289de88/vtkPVFoamFieldTemplates.C)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/799Current develop branch does not compile in SP2023-12-07T19:03:31ZAdminCurrent develop branch does not compile in SPThrowing the following error:
turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C: In member function ‘virtual void Foam::outletMachNumberPressureFvPatchScalarField::writ...Throwing the following error:
turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C: In member function ‘virtual void Foam::outletMachNumberPressureFvPatchScalarField::write(Foam::Ostream&) const’:
turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C:252:44: error: no matching function for call to ‘Foam::Ostream::writeEntryIfDifferent(const char [3], double, const scalar&)’
os.writeEntryIfDifferent("c1", 0.0, c1_);
^
turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C:252:44: note: candidate is:
In file included from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/OSstream.H:39:0,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/messageStream.H:216,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/error.H:51,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/UListI.H:26,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/UList.H:532,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/List.H:43,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/wordList.H:48,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/patchIdentifier.H:38,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/polyPatch.H:42,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/finiteVolume/lnInclude/fvPatch.H:39,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/finiteVolume/lnInclude/fvPatchField.H:47,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/finiteVolume/lnInclude/fixedValueFvPatchField.H:57,
from /scratch/OpenFOAM/OpenFOAM-plus-develop/src/finiteVolume/lnInclude/fixedValueFvPatchFields.H:29,
from turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.H:133,
from turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C:26:
/scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/Ostream.H:219:22: note: template<class T> Foam::Ostream& Foam::Ostream::writeEntryIfDifferent(const Foam::word&, const T&, const T&)
Ostream& writeEntryIfDifferent
^
/scratch/OpenFOAM/OpenFOAM-plus-develop/src/OpenFOAM/lnInclude/Ostream.H:219:22: note: template argument deduction/substitution failed:
turbulentFluidThermoModels/derivedFvPatchFields/outletMachNumberPressure/outletMachNumberPressureFvPatchScalarField.C:252:44: note: deduced conflicting types for parameter ‘const T’ (‘double’ and ‘Foam::scalar {aka float}’)
os.writeEntryIfDifferent("c1", 0.0, c1_);Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/800sphereSurfactantFoam and $(FOAM_USER_APPBIN )2018-04-15T20:13:00ZAdminsphereSurfactantFoam and $(FOAM_USER_APPBIN )Hi all,
Inside the Make/files of sphereSurfactantFoam the binary location seems to be set to $(FOAM_USER_APPBIN), not sure if this is really a bug
EXE = $(FOAM_USER_APPBIN)/sphereSurfactantFoam
Cheers
AndreaHi all,
Inside the Make/files of sphereSurfactantFoam the binary location seems to be set to $(FOAM_USER_APPBIN), not sure if this is really a bug
EXE = $(FOAM_USER_APPBIN)/sphereSurfactantFoam
Cheers
Andreahttps://develop.openfoam.com/Development/openfoam/-/issues/801polyBoundaryMesh::whichPatch should use binary search, not linear2019-01-02T14:29:08ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.compolyBoundaryMesh::whichPatch should use binary search, not linearwhichPatch does a linear search over all patches. Almost all meshes have the patches in order so a binary search could be faster for larger numbers of patches.whichPatch does a linear search over all patches. Almost all meshes have the patches in order so a binary search could be faster for larger numbers of patches.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/802FoamToVTK crashes on cyclic patches2018-04-18T08:11:48ZAdminFoamToVTK crashes on cyclic patchesOpenFOAM plus-20ffdb88930e crashes when I try to create VTK files using 'foamToVTK'. OpenFOAM plus-bb816234a13e runs fine on the same case.
The error is:
`From function virtual Foam::label Foam::cyclicPolyPatch::neighbPatchID() const
...OpenFOAM plus-20ffdb88930e crashes when I try to create VTK files using 'foamToVTK'. OpenFOAM plus-bb816234a13e runs fine on the same case.
The error is:
`From function virtual Foam::label Foam::cyclicPolyPatch::neighbPatchID() const
in file faMesh/faPatches/constraint/cyclic/cyclicFaPatch.C at line 286.`
I've attached my test case where I got the error.
[RotatingWall_64x16x32_WALE.zip](/uploads/c11d77860f50c026e548c03894480553/RotatingWall_64x16x32_WALE.zip)https://develop.openfoam.com/Development/openfoam/-/issues/803Overset bugs2018-04-25T09:13:01ZAdminOverset bugsI'm using 68185c76 on Debian GNU/Linux 8 (jessie). I believe I found some problems with the overset mesh implementation.
1. dynamicOversetFvMesh.C:96
Pstream::exchange<labelList, label>(remoteFaceCells, sendCells);
Neither remoteFa...I'm using 68185c76 on Debian GNU/Linux 8 (jessie). I believe I found some problems with the overset mesh implementation.
1. dynamicOversetFvMesh.C:96
Pstream::exchange<labelList, label>(remoteFaceCells, sendCells);
Neither remoteFaceCells nor sendCells are used after this exchange. I can't see its purpose. Results are not affected when I comment it out.
2. Parallelisation problem. The overSimpleFoam tutorial (aerofoil) converges in serial, but fails to converge in parallel. May be related to above. Mind you, this may be a red herring, because I get this warning:
--> FOAM Warning :
From function bool Foam::oversetPolyPatch::master() const
in file oversetPolyPatch/oversetPolyPatch.C at line 149
The master overset patch is not the first patch. Generally the first patch should be an overset patch to guarantee consistent operation.
-Davidhttps://develop.openfoam.com/Development/openfoam/-/issues/804additional input/output parameters for lumped point motion2018-06-07T05:58:53ZMark OLESENadditional input/output parameters for lumped point motion- input or output scaling of values. Eg when the structures model uses `mm`, `ton` units etc.
- logging of input/output. To track the information exchange throughout the entire simulation- input or output scaling of values. Eg when the structures model uses `mm`, `ton` units etc.
- logging of input/output. To track the information exchange throughout the entire simulationv1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/806redistributePar does not work with collated I/O format2022-05-07T08:43:37ZAdminredistributePar does not work with collated I/O formatHi, it seems that the redistributePar Tool is only written for uncollated format. Using collated format is not possible. Process stucks - see logfile. For reproducing I run the cavitiy mesh/parallel case
controlDict adds:
OptimisationS...Hi, it seems that the redistributePar Tool is only written for uncollated format. Using collated format is not possible. Process stucks - see logfile. For reproducing I run the cavitiy mesh/parallel case
controlDict adds:
OptimisationSwitches
{
//- Parallel IO file handler
// collated (default), collated or masterUncollated
fileHandler collated;
maxThreadFileBufferSize 0; -> this is set to zero by purpose for cluster setup!
maxMasterFileBufferSize 2e9;
}
[log.redistributePar.decompose](/uploads/9226895799c39911aa7529d4754ed860/log.redistributePar.decompose)
\#\# Reattaching the author to the issue ticket: @hxaxtma \#\#Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/807processorField FO cannot be used with 'postProcess -func'2018-07-04T10:47:28ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comprocessorField FO cannot be used with 'postProcess -func'Put attached
[processorField](/uploads/88917ae3ececefb3629b9dc576537eb3/processorField)
in etc/caseDicts/postProcessing/fields/processorField and you can do
```
mpirun -np 2 postProcess -func processorField -parallel
```
Ok?
Put attached
[processorField](/uploads/88917ae3ececefb3629b9dc576537eb3/processorField)
in etc/caseDicts/postProcessing/fields/processorField and you can do
```
mpirun -np 2 postProcess -func processorField -parallel
```
Ok?
https://develop.openfoam.com/Development/openfoam/-/issues/808checkMesh crash on zero volume cell2018-07-02T16:12:22ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcheckMesh crash on zero volume cellMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/809Error in documentation of effectivenessHeatExchangerSource in the Extended Co...2019-01-08T17:32:13ZAdminError in documentation of effectivenessHeatExchangerSource in the Extended Code GuideIn the Extended Code Guide, the table format for the effectiveness is written as:
(
0.02
(
(0.1 A)
(0.2 B)
(0.3 C)
),
0.04
(
(0.1 D)
...In the Extended Code Guide, the table format for the effectiveness is written as:
(
0.02
(
(0.1 A)
(0.2 B)
(0.3 C)
),
0.04
(
(0.1 D)
(0.2 E)
(0.3 F)
),
0.06
(
(0.1 G)
(0.2 H)
(0.3 I)
)
);
However, this format does not work. Instead, a working table looks like this:
(
(0.02
(
(0.1 A)
(0.2 B)
(0.3 C)
))
(0.04
(
(0.1 D)
(0.2 E)
(0.3 F)
))
(0.06
(
(0.1 G)
(0.2 H)
(0.3 I)
))
);
The documentation in the Extended Code Guide should be changed accordingly.https://develop.openfoam.com/Development/openfoam/-/issues/811annularThermalMixer tutorial does not run2018-04-27T06:18:15ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comannularThermalMixer tutorial does not runshm does not set the cellZones -> both rotor and stator side rotate.shm does not set the cellZones -> both rotor and stator side rotate.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/812case fails in 17122018-05-02T11:26:40ZAdmincase fails in 1712motorbike case fails with wallBoundedstreamline FO in 1712.
Reference case is attached herewith[motorBike-wallBoundedStreamLineFO.tgz](/uploads/e5ce2ed5152fe2708e970c01260ce354/motorBike-wallBoundedStreamLineFO.tgz)motorbike case fails with wallBoundedstreamline FO in 1712.
Reference case is attached herewith[motorBike-wallBoundedStreamLineFO.tgz](/uploads/e5ce2ed5152fe2708e970c01260ce354/motorBike-wallBoundedStreamLineFO.tgz)Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/813compilation / usage of fftw2018-06-07T05:58:37ZMark OLESENcompilation / usage of fftw@andy@andyAdminAdmin