Development issueshttps://develop.openfoam.com/groups/Development/-/issues2023-12-13T17:01:12Zhttps://develop.openfoam.com/Development/openfoam/-/issues/1786checkMesh -writeFields does not check correctness2023-12-13T17:01:12ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcheckMesh -writeFields does not check correctness### Functionality to add/problem to solve
`checkMesh -writeFields '(BANANA)'`
will happily run and not give any indication about illegal input. Attached file checks.
@mark : happy with this?
[checkMesh.C](/uploads/32222724bb5d738f8c4...### Functionality to add/problem to solve
`checkMesh -writeFields '(BANANA)'`
will happily run and not give any indication about illegal input. Attached file checks.
@mark : happy with this?
[checkMesh.C](/uploads/32222724bb5d738f8c498a8faf9930aa/checkMesh.C)https://develop.openfoam.com/Development/openfoam/-/issues/2023checkMesh write surface fields2022-12-23T15:02:41ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcheckMesh write surface fields### Functionality to add/problem to solve
checkMesh to write surface fields for face-based mesh parameters### Functionality to add/problem to solve
checkMesh to write surface fields for face-based mesh parametersMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/763checkMesh writing min tet volume and e.g. cellRegion2023-12-07T19:03:27ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comcheckMesh writing min tet volume and e.g. cellRegionUseful to have checkMesh also write the minimum tet volume per cell and cell region to e.g. detect shm problems.Useful to have checkMesh also write the minimum tet volume per cell and cell region to e.g. detect shm problems.Mattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/1070chemkinToFoam not working for the chemical mechanism format from latest Chemk...2021-11-15T18:37:19ZAdminchemkinToFoam not working for the chemical mechanism format from latest Chemkin VersionHello,
We recently would like to convert chemical mechanism to OpenFOAM format. However, for some chemical mechanisms, they have the information about "PLOG" in the mechanism file. They are used to identify the kinetic parameters for s...Hello,
We recently would like to convert chemical mechanism to OpenFOAM format. However, for some chemical mechanisms, they have the information about "PLOG" in the mechanism file. They are used to identify the kinetic parameters for some special pressure conditions (see attached image). Because of them, the conversion failed. The error information has been attached in this email.
The Openfoam we are using is 5.0 version. Do you have comments about how to resolve this issue if we still would like to use chemkinToFoam.
![20181113131347](/uploads/8a4968f9b269e6f26c6d4ca661c311a8/20181113131347.png)
![20181113131337](/uploads/1f7e08e3bc2c10803e6ca338bbcd9542/20181113131337.png)
![20181113131327](/uploads/a941ebcf1be9bc4fd28ba0f148f231e6/20181113131327.png)https://develop.openfoam.com/Development/openfoam/-/issues/2398chtMultiRegionSimpleFoam - of2112 does not catch analitical results where of2...2022-11-02T09:08:59ZMatteo QuirinochtMultiRegionSimpleFoam - of2112 does not catch analitical results where of2106 does<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
The same test case if it is run with of2106 the analytical solution is obtained, if it is run with of2112 the analytical solution is not catched.
### Steps to reproduce
The case is shared in [this](https://github.com/matteoquirino/of2112-cht-possibleBug) repo. The test case is taken from [this](https://arc.aiaa.org/doi/10.2514/1.T6165) article. Just run "Allrun-serial" to launch the simulation. Try to run the simulation loading of2106 environment and then using of2112 environment. The solution given by of2016 is correct the one computed using of2112 is wrong by some degrees in temperature.
### Example case
The test case is taken from [this](https://arc.aiaa.org/doi/10.2514/1.T6165) article.
![Schermata_da_2022-03-08_09-48-15](/uploads/8f97013b290987e70dcf147faa7e6e0c/Schermata_da_2022-03-08_09-48-15.png)
h is the convective coefficient on the far right of the system, it is so low as it must represent vacuum. Lc and kc are set to 1e-6 m and 1e-4 W/m/K.
The case is very simple and fast.
### What is the current *bug* behaviour?
Analitical solution not catched by of2112 but catched by of2106. The one computed by of2112 is 330 K and 335 K whilst the correct one is 327 K 338 K.
### What is the expected *correct* behavior?
To catch the analytical solution.
### Relevant logs and/or images
Please see section above.
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v2112|v2106|v2012|v2006|v1912|v1906 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version : v2112 | v2106
- Operating system : ubuntu
- Hardware info :
- Compiler : precompiled versions of v2112 and v2106
### Possible fixesSergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/issues/1530chtMultiRegionTwoPhaseEulerFoam: missing L parameters for restart2020-01-21T20:24:12ZPawan GhildiyalchtMultiRegionTwoPhaseEulerFoam: missing L parameters for restartI) Restarting the case from solution , ask for missing parameters L from Bromley model .
2)Switching the DebugSwitches i.e below one to 2 , lead solver failing with error. Please check with tutorial for
chtMultiRegionTwoPhaseEulerFo...I) Restarting the case from solution , ask for missing parameters L from Bromley model .
2)Switching the DebugSwitches i.e below one to 2 , lead solver failing with error. Please check with tutorial for
chtMultiRegionTwoPhaseEulerFoam
DebugSwitches
{
compressible::alphatWallBoilingWallFunction 2;
} Sergio FerrarisSergio Ferrarishttps://develop.openfoam.com/Development/openfoam/-/issues/1186chtSolvers - mappedWall - thin wall2019-01-30T10:51:50ZAdminchtSolvers - mappedWall - thin wallHello,
I am trying to map temperature from fluid region to the thin solid region. I expected that the heat transfer is not only in a normal direction in this case. I have used a compressible::turbulentTemperatureCoupledBaffleMixed bound...Hello,
I am trying to map temperature from fluid region to the thin solid region. I expected that the heat transfer is not only in a normal direction in this case. I have used a compressible::turbulentTemperatureCoupledBaffleMixed boundary conditions. It was working well in OpenFOAM-2.x but in the case of OpenFAOM-v1806 I have received the following error:
Attempt to cast type zeroGradient to type compressible::turbulentTemperatureCoupledBaffleMixed
From function To& Foam::refCast(From&) [with To = const Foam::compressible::turbulentTemperatureCoupledBaffleMixedFvPatchScalarField; From = const Foam::fvPatchField<double>]
in file /home/betak/OpenFOAM/OpenFOAM-v1812/src/OpenFOAM/lnInclude/typeInfo.H at line 136.
I want to ask you if is there any major changes in mapped boundary conditions between OpenFOAM-2.x and OpenFoam-v18xx.
Thank you
With regards
Vojtech Betak
[MULTIREGION_CHT.tar.xz](/uploads/9c16ad87fdab74aec4c06b883e3cd024/MULTIREGION_CHT.tar.xz)https://develop.openfoam.com/Development/openfoam/-/issues/1389Clang problem reading wild cards2020-02-03T06:15:15ZSergio FerrarisClang problem reading wild cardsClang has problems reading wild cards such as "(U|k|epsilon|s).*".
It doesn't expand it correctly thus, the error: Entry 'epsilonFinal' not found in dictionary.....Clang has problems reading wild cards such as "(U|k|epsilon|s).*".
It doesn't expand it correctly thus, the error: Entry 'epsilonFinal' not found in dictionary.....https://develop.openfoam.com/Development/openfoam/-/issues/2731Clarification on Lambda2 function object2023-09-29T12:54:35ZYannClarification on Lambda2 function object### Functionality to add/problem to solve
The description of the Lambda2 function object states:
> The Lambda2 function object computes the second largest eigenvalue of the sum of the square of the symmetrical and anti-symmetrical par...### Functionality to add/problem to solve
The description of the Lambda2 function object states:
> The Lambda2 function object computes the second largest eigenvalue of the sum of the square of the symmetrical and anti-symmetrical parts of the velocity gradient tensor.
But it seems the function actually computes the opposite value: -Lambda2
`return store
(
resultName_,
-eigenValues(SSplusWW)().component(vector::Y)
);`
This is a bit confusing, since negative Lambda2 values are supposed to indicate vortex cores while in OpenFOAM you need to look for positive values to get vortex cores.
### Target audience
Anyone using Lambda2 to visualize vortex structures
### Proposal
Two possible solutions:
1. writing the actual Lambda2 rather than -Lambda2
2. updating the function description to clearly mention the opposite value of Lambda2 is written
I don't really have a preference between these solutions, as long as the description matches the code to avoid misleading users.
### Links / references
This old thread put me on track: https://www.cfd-online.com/Forums/openfoam-post-processing/117005-lambda2-openfoam-utilities.htmlKutalmış BerçinKutalmış Berçinhttps://develop.openfoam.com/Development/openfoam/-/issues/1834Class faMatrix is not fully compilable2020-09-16T17:21:55ZPetr VitaClass faMatrix is not fully compilable<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be re...<!--
*** Please read this first! ***
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "bug" label and check to see if it has already been reported
You can see how your report will be rendered on the platform by using the
"preview" tab above
-->
<!--
All text between these markers are comments and will not be present in the
report
-->
### Summary
Method `faMatrix::setValues()` (`src/finiteArea/faMatrices/faMatrix/faMatrix.C`) does not compile under *OpenFOAM-v2006* as it uses:
- method `lduMatrix::eliminatedEqns()` that is part of *foam-extend-4.1*-project, but misses in *OpenFOAM-v2006*
- non-const `internalField()` method that seems to be renamed to `ref()` under *OpenFOAM-v2006*
### Steps to reproduce
Try to compile the attached code:
[faMatrixBug.tgz](/uploads/c995d881bda200a88720d7fd7be24efd/faMatrixBug.tgz)
### Example case
<!--
If possible, please create a SMALL example and attach it to your report
If you are using an older version of OpenFOAM this will also determine
whether the bug has been fixed in a more recent version
-->
N/A
### What is the current *bug* behaviour?
<!-- What actually happens -->
Compilation error.
### What is the expected *correct* behavior?
<!-- What you should see instead -->
Compilation success.
### Relevant logs and/or images
<!--
Paste any relevant logs - please use code blocks (```) to format console
output, logs, and code as it's very hard to read otherwise.
-->
N/A
### Environment information
<!--
Providing details of your set-up can help us identify any issues, e.g.
OpenFOAM version : v1806|v1812|v1906 etc
Operating system : ubuntu|openSUSE|centos etc
Hardware info : any info that may help?
Compiler : gcc|intel|clang etc
-->
- OpenFOAM version : OpenFOAM-v2006
- Operating system : CentOS 8 (4.18.0-193.14.2.el8_2.x86_64)
- Hardware info : VirtualBox 6.1.12 r139181
- Compiler : gcc 8.3.1
Bug breaks basic C++ rules, should not depend on a specific environment.
### Possible fixes
<!--
If you can, link to the line of code that might be responsible for the
problem
The "/label ~bug" text is a gitlab flag that will add the "bug" label to this
issue
-->
Quick and dirty patch:
[faMatrix.C.patch](/uploads/cdf4fec1385c4de69956aa810b89ba67/faMatrix.C.patch)
A more elegant solution would involve the port of the `lduMatrix` class from *foam-extend*-project.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/900cleanCase deletes blockMeshDict2018-07-01T05:46:07ZJohan RoenbycleanCase deletes blockMeshDictMany OpenFOAM users still use older OF version. When they eventually try to port their older OpenFOAM cases to newer OpenFOAM versions it can be quite annoying that the cleanCase function in bin/tools/CleanFunctions deletes the constant/...Many OpenFOAM users still use older OF version. When they eventually try to port their older OpenFOAM cases to newer OpenFOAM versions it can be quite annoying that the cleanCase function in bin/tools/CleanFunctions deletes the constant/polyMesh, where their blockMeshDict may still reside.
I suggest introducing a check in cleanCase, so that it moves an existing blockMeshDict (or any *Dict in polyMesh for that matter) from constant/polyMesh to the system folder before deleting polyMesh.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/639cleanup autoPtr, tmp, xfer2020-10-20T16:23:38ZMark OLESENcleanup autoPtr, tmp, xfer- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).- Some constructors and methods can be constexpr, noexcept.
- most places have a const copy constructor that steals the contents. Could/should be revised to use a universal reference and prohibit const copy (as per std::unique_ptr).v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/512cleanup construction selectors2017-07-10T12:42:23ZMark OLESENcleanup construction selectorsCan use `auto` with that hashtable `cfind` for simpler looking code.Can use `auto` with that hashtable `cfind` for simpler looking code.v1712Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/271cleanup endian handling2016-12-23T12:39:41ZMark OLESENcleanup endian handlingSimilar code spread in several placesSimilar code spread in several placesVersion v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/254cleanup/extend ostream to ease usage2017-01-02T12:25:13ZMark OLESENcleanup/extend ostream to ease usage*Many* places with things like this:
os.writeKeyword(key) << val << token::END_STATEMENT << nl;
Provide a single `os.writeEntry(key, val)` replacement.
The previously introduced `Ostream::beginBlock` and `Ostream::endBlock` should...*Many* places with things like this:
os.writeKeyword(key) << val << token::END_STATEMENT << nl;
Provide a single `os.writeEntry(key, val)` replacement.
The previously introduced `Ostream::beginBlock` and `Ostream::endBlock` should include a newline for convenience.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/352cleanup noFunctionObjects vs withFunctionObjects etc2018-08-09T10:21:58ZMark OLESENcleanup noFunctionObjects vs withFunctionObjects etcpotentialFoam is the only solver or application to use `-withFunctionObjects`, all others have an implicit `-noFunctionObjects`. This exception does make sense, but opens questions about the general handling of function-objects. There ar...potentialFoam is the only solver or application to use `-withFunctionObjects`, all others have an implicit `-noFunctionObjects`. This exception does make sense, but opens questions about the general handling of function-objects. There are a number of utilities (conversion, blockMesh, etc) without a time-loop and thus it doesn't make much sense to even provide a `-noFunctionObjects` option for them.
Propose adding a argList::noFunctionObjects() method - similar to the argList::noParallel() method - to remove the availability of the `-noFunctionObjects` option and adjust Time accordingly.
Currently:
functionObjects_
(
*this,
argList::validOptions.found("withFunctionObjects")
? args.optionFound("withFunctionObjects")
: !args.optionFound("noFunctionObjects")
)
Proposed:
functionObjects_
(
*this,
argList::validOptions.found("withFunctionObjects")
? args.optionFound("withFunctionObjects")
: argList::validOptions.found("noFunctionObjects")
? !args.optionFound("noFunctionObjects")
: false
)
For potentialFoam it also doesn't make sense to provide the `-noFunctionObjects` option at all. It adds clutter and will always be ignored anyhow.
@andy @Mattijs @PrashantVersion v1706Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1775cleanup of autoPtr, tmp classes2020-08-11T17:17:55ZMark OLESENcleanup of autoPtr, tmp classesShould remove some slight inconsistencies between autoPtr and tmp, and reduce some coding verbosity.
- For autoPtr, can use assignment from `nullptr` to effect a reset. Should also be allowed for tmp.
- Reduce use of autoPtr `empty()` a...Should remove some slight inconsistencies between autoPtr and tmp, and reduce some coding verbosity.
- For autoPtr, can use assignment from `nullptr` to effect a reset. Should also be allowed for tmp.
- Reduce use of autoPtr `empty()` and `valid()` methods.
The autoPtr empty() method was introduced (Jan-2009) to reduce these types of constructs:
```
if (!myPtr.valid()) ...
if (myPtr.empty()) ...
```
But now there are some places with this type of thing:
```
if (!myPtr.empty()) ...
```
Since we now have an explicit `bool` operator, probably makes sense to use that instead:
```
if (myPtr) ...
if (!myPtr) ...
```Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/635Cleanup of git repo2020-03-13T14:25:47ZAdminCleanup of git repoHi,
Is it possible to do some cleanup of the repo. I noticed the "twoPhasePachuka" tutorial case has historical artefacts that are mainly responsible for this. I reduced the repo size from 1.1G to 300M by issuing the following commands (...Hi,
Is it possible to do some cleanup of the repo. I noticed the "twoPhasePachuka" tutorial case has historical artefacts that are mainly responsible for this. I reduced the repo size from 1.1G to 300M by issuing the following commands (and then re-added the tutorial case)
```
git filter-branch --tag-name-filter cat --index-filter 'git rm -rf --cached --ignore-unmatch tutorials/multiphase/MPPICInterFoam/twoPhasePachuka' --prune-empty -f -- --all
rm -rf .git/refs/original/
git reflog expire --expire=now --all
git gc --aggressive --prune=now
```
Regards
Andrew
\## Reattaching the author to the issue ticket: @Jackson ##https://develop.openfoam.com/Development/openfoam/-/issues/751cleanup packed lists2018-05-30T09:53:40ZMark OLESENcleanup packed listsVarious things affecting PackedList and PackedBoolList
- PackedBoolList is a class built on PackedList with additional features, but could be streamlined/reduces with some refactoring.
- iterator access in general is/was a questionable d...Various things affecting PackedList and PackedBoolList
- PackedBoolList is a class built on PackedList with additional features, but could be streamlined/reduces with some refactoring.
- iterator access in general is/was a questionable design feature. It is normally needed, and adds a layer of complexity. However, being able to quickly find and access the indices of bits set (for PackedBoolList) would be more useful - we otherwise spend loads of times indexing through zeroes and have numerous bit-ops on the way (losing the inherent parallelism for Bool).
- propagate into reduction operations.v1806Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1806ClearLinux Build Support2024-01-11T18:00:37ZDevin Charles PrescottClearLinux Build Support### Functionality to add/problem to solve
Compile support (Documentation) for ClearLinux.
### Target audience
ClearLinux is a performance-centric Linux distribution focusing on Intel processors which are commonly found in commercial...### Functionality to add/problem to solve
Compile support (Documentation) for ClearLinux.
### Target audience
ClearLinux is a performance-centric Linux distribution focusing on Intel processors which are commonly found in commercial applications and HPC resources.
### Proposal
As an amateur in the realm of building from source in the Linux environment I'm struggling with what I assume are simple issues: having installed all prerequisites and run the `foamSystemCheck` command with a pass, I'm still running into issues with openmpi (can't find mpi.h).
Assuming others are similarly struggling, updating documentation (or some help here) to include this distribution.
### What does success look like, and how can we measure that?
A successful build on ClearLinux.
### Funding
Maybe? Willing to document procedure and test.
~"compilation"
~"documentation"
~"feature request"Mark OLESENMark OLESEN