Development issueshttps://develop.openfoam.com/groups/Development/-/issues2023-12-21T15:56:08Zhttps://develop.openfoam.com/Development/openfoam/-/issues/2963add non-blocking communication for cyclic AMI2023-12-21T15:56:08ZMark OLESENadd non-blocking communication for cyclic AMIcross-ref: EP2240cross-ref: EP2240https://develop.openfoam.com/Development/openfoam/-/issues/1522Add OpenQBMM2020-02-10T15:21:01ZMark OLESENAdd OpenQBMMAs per discussions with @andy and @albertop - aim to add OpenQBMM in as a submodule for 1912.
Alberto has rejiged some bits to compile will 1906 (only some deprecation warnings for dimensionedType that can be safely ignored). I've recom...As per discussions with @andy and @albertop - aim to add OpenQBMM in as a submodule for 1912.
Alberto has rejiged some bits to compile will 1906 (only some deprecation warnings for dimensionedType that can be safely ignored). I've recompiled his branch with the 1912 develop and nothing came up with gcc-7.4.
May need to recheck with gcc-4.8.5, but probably not too bad.
As soon as we get a _mostly_ finalized branch (even better, tagged) can add the submodule.
Q: The subdirectory name as under modules/OpenQBMM, modules/open-qbmm ...? We are flexible.v2006Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1315add patch blacklisting to surfaceMeshExtract2019-07-09T18:04:27ZMark OLESENadd patch blacklisting to surfaceMeshExtract- similar idea as to foamToVTK -excludePatches
Cross-ref EP.1000- similar idea as to foamToVTK -excludePatches
Cross-ref EP.1000Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/ThirdParty-common/-/issues/46add pkgconfig management/handling to makePETSC2020-06-26T08:05:52ZMark OLESENadd pkgconfig management/handling to makePETSCRelated to suggestion by @szampini - we should address pkgconfig contents when using makePETSC (as per the makeQT handling) to ensure things are movableRelated to suggestion by @szampini - we should address pkgconfig contents when using makePETSC (as per the makeQT handling) to ensure things are movableMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1375add -postProcess to solvers2020-03-13T14:46:56ZMark OLESENadd -postProcess to solversMissing on some solvers, as mentioned on
https://www.cfd-online.com/Forums/openfoam-bugs/217677-wrong-statement-openfoam-documentation.htmlMissing on some solvers, as mentioned on
https://www.cfd-online.com/Forums/openfoam-bugs/217677-wrong-statement-openfoam-documentation.htmlMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/764addProfiling has overhead even if not active2023-12-07T19:03:28ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comaddProfiling has overhead even if not activeaddProfiling calls clockTime even if not active. The profilingTrigger does two thing:
- construct clockTime. This calls the low-level time function.
- optionally return/construct a profilingInformation. This is protected from doing anyth...addProfiling calls clockTime even if not active. The profilingTrigger does two thing:
- construct clockTime. This calls the low-level time function.
- optionally return/construct a profilingInformation. This is protected from doing anything expensive unless it is active().
The addProfiling macro should really check for profiling::active().Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1623Add real density in turbulence models (for 2 phase flow simulations, such as ...2022-02-28T11:46:59ZGabriel Barajasbarajasg@unican.esAdd real density in turbulence models (for 2 phase flow simulations, such as fluid-structure interaction)It is a request that can be very useful when simulating fluid-structure interaction cases (two phase flow cases with an interface) for reducing the numerical damping.
I have realized that in turbulence models, density is defined as *geo...It is a request that can be very useful when simulating fluid-structure interaction cases (two phase flow cases with an interface) for reducing the numerical damping.
I have realized that in turbulence models, density is defined as *geometricOneField* (value of One all over the domain).
Just by changing to real density values (rhoFluid and rhoAir defined in *constant/transportProperties*), we can get more realistic values in the inteface water-air of the turbulent kinematic viscosity (as it can be seen in the picture).
![pic](/uploads/221e939f8e2c0d3f5cb517e58df4c085/pic.png)
I have added the subfix **IH** to all the new modification, so the *standard* and *new* turbulence models can coexist in the same libraries.
I enclose the codes ( **transportModels.tar.xz** and **TurbulenceModels.tar.xz**), the new solver (**interFoamIH.tar.xz**) and two tutorials:
* **waveExample_StokesI_Kepsilon.tar.xz**: waves (stokesI) in empty channel with standard turbulence model (kEpsilon).
* **waveExample_StokesI_KepsilonIH.tar.xz**: waves (stokesI) in empty channel with new turbulence models (called kEpsilonIH).
Please note that I have just updated the three most used turbulence models for fluid-structure interaction (kEpsilon, kOmega, kOmegaSST). It can be done for all the others too.
[interFoamIH.tar.xz](/uploads/d2e8104a9d09132e63cda38ae3815f04/interFoamIH.tar.xz)
[transportModels.tar.xz](/uploads/643299a779dffb9cf98ff470cc256336/transportModels.tar.xz)
[waveExample_StokesI_Kepsilon.tar.xz](/uploads/628207ad9bd7135d3f6017ac10a6f031/waveExample_StokesI_Kepsilon.tar.xz)
[TurbulenceModels.tar.xz](/uploads/c1c9eec00c515a4197a9cb3f8e090c08/TurbulenceModels.tar.xz)
[waveExample_StokesI_kEpsilonIH.tar.xz](/uploads/a236fe8cd44b1d50e278604db340e80b/waveExample_StokesI_kEpsilonIH.tar.xz)https://develop.openfoam.com/Development/openfoam/-/issues/1901Add searchable spheroid2020-10-29T08:14:54ZMark OLESENAdd searchable spheroidThis is an idea that I discussed offline with @Mattijs. Having spheroid as a shape could be useful for external surroundings etc. Found some ideas, but equally importantly I have someone willing to implement it (@victorOle). The first ef...This is an idea that I discussed offline with @Mattijs. Having spheroid as a shape could be useful for external surroundings etc. Found some ideas, but equally importantly I have someone willing to implement it (@victorOle). The first efforts look good, but would likely make most sense to merge into searchableSphere and treat the uniform radii as a special optimized case.
Largely able to work from [Geometric Tools](https://www.geometrictools.com/Documentation/DistancePointEllipseEllipsoid.pdf) documentation (CC-BY 4.0), but needs rework for the OpenFOAM frameworkMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/922Add searchableSurface single point getVolumeType2018-07-10T16:07:40ZMark OLESENAdd searchableSurface single point getVolumeTypeFor #921 we need to cycle over potentially several surfaces and faces.
It is too slow and costly to use the getVolumeType for the list of points - need the lowest level single point query.For #921 we need to cycle over potentially several surfaces and faces.
It is too slow and costly to use the getVolumeType for the list of points - need the lowest level single point query.v1812Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2390add selection mechanism for cloudInfo function object2022-06-22T09:21:11ZMark OLESENadd selection mechanism for cloudInfo function objectAs mentioned in EP1594 it can be useful to restrict calculation of D32 and other spray properties to a subset of parcels.
- add a predicate selection mechanism similar to vtkCloud etc.As mentioned in EP1594 it can be useful to restrict calculation of D32 and other spray properties to a subset of parcels.
- add a predicate selection mechanism similar to vtkCloud etc.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1717add shell syntax for modules2020-06-05T11:47:28ZMark OLESENadd shell syntax for modules- refactor/modify foamCreateModuleInclude to support shell output- refactor/modify foamCreateModuleInclude to support shell outputMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/246Add sudo to docker container2020-06-18T21:18:13ZAdminAdd sudo to docker containerIn the install script /etc/profile.d is projected into the container. Which is great because that way a non-root access for installing software etc could be set up. Problem is that sudo currently is not installed in the container.
\## ...In the install script /etc/profile.d is projected into the container. Which is great because that way a non-root access for installing software etc could be set up. Problem is that sudo currently is not installed in the container.
\## Reattaching the author to the issue ticket: @bgschaid ##Pawan GhildiyalPawan Ghildiyalhttps://develop.openfoam.com/Development/openfoam/-/issues/1573Add support for automatically reading "fileName.orig" files if the correspond...2020-01-29T03:40:36ZAlberto PassalacquaAdd support for automatically reading "fileName.orig" files if the corresponding "fileName" is absentCurrently, .orig files are used to back files up before performing initialization with utilities such as setFields.
However, the .orig files either
1. Need to be rename with rm or a script
2. The utility foamRestoreFiles -method orig...Currently, .orig files are used to back files up before performing initialization with utilities such as setFields.
However, the .orig files either
1. Need to be rename with rm or a script
2. The utility foamRestoreFiles -method orig -withZero must be executed, which renames the .orig files on the 0 directory instead of renaming a copy of the same files, effectively destroying the .orig file
The .org version has implemented a feature to read the .orig files automatically if the corresponding "non .orig" file is missing: https://github.com/OpenFOAM/OpenFOAM-dev/commit/df6e2da2dd89227cee05c0bc0c1bf4f9b80849d5 This feature would make the process of preserving .orig files a lot simpler and transparent to the user.v2006https://develop.openfoam.com/Development/openfoam/-/issues/3043Add support for extrae profiling.2023-12-20T16:59:20ZMark OLESENAdd support for extrae profiling.Patch provided by @josep.pocurull
[OpenFOAM-v2206.extrae-profiling.patch](/uploads/9a9bfbc7b7af9f9e35eef00bc343580c/OpenFOAM-v2206.extrae-profiling.patch)Patch provided by @josep.pocurull
[OpenFOAM-v2206.extrae-profiling.patch](/uploads/9a9bfbc7b7af9f9e35eef00bc343580c/OpenFOAM-v2206.extrae-profiling.patch)Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1238add support for mingw cross-compilation2020-08-05T17:56:26ZMark OLESENadd support for mingw cross-compilationMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1237add support for writing finiteArea fields2019-04-26T08:09:45ZMark OLESENadd support for writing finiteArea fields- currently no easy mean of writing into other formats (ensight, vtk, etc).
- implement as a function object, reusing the newly revised surface writers
cross-ref: EP945- currently no easy mean of writing into other formats (ensight, vtk, etc).
- implement as a function object, reusing the newly revised surface writers
cross-ref: EP945Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/2712Add thousand separators to meshing utility output2023-02-28T23:15:09ZGuanyang XueAdd thousand separators to meshing utility output### Functionality to add/problem to solve
Adding thousand separators to the output so it's easier for human to read long integers.
### Target audience
All meshing utilities (and probably some other applications)
### Proposal
Add s...### Functionality to add/problem to solve
Adding thousand separators to the output so it's easier for human to read long integers.
### Target audience
All meshing utilities (and probably some other applications)
### Proposal
Add some code to `messageStream` when printing integers
### What does success look like, and how can we measure that?
For example the current output of `blockMesh` is like
```
Mesh Information
----------------
boundingBox: (0 -0.0005 0) (0.012 0.0005 5e-05)
nPoints: 4911759
nCells: 4729600
nFaces: 14369360
nInternalFaces: 14008240
----------------
```
Adding thousand separators to integers will make it much easier to read.
```
Mesh Information
----------------
boundingBox: (0 -0.0005 0) (0.012 0.0005 5e-05)
nPoints: 4,911,759
nCells: 4,729,600
nFaces: 14,369,360
nInternalFaces: 14,008,240
----------------
```
### Links / references
You don't need to write any code to parse numbers. C++ has built-in functions to do that.
https://cplusplus.com/reference/locale/numpunct/https://develop.openfoam.com/Development/openfoam/-/issues/1234add wmake rules for PGI compiler2019-04-26T08:09:16ZMark OLESENadd wmake rules for PGI compilerMark OLESENMark OLESENhttps://develop.openfoam.com/Development/ThirdParty-common/-/issues/56ADIOS recompiles although already compiled2020-08-18T15:51:01ZHåkanADIOS recompiles although already compiled### Summary
ADIOS recompiles although already compiled
### Steps to reproduce
Follow the installation procedure of v2006. The problem is in the file https://sourceforge.net/projects/openfoam/files/v2006/ThirdParty-v2006.tgz. Running ....### Summary
ADIOS recompiles although already compiled
### Steps to reproduce
Follow the installation procedure of v2006. The problem is in the file https://sourceforge.net/projects/openfoam/files/v2006/ThirdParty-v2006.tgz. Running ./Allwmake several times, it is not noted that ADIOS is already compiled, so it compiles again. The problem is that the check if it is installed looks for a lib64 directory, while the compilation of ADIOS creates a lib directory. It can be fixed by:
pushd $ADIOS2_ARCH_PATH; ln -s lib lib64; popd
However, it would be better if the test is modified to do it correctly, or if the ADIOS compilation produces a lib64 directory directly.
### Example case
See above
### What is the current *bug* behaviour?
ADIOS recompiles although already compiled
### What is the expected *correct* behavior?
ADIOS should not be compiled if it is already compiled.
### Relevant logs and/or images
The Allwmake command gives output that ADIOS is recompiled.
### Environment information
- OpenFOAM version : v2006
- Operating system : Ubuntu 20.04
- Hardware info : N/A
- Compiler : N/A
### Possible fixes
makeAdios2, line 30:
if [ -d "$dir/include" -a -r "$dir/lib$WM_COMPILER_LIB_ARCH/libadios2$EXT_SO" ]
The $WM_COMPILER_LIB_ARCH needs to be removed, or the problem needs to be fixed some other way.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1801ADIOS recompiles although already compiled2020-08-10T10:53:08ZHåkanADIOS recompiles although already compiled### Summary
ADIOS recompiles although already compiled
### Steps to reproduce
Follow the installation procedure of v2006. The problem is in the file https://sourceforge.net/projects/openfoam/files/v2006/ThirdParty-v2006.tgz. Running ....### Summary
ADIOS recompiles although already compiled
### Steps to reproduce
Follow the installation procedure of v2006. The problem is in the file https://sourceforge.net/projects/openfoam/files/v2006/ThirdParty-v2006.tgz. Running ./Allwmake several times, it is not noted that ADIOS is already compiled, so it compiles again. The problem is that the check if it is installed looks for a lib64 directory, while the compilation of ADIOS creates a lib directory. It can be fixed by:
pushd $ADIOS2_ARCH_PATH; ln -s lib lib64; popd
However, it would be better if the test is modified to do it correctly, or if the ADIOS compilation produces a lib64 directory directly.
### Example case
See above
### What is the current *bug* behaviour?
ADIOS recompiles although already compiled
### What is the expected *correct* behavior?
ADIOS should not be compiled if it is already compiled.
### Relevant logs and/or images
The Allwmake command gives output that ADIOS is recompiled.
### Environment information
- OpenFOAM version : v2006
- Operating system : Ubuntu 20.04
- Hardware info : N/A
- Compiler : N/A
### Possible fixes
makeAdios2, line 30:
if [ -d "$dir/include" -a -r "$dir/lib$WM_COMPILER_LIB_ARCH/libadios2$EXT_SO" ]
The $WM_COMPILER_LIB_ARCH needs to be removed, or the problem needs to be fixed some other way.Mark OLESENMark OLESEN