Development issueshttps://develop.openfoam.com/groups/Development/-/issues2018-10-30T16:37:01Zhttps://develop.openfoam.com/Development/openfoam/-/issues/1047Errors on the patches between processors with buoyantBoussinesqPimpleFoam2018-10-30T16:37:01ZAdminErrors on the patches between processors with buoyantBoussinesqPimpleFoamHello,
I am running a case with buoyantBoussinesqPimpleFoam. I get a good solution when running in serial, but in parallel there is strange behaviour on the patches. This behaviour is absent if gravity is set to zero. I got the same beh...Hello,
I am running a case with buoyantBoussinesqPimpleFoam. I get a good solution when running in serial, but in parallel there is strange behaviour on the patches. This behaviour is absent if gravity is set to zero. I got the same behaviour when running in OpenFOAM 5 and 3, on different computers. Attached is an example case reproducing said error.
Regards,
Sara
[boxParallel.tar](/uploads/467668c8bbdc2e32152429e4a5ce5cb5/boxParallel.tar)![bug](/uploads/7f137bf1d2e383d9a2395b9f49c56d9e/bug.png)https://develop.openfoam.com/Development/openfoam/-/issues/1046Function1 does not know about coordinates2019-04-04T10:11:01ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comFunction1 does not know about coordinatesGeneral issue for development of PatchFunction1General issue for development of PatchFunction1https://develop.openfoam.com/Development/openfoam/-/issues/1045ccmToFoam and foamToCcm build error2018-10-17T22:10:07ZAdminccmToFoam and foamToCcm build errorthe install location from makeCCMIO differs from what ccm/Allwmake for ccmToFoam and foamToCCm. So, Allwmake script failed to find libccm.so and compile ccmToFoam and foamToCCm.
I have a look at ccm/Allwmake script and etc/config.sh/ccm...the install location from makeCCMIO differs from what ccm/Allwmake for ccmToFoam and foamToCCm. So, Allwmake script failed to find libccm.so and compile ccmToFoam and foamToCCm.
I have a look at ccm/Allwmake script and etc/config.sh/ccm in OpenFOAM-plus source tree.
Allwmake tries to find the library in $FOAM_LIBBIN
but etc/config.sh/ccmio sets the library location to $WM_THIRD_PARTY_DIR/platforms/$WM_ARCH$WM_COMPILER/$ccmio_version
the value from ccmio script is close to $FOAM_EXT_LIBBIN but not exactly.
makeCCMIO in ThirdParty-plus tries to install to $WM_THIRD_PARTY_DIR/platforms/$WM_ARCH$WM_COMPILER which is set by the value defined in etc/tools/ThirdPartyFunctions and identical value by etc/config.sh/ccmio
I think Allwmake for ccmToFoam and foamToCcm should be modified to match the thirdparty library location to make to work the utilities for ccm.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1044Add lagrangianTools functionality to develop branch2018-11-24T14:58:40ZRoger AlmenarAdd lagrangianTools functionality to develop branchIs it possible to add the functionality available under lagrangianTools to the develop branch, towards release with v1812?Is it possible to add the functionality available under lagrangianTools to the develop branch, towards release with v1812?Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1043logical ops with odd return values.2018-10-17T15:40:45ZMark OLESENlogical ops with odd return values.In ops.H we have various operations defined, but things like `andOp`, `lessOp` etc should be returning bool.In ops.H we have various operations defined, but things like `andOp`, `lessOp` etc should be returning bool.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1042External forces for rigid body dynamics2019-12-24T11:18:55ZAdminExternal forces for rigid body dynamicsCurrently the rigidBodyDynamics library only supports springs, dampers and a prescribed rotation. I'd love to see a functionality that allows for an external force restraint. E.g for simulating a rigid body that is being pushed by a cert...Currently the rigidBodyDynamics library only supports springs, dampers and a prescribed rotation. I'd love to see a functionality that allows for an external force restraint. E.g for simulating a rigid body that is being pushed by a certain force. Which might be especially useful for overset simulations. Attached is this restraint, which I'd like to see added to src/rigidBodyDynamics/restraints. The force is time and direction variable via function1.
[externalForce.zip](/uploads/a7e0e7af6e122a0b2b3b8c67b7ef001a/externalForce.zip)
Best regards
Stephan
\## Reattaching the author to the issue ticket: @Goeke ##https://develop.openfoam.com/Development/openfoam/-/issues/1041overset wall-wall interaction2020-03-13T13:42:42ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comoverset wall-wall interactionThe heatTransfer tutorial triggers interpolating from donor cells that themselves are marked as holes. This is currently not allowed.The heatTransfer tutorial triggers interpolating from donor cells that themselves are marked as holes. This is currently not allowed.https://develop.openfoam.com/Development/openfoam/-/issues/1040inconsistency in K/kappa reading for solidProperties2018-10-15T07:53:49ZMark OLESENinconsistency in K/kappa reading for solidPropertiesIf both `K` and `kappa` are present - on construct `K` will be used and `kappa` ignored.
For dictionary re-reading, both `K` and `kappa` are read if present. `kappa` is read second and will thus take effect.
- should use a Compat method...If both `K` and `kappa` are present - on construct `K` will be used and `kappa` ignored.
For dictionary re-reading, both `K` and `kappa` are read if present. `kappa` is read second and will thus take effect.
- should use a Compat method to handle this.https://develop.openfoam.com/Development/openfoam/-/issues/1039rigid body motion solver2021-07-06T13:28:55ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comrigid body motion solverGeneric issues with rigid body motion solverGeneric issues with rigid body motion solverhttps://develop.openfoam.com/Development/openfoam/-/issues/1038Reference to Tsuji(1992) for SpringSliderDashpot2019-12-09T22:22:46ZAdminReference to Tsuji(1992) for SpringSliderDashpotA while ago, I was not familiar with DEM and the literature on it. I started using DPMFoam and I wanted to know how the collisions worked. Then I had a hard time figuring out the spring slider dash-pot collision model in the lagrangian-i...A while ago, I was not familiar with DEM and the literature on it. I started using DPMFoam and I wanted to know how the collisions worked. Then I had a hard time figuring out the spring slider dash-pot collision model in the lagrangian-intermediate library.
Eventually I found that it is the implementation of the Tsuji(1992) paper. Would it be possible to make a reference to this paper in the following models: WallSpringSliderDashpot, WallLocalSpringSliderDashpot and PairSpringSliderDashpot?
For clarity I've included the paper[Tjuji_1992.pdf](/uploads/ab3ca587f7232f4d2d534d5664a2dedc/Tjuji_1992.pdf)https://develop.openfoam.com/Development/openfoam/-/issues/1037can bypass absolute case path in argList2018-10-11T10:21:58ZMark OLESENcan bypass absolute case path in argListThe beautifying code in argList means that specifying `-case ..` results in non-absolute case path.The beautifying code in argList means that specifying `-case ..` results in non-absolute case path.Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1036wmkdepend sometimes throws2023-12-07T18:58:57ZMark OLESENwmkdepend sometimes throwsEvidenced by this:
```
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
```
The root cause is incorrect token shifting when getting the next file chunk.
@MattijsEvidenced by this:
```
terminate called after throwing an instance of 'std::length_error'
what(): basic_string::_M_create
```
The root cause is incorrect token shifting when getting the next file chunk.
@MattijsMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1035Bad alloc/free whe setting PtrList, UPtrList twice2018-10-12T12:01:27ZMark OLESENBad alloc/free whe setting PtrList, UPtrList twiceExample code,
```
PtrList<T> list(2);
list.set(0, ptr0);
// reorder, reorganization etc ...
list.set(0, ptr0update);
list.set(1, ptr1);
```
The problem being that the second call to `list.set(1, ptr1)` returns an autoPtr to the old poi...Example code,
```
PtrList<T> list(2);
list.set(0, ptr0);
// reorder, reorganization etc ...
list.set(0, ptr0update);
list.set(1, ptr1);
```
The problem being that the second call to `list.set(1, ptr1)` returns an autoPtr to the old pointer for memory management. This autoPtr contains a managed pointer to `ptr1` which will get freed although `ptr1` should still be under management of the PtrList.
Change:
Setting the PtrList entry to the same pointer address should be a no-op and return a nullptr.v1812Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1034searchableSurfacesQueries does not handle multiple separate surfaces2021-07-06T13:28:14ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comsearchableSurfacesQueries does not handle multiple separate surfacesMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comhttps://develop.openfoam.com/Development/openfoam/-/issues/1033Empty value for a scalar entry in a dictionary results in an uninitalized var...2019-01-14T14:28:05ZAdminEmpty value for a scalar entry in a dictionary results in an uninitalized variable# Description (summary)
The following code
scalar x = readScalar(dictionary.lookup("ascalar"));
leaves x in an uninitialized state if the dictionary entry of "ascalar" is given
as one of the following
* ascalar;
* ascalar ;
wh...# Description (summary)
The following code
scalar x = readScalar(dictionary.lookup("ascalar"));
leaves x in an uninitialized state if the dictionary entry of "ascalar" is given
as one of the following
* ascalar;
* ascalar ;
where in the letter the white space can be an arbitrary number of either spaces and/or tabs.
This may lead to floating point exceptions or incorrect results in the course of a simulation and the connection
of the observed error to a missing dictionary value might not be obvious.
# Test case
Use the _cavity_ test case from the OpenFOAM tutorials (tutorials/incompressible/icoFoam/cavity/cavity).
Steps:
* In _system/controlDict_ replace "deltaT 0.005;" with "deltaT ;".
* Run _blockMesh_
* Run _icoFoam_
This should result in a floating point exception in
`Foam::fv::EulerDdtScheme<Foam::Vector<double> >::fvmDdt(Foam::GeometricField<Foam::Vector<double>, Foam::fvPatchField, Foam::volMesh> const&)`.
# Operating system and OpenFOAM version
* Operating system: Linux
* OpenFOAM version: commit a2b459a890ed235d48829bdbdad77eb331fa09e1 (tag: OpenFOAM-v1806, master branch)
* Compiler: gcc-8.2.0
# Detailed description
The problem arises from `Foam::scalar Foam::readScalar(Istream& is)` (defined in src/OpenFOAM/primitives/Scalar/scalar/scalar.C)
Foam::scalar Foam::readScalar(Istream& is)
{
scalar val;
is >> val;
return val;
}
and `Istream& operator>>(Istream& is, Scalar& val)` (defined in src/OpenFOAM/primitives/Scalar/Scalar.C)
Istream& operator>>(Istream& is, Scalar& val)
{
token t(is);
if (!t.good())
{
is.setBad();
return is;
}
if (t.isNumber())
{
val = t.number();
is.check(FUNCTION_NAME);
}
else
{
is.setBad();
FatalIOErrorInFunction(is)
<< "wrong token type - expected Scalar, found " << t.info()
<< exit(FatalIOError);
}
return is;
}
The second function leaves `val` unchanged if `is` is an empty stream and thus bypasses the `isNumber()` check.
Since `val` is an uninitialized state when it is passed, it is still in an uninitialized state when it is returned by `readScalar(Istream& is)`.
# Suggestions for a fix
Since it is difficult (or not possible at all) to decide in a general function like `readScalar(Istream& is)` if the read value is valid or not,
I would suggest a fix in the `primitiveEntry` class. This fix given below relies on the following invariant for a `primitiveEntry` object
to be true:
A valid primitveEntry object is required to have a non-empty value after construction.
For my use cases of OpenFOAM this is a valid assumption, but of course, I maybe wrong here, so please check it.
I added the following private member function to `primitveEntry`
void Foam::primitiveEntry::checkForEmptyValue() const
{
if (this->size() == 0)
{
FatalIOErrorInFunction(*this)
<< "Attempt to create a primitiveEntry with"
<< " an empty value for keyword '"
<< this->keyword() << "'"
<< abort(FatalIOError);
}
}
and added this check as the last expression in each constructor defined in _primitiveEntry.C_, _primitiveEntryIO.C_ and _primitiveEntryTemplates.C_, e.g.
Foam::primitiveEntry::primitiveEntry(const keyType& key, const ITstream& is)
:
entry(key),
ITstream(is)
{
name() += '.' + keyword();
checkForEmptyValue();
}
Using this fix with the test case setup described above terminates _icoFoam_ with the following message
--> FOAM FATAL IO ERROR:
Attempt to create a primitiveEntry with an empty value for keyword 'deltaT'
file: /home/bt/OpenFOAM/bt-plus/run/tutorials/incompressible/icoFoam/cavity/cavity/system/controlDict.deltaT at line 0.
From function void Foam::primitiveEntry::checkForEmptyValue() const
in file db/dictionary/primitiveEntry/primitiveEntry.C at line 126.
FOAM aborting
which gives a clear hint at the source of error I think.
The nice thing about this fix is that it also resolves an analogue bug when reading label-type values from a dictionary.
However, while this fixes the bug for streams from reading a dictionary, it persists for other stream sources and requires a fix in `Istream& operator>>(Istream& is, Scalar& val)`.
I hope the provided information is helpful and if there is anything missing, please let me know.
Best regards,
Tobias TolleMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1030Syntax error near unexpected token2018-10-16T05:59:30ZAdminSyntax error near unexpected token![issue](/uploads/25b3de515657517c15dc079eed035083/issue.PNG)
I installed OpenFOAM about a month ago, it worked very well. But from last week, these errors keep showing up when I just open the Ubuntu without doing any things.
Is there...![issue](/uploads/25b3de515657517c15dc079eed035083/issue.PNG)
I installed OpenFOAM about a month ago, it worked very well. But from last week, these errors keep showing up when I just open the Ubuntu without doing any things.
Is there anyone having the same problem? What should I do?
Thank you!Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/1028Poisson: KHI case failing with develop branch in walldistance calcualtion using2020-01-08T14:42:09ZPawan GhildiyalPoisson: KHI case failing with develop branch in walldistance calcualtion usingHello @Mattijs @Sergio
KHI case work fine with 1806 but with latest develop version,
it is failing while doing wallDistance calculation using poisson
but work fine with meshWave. Is there any changes applied to poisson metho...Hello @Mattijs @Sergio
KHI case work fine with 1806 but with latest develop version,
it is failing while doing wallDistance calculation using poisson
but work fine with meshWave. Is there any changes applied to poisson method. ?
Thanks
Pawanhttps://develop.openfoam.com/Development/openfoam/-/issues/1026overset with mesh deformation2020-01-08T14:43:11ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comoverset with mesh deformationOverset with mesh deformation is not demonstrated.Overset with mesh deformation is not demonstrated.https://develop.openfoam.com/Development/openfoam/-/issues/1025buoyantPimpleFoam2020-01-03T20:52:53ZPawan GhildiyalbuoyantPimpleFoamhello @andy @Sergio
buoyantPimpleFoam does not read rhoMin/rhoMax or pMinFactor
(I cannot see in log whether it is being read )
Also, i can see it is not being applied while solver is running.
Any particular reason for this . ...hello @andy @Sergio
buoyantPimpleFoam does not read rhoMin/rhoMax or pMinFactor
(I cannot see in log whether it is being read )
Also, i can see it is not being applied while solver is running.
Any particular reason for this . If not, can we have same limiter
in buoyantPimpleFoam.
Regards
Pawanhttps://develop.openfoam.com/Development/openfoam/-/issues/1024transformList with maps2018-09-28T14:55:36ZMark OLESENtransformList with maps- incorrect dereference of single rotation tensor applied to maps.
Appears to be a copy/paste issue from a list of tensors- incorrect dereference of single rotation tensor applied to maps.
Appears to be a copy/paste issue from a list of tensorsMark OLESENMark OLESEN