Development issueshttps://develop.openfoam.com/groups/Development/-/issues2016-10-04T09:50:10Zhttps://develop.openfoam.com/Development/openfoam/-/issues/249Field construct from indirect list2016-10-04T09:50:10ZMark OLESENField construct from indirect listCurrently need two parameters to construct a field from indirect addressing. A constructor from UIndirectList for ease of use. Already filed upstream, but no activity there.
@MattijsCurrently need two parameters to construct a field from indirect addressing. A constructor from UIndirectList for ease of use. Already filed upstream, but no activity there.
@MattijsMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/250Merge points with indirect list.2019-12-09T22:04:13ZMark OLESENMerge points with indirect list.Should be able to merge a subset of points (e.g. only those on boundaries). Adjust merge points parameters list to handle this.
@MattijsShould be able to merge a subset of points (e.g. only those on boundaries). Adjust merge points parameters list to handle this.
@MattijsMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/252Cannot directly access the raw pointer/reference from autoPtr2019-12-09T22:04:14ZMark OLESENCannot directly access the raw pointer/reference from autoPtrAll of the access methods for autoPtr include validity checks and will fail if the underlying point is NULL.
In some cases, however, we'd like to retain the automatic deletion mechanism, but still address a nullptr. This is mostly for c...All of the access methods for autoPtr include validity checks and will fail if the underlying point is NULL.
In some cases, however, we'd like to retain the automatic deletion mechanism, but still address a nullptr. This is mostly for cases in which a file-stream should be allocated, but only on the master process. For these cases we'd still like to pass through and reference the underlying pointer (eg, to obtain the correct method call) without tripping the pointer check mechanism. If we attempt to use the `ptr()` method, the autoPtr memory management is bypassed and we risk memory leaks.
Instead provide an alternative mechanism to obtain the _raw_ underlying pointers/references. The first proposal used `refOrNull()` for this particular operation, but if expanding this to include pointers, it is not the best name. Propose to use `rawPtr()` and `rawRef()` for these useful, but potentially dangerous, operations.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/254cleanup/extend ostream to ease usage2017-01-02T12:25:13ZMark OLESENcleanup/extend ostream to ease usage*Many* places with things like this:
os.writeKeyword(key) << val << token::END_STATEMENT << nl;
Provide a single `os.writeEntry(key, val)` replacement.
The previously introduced `Ostream::beginBlock` and `Ostream::endBlock` should...*Many* places with things like this:
os.writeKeyword(key) << val << token::END_STATEMENT << nl;
Provide a single `os.writeEntry(key, val)` replacement.
The previously introduced `Ostream::beginBlock` and `Ostream::endBlock` should include a newline for convenience.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/255ease dictionary output2017-02-01T10:22:49ZMark OLESENease dictionary outputProvide a `dictionary::write` that can also handle a leading key as its header.Provide a `dictionary::write` that can also handle a leading key as its header.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/256remove unneeded lines in list binary output.2017-07-03T07:20:58ZMark OLESENremove unneeded lines in list binary output.Writing an empty list in binary results in unnecessary newlines.Writing an empty list in binary results in unnecessary newlines.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/257unused/unneeded macros for UINT64_MIN2017-01-24T17:02:16ZMark OLESENunused/unneeded macros for UINT64_MINVersion v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/258paraview plugin not being built in merged version2016-10-24T21:17:05ZMark OLESENparaview plugin not being built in merged versionchange in logic with config changechange in logic with config changeMark OLESENMark OLESEN2016-10-04https://develop.openfoam.com/Development/openfoam/-/issues/260implicit plane constructors cause weirdness2016-12-23T12:39:40ZMattijs Janssens4-Mattijs@users.noreply.develop.openfoam.comimplicit plane constructors cause weirdnessin shm was using
p.boundaryField()[patchi] == scalarField(..)
which causes implicit plane-construct-from-scalarList to be invoked.in shm was using
p.boundaryField()[patchi] == scalarField(..)
which causes implicit plane-construct-from-scalarList to be invoked.https://develop.openfoam.com/Development/openfoam/-/issues/261Provide support for C++11 initializer lists in a few more places2017-02-01T10:22:34ZMark OLESENProvide support for C++11 initializer lists in a few more placesMark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/262Absolute third-party paths in wmkdep, possible false positive on sed2016-11-07T06:27:23ZMark OLESENAbsolute third-party paths in wmkdep, possible false positive on sedAlso reported as http://bugs.openfoam.org/view.php?id=2283
In the wmake rules 'transform', the sed expression is missing a beginning anchor and a trailing slash , which makes it slightly susceptible to a false substitutions.
Additional...Also reported as http://bugs.openfoam.org/view.php?id=2283
In the wmake rules 'transform', the sed expression is missing a beginning anchor and a trailing slash , which makes it slightly susceptible to a false substitutions.
Additionally, any dependencies within ThirdParty retain their absolute path and are not resolved to `$WM_THIRD_PARTY_DIR`.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/264foamCleanPath performs strangely if username/path has @ and . characters2019-12-09T22:04:13ZAdminfoamCleanPath performs strangely if username/path has @ and . charactersDear all,
I'm trying to compile the v1606+ with standard GNU tools, on a CentOS 7 based cluster. When I source etc/bashrc, i receive a strange error, like
```
[lcarvalheiro@argus etc]$ source bashrc
sed: -e expressão #1, cará...Dear all,
I'm trying to compile the v1606+ with standard GNU tools, on a CentOS 7 based cluster. When I source etc/bashrc, i receive a strange error, like
```
[lcarvalheiro@argus etc]$ source bashrc
sed: -e expressão #1, carácter 43: opção desconhecida para 's'
sed: -e expressão #1, carácter 56: opção desconhecida para 's'
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: No such file or directory
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: No such file or directory
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: No such file or directory
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: No such file or directory
-bash: uname: No such file or directory
Your "" operating system is not supported by this release
of OpenFOAM. For further assistance, please contact www.OpenFOAM.com
-bash: sed: command not found
-bash: mpicc: command not found
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: command not found
/home/lcarvalheiro@UA.PT/OpenFOAM/OpenFOAM-v1606+/bin/foamCleanPath: line 110: sed: command not found
-bash: sed: No such file or directory
```
(obviously, I get an empty PATH and LD_PATH)
If I comment the if condition in lines 108-111 on the file foamCleanPath, sourcing etc/bashrc executes without errors, but Allwmake ends with
```
========================================
Done ThirdParty Allwmake
========================================
+ wmakePrintBuild -check
no git description found
+ wrmo OpenFOAM/global/global.o
wrmo error: could not find Make directory
[lcarvalheiro@argus OpenFOAM-v1606+]$
```
Is there any way to tackle this issue?
Thanks in advancehttps://develop.openfoam.com/Development/openfoam/-/issues/265BUG: snappyHexMesh doesn't fully respect the -decomposeParDict option2019-12-09T22:04:15ZAdminBUG: snappyHexMesh doesn't fully respect the -decomposeParDict optionsnappyHexMesh doesn't fully respect the -decomposeParDict option. Crashes half way through when it starts looking for system/decomposeParDict. Looks like it occurs right after the castellation phase. In addition, the -decomposeParDict op...snappyHexMesh doesn't fully respect the -decomposeParDict option. Crashes half way through when it starts looking for system/decomposeParDict. Looks like it occurs right after the castellation phase. In addition, the -decomposeParDict option on snappyHexMesh doesn't appear to like relative paths (this works with other utilities though).
This is the command I used to run...
mpirun -np 4 snappyHexMesh -overwrite -decomposeParDict /home/graupjj/OpenFOAM/graupjj-plus/run/of/system/decomposeParDict1 -profiling -parallel
This is the error I got...
Doing final balancing
Found 0 zoned faces to keep together.
Found 0 separated coupled faces to keep together.
[0]
[0]
[0] --> FOAM FATAL IO ERROR:
[0] cannot find file
[0]
[0] file: /home/graupjj/OpenFOAM/graupjj-plus/run/of/processor0/system/decomposeParDict at line 0.
[0]
[0] From function regIOobject::readStream()
[0] in file db/regIOobject/regIOobjectRead.C at line 237.
[0]
FOAM parallel run exiting
Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/266Unify surface area/normal calculations2017-01-02T12:22:12ZMark OLESENUnify surface area/normal calculationsNeed face areas and normals for meshed surfaces in several places. It makes sense to relocate this frequently needed functionality to PrimitivePatch. PolyPatch continues to use a slice field for efficiency on poly meshes.Need face areas and normals for meshed surfaces in several places. It makes sense to relocate this frequently needed functionality to PrimitivePatch. PolyPatch continues to use a slice field for efficiency on poly meshes.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/271cleanup endian handling2016-12-23T12:39:41ZMark OLESENcleanup endian handlingSimilar code spread in several placesSimilar code spread in several placesVersion v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/273compile issue with gcc-5.22019-12-09T22:04:13ZMark OLESENcompile issue with gcc-5.2Superfluous `#include "FieldFunctions.H"` provokes warnings/errors.Superfluous `#include "FieldFunctions.H"` provokes warnings/errors.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/274BUG: single locationInMesh behavior now broken when compared with the foundat...2016-10-18T05:05:13ZAdminBUG: single locationInMesh behavior now broken when compared with the foundation codeThe single locationInMesh behavior is now broken when there is a geometry based cellZone defined when compared to the foundation code.
I've attached 3 pics and the model. The geometry pic is a pipe with a cellZone geometry defined in t...The single locationInMesh behavior is now broken when there is a geometry based cellZone defined when compared to the foundation code.
I've attached 3 pics and the model. The geometry pic is a pipe with a cellZone geometry defined in the middle.
![geometry](/uploads/80450e9dd316c13340de821bbaf3fd13/geometry.PNG)
The "3.0.x_mesh_with_cellZone.png" pic is what foundation version 3.0.x produces when a single locationInMesh is defined to one side of the cellZone. 3.0.x correctly sets the middle to one cellZone and the rest of the pipe to defaultFaces.
![3.0.x_mesh_with_cellZone](/uploads/91dace921e83fe4d3c8fc443c9663e92/3.0.x_mesh_with_cellZone.PNG)
The "v1606_mesh_with_cellZone_broken.PNG" shows what v1606 produces using the same model. It cuts off half the pipe and then leaks out into the background mesh. Not cool.
![v1606_mesh_with_cellZone_broken](/uploads/2e937dd4d15eebf0371ec383085e0347/v1606_mesh_with_cellZone_broken.PNG)
I know there has been a lot of changes so if I'm missing something let me know. I have tested the locationsInMesh functionality and that works OK for this model, but the single locationInMesh fails. I've attached the model.
[mesh_issue.tar.gz](/uploads/3f1f0af8bf58b7d1b42746861e3892d9/mesh_issue.tar.gz)https://develop.openfoam.com/Development/openfoam/-/issues/277sed: -e expression #1, char 72: unknown option to `s' ( And some funky PATH e...2016-10-29T08:39:43ZAdminsed: -e expression #1, char 72: unknown option to `s' ( And some funky PATH errors )```
[ steven.walton ] [~] > lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.1 LTS
Release: 16.04
Codename: xenial
```
I am also on a domain controlled computer.
When sourcing `/opt/openfoa...```
[ steven.walton ] [~] > lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 16.04.1 LTS
Release: 16.04
Codename: xenial
```
I am also on a domain controlled computer.
When sourcing `/opt/openfoam4/etc/bashrc` and opening a new bash terminal I get the following error
```
sed: -e expression #1, char 72: unknown option to `s'
sed: -e expression #1, char 111: unknown option to `s'
sed: -e expression #1, char 111: unknown option to `s'
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
bash: uname: No such file or directory
Your "" operating system is not supported by this release
of OpenFOAM. For further assistance, please contact www.OpenFOAM.org
Command 'sed' is available in '/bin/sed'
Command 'mpicc' is available in '/usr/bin/mpicc'
The command could not be located because '/usr/bin' is not included in the PATH environment variable.
The command could not be located because '/bin' is not included in the PATH environment variable.
mpicc: command not found
sed: command not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
/opt/openfoam4/bin/foamCleanPath: 110: /opt/openfoam4/bin/foamCleanPath: sed: not found
bash: sed: No such file or directory
/opt/openfoam4/bin/foamCleanPath: 129: /opt/openfoam4/bin/foamCleanPath: sed: not found
```
The worse part of this is that `PATH` gets completely overwritten!
I can fix some of this by getting rid of line 154 in `/opt/openfoam4/etc/bashrc`. That reduces to the following error
```
sed: -e expression #1, char 72: unknown option to `s'
sed: -e expression #1, char 111: unknown option to `s'
sed: -e expression #1, char 111: unknown option to `s'
```
If I am running in zsh (yes, I know it says bashrc) I get
```
sed: -e expression #1, char 72: unknown option to `s'
/opt/openfoam4/etc/config.sh/aliases:73: bad option: -t
```
If I enter bash and type `wmRefresh` it overwrites `PATH` and I now have no access to simple commands like `ls`. ( Removing the `-t` in that line reduces the last error in zsh but adds the line `bash: type: wmRefresh: not found` into the list of errors for bash.) Which is strange because the comment above line 73 in `/opt/openfoam4/etc/config.sh/aliases` says `For backward-compatibility unalias wmRefresh if it is defined as an alias`.
Working through this one I see that `which wmRefresh` and `alias wmRefresh` return nothing. So getting the same behaviour in both shells ( and a lack of care for backwards compatibility at this point ) I found that I could just remove lines 74-80 in `/opt/openfoam4/etc/config.sh/aliases`. Note that if I just removed line 73 bash would have `PATH` overwritten again ( **why ever modify `PATH` when we have other environment variables?** ).
So at this point I am only left with the sed errors ( 1 in zsh and 3 in bash ). I cannot tell that I am getting any errors* in using OpenFoam, but as you might imagine it is quite annoying seeing multiple errors every time I open a new shell. I have been attempting to resolve these issues by looking at where `sed` has been used, but I'm not seeing a problem. It doesn't appear to be a `sed` command within `/opt/openfoam4/etc`, and grepping a directory back results is quite a log of commands.
So I am wondering if anyone else has had this error and solved it.
*To check validity through modifications I am just run the cavity icoFoam case, checking for the known solution.https://develop.openfoam.com/Development/openfoam/-/issues/279tutorial RunFunctions ignore non-standard locations of decomposeParDict2017-07-12T07:20:28ZMark OLESENtutorial RunFunctions ignore non-standard locations of decomposeParDictSeems to have broken with last foundation merge.Seems to have broken with last foundation merge.Version v1612Mark OLESENMark OLESENhttps://develop.openfoam.com/Development/openfoam/-/issues/280sourcing etc/bashrc breaks with aliases2016-12-23T12:39:42ZMark OLESENsourcing etc/bashrc breaks with aliasesIf `cd` is an alias, the new sourcing mechanism breaks.If `cd` is an alias, the new sourcing mechanism breaks.AdminAdmin