Skip to content

GitLab

Open
Created by Mark Olesen@markMaintainer

potential sizing issue for DynList

Not sure if this is intentional or not. For the constructor

DynListCame(label sz)

will set both the allocated size and the addressable area to be sz. The testDytestDynList.C

https://develop.openfoam.com/Community/integration-cfmesh/blob/port-v1712/testingInterfaces/testDynList/testDynList.C#L40

and https://develop.openfoam.com/Community/integration-cfmesh/blob/port-v1712/testingInterfaces/testDynList/testDynList.C#L50

suggests that this may not be intended (the addressable content being any random junk).

I seem to remember having something similar in a very early incarnation of DynamicList, but this form of the constructor got changed to meaning the same as "reserve allocated space, but start with a zero addressable size".

I did a quick check (by temporarily removing this constructor) and it doesn't seem to be used in too too many places. Nonetheless, it could be worth taking a look at.

@Juretic

Edited by Mark Olesen