Skip to content
  • Will Bainbridge's avatar
    7280f0ad
    KinematicParcel: Apply in-cell updates before hitting the face · 7280f0ad
    Will Bainbridge authored and Andrew Heather's avatar Andrew Heather committed
    The evolution of a KinematicParcel happens in three stages; (1) tracking
    across the cell, (2) interaction with the face or patch that has been
    hit, and (3) clculation and and update of parcel and cell properties.
    The KinematicParcel used to evolve in this order, as steps 1 and 2 were
    part of the same lower level method. This meant that the update stage
    was done after interacting with the face, meaning the parcel was not in
    the cell that had just been tracked through, or, by means of a patch
    interaction, had been modified such that it was no longer representative
    of the track through the cell.
    
    With the separation of stages 1 and 2 in the base class, it is now
    possible to do the update stage before interacting with the face (i.e.,
    proceeding in the order 1, 3, 2). This makes the state consistent for
    the updates, and avoids the issues described.
    
    Patch contributed by Timo Niemi, VTT.
    This resolves bug report https://bugs.openfoam.org/view.php?id=2282
    7280f0ad
    KinematicParcel: Apply in-cell updates before hitting the face
    Will Bainbridge authored and Andrew Heather's avatar Andrew Heather committed
    The evolution of a KinematicParcel happens in three stages; (1) tracking
    across the cell, (2) interaction with the face or patch that has been
    hit, and (3) clculation and and update of parcel and cell properties.
    The KinematicParcel used to evolve in this order, as steps 1 and 2 were
    part of the same lower level method. This meant that the update stage
    was done after interacting with the face, meaning the parcel was not in
    the cell that had just been tracked through, or, by means of a patch
    interaction, had been modified such that it was no longer representative
    of the track through the cell.
    
    With the separation of stages 1 and 2 in the base class, it is now
    possible to do the update stage before interacting with the face (i.e.,
    proceeding in the order 1, 3, 2). This makes the state consistent for
    the updates, and avoids the issues described.
    
    Patch contributed by Timo Niemi, VTT.
    This resolves bug report https://bugs.openfoam.org/view.php?id=2282
Loading