Skip to content
Snippets Groups Projects
Commit 7c584292 authored by Mark OLESEN's avatar Mark OLESEN
Browse files

COMP: use '-n' instead of '-np' for runParallel (#1238)

- options '-n' and '-np' are synonymous, but some mpiexec versions may
  only recognize '-n' and not '-np'
parent 3702629b
Branches
Tags
No related merge requests found
...@@ -179,13 +179,13 @@ getApplication() ...@@ -179,13 +179,13 @@ getApplication()
# #
runApplication() runApplication()
{ {
local appRun logFile logMode local appName appRun logFile logMode
# Any additional parsed arguments (eg, decomposeParDict) # Any additional parsed arguments (eg, decomposeParDict)
local appArgs local appArgs
# Parse options until executable is encountered # Parse options until executable is encountered
while [ $# -gt 0 -a -z "$appRun" ] while [ "$#" -gt 0 ] && [ -z "$appRun" ]
do do
case "$1" in case "$1" in
-a | -append) -a | -append)
...@@ -211,10 +211,10 @@ runApplication() ...@@ -211,10 +211,10 @@ runApplication()
shift shift
done done
local appName="${appRun##*/}" appName="${appRun##*/}"
logFile="log.$appName$logFile" logFile="log.$appName$logFile"
if [ -f "$logFile" -a -z "$logMode" ] if [ -f "$logFile" ] && [ -z "$logMode" ]
then then
echo "$appName already run on $PWD:" \ echo "$appName already run on $PWD:" \
"remove log file '$logFile' to re-run" "remove log file '$logFile' to re-run"
...@@ -236,7 +236,7 @@ runApplication() ...@@ -236,7 +236,7 @@ runApplication()
# #
runParallel() runParallel()
{ {
local appRun logFile logMode nProcs local appName appRun logFile logMode nProcs
# Any additional parsed arguments (eg, decomposeParDict) # Any additional parsed arguments (eg, decomposeParDict)
local appArgs="-parallel" local appArgs="-parallel"
...@@ -248,7 +248,7 @@ runParallel() ...@@ -248,7 +248,7 @@ runParallel()
fi fi
# Parse options until executable is encountered # Parse options until executable is encountered
while [ $# -gt 0 -a -z "$appRun" ] while [ "$#" -gt 0 ] && [ -z "$appRun" ]
do do
case "$1" in case "$1" in
-a | -append) -a | -append)
...@@ -281,23 +281,24 @@ runParallel() ...@@ -281,23 +281,24 @@ runParallel()
[ -n "$nProcs" ] || nProcs=$(getNumberOfProcessors system/decomposeParDict) [ -n "$nProcs" ] || nProcs=$(getNumberOfProcessors system/decomposeParDict)
local appName="${appRun##*/}" appName="${appRun##*/}"
logFile="log.$appName$logFile" logFile="log.$appName$logFile"
if [ -f "$logFile" -a -z "$logMode" ] if [ -f "$logFile" ] && [ -z "$logMode" ]
then then
echo "$appName already run on $PWD:" \ echo "$appName already run on $PWD:" \
"remove log file '$logFile' to re-run" "remove log file '$logFile' to re-run"
else else
echo "Running $appRun ($nProcs processes) on $PWD " echo "Running $appRun ($nProcs processes) on $PWD "
# Options '-n' and '-np' are synonymous, but msmpi only supports '-n'
if [ "$logMode" = append ] if [ "$logMode" = append ]
then then
( (
$mpirun -np $nProcs $appRun $appArgs "$@" </dev/null >> $logFile 2>&1 $mpirun -n $nProcs $appRun $appArgs "$@" </dev/null >> $logFile 2>&1
) )
else else
( (
$mpirun -np $nProcs $appRun $appArgs "$@" </dev/null > $logFile 2>&1 $mpirun -n $nProcs $appRun $appArgs "$@" </dev/null > $logFile 2>&1
) )
fi fi
fi fi
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment