Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O OpenFOAM-plus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 339
    • Issues 339
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • OpenFOAM-plus
  • Issues
  • #400
Closed
Open
Issue created Feb 08, 2017 by Mark OLESEN@markMaintainer

dubious combineFields operation in fieldValue

@andy, @Sergio

  1. Write access of tmp using (), but even with ref() it wouldn't be clearer about how/where data are managed - code isn't called anywhere anyhow.

     void combineFields(tmp<Field<Type>>& field)
     {
         combineFields(field());
     }
  2. combineFields does a gather/scatter + combine. However, the only consumer at the moment seems to be a surfaceWriter, which channels everything via the master. Could perhaps reduce some communication here and also micro-optimize for serial case.

Assignee
Assign to
Time tracking